From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61A7BA0524; Fri, 5 Feb 2021 17:27:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D19F340682; Fri, 5 Feb 2021 17:27:18 +0100 (CET) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by mails.dpdk.org (Postfix) with ESMTP id 77AE14067B; Fri, 5 Feb 2021 17:27:16 +0100 (CET) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 05 Feb 2021 08:27:15 -0800 Received: from HQMAIL105.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 05 Feb 2021 08:27:15 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 05 Feb 2021 08:27:15 -0800 Received: from HKMAIL103.nvidia.com (10.18.16.12) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 5 Feb 2021 16:27:14 +0000 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 5 Feb 2021 16:27:12 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 5 Feb 2021 16:27:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kKqEZbBJ30owVeT9KaB/UETlR7Mgg/UE6a5/kmeXegTm1omf8R8CF+x2bmRtjzmZ7snK28oGee7JuUtNPwmN5c72YTHx+W542XkKjg61euylsCu1oDEev7X0HTLtdCQlHsJ+fIgDlt/up9EGSkaCrcjlTes7AFf2H50KUDRaO7L9swEbCr2V3yxsNzCBNTmp26RdVKkr31hDz//a6H53XErl9bbYDd0ml7bH+NQnE+EbWrucVM90wp5MYZnhtzZxWDqRvM5V3QTRPs2ajvBightmlCJlO49OyVv5aiiLiKg3YFNKOG3mrLRbl5gYcV4UpQZUU8mqXesQuhkJvByvkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9kkaSlCK8/gKZ5Mgc4BfPWw4XbMK9y50VkgqXiVXLlI=; b=M8pQYcsyeZC3DhQFKNglKKGnrmgWPIHmoikmGxXLPrX7iHqvGGKv2w19+DxjgPcj1BeV9PTcU4b3bhIOnaPVStBcepjZcfByCvL91ejKao8Naw1YH9hFJnfZFV8xx+Mb5orqDkf6dMjwEXfzoWiaBt2lhmNaUvpNfIppyUYn30uiRzlMLrVlPgeKYphXct79n50+8aymHREfgTmnPdFfOCTuVln4ISOaF6VkIToiRyxS5wqtkyvImJQNQ7hVrMuLMpNv5mBxV6cQdEH4ujjkmbF5VvCYrWuIX3Y14KyKvy7PZWpHK+9DDcyBBtfW8fxB2HodiKFsq8c7hBAZb7NEdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM6PR12MB4170.namprd12.prod.outlook.com (2603:10b6:5:219::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.24; Fri, 5 Feb 2021 16:27:10 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::e4a9:f9a1:d873:d07a]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::e4a9:f9a1:d873:d07a%5]) with mapi id 15.20.3805.028; Fri, 5 Feb 2021 16:27:10 +0000 From: Slava Ovsiienko To: Alexander Kozyrev , "dev@dpdk.org" CC: "stable@dpdk.org" , Raslan Darawsheh , Matan Azrad , Ori Kam Thread-Topic: [PATCH] net/mlx5: fix TCP flag field modification Thread-Index: AQHW+2uHK01tro07qUiX8YAgeJEsRKpJwI+Q Date: Fri, 5 Feb 2021 16:27:10 +0000 Message-ID: References: <20210205030304.29477-1-akozyrev@nvidia.com> In-Reply-To: <20210205030304.29477-1-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7e23bddf-29c5-4e94-3dca-08d8c9f2e339 x-ms-traffictypediagnostic: DM6PR12MB4170: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-header: ProcessedBy-CMR-outbound x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EBb45lUrkPg+LzVLI8dpgZufEfs7Skr7SJc2+h+CYJ7TP+V0fLlYEqhbh0uFDhbh6dkLMnW8VdZa0OU8C0V6Nj1p6vIjJmNpXAXsBuIalA8x+d4KtWXPB34+m7Apv7ou4cK78a2zbA0nVB5GwMC8S28AioOAcXTKjcboeGG0R/KiGpuGJYvphhg0uCSDKMnUh/vG47KkqvukM9qlXK4YHag08DmIJ0BehSaTm/ydu/T2rPuADJ32U7cbnupjIKE78DXbwGmJiYFMi5rjdp9owpBgY7ynCuPpkNNyhc6ZEcePJS1/HWsLkjJLSKRG2Nq9MWnV1CcvYYWWIia4IEFPuj9J688TD4Txj3KOb45Rfzu180ND3cSZvZyvT9gPu072eXUC6gxRk7ijbO8S6ldI1risK1KhdF3/wVUkvKT78wumPJ3+2JO/5hc1UadywBOIfWW7GDGdVdAKP/rV2MjTCHAibpKmpuCaweJkO72h4DfiiETuq2tVSaSyX6KBdNljL1xIE9X9zZoIwND/EDquiQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(346002)(366004)(136003)(376002)(54906003)(7696005)(110136005)(4326008)(76116006)(66556008)(66446008)(66476007)(8676002)(450100002)(107886003)(33656002)(64756008)(86362001)(316002)(66946007)(186003)(83380400001)(71200400001)(26005)(52536014)(9686003)(8936002)(53546011)(5660300002)(2906002)(6506007)(478600001)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?upfMsOw2J7j48U64UjnO71cGO9cHVRB8f/dxrkUKUpTFVdnfuD1LxWgCOD5H?= =?us-ascii?Q?Id+ZhiuA8YURRgHr9aYQR6LVCQgKpcHpn/038GX7MSQ4d8p4Va6olrB8yMYG?= =?us-ascii?Q?7fam0GToo9MFLvekjsXGw1Q0GAxws5UA85mXQsZ3jNkNj00cgEu2FoHhwBww?= =?us-ascii?Q?ln5IgZfyR/oRox9Kry8yeBwg9EsQJxfuIYEXm9tzy25BmmTgObRhCDVM6LWY?= =?us-ascii?Q?1dOOLrNdjnFZaY4NUJiFIUJQkiLtSmpCgPJnqkpC/yXiRkMflhQ8Pa1gATuD?= =?us-ascii?Q?PViZ1nK58afLmVjRXe/RMwPgk2LOrn9JKx1GmwkJyLYdigVZgeMfpumXrrtn?= =?us-ascii?Q?BIju9Xu6471NGd+0zEvKbAAUpLvqHwpySJD57voFnzW36xxjOXjifAo6o6aG?= =?us-ascii?Q?rygxoBfyCpdmgJA6A9c8UO0Nm/MTl3IHHxtrG76vi3Yl1fzx1qqTpLoGzWuR?= =?us-ascii?Q?yXrDbu4EzK667vC2dQBoxlcP1cB6QaalXAR8BkydUqtoOzqG+trkO8aIiPWI?= =?us-ascii?Q?eRYdU/NFSRoS5tWEemfGToGYD8fpsN5gsHekDgXPWGWKxVksZJdvCi4EKoNo?= =?us-ascii?Q?apmJfL8S8In+tbsBS7EcGa5+u8uK1awESLK5a7A1j7HKFyLj0TnpCTkMDna1?= =?us-ascii?Q?wpMMwtRcUTqZX0W5QUPvj1aFhvlppAzbuyZxRjcA20jySKWOTKMMt0G9ghnv?= =?us-ascii?Q?ql8h2aLB0LUiG7QXv37E14N+cOM6CmAkzbs5zij7XQiaTsO2OSvywdIjUaez?= =?us-ascii?Q?IQft/JoWnrsI/j4Nr45DDaQbJkyF1NFnIuQQhh23O+6E+44nuo395elQYkSa?= =?us-ascii?Q?i2kZmmjn2dGbPmjsSEWt7ApSXfUwNcXMip8g27xD3bcMplqm8+xaNcz6OdCD?= =?us-ascii?Q?v17H5jh2WW21whIhml8IfDR8kbfmf+xj/nNth7M4hPOzAEELSCsc1r0N+JST?= =?us-ascii?Q?4X2QuZnM3YQc9DCpK9J19jnWl1d+IzOSrNRCUn82xWj3KK05E/xSPMTrX+Rb?= =?us-ascii?Q?P1aQAlm4/W1A78ipdf9V1gLgUKgnMMj0BtSTwcEVooQI8TOiO53ujPVB8Y7Q?= =?us-ascii?Q?AETGqjMmnfohcyfKUtfYP0pBt8sKC5yvyrmkF4G6bEVUuGc/wNub1p/D/lEN?= =?us-ascii?Q?itVsq2PSmBMyuQybsU2GId2GEPN9HGzOqBEc642TANTargDqjYVm4qdK7P6M?= =?us-ascii?Q?iRzMnWfQwlcy1nwuVMsZokiPPdQK/l1JB50NVp6KOq/KeRW+9OAgQj0uLxzK?= =?us-ascii?Q?BL8ottOsvYegk28BTvMklhmArQ3wyugzmLfdo7VzlyYpBwAb+L1DvhPzKSHf?= =?us-ascii?Q?wh4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e23bddf-29c5-4e94-3dca-08d8c9f2e339 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2021 16:27:10.3793 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q72lTzPmL9w9sVnypaguwoJ9x7lqlEatgeGccJBxe+TPbBLeI7pzjAWvsZETA4N9xrHeYhcdEE/f/uML8U0M9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4170 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1612542435; bh=9kkaSlCK8/gKZ5Mgc4BfPWw4XbMK9y50VkgqXiVXLlI=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-header:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=T+h25XdRvVXJv4ip62inbsmqHTRr6D8M7ZjZMZYhukIpq1IbHz10b9kHQuMXfyo0k Mgc7tMbNPHqAJQCBZ/A30zb04Yfc4ilwHTUvFD1A6LmN+IrngwMUHBT3FPh+rlykOL ZDS+wS0M1ZZWExAGdE/to8DpxcZCjPkOsfuKyRpZQho0KiEkCscr8qaTCsQisxzzvC CFMLwW3ACVcDt7E0dleoEt0qkLwjWCFIaPrtto0kEjkppXD04NvPuMRthCFj8fdkkG f0Bcb3TrZfNs72qCsL3kY8skzZPPS3lmOnsBndFoKf+X9GXT75RomFJ82a6uXUrXAx 8wYBsCWgwIxDA== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix TCP flag field modification X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Alexander Kozyrev > Sent: Friday, February 5, 2021 5:03 > To: dev@dpdk.org > Cc: stable@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad ; > Ori Kam > Subject: [PATCH] net/mlx5: fix TCP flag field modification >=20 > Wrong modification field ID is used for TCP flags: the inner TCP flag fie= ld is > changing instead of the outermost one. > Use the proper field ID to match the expectations. >=20 > Fixes: 641dbe4fb0 ("net/mlx5: support modify field flow action") > Cc: stable@dpdk.org >=20 > Signed-off-by: Alexander Kozyrev Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_dv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index 76696b7b62..a44291a3c9 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -1653,7 +1653,7 @@ mlx5_flow_field_id_to_modify_info > break; > case RTE_FLOW_FIELD_TCP_FLAGS: > info[idx] =3D (struct field_modify_info){1, 0, > - MLX5_MODI_IN_TCP_FLAGS}; > + MLX5_MODI_OUT_TCP_FLAGS}; > if (mask) { > mask[idx] =3D 0x0000003f; > if (width < 6) > -- > 2.24.1