From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87DC5A0093; Thu, 10 Mar 2022 10:23:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 774404114A; Thu, 10 Mar 2022 10:23:15 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2048.outbound.protection.outlook.com [40.107.243.48]) by mails.dpdk.org (Postfix) with ESMTP id 539B941143; Thu, 10 Mar 2022 10:23:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B177UvFbPgoGvyrp2ldifdaW6aVdASXSDC0wlPnGT+slw7NgzmCiNU/FUsikMcCI6T7tSfDy3JMiNtC0Q299BaPlUIRTw2RoGEoeuzh53VlE8QZxRBIf+EA1jXOL30GuQT6df57669I3GFyX5Vk5xoAzG9dNQrvne1ilqPtiAmQVWr9Lb97gBBq6rI8nA4wl5plJeGBhcrjlp5IPqo8DcpKKDR8rjDi6t3T9Q5gLkX8XD/2aRy4D5BXrEks/Zvn5nJ9NeanpTE/fU4PePn9pEgj3VUGnsn9dbtfTVVbcLWoqoyAtldduVjn8vUBu2oed3zjLXwAOJsCZIRXK9P8yog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LgOW5Z2hKO1mCxaCOxPy+D5sn/6KGGSEjNxEmvyHVVE=; b=UY9Buw03yOiDEmDTfN7mE6UR0TBD5eZAlDf6CsEt13DcXPnqa0bojs0Z4ZEj9mg5o0HNeMFKRKJWNwx500cYi0DHbMluSjKJUcCSPEB5yhJqt3HDcmdT7IW45vThuevLcsj0eGbbH0kAFo0G/tCcFUyaxmSizLxn/i3mJfPbAgE1X96YQultSjeq5cujD+uQIFJePmYPsIGHabhwbm5ZU9PJKBeT5l/ijaINSE345j4lbaLHSOBM/A0aOW9xB3wAh5wE15Hq6ujl4ImdbBdFZ+2RC2IK5HBVMJ7SqaWn8JrBAM0rFyOs63O+lJrM3kxAphvJQD9kCPeEylU+Oq6qMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LgOW5Z2hKO1mCxaCOxPy+D5sn/6KGGSEjNxEmvyHVVE=; b=uIN9awnWKsvA9r+mKO7HJD3vCEgSWfz4YsBFolpi2DCeLCZRCPoGIs0H56+Az/kjM+iXL27nx4Pa/+rAhgAKOm5qXK1EbozxTKVRriTDnHD3ZBRLt3nG8b9Ne9sAcgcUBLLhJEd26nIBbtZamRgBox5Isy1p85WtHqhNRkzv9hqE5YBQKuLYpGwGTSDeymNHTP7umpDPtcA5FBldtlhLRx1lIIHqdXR0Q1Y4Zj8L2DyufDU3U+FfjnVTl0Go3s2T1e1mMJB6LhHJPBian4GxkYRCAihvQF+TfcHCAI+M8DAi39d0UrJM4qmYR2tnRZvUHVwByhJsFekoct0usP5X9g== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by BL1PR12MB5363.namprd12.prod.outlook.com (2603:10b6:208:317::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22; Thu, 10 Mar 2022 09:23:12 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::30be:23f7:868b:5cd0]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::30be:23f7:868b:5cd0%7]) with mapi id 15.20.5061.022; Thu, 10 Mar 2022 09:23:12 +0000 From: Slava Ovsiienko To: Thinh Tran , "dev@dpdk.org" CC: "drc@linux.vnet.ibm.com" , Raslan Darawsheh , Dmitry Kozlyuk , "stable@dpdk.org" Subject: RE: [PATCH v2] net/mlx5: fix CPU socket ID for Rx queue creation Thread-Topic: [PATCH v2] net/mlx5: fix CPU socket ID for Rx queue creation Thread-Index: AQHYM+7A5D4JpTYS9Eqn8FMwRq7J0Ky4WKsw Date: Thu, 10 Mar 2022 09:23:12 +0000 Message-ID: References: <20220307225256.172328-1-thinhtr@linux.vnet.ibm.com> <20220309194900.341944-1-thinhtr@linux.vnet.ibm.com> In-Reply-To: <20220309194900.341944-1-thinhtr@linux.vnet.ibm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 063a0eef-3359-4ff0-3d66-08da02779967 x-ms-traffictypediagnostic: BL1PR12MB5363:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6Wpc+ayw/HiaP9LKdjaDbojtSkzVn9DxxtnIxxLyl8F9/tiyuSdYRD6nP0YQXANMs5BqFRJoCPvMUj+9knLPQJZ1YZiCFKbOpVSNVS5ATT7k5JWMtDv1FSvefpAG+NpLeVloaE0PGLy6Xa61VEdQ5vSTNXm/oxKDco/EWr2oEOJZdzczCkUDAg/wRw3xpefmHjxQM5JeAe+P9lnDdnVllp5ut1TNiBp2tsVu5nxP0PIVtkHSvj9PNbbjIqF2qohSgJZrJGbjtCWm08Mmof0COey21NH8XRYzY5Xu7OVkH72uPivpn2czvOodP4ckNBkK1FjYSwPEqp+SC4d4HaNal4jrxIJ+oPQtIvhSM/Vfjn92o/5tk1O/pH53aVUi0nkOLAiI+scDibpo94LO6rMvxddXq7S6wnz7Z/SQ0IYsml+1atOVJJFfj2hEd8kuN9YYbRix9keecbOzGKxX1rRu7gwJj9x2RzYHN3F4+FAIKxuSJL+xIVOv+1IdYUXFJz2aWEaL4Xz+6soFasK+2ewaCibabKFVp7sSGikid0TKaRRkeaATYbU4vLYtFdOrcG7fVpyVNY01RFmSTyISlTF9qb0bxt3da+HrF3mX2jP/F5WxSfunrtiZNudgm/mExnOOMsW4Du2gEoBJiMjHRFZU2jQXww5GyGzz4UUrHrZCAVQmXJBbEj77FyfSTLlYsb26IcwKq93jKEwKujQgHYdR1Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(71200400001)(2906002)(55016003)(38070700005)(508600001)(316002)(76116006)(66946007)(66476007)(64756008)(8676002)(4326008)(66556008)(66446008)(86362001)(54906003)(110136005)(83380400001)(186003)(26005)(53546011)(6506007)(7696005)(38100700002)(122000001)(9686003)(52536014)(8936002)(5660300002)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nhPvlnK3NgVqFKtO56Y9XXE0DFmC4nz6tj6XUADiP047/gE/O2WkY6s+nhik?= =?us-ascii?Q?LklDSklSd4PZO3kJ3NbVIuYlg6ZD6fjYl9D0qANPh//dwj3aBHZRoMP4720O?= =?us-ascii?Q?NaAjz6xAepfpP21gB6LpIG0+V9vPXjY5K1abKrXHUIHoWHROVGliFL4t1M6D?= =?us-ascii?Q?cjvgTn/+TT/EbD3AiFbGmQZSqX3XcxQNQyWlz1Q+1lVr6CpNHXtlqrPgd0KH?= =?us-ascii?Q?CpEi9XJLN7rbwrDTiL1ygoTy3vUoB0jFdAyGSyNrYuG0E4VAUxm54n+CoqRr?= =?us-ascii?Q?T2cLD8aBJ2Ywj2q6isKy3GCeRwDSDQ8Cnt7b4VC4l+nxc5kAbs/DftUFCtCk?= =?us-ascii?Q?bjiDHAQ3S7ZmdlOu7Kvk5VO45U6f/Dkda8u7bsTlfgAhjQEwQdh5ieMjgdZ9?= =?us-ascii?Q?5xIZLyvYiG/tNb3CBfMQGg4ZlHxrxt2aZ8kdXi9/MttBU5p4TUZtr6CROnks?= =?us-ascii?Q?EHGAPQHkLOFXsywIOzc4rKtbUmjU0NKiFkX1Y5bX1tzd75igZvU/CzoKqBeP?= =?us-ascii?Q?x30VpFX8r5xDieMlCH376c4Wer4PC20rqhyoN/xzkD1ExEFYQZ3tSvDKcV1s?= =?us-ascii?Q?NUMlhzbmJ2LmcVrZJrQnaRe7oYQ5iOs3ZYAsVVcWgGVnWRox1XIGDmo0Nqoa?= =?us-ascii?Q?/+ZeQ31UZzw/KaxWPgTDg2J9ZATxXzq5hd6VZBkYLyBB/22ePVBavKqCr9Lh?= =?us-ascii?Q?HOf4QjZr2EiaZHn8dFYaWScI4PfSuy3iBnwGXgCtIrc1+ooy0ryVWxb8Hp7/?= =?us-ascii?Q?IpAspsF/ooj6+8tRae7n/QkH1/ShCQ7bSnUa+w8PjJMnaWhe4L4W45Vozmx0?= =?us-ascii?Q?ZGYbgntEW9UfhCrAQLYO4rcgC2S65hGCod20lCVkcQl2qMfM+JrV6WJkw1VB?= =?us-ascii?Q?1TCe574bTxrB8qbwb8gJLlH+zbkLUW+paod/SyKEhi76hyFp6s0+uQMvyw9J?= =?us-ascii?Q?yM9+JzFi/T7j2nb83B8/SLhuuLu1ATxy46A3fC9lz1I3znpaE31fBAVDecVT?= =?us-ascii?Q?ywUNHACzHw5QbBFpLH9DpaBKcGMnkdYs6hLu9o/jEIxts5iKlRPsIloLCGbU?= =?us-ascii?Q?TeQDMYGV1/tcha/bFgrKFsXjryx5P4XeI6FQj99wjJUvpBYGkJl9P28Jkv1d?= =?us-ascii?Q?FadAfKVm1Uu8zJQjvO35C37FqfAw97zHqbjSpYfT7zmLAqP9h4zxwha0UMo6?= =?us-ascii?Q?PlA20D8F3YmQs3wlCvDiM4gOcz9tej993f6Q7jzGhdeYwvJf032xLd2xbdmk?= =?us-ascii?Q?z7D7h2pPBMusFKDu60Tp0t2i2SOdKsl6z71dTU+/Qdm3fp78j7rPnXFP/2CS?= =?us-ascii?Q?LCAir5lE2RApAohTczq8A40JDm7IoiR7R5y7G2XFuNlRr/K5ZoejmaqpwLp3?= =?us-ascii?Q?FsEEI13vcGRV569DoZJHWeBwqlPfbKOBeSvr0BEKY6fl1XavB0I0Ykqd5V02?= =?us-ascii?Q?JWRnWY+ePoDv3ny3AbWtZpMl65a+qyDm?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 063a0eef-3359-4ff0-3d66-08da02779967 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2022 09:23:12.1577 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4qeyVLtCU2Un3IkPEuUo3Ahf4/QCpYzp+rOrZgKpjgmB9kniNV3ra+IUoPjGN5bumvKpRxbdS5TMLstFK6cSXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5363 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Thinh the line: "v2: change patch description, no code change" should not be in commit message body, it should be after "---" Besides this: Acked-by: Viacheslav Ovsiienko With best regards, Slava > -----Original Message----- > From: Thinh Tran > Sent: Wednesday, March 9, 2022 21:49 > To: dev@dpdk.org > Cc: drc@linux.vnet.ibm.com; Slava Ovsiienko ; > Raslan Darawsheh ; Dmitry Kozlyuk > ; Thinh Tran ; > stable@dpdk.org > Subject: [PATCH v2] net/mlx5: fix CPU socket ID for Rx queue creation >=20 > The default CPU socket ID was used while creating the Rx queue and this > caused creation failure in case if hardware was not resided on the defaul= t > socket. >=20 > The patch sets the correct CPU socket ID for the mlx5_rxq_ctrl before cal= ling > the mlx5_rxq_create_devx_rq_resources() which eventually calls > mlx5_devx_rq_create() with correct CPU socket ID. >=20 > v2: change patch description, no code change >=20 > Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX") > Cc: stable@dpdk.org >=20 >=20 > Signed-off-by: Thinh Tran > Reviewed-by: David Christensen >=20 > --- > drivers/net/mlx5/mlx5_devx.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c > index af106bda50..5ab092a259 100644 > --- a/drivers/net/mlx5/mlx5_devx.c > +++ b/drivers/net/mlx5/mlx5_devx.c > @@ -947,6 +947,8 @@ mlx5_rxq_devx_obj_drop_create(struct rte_eth_dev > *dev) > rte_errno =3D ENOMEM; > goto error; > } > + /* set the CPU socket ID where the rxq_ctrl was allocated */ > + rxq_ctrl->socket =3D socket_id; > rxq_obj->rxq_ctrl =3D rxq_ctrl; > rxq_ctrl->is_hairpin =3D false; > rxq_ctrl->sh =3D priv->sh; > -- > 2.27.0