Re: [dpdk-dev] [PATCH v2] build: list symbols exports in a single file

[Tal Shnaiderman <talshn@nvidia.com>]

> Subject: Re: [PATCH v2] build: list symbols exports in a single file
> 
> External email: Use caution opening links or attachments
> 
> 
> 07/04/2021 10:53, Dmitry Kozlyuk:
> > 2021-04-07 10:16 (UTC+0200), David Marchand:
> > > On Tue, Apr 6, 2021 at 10:09 PM David Marchand
> > > <david.marchand@redhat.com> wrote:
> > > > We have exports missing in EAL for some series posted on the ml
> > > > waiting for merges.
> > > > I suspect some recent merged changes have issues too (but did not
> check yet).
> > > > This current patch does not address such issues and we need fixes
> > > > afterwards if this is what you mean.
> > >
> > > I did a first pass.
> > >
> > > I see symbols from rte_random.c and rte_version.c not exported,
> > > while those files are compiled for Windows.
> > > Could you explain why these are not exported?
> >
> > These are just forgotten, can be safely exported.
> 
> I prefer we don't mix fixes with this format rework.
> Please send fixes on top of this patch.
> Cc'ed Tal & Ophir for mlx5.
> 

Thanks David for resolving the duplication.

For mlx5, the functions mlx5_devx_cmd_*, mlx5_mp_* and mlx5_memory_stat_dump are compiled but currently not used.

I can send a separate patch exporting all of them to be more aligned with Linux, or we can export them whenever we'll actually start using them.

Regardless: 

Tested-by: Tal Shnaiderman <talshn@nvidia.com>