From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94B1BA0524; Tue, 13 Apr 2021 20:58:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4DC3416128C; Tue, 13 Apr 2021 20:58:18 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2048.outbound.protection.outlook.com [40.107.95.48]) by mails.dpdk.org (Postfix) with ESMTP id 81F76161273 for ; Tue, 13 Apr 2021 20:58:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MrtEzZSZQ/SwSlGok+9tWkxyxTyGizNKff2keP69N4SJSGHE27aMXYIgAkVySI7BQcFdlYyH2ITP/IrCFDv94mx4NiEefK9uJRfLzYHzp0//j6gu1xyZFysr+yYWkogz4JgzWNXFtb/w35bEgj+NnZl5t7+ig/O/4Cw+s1XG/8/6M5PNRNxIYrgeDy37QGaxE1WPk8K7NxFYx15eAKQ4PsCHfsuapTAIwcWk25TZ0hW4vKSJK+1+N27s4A5M0kpbSj6jsxRrUm3/CKv7tM1fhb1sEID0uQ0KnTuRr7beLXm4pV6gUJvuWHKEA49w+GuMwejREJC8HVzJoWG3vOpqow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=46w2xQXXCj8up9eq8yOT/2Uvxh7anVUh4YIiMykMXUU=; b=j89IJpTuH1Q7na4+ubSrhjX0LRYLfXbAijGTE9jLQdQ/w6bWo+QaypXLa04bqlqox5ogixFzWQ5I9LwhegshJS8npecWtgViBpx7v0ogAO7mkvAc+TJhKEKynB+cBsMmvQ9FEDBkcMx8AS6APwtGFetzZgkkqqUkhaIiLKpU6HS0NmVqMgdSZto9exIFhegl5Z4ubt3s7jvKfZrIHM2ytlk2d4D4cpxUaX4quD+jwROlSNKnBxOES1XgXKfcplvpJ+a3QM+3cUJMl1e4AQgjC9BthAScE1wGyMWbqSLFIxnSSzpKUaJEUR01LTSeYcaS7QSHxH20lzL7a+1pqkThgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=46w2xQXXCj8up9eq8yOT/2Uvxh7anVUh4YIiMykMXUU=; b=tr4M9IVfYrRs5I/wAtculrgH/2c1a8pzxX1N/cbZswZ9n0OIW7nzNpKQDeHYnXV1dTv1P8zU195gFQyuzc7/z/6NHrNG+WGWXV2MyZXIy1guvQ11lM4O70uipCk9BkHOYEA7zsuBEn+zbv0XzcuTOsg6KzdtSOi3pLe5T6WywZNcn+6NVnoVagPHyYIJeXyeJls0lhOF+E6Yi1Yr6JdSlLeHcWLP20krlYirwuBtUKXx9Xu/0LbYOeTq5NKoVY4r4uTSDdHKoeKksS8Z+/ppwaBg83sz4D3fq1O0Q6gLQgyb5RA6sfsrJXtMt3ZReqNX7bcSgG2jxhxijrhS+1hAwQ== Received: from DM6PR12MB3945.namprd12.prod.outlook.com (2603:10b6:5:1c2::27) by DM6PR12MB3851.namprd12.prod.outlook.com (2603:10b6:5:1c2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.22; Tue, 13 Apr 2021 18:58:16 +0000 Received: from DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::9d62:2f16:264b:285d]) by DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::9d62:2f16:264b:285d%5]) with mapi id 15.20.4020.022; Tue, 13 Apr 2021 18:58:16 +0000 From: Tal Shnaiderman To: Jie Zhou , "dev@dpdk.org" CC: "dmitry.kozliuk@gmail.com" , "xiaoyun.li@intel.com" , "roretzla@microsoft.com" , "pallavi.kadam@intel.com" , NBU-Contact-Thomas Monjalon , "bruce.richardson@intel.com" , "ferruh.yigit@intel.com" Thread-Topic: [dpdk-dev] [PATCH v3 6/6] app/testpmd: enable testpmd on Windows Thread-Index: AQHXMIlG7WC95Ao7o0evnrZyzOoUF6qyxnQg Date: Tue, 13 Apr 2021 18:58:16 +0000 Message-ID: References: <1616172695-28505-1-git-send-email-jizh@linux.microsoft.com> <1618334363-15147-1-git-send-email-jizh@linux.microsoft.com> <1618334363-15147-7-git-send-email-jizh@linux.microsoft.com> In-Reply-To: <1618334363-15147-7-git-send-email-jizh@linux.microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [5.29.61.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 144c90df-bc4d-4147-516d-08d8feae1891 x-ms-traffictypediagnostic: DM6PR12MB3851: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QbWPRz+8Ox77jcyUk5wAxrFJv9uejYo3IHnSwTc794Lffd4WewiUJD3EnLZotje7CvofsIk+hXqRHxkfBoMPJVspX380FGE+rhbqWR/CFEI2aO9taVwhgiLDcn2h5+s8hMCos0XIU8hQzkgs/KE3K50SkWwwaPfJgxcpczsONA8NBTlceDCXIkycQ5Zl4NhyQ88rclFLllFa0C1oAbIXq0yBY08IX2sOT1gIU/IAgAKc6NjDYtgvkzArad/vC33FwBdC8/V14wMn5iggK0NtoFg3AFbdl0KIiKQ7EvK/E4KMvAKJVPxSNTViz/W3l6/RRkJDPd5P/ZmbtV+CCvPCtfXfiLf96CHX3WiG2nl3AxcTLkP3jK1yWu1Gyo5lVJCa+dnhwJHROWyq9OCI4WPYDE7zTM9ded02R8jieJ60jH7rEMge0rcJPZmgcMoZ/EQM2EfX0Om7EsPG+NfBADXywcoJaPVFtq9n9RoikgDNOrChb71PMzPLRzIg3qfqA2+8zOWIiFc04DGWT/+JF2arxIjub8/N0InggmrDe0Sulo9tCdDmC7qG0lpmzMLyGleQGWvcnRfOikAeOix0v7IIc78S97HvlKF7/QImlLYHvV/QekKl8SPwcJXS3CmCmecosEXwUGTkCxypbMbVEv13mA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3945.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(39860400002)(366004)(136003)(346002)(316002)(38100700002)(64756008)(7696005)(26005)(122000001)(478600001)(71200400001)(52536014)(8936002)(186003)(66446008)(6506007)(5660300002)(2906002)(66946007)(55016002)(86362001)(33656002)(9686003)(8676002)(76116006)(66476007)(66556008)(83380400001)(110136005)(4326008)(54906003)(21314003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?n7/++RtFTzkJHlhvM1m+B1Z7lKCQ2ficU7fnvFgebCN5SgJT82s8Rzj+dh8V?= =?us-ascii?Q?PVf9M41nyWxmTydZkDG/lqaGiYj7cA0nnLnHkvRRzbHbEGLtzOkzpLKvLUZO?= =?us-ascii?Q?KcheM9rbxsPFSgSMHFbgO9BsM+GjwGIAzgOAcJP0HslsF6+5NtebKQan31nU?= =?us-ascii?Q?rVr4/O3C+LZXDhFg/9wi2QocBmcQZlKcbUHjAYN5McI13cdzr/YM+HK3BEiS?= =?us-ascii?Q?xYWaHsEvJ2nuzJtIrJZadKUCEuVTTA2Fi3BO5bCFnB9ruuJAq7I9kEpnaVxA?= =?us-ascii?Q?MiReoTPiN3DywePaavBPH42x+gxl+LXd5XQdr3KUmLgcJFb14VZ4cA66n+y4?= =?us-ascii?Q?uiyOM6+9BAtLrFiGYp6SAGTt32jaCbBTHVLie9CahKKNvkITkM6rNhJKvqcc?= =?us-ascii?Q?mwNzzMhgpbFPGilOfVkPSzzmgepg9+0ipORKYxAif1rtQpsnr7hPzkuA98NU?= =?us-ascii?Q?fv6OkqZHsx+hxK/Byxiwjz/F2Vks+AINniep8+qIrf0GqeYMTaYj9gJbm2Vp?= =?us-ascii?Q?ojYVkJdoJFop8V5H5RMada18Z7hfgcFAWmn+IQ9wahM3eIEPdq9tblQfUZcV?= =?us-ascii?Q?7eVAc8SOw24IZsqH7vigXz3NM/1siKojaLwrBKgE5o9BSzK6r6mNPiQYo4Xd?= =?us-ascii?Q?b3Pa30f6QdVTbp1iJmUaWSNQ1LOUaZ+ac4U0XNU+VPIwfIZryVjiy+JjizJz?= =?us-ascii?Q?CdHDRuKqwzEr8ecZOS0+CSAE0G+Daqb6MUxZiQnW2j9kwZO/lw1N1zQMO/Xw?= =?us-ascii?Q?OUvkaC/9zZ3jmp33450qCoiioHU7ws3umhFHQHVu+eFtHeZJh9ezTb1nkW+z?= =?us-ascii?Q?rAFxiMRdrJnrzvQu1vUI9KUj1ZiG/UPnN6uGB4IgrkGHQ+QpH/UlMUpE/EkF?= =?us-ascii?Q?j6apBaVLnXd8BL56BeMVKLtSwchppELT/7Dj2F3AzBJwvsEcv57TaietrZYW?= =?us-ascii?Q?rC6DGLX9pV8RTOdClw8Suw5RNKqy7JT0UEqvPd0M1M1GRNG6EbkdFr/7a+80?= =?us-ascii?Q?s0Ai26770AExOy7vLKtGdoMixvKFGTpBjXsJt3NIAFzMXAzA1yplpJNYr5rf?= =?us-ascii?Q?2vIw5J3UosrK7jV4VRLzIU7AW0/C5a5X6m9kchB4r0Dtv04B8VIDB+S751dR?= =?us-ascii?Q?sWiXg+GUEaJTlNIAxQF8ja/4l2K8NLnVXtWkvunBKvXPh6Qg5tdUgQ9rg6za?= =?us-ascii?Q?mPf2eaQxNlKxQFjxMmJyYQlMNKHHTWEphJVpf+O2KTMhC///oUntHuTYepnX?= =?us-ascii?Q?WUCNzS2D+pc8JYdl9zXTcUQix/mlsS+aiMjf182kcFiXRXaz1/lEYkQdv2bJ?= =?us-ascii?Q?H0Y=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3945.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 144c90df-bc4d-4147-516d-08d8feae1891 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2021 18:58:16.1337 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pqVDzKdK9ddKZoQcVDMEHfsnzEH+JgCcTybeP+c/+xeAGvKhptGkCyk2o1gRsq5DpOkjwx1lC9vdGLnpITTrZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3851 Subject: Re: [dpdk-dev] [PATCH v3 6/6] app/testpmd: enable testpmd on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: [dpdk-dev] [PATCH v3 6/6] app/testpmd: enable testpmd on > Windows >=20 > External email: Use caution opening links or attachments >=20 >=20 > From: Jie Zhou >=20 I think this patch can be split further since it contains different topics,= I would've split it at least to the following: 1) Resolve name collisions with Windows types. 2) Add clock_gettime_monotic for testpmd on Windows. 3) Replace unix specific functions and code to OS independent. 4) build testpmd.=20 > This patch is to enable testpmd on windows. It mainly includes: > - Disable unsupported Apps on Windows under app\ except testpmd Patch 4 > - Resolve name collisions with Windows types Patch 1 > - Add clock_gettime_monotic for testpmd on Windows Patch 2 > - Make printf format work for both Linux and Windows Patch 3 > - Replace htons with RTE_BE16 Patch 3 > - Replace inet_aton with inet_pton Patch 3, also explain why this change is needed > - Fix parse_fec_mode to return fec_capa to remove compilation warning Patch 3, unless this is a real fix and needs its own patch. > - Replace mman.h POSIX APIs with rte_mem_xxx APIs Patch 3 > - Use OS independant rte_rand Patch 3 >=20 > Signed-off-by: Jie Zhou > Signed-off-by: Jie Zhou > ---