From: Tal Shnaiderman <talshn@nvidia.com>
To: Leyi Rong <leyi.rong@intel.com>,
"qi.z.zhang@intel.com" <qi.z.zhang@intel.com>,
"pallavi.kadam@intel.com" <pallavi.kadam@intel.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"ranjit.menon@intel.com" <ranjit.menon@intel.com>,
"beilei.xing@intel.com" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix mingw build error
Date: Tue, 26 Jan 2021 17:04:11 +0000 [thread overview]
Message-ID: <DM6PR12MB3945AD2394179EBCB03DD174A4BC9@DM6PR12MB3945.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210126153819.63625-1-leyi.rong@intel.com>
> Subject: [dpdk-dev] [PATCH] net/i40e: fix mingw build error
>
> External email: Use caution opening links or attachments
>
>
> Disable i40e avx512 code path for windows build to avoid the mingw build
> error.
>
> Fixes: e6a6a138919f ("net/i40e: add AVX512 vector path")
>
> Signed-off-by: Leyi Rong <leyi.rong@intel.com>
> ---
> config/x86/cross-mingw | 3 +++
> drivers/net/i40e/meson.build | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/config/x86/cross-mingw b/config/x86/cross-mingw index
> 4c15a7fa2e..48a82b457e 100644
> --- a/config/x86/cross-mingw
> +++ b/config/x86/cross-mingw
> @@ -11,3 +11,6 @@ system = 'windows'
> cpu_family = 'x86_64'
> cpu = 'native'
> endian = 'little'
> +
> +[properties]
> +c_args = '-mno-avx512f'
Should be in a different patch since it effects the whole project.
> diff --git a/drivers/net/i40e/meson.build b/drivers/net/i40e/meson.build
> index c0acdf4fd4..c9a1a50407 100644
> --- a/drivers/net/i40e/meson.build
> +++ b/drivers/net/i40e/meson.build
> @@ -54,7 +54,7 @@ if arch_subdir == 'x86'
> cc.has_argument('-mavx512f') and
> cc.has_argument('-mavx512bw'))
>
> - if i40e_avx512_cpu_support == true or i40e_avx512_cc_support == true
> + if not is_windows and (i40e_avx512_cpu_support == true or
> + i40e_avx512_cc_support == true)
DmitryK already mentioned it previously; you only need to disabled MinGW64 since clang isn't seeing those errors.
> cflags += ['-DCC_AVX512_SUPPORT']
> avx512_args = [cflags, '-mavx512f', '-mavx512bw']
> if cc.has_argument('-march=skylake-avx512')
> --
> 2.17.1
next prev parent reply other threads:[~2021-01-26 17:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 15:38 Leyi Rong
2021-01-26 16:18 ` Kadam, Pallavi
2021-01-26 17:04 ` Tal Shnaiderman [this message]
2021-01-27 8:30 ` Rong, Leyi
2021-01-27 8:47 ` [dpdk-dev] [PATCH v2 0/2] " Leyi Rong
2021-01-27 8:47 ` [dpdk-dev] [PATCH v2 1/2] config: disable avx512 on mingw cross build Leyi Rong
2021-01-27 8:47 ` [dpdk-dev] [PATCH v2 2/2] net/i40e: fix mingw build error Leyi Rong
2021-01-27 10:40 ` Bruce Richardson
2021-01-27 12:18 ` Rong, Leyi
2021-01-27 14:27 ` [dpdk-dev] [PATCH v3 0/2] " Leyi Rong
2021-01-27 14:27 ` [dpdk-dev] [PATCH v3 1/2] config: disable avx512 on mingw cross build Leyi Rong
2021-01-27 14:27 ` [dpdk-dev] [PATCH v3 2/2] net/i40e: fix mingw build error Leyi Rong
2021-01-27 19:15 ` [dpdk-dev] [PATCH v3 0/2] " Kadam, Pallavi
2021-01-28 12:28 ` David Marchand
2021-01-28 21:26 ` Thomas Monjalon
2021-02-02 8:36 ` David Marchand
2021-02-02 9:09 ` Rong, Leyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB3945AD2394179EBCB03DD174A4BC9@DM6PR12MB3945.namprd12.prod.outlook.com \
--to=talshn@nvidia.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=leyi.rong@intel.com \
--cc=pallavi.kadam@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=ranjit.menon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).