DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tal Shnaiderman <talshn@nvidia.com>
To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>,
	Olivier Matz <olivier.matz@6wind.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Ranjit Menon <ranjit.menon@intel.com>, Aaron <aconole@redhat.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only linker flags with COFF
Date: Thu, 14 Jan 2021 09:27:19 +0000	[thread overview]
Message-ID: <DM6PR12MB3945D6FB0DFDA2C2B16B23A6A4A80@DM6PR12MB3945.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1999240.RY27NfppNA@thomas>

> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only linker
> flags with COFF
> 
> External email: Use caution opening links or attachments
> 
> 
> 13/01/2021 21:27, Ranjit Menon:
> > On 1/11/2021 4:36 PM, Dmitry Kozlyuk wrote:
> > > The --export-dynamic linker option is only applicable to ELF.
> > > On Windows, where COFF is used, it causes warnings:
> > >
> > >      x86_64-w64-mingw32-ld: warning: --export-dynamic is not supported
> > >      for PE+ targets, did you mean --export-all-symbols? (MinGW)
> > >
> > >      LINK : warning LNK4044: unrecognized option '/-export-dynamic';
> > >      ignored (clang)
> > >
> > > Don't add --export-dynamic on Windows anywhere.
> > >
> > > Fixes: b031e13d7f0d ("build: fix plugin load on static build")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > > ---
> > > Using TLS variables with DLLs is problematic on Windows for now, so
> > > not attempting to check or solve the issue with plugin load.
> >
> > Acked-by: Ranjit Menon <ranjit.menon@intel.com>
> 
> Applied, thanks
> 
> Why we didn't catch it in advance in CI?
> 

I think Windows CI still passes on builds with warnings, maybe we can change it now that we cleared all of them.

  reply	other threads:[~2021-01-14  9:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12  0:36 [dpdk-dev] " Dmitry Kozlyuk
2021-01-13 20:27 ` Ranjit Menon
2021-01-13 20:55   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-01-14  9:27     ` Tal Shnaiderman [this message]
2021-01-14  9:30       ` Thomas Monjalon
2021-01-14 10:30         ` Tal Shnaiderman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB3945D6FB0DFDA2C2B16B23A6A4A80@DM6PR12MB3945.namprd12.prod.outlook.com \
    --to=talshn@nvidia.com \
    --cc=aconole@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=olivier.matz@6wind.com \
    --cc=ranjit.menon@intel.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).