From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE507A0A02; Thu, 14 Jan 2021 10:27:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C2F1141020; Thu, 14 Jan 2021 10:27:29 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by mails.dpdk.org (Postfix) with ESMTP id 65931141011; Thu, 14 Jan 2021 10:27:27 +0100 (CET) Received: from HKMAIL103.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 14 Jan 2021 17:27:25 +0800 Received: from HKMAIL103.nvidia.com (10.18.16.12) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 14 Jan 2021 09:27:22 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 14 Jan 2021 09:27:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CAW8UY7+U3od3+iBqdLyhi1wrfaEG+vPWO+Y03tYTQuRFKx/c6NYboV9tQ9yZoF8Yz7SocBePRZGzPjCQXhYdmjyPWY5ER+GRTTKgKs7wys0IJ/d5A7xN/UcI/wQw5q0+u+A/JDTyZNsT2GuQ2QOpx5tiZbju4smDbZ84FaX3NdIet8BixYNCh5kf8+6PJ5kcAM7Vn50P5NibmP2dLmsPIuqAxg3xSeS2qf2x8bdC91qnJn3CiyPoQO4fTcx4dC18NKycqEV8G+o/uVX6vnz/PCVc3Rj+ojy4uTagE3d4F370pgXiyz3ScnkHk2G+LboMejPI0NukVKefcCNkG5Eeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Jq8rJxPGH70Ms/PBgr8fSWdpt0HNImAF0Yw5CgQ3zI=; b=jdksM8aNvCIO0Wn3KnsczX+FWQoEXCLZzyQTKFY3bb6ypmBVPrP5Tv1bH6pkAHMhWBeCpBXpy3l45kN6h+78ckCNFq6jJD9Sf4DBU9Lug1uU5EuyXwMliQqBEHN3aqFbB1u/xZvpnzL9aExUidT5Cbl/CKIAQtoC+9130khwDdtsJtmiYS8bO1KkpueQShF5UBpPrquzDKzvr01616rc/Fr6ir8wjASfdX4yMHqloX8EycVWDjOl+dfng4f1t/8vdvIpo6RWDAIL9LXFrW9+a+T5dcLY0vtJF2UIru7vSqS2pO/7pvL2qSlC/K9moRzyUDxrAxd3Y0fosM31k2hRkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB3945.namprd12.prod.outlook.com (2603:10b6:5:1c2::27) by DM6PR12MB5023.namprd12.prod.outlook.com (2603:10b6:5:1b6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Thu, 14 Jan 2021 09:27:20 +0000 Received: from DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::d1dc:9fb2:4724:53df]) by DM6PR12MB3945.namprd12.prod.outlook.com ([fe80::d1dc:9fb2:4724:53df%7]) with mapi id 15.20.3742.012; Thu, 14 Jan 2021 09:27:19 +0000 From: Tal Shnaiderman To: NBU-Contact-Thomas Monjalon , Dmitry Kozlyuk CC: "dev@dpdk.org" , "stable@dpdk.org" , Olivier Matz , Bruce Richardson , Ranjit Menon , Aaron Thread-Topic: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only linker flags with COFF Thread-Index: AQHW6e5x8JcPAjEm9UaLVKH7lJoWY6om2oQQ Date: Thu, 14 Jan 2021 09:27:19 +0000 Message-ID: References: <20210112003602.29004-1-dmitry.kozliuk@gmail.com> <1999240.RY27NfppNA@thomas> In-Reply-To: <1999240.RY27NfppNA@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [77.137.141.17] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 47e3f53e-32bd-42c8-93e6-08d8b86e9776 x-ms-traffictypediagnostic: DM6PR12MB5023: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Jrw9yv9L0VIvC91zjRZwWCfazYqa9uSLox9x9RsqzkBNYTtt3q9qgh7lZSxcSm2hB9HHgfKnJFDGp378PS/yMGtgex672LVK1QXHw3QrdGQTGRlAJotkN9nse5Y0Wc9ble/pujjnMcmm4wGnPjGef/nd6LORQX5oBDuGVY70kleg7T/XcG0OpJwj3Mu0fIRhCdbp4jCOZKxtdalPoPw1hrgPJim1V6IEfEJ8LeVdTwaeFt17eBkvZ+cLMnyJ3zY7h/1bheRnsOqgw9TXlI9bIA2+MnCBnZEOzQyh5NutxSOt5VszcqrYTpIaOksdLheo/hqFDFKzpzFoYlL3EfrDzixIJnui/9Gvv+BejOSh1sCOk1EU/NoazuO+hbDre4pjhd4vjqUVrEM1kwENfyW9Yg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3945.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(346002)(366004)(396003)(376002)(136003)(5660300002)(7696005)(66946007)(83380400001)(33656002)(110136005)(8676002)(316002)(4326008)(2906002)(54906003)(64756008)(52536014)(66446008)(55016002)(6506007)(9686003)(66556008)(186003)(26005)(53546011)(71200400001)(8936002)(478600001)(76116006)(86362001)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?UAGo39GuM8Ny/srvaScLfFUaoGAXVVmn60+wsgZjQMB6XkykzzLeDqjSYgaM?= =?us-ascii?Q?lKN1lFVJYRZ+SdcSgVXGcRcRiPtQBor5gpz3s2AKGFZercwHQOPJsqh0o7Qp?= =?us-ascii?Q?TKDiooaN6nMm3sRtE3hykRcgxEL48UZ6Frvw3pb/ZwAYjju0t2AvwvaRBkNB?= =?us-ascii?Q?GcREseZ5Xdh2WCk5Tyt0Uq8HqM49xdYKi26zqYKSMtkEDPhRCe/QvuDqm6d1?= =?us-ascii?Q?NggMG3PWgZC+5GlDWS9oK4qXgz8qRxuQEl1aO1V97zv/PDryaHuDglejMXDk?= =?us-ascii?Q?iBfZGdZOlXVadAbL008leB5H0SUidcIZmGNc/6/X3qxMcbIe2u/GxKzJJlWb?= =?us-ascii?Q?RzfVA3pt8I8t1s/GXcq7h4qMw7ja4O23HicoJR0WtRXJGvwGeBCbrJzireF3?= =?us-ascii?Q?cb6YpIWSDXPpGmWcUXSKXeZTXrAugVPmIPscqhiH8sHcqJOPeHqWgKCzm/+5?= =?us-ascii?Q?QhqEpfxzaYwIosr+c+ZRYsgNizeGOFAiyuzD1P/NAQUmd3+EPSISLIY8SVf5?= =?us-ascii?Q?mh7cexfgCkKrPCY3ka+zmGskIChWytkshq86GA+1U6a4aA+Yptn54mE6x6WW?= =?us-ascii?Q?Sx3bfdzdCpgSY9PG9r9yuW24DIwO7NGaZ1ctE0br2TRlpmlxuE+W9IJlrgf6?= =?us-ascii?Q?x3ek9lK4AlRXQiXXm/7CQ6dMp4h0jGzZyVMbZfLUaizcPM8l1TmYQt9p8Nyu?= =?us-ascii?Q?uCuBmQ3btqk1yxFK5RLI3O8mIol1ocoNXlo0mmu0D8fHZZx6IevErYwn9s82?= =?us-ascii?Q?UM8x9LEgR5sTOoHBurMHmVwJMGjygktKe1e4VzjJGWW3+QOW26iQJRa4WMia?= =?us-ascii?Q?LPAaYSBOe63mibukEv86E/lVANZewbiJ8KntDIRbW2dub9PrukFHPcXdTLUP?= =?us-ascii?Q?Y5HNt8UfzwYj7hPDjfBEGHx10yCh8dIMFTW4uh+Pg1a2Tdq1tPCSCFemymRD?= =?us-ascii?Q?Nj4SoGDyF8AZ+xMsq4K1cbQKEjDBr4npF3CO3ObjCp8=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3945.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47e3f53e-32bd-42c8-93e6-08d8b86e9776 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2021 09:27:19.9179 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zW9qChRCx414ELT9Z2EU9nfHLjE950/FSLMjeIvNpzBIw1Ogqs8skEHAvTD17z0Hl0jKBd53yronKIYEUM4WEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5023 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1610616445; bh=+Jq8rJxPGH70Ms/PBgr8fSWdpt0HNImAF0Yw5CgQ3zI=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=o/z/C3OZzxJ0WovDn2rGE2d2nTqd2/QAKERnrZclxGS6f+uISo5ZazA6BBYjmh5sX B9L+8WC/EV8gmG7+jAMEroAMVdAB6Y7AYa3GLSPK2qXR+ab4qb1dhj7HIqhRhQ5rrZ 1jg4Ykbf44/3u0xwJwXYabFkBroZMJPWDaF4vs7nHpQ221Soc1vy13lB9LaQMAx6i4 gxPe8PMkTz+cJwklb3tEVicBb4jBmcXoQXRInRHKRuzjdx1bqGx8BV++WzJ/nMiqPP CuC6U2Q223RCMi1HdZOU8kbK2x4Tjy8EjRmWn/BNj2Cmb/psen2Wc5gjoRELxwtgv9 HwKML4LCsrM2g== Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only linker flags with COFF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only l= inker > flags with COFF >=20 > External email: Use caution opening links or attachments >=20 >=20 > 13/01/2021 21:27, Ranjit Menon: > > On 1/11/2021 4:36 PM, Dmitry Kozlyuk wrote: > > > The --export-dynamic linker option is only applicable to ELF. > > > On Windows, where COFF is used, it causes warnings: > > > > > > x86_64-w64-mingw32-ld: warning: --export-dynamic is not supporte= d > > > for PE+ targets, did you mean --export-all-symbols? (MinGW) > > > > > > LINK : warning LNK4044: unrecognized option '/-export-dynamic'; > > > ignored (clang) > > > > > > Don't add --export-dynamic on Windows anywhere. > > > > > > Fixes: b031e13d7f0d ("build: fix plugin load on static build") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Dmitry Kozlyuk > > > --- > > > Using TLS variables with DLLs is problematic on Windows for now, so > > > not attempting to check or solve the issue with plugin load. > > > > Acked-by: Ranjit Menon >=20 > Applied, thanks >=20 > Why we didn't catch it in advance in CI? >=20 I think Windows CI still passes on builds with warnings, maybe we can chang= e it now that we cleared all of them.