From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB429A0C3F; Thu, 15 Apr 2021 16:21:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49B0F1622A1; Thu, 15 Apr 2021 16:21:21 +0200 (CEST) Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-eopbgr750045.outbound.protection.outlook.com [40.107.75.45]) by mails.dpdk.org (Postfix) with ESMTP id 21D8E162214 for ; Thu, 15 Apr 2021 16:21:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LfT7rozUjEKwmw34OhywhQYJk2iaGc2GsIs0PfTaQPG/V3Gf5eyVMDFuGpwf0PZJmQn6cXcBTubJ3pJZrCo23j3AB7CjOFd8yX2UwNXhkNbm8JkkTzWB9UwjzJcHVz9bCwf/nSec0zrCe1OtqHJOT+LANUItbAMnGRqwBifJZ1YW1PFl0pjpwspETpoHkHeXjxTpc/WBYKsLV92cv53nXLcX41YfQGCi/jOnu0zTJ8HcUedpoh3H/2nAgwUb5s2HdOvmCL8y4jFjP3kxI4qOZBJHD6SzFEir2+dV+b7mwaK4Dgh5FL33SnlFosdHWxOzTKcPfrDaUF/EjIG0aZNbUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z6bwBfc0JVEcnGMoxw/N58nKQU0uZueFqfdbH5LtclY=; b=JMExYA7W0HaJfNTSdPznmbMFdpgtjFPeSxLCMlZsTgO4DAH2PDA8iO9v822+7xVMeyZr+IM4G4L07Rl8Vdg/dtb9capzOP6R8Ayt6s+KWfGYgo/8jmNDUZJI7/snDzORzVrKOgVFzkeHVfDUXWYSA0+snmpbNcPADb9jOo4BLfS6BbOSfRno/p9G/xHLeoB8PgHYRVdEB3X5aTMCZaS8dm9FihceFN9KTEj2Jd/SaHmJvzE0dxpieaBCtjfW3m0GjT2Lj8oVWYNvd51nl6ORsnYQWwo3tmZtr/I1Bp1LOCyhmw2uaFlWfsa0ShGr6Pn7TcAJEuYzudYvsWrJbalm5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z6bwBfc0JVEcnGMoxw/N58nKQU0uZueFqfdbH5LtclY=; b=L7nrUDvGpCcKgHaCXnj5Jgdx/wt5vCy4XmASVjJXA/pHpdQoyrBNji0GpEKDgvZzfZgTphMpRfzgvNNhe2P5LhPHw+qoB69waighHvbCCGq3nqF53sS9JsD5iRaE4Ecll6VCQfntBRCmWku1lCqzQAuRazaG5tQUn5APFmgaDd5Jx++/5wPlXYHjro7PKkZHCPGFofjQQcuzwiG2sQR/WqhYc1y63SCOlXuBsPnFkZYAiOEQ8r3Ljkf7NX1Ss86qkgp9kAKlauhbJmya3zkJO9HcvgD2C+Ro+lgK/mRVkn5ysTGZWBf3FChnGfsWlzGkATL1tRP670/txycmESRwcA== Received: from DM6PR12MB4090.namprd12.prod.outlook.com (2603:10b6:5:217::11) by DM6PR12MB3194.namprd12.prod.outlook.com (2603:10b6:5:184::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.21; Thu, 15 Apr 2021 14:21:17 +0000 Received: from DM6PR12MB4090.namprd12.prod.outlook.com ([fe80::fd19:da7e:347b:87da]) by DM6PR12MB4090.namprd12.prod.outlook.com ([fe80::fd19:da7e:347b:87da%4]) with mapi id 15.20.4042.018; Thu, 15 Apr 2021 14:21:17 +0000 From: Li Zhang To: Raslan Darawsheh , "dekelp@nvidia.com" , Ori Kam , Slava Ovsiienko , Matan Azrad , Shahaf Shuler CC: "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , Roni Bar Yanai Thread-Topic: [PATCH v4 10/14] net/mlx5: initialize the flow meter ASO SQ Thread-Index: AQHXMfgAlOWuX1G3Hk6dbpoAb5gUPqq1oO0Q Date: Thu, 15 Apr 2021 14:21:16 +0000 Message-ID: References: <20210331073632.1443011-1-lizh@nvidia.com> <20210414025736.31142-1-lizh@nvidia.com> <20210414025736.31142-11-lizh@nvidia.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [139.227.253.12] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4fb72e9c-06f1-498e-bfa2-08d90019bba2 x-ms-traffictypediagnostic: DM6PR12MB3194: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3383; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: McwgNEyosZWOrjNrTF6xtGRCS9GfBa+cYWSWp9kBSNrh3tq9GEsWrukwp1xBPREKB5C0v7uP1GPdGSvC7ivKr9zwvgGFuAPG9XsuuJOdNu2PsVF2D70g9EQD0fq48CS0wvxUCdXSuM9ZMcnaSmDk8GyikUQ4vk0jzrD8fY0Fka4JaUaZ+nccdAMqAsz1Eq6aI8EgkLEyXfHXRxxAruxc3HlHKU0g3281EsX0J4+PMzPYcHp/EMMLiky2rsWLic5DjOgoP1sjCY0NbBZwiZVLgfY96IGtEKRYd8G2hZU0JsSSB9+QFMcHR9A1pOyDIt29GiN5uVxm1r+sgYqt4gPcJRE/9KKMYP0uKldjp4+qGVqFe+pBvhtjm/iwLEQSRc3FAYTtG4aKDMYGd0KuajcEQ1NuoQglOZ8ySdp/zEJNZGVf2ohPKCo1oUHuALpMyCq2kHQnHDY+UJOnA3XoaYURUlo7DBWAM8U2Z146v1eDNNbAMlCPjlqj/Om4O8KbPGthB2n20IajD7IsqQLPqybtfiX3PwNlKcWGu2Exp2z3awB6Fjakalh0XBWnUCMVgeVXBmIRTrTjJvVMIODKioj/0sG4mJ5MuLHtmLHT7AQDL4k= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4090.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(346002)(136003)(376002)(39860400002)(86362001)(8676002)(478600001)(53546011)(64756008)(83380400001)(52536014)(38100700002)(5660300002)(66446008)(4326008)(6506007)(122000001)(7696005)(316002)(54906003)(66476007)(33656002)(76116006)(9686003)(66556008)(8936002)(71200400001)(26005)(66946007)(6636002)(107886003)(110136005)(186003)(55016002)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?4ndnpDKpJM9MpkHo4ntOSvcOlgC8NGJ6+VpItrvVmw9zkcHi7DrFc8wE+lnN?= =?us-ascii?Q?3SgqVio+Tz76kqq7K/Fj0Q4Yh4HzvgI9E/iJiQrK7EvrWRs+p26/qxUd0qLr?= =?us-ascii?Q?Egn4zOLXhBKYmyCCMsD7UblSB3nCYWglWj8cFH/NIr5WBzDeKt7j4FekAzxs?= =?us-ascii?Q?WCUm6ayV/dEiZP+rF+0FAzzOTdahRYfOSvYvrB2kKH38di0Bv1iOHschHhCg?= =?us-ascii?Q?hiDWs/2cTbwl5zs8HRH3fXDhQJel3um3vvkVxD9cgOAUwSP4EzBuDWj6Vil6?= =?us-ascii?Q?WMzD7/45pKDDAnVEvzaXGiweHkmwWF5N1f5YN9vWctZ9apQKutG+jv0PNHn0?= =?us-ascii?Q?wMw3YIr5YafRR8rb5+EfaCvd9ptvvrb7CvlbZphJ0VExzX+36FTvUV7OU37k?= =?us-ascii?Q?AFIkfgwTzFbXmFJbEZ8HQXehWN28M40ghhMLBCggHdGTTvW+qRs2mKlvYRCI?= =?us-ascii?Q?C4IJhM/MFX1bYP2AUMUhUlkqCUqPLGCSOEa0GjI3AKmdf36jSEHN71PGAtrj?= =?us-ascii?Q?ALCB/WrQH68HmnEU/xVuQe6KOT0WB6pf///6e/+baprZjVD4qaFIPJeg+4uX?= =?us-ascii?Q?pSUZW3cU7Y3luu+XcohQS6cTe3ZcKBlVA8fokoD3pl18t7vWTaj319nJWjLE?= =?us-ascii?Q?6OXwCNjoF5ZIZDbQXORjrUKNmkClQ+UXisQssuEg58cQ/ltNPHYafbH1qniP?= =?us-ascii?Q?FIcgt0+sLE1b0pyXvCJyHmEfIXmgliwg3F7BV3NTLFsZDRrzArCIEgG4mIja?= =?us-ascii?Q?Q4c9J3cwFUmzwKdVSECjShVzXji7Tg5Us3DksVNl1vp2YQ1Wl/YooGMpgWuG?= =?us-ascii?Q?lVa29bxcqRviOB+PYXHhwwQqBL+8rkPnVwE8DpDC5gtnj5WSoVKsSmoyowRP?= =?us-ascii?Q?QDDG7lmibiKYZmcp4hMQYviBMNgawV1h5l0OQm87exOrVeMNmwG06pTkEaTC?= =?us-ascii?Q?WSJviT2zAH78JX4Dzis5yU0joE8Jmz4WyPa3mSMk1Ck70V5of5BdVytxLOSc?= =?us-ascii?Q?ZnqRb4Sh7w7da4y7OwfY+CvzoqYZK9LshwPza+frDSH20LM8EwNtV4r6ggVV?= =?us-ascii?Q?IDws1kF3+Kx4jhzf9ah+Cc8rRUHKyG0isBx5kCOVWEFWphCBBHjuBplXAyDY?= =?us-ascii?Q?KoGFg7sfYAAzsji9h63wpd2WlPYPkcsdDQBnhUqlxFEpJxnBt6PIHTIfsjFP?= =?us-ascii?Q?qGJS/JfRTCVkNackaSrM0/dtzuj+4Fij9VLuBxzySN7dB6igeiFWrBMp910P?= =?us-ascii?Q?Y2pSmyg0Ux0AqoNRghxovfZRKtRvB0TKt2qXb+qbTo8kFDCG+fuanWaoVhAF?= =?us-ascii?Q?ILrxZqyh0JszHear5krFzQTw?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4090.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4fb72e9c-06f1-498e-bfa2-08d90019bba2 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2021 14:21:16.9852 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JUzofkExBoauMSnRWPxncIfCzCDgHAoY/bEcShaUmDfNgTb+I/q+1fpssqI75vZ5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3194 Subject: Re: [dpdk-dev] [PATCH v4 10/14] net/mlx5: initialize the flow meter ASO SQ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Raslan, Thanks. I will fix in the next patch. Regards, Li Zhang > -----Original Message----- > From: Raslan Darawsheh > Sent: Thursday, April 15, 2021 9:05 PM > To: Li Zhang ; dekelp@nvidia.com; Ori Kam > ; Slava Ovsiienko ; Matan > Azrad ; Shahaf Shuler > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ; Roni Bar Yanai > Subject: RE: [PATCH v4 10/14] net/mlx5: initialize the flow meter ASO SQ >=20 > Hi Li, >=20 > > -----Original Message----- > > From: Li Zhang > > Sent: Wednesday, April 14, 2021 5:58 AM > > To: dekelp@nvidia.com; Ori Kam ; Slava Ovsiienko > > ; Matan Azrad ; Shahaf > > Shuler > > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ; > > Raslan Darawsheh ; Roni Bar Yanai > > > > Subject: [PATCH v4 10/14] net/mlx5: initialize the flow meter ASO SQ > > > > Initialize the flow meter ASO SQ WQEs with all the constant data that > > should not be updated per enqueue operation. > > > > Signed-off-by: Li Zhang > > Acked-by: Matan Azrad > > --- > > drivers/net/mlx5/linux/mlx5_os.c | 17 ++++ > > drivers/net/mlx5/meson.build | 2 +- > > drivers/net/mlx5/mlx5.c | 68 ++++++++++++- > > drivers/net/mlx5/mlx5.h | 22 +++-- > > drivers/net/mlx5/mlx5_flow.h | 4 +- > > .../mlx5/{mlx5_flow_age.c =3D> mlx5_flow_aso.c} | 96 ++++++++++++++++- > -- > > drivers/net/mlx5/mlx5_flow_dv.c | 7 +- > > drivers/net/mlx5/mlx5_flow_meter.c | 7 +- > > 8 files changed, 191 insertions(+), 32 deletions(-) rename > > drivers/net/mlx5/{mlx5_flow_age.c =3D> mlx5_flow_aso.c} (85%) > > > > diff --git a/drivers/net/mlx5/linux/mlx5_os.c > > b/drivers/net/mlx5/linux/mlx5_os.c > > index 6ac334263e..ee0d45796a 100644 > > --- a/drivers/net/mlx5/linux/mlx5_os.c > > +++ b/drivers/net/mlx5/linux/mlx5_os.c > > @@ -818,6 +818,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, > > char name[RTE_ETH_NAME_MAX_LEN]; > > int own_domain_id =3D 0; > > uint16_t port_id; > > + uint32_t log_obj_size; > This would raise this compilation error: > rivers/libtmp_rte_net_mlx5.a.p/net_mlx5_linux_mlx5_os.c.o -MF > drivers/libtmp_rte_net_mlx5.a.p/net_mlx5_linux_mlx5_os.c.o.d -o > drivers/libtmp_rte_net_mlx5.a.p/net_mlx5_linux_mlx5_os.c.o - > c ../../root/dpdk/drivers/net/mlx5/linux/mlx5_os.c > ../../root/dpdk/drivers/net/mlx5/linux/mlx5_os.c: In function > 'mlx5_dev_spawn': > ../../root/dpdk/drivers/net/mlx5/linux/mlx5_os.c:823:11: error: unused > variable 'log_obj_size' [-Werror=3Dunused-variable] > uint32_t log_obj_size; > ^~~~~~~~~~~~ > When compiling with rdma-core-33 >=20 > Kindest regards > Raslan Darawsheh