From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BA2BA04B1; Wed, 9 Sep 2020 05:42:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 88E6E1B9B7; Wed, 9 Sep 2020 05:42:01 +0200 (CEST) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 588D72BAB for ; Wed, 9 Sep 2020 05:42:00 +0200 (CEST) Received: from hkpgpgate101.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 09 Sep 2020 11:41:58 +0800 Received: from HKMAIL104.nvidia.com ([10.18.16.13]) by hkpgpgate101.nvidia.com (PGP Universal service); Tue, 08 Sep 2020 20:41:58 -0700 X-PGP-Universal: processed; by hkpgpgate101.nvidia.com on Tue, 08 Sep 2020 20:41:58 -0700 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 9 Sep 2020 03:41:58 +0000 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.52) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 9 Sep 2020 03:41:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MPju1ZzK7MSXZnONBFG6gAH6XC5wjwf7wR5ngKT+UPct0lmTXVnT0XgRSEqU5fUPhe27nSPFa+5zcXBqaWJL7uJsweH4n1HCLnlT1tcUHhLkAw/jm4hNrImyLH64VIs9Wrgy8hfGC9nDi6hnecZoUAZUR789fzzG/VPT/YeFuN71rt80Bj9HVJ5rSVmAv3HDFHvMiSpwCbPZKdixXfdYucXVkRUkyonDBJFxj2GGsX1QAo9zze6HqyWljUvbJ0HdRj2qx22xHd5tOklUPoUjGRhYGzC0NATvANQOkTkixWGHT5ybDfJul+6xxsG0Hi7h1685TqD5UESkPdq7DpaiOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KDl8y0yhc3Mrx85w3m3Gnh5bnz96hwSAwiNtgEuslMc=; b=g20YvzP/hkJ6MVzRATTC8vPKs5nyym5bE2EaOiSPjLtfgL04VOgJf5p/80SC8b1Iw2VtJQ+RGscW2nICtNNCXIo4xnY7/sGbK00Vs8hZ/1o8JrKaVnqGy3m4pkNUuiR4X0iRgZdf7NwHSnqGupOKQhVG1RTUDhUBtb1vA9CE4PwUR0q2jfg3TV6VnI7wI5gJA/lf30JC1sbSPv2KgaC7ussYJ1SS7g+brEfwOJJ+w0aA/1fAesdIcpB1ArfXdCpodcPlA/Ahzqr/uFztEuy9mAo+r4PCGhnNIZM5PAjvyHABOZy37nnxS5qhmgDBYwQ6GYRkRQgR2vkuZF3On1NzLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB4090.namprd12.prod.outlook.com (2603:10b6:5:217::11) by DM6PR12MB3483.namprd12.prod.outlook.com (2603:10b6:5:11f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15; Wed, 9 Sep 2020 03:41:55 +0000 Received: from DM6PR12MB4090.namprd12.prod.outlook.com ([fe80::8c42:6852:1b18:13ad]) by DM6PR12MB4090.namprd12.prod.outlook.com ([fe80::8c42:6852:1b18:13ad%7]) with mapi id 15.20.3348.019; Wed, 9 Sep 2020 03:41:55 +0000 From: Li Zhang To: NBU-Contact-Thomas Monjalon CC: Dekel Peled , Ori Kam , "Slava Ovsiienko" , Matan Azrad , "dev@dpdk.org" , Raslan Darawsheh , "Jiawei(Jonny) Wang" Thread-Topic: [RFC] app/testpmd: distinguish ICMP identifier fields in packet Thread-Index: AQHWhd95ajHn75XGe0WAt/z57Tb+BqlfqlbA Date: Wed, 9 Sep 2020 03:41:55 +0000 Message-ID: References: <20200908100636.4575-1-lizh@nvidia.com> <7059369.UvQaBsvclW@thomas> In-Reply-To: <7059369.UvQaBsvclW@thomas> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [20.188.15.144] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f73d0248-12df-4d69-b1a3-08d854724c60 x-ms-traffictypediagnostic: DM6PR12MB3483: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SGRXM9doxZFApS9tclw3kK8oQEx6uPt9JLh15vO8m5hkke2HJw5VdOrLvbJFmBDrmmen7qbYdU7SvCXxCT7zJslPL75R32pONAwwPDwwEVIm5OxwndS865a78y/UwWnnPK5IFNjjc06/k+Pi6COj3wKfVf/ct1vUNsCVEcw/W2vMz7jBLB0FYGFdf/DJo/uEGLg2U6YVqjfpONZWI6BJhLWgMh7erKLcBtp1FYfXvxTZKadIJnd1P+UpCF6iv07FydRDy6gz9l+pbBf94cA4mrcUFcWZNXc8F9pt5S814OgeCSCPX6gMaXhaLNOTuSVfPDu4bGuPUhfYCcbJGzNYgZkEzvYC2Wxy1RLBfrb3R2u2FqqViz7kKhM3nGttQqIyFFQwf6qF9xOm2gVoVgcpDQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4090.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39850400004)(376002)(396003)(346002)(366004)(478600001)(52536014)(26005)(2906002)(33656002)(83380400001)(6916009)(186003)(66946007)(76116006)(5660300002)(7696005)(107886003)(54906003)(66446008)(64756008)(8676002)(66476007)(66556008)(316002)(53546011)(6506007)(55016002)(9686003)(71200400001)(4326008)(45080400002)(8936002)(86362001)(966005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: keeh/FIQ31l2j6dGz9V7pdfVY7V0+EIeV2PGVJouYdq4WD2T9tge5/lzHAf2e3asegQcHEBsUuD4r02VKHARL6/UL912vtPh8fl3X1ZjxiLxNj5IhFoD5w7Ovn2eioxcr978SeUrYEaezk5OwLgxNRjY0ztdwme5xMCGPdWO6f1WJMf8C7Tw1LKMvJmHYZFQJ6TUQJgQ2MAGjaVKlCvJVybwLekzUH5vezRk2ANgk22knmqX7kUEbeqIixcJXo+QMViamUyCI4o1ZwH3gMtvG1cVnLLD4+D8hCG5I03+I6O85eAWkbOVAmydNbtEMBx8kBK3vLFFOGzNu4wkyp93lsN0nEW697PSsrdS8VS1FgMeVOrQhVT317Z0HO0DZK9QCUe3MrGN5Swx7A3UZo6ih6PLeMKNpKMSqrBLboyJDIuw7WcCyPneV7U2S7r96EbLMMvpc3AFv9GlW8/5qShOU7Hg80Fr33cc9yvM60QBiRn4EZokz94BkuWUjOcOJVWjwU0s6nFXQkI2aDRwYjbuNvhhYwm//ADucfgStOeWRSeWhbf+gcmwEKhWnIGnO0s6I9UoxPrks32C8Hi86qj0acSIdoHl7sLm7iEXDtsPlxZaWMet7zH0oYXijeY/M/XGR8QG8aqAfbqnAGOq1+Bikg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4090.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f73d0248-12df-4d69-b1a3-08d854724c60 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2020 03:41:55.6329 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Sc5JpJ3o+RquUG5e7xpBdqHw7ACzcOtUJazwCLcH8kr/oK3dFnoHVoTqVU+Xyw4D X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3483 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1599622918; bh=KDl8y0yhc3Mrx85w3m3Gnh5bnz96hwSAwiNtgEuslMc=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=kUJu3GBqzlAB8tUVInrYN0B3jC7ZtU4UbfGQ+GuKAN6jGMUbPKdYbCLorTgIq8QCp NoC6ZYM+24Ke03OARu1YWrbwqlg2eZ3SjZO0Phf+1wRk0EixmPKmFDUZ6kOUGGkFTc HtX9Nwb4nIPRSqM57oksuaR7fCosX41QLOY9mAsInQgSGCye12wSAVsGNMIsNVmvT/ +aDf7OtAmuxQ/MaT0XJk5NJdzAz5+kQXpZZnbJhc7/PCZeVsdmNoL9n4fcA22dnJJy jmUZIrQLxP/dTpZ3pYheZYpTeKuZMmzSktoBwLBmnuQkQHBraZqHUNLxFTP006R4M6 T1F5nCFOJzy3Q== Subject: Re: [dpdk-dev] [RFC] app/testpmd: distinguish ICMP identifier fields in packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks! I update it now. Regards, Li Zhang -----Original Message----- From: Thomas Monjalon =20 Sent: Tuesday, September 8, 2020 8:56 PM To: Li Zhang Cc: Dekel Peled ; Ori Kam ; Slava Ovsi= ienko ; Matan Azrad ; dev@dpdk.or= g; Raslan Darawsheh Subject: Re: [RFC] app/testpmd: distinguish ICMP identifier fields in packe= t External email: Use caution opening links or attachments Hi, lizh wrote: > Ability to distinguish ICMP identifier fields in packets. > Dstinguish ICMP sequence number field too. > Already supports ICMP code and type fields in current version. > Existing fields in ICMP header contain the required information. > ICMP header already is supported and no code change in RTE FLOW. > Extend testpmd CLI to include the fields of ident and sequence number. > One example: > flow create 0 ingress pattern eth / ipv4 / > > icmp code is 1 ident is 5 seq is 6 / > end actions count / queue index 0 / end > > The ICMP packet with code 1, identifier 5 and sequence number 6 will=20 > be matched. > It will implement action counter and forward to queue 0. > > Signed-off-by: lizh Please configure your git environment so that your full name is filled. The= n redo the Signed-off so that it appears as: Li Zhang As you are new to DPDK, I suggest reading the guidelines for contributing: https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2= Fcore.dpdk.org%2Fcontribute%2F%23send&data=3D02%7C01%7Clizh%40nvidia.co= m%7C4d1f647de21844be83a408d853f69ab5%7C43083d15727340c1b7db39efd9ccc17a%7C0= %7C0%7C637351665917806609&sdata=3DdPG6VLa5HejKvwcGlqGKtfLwl%2BNEiybFSc5= RUmmJDps%3D&reserved=3D0