From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE54FA0524; Tue, 13 Apr 2021 13:02:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B787160E3A; Tue, 13 Apr 2021 13:02:07 +0200 (CEST) Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700087.outbound.protection.outlook.com [40.107.70.87]) by mails.dpdk.org (Postfix) with ESMTP id 97618160E39 for ; Tue, 13 Apr 2021 13:02:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R6jL9so5gdUkhS/0jLZQGY8iri6+Seh7OQrenRMKscg3lK6GSiUTBNsBIEYdRXPpt8M+ILyh5r1O3BcSBXm38XkmHTo7E9pHxfEstLrBYX5nxGgUrt1WxIfKHks9zeZgxKwrQdvWqqqfb1y6fvCuYVzfT+eaat2cJP749oG650HJD/DAHVh175bK4XOg4mzQgxtbjXfhlJcwDxwKc+n4arAB/eyj3OSSY9rQMAz+R9lnMr8BawoetSvy8484ldXIh/qqN2Y43fT+tZDziyP0Fgph6ZYin1Y90XCam18x2OZtOKrGnItzO6nNzWfngMVlIlJiglnn6h3Vzc/tUW2XWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z5OJoblUf297H0xUQgFbbC7SpczuJYCleBoIhQuSffE=; b=dr/jxRxb6WJqXtFO99fBvdfaTO+OhTUd3SspRfuiKS3QLFccObiW1+cObMhtcmMOZaaPBpTQKUc9BaEJ8TK3pScHT1njVIJebezhjX4Xvul7YDnY2iLPTMWpDcZE6HhJdhYaq8YN9wKVwwdHnKcnlEDTvCHEvEeOfWJIz/P+cwHwrxFzOzfTQaFPE3/e3t8odnTv/0sLJrkowp6IyHN/alBAZKgOE/Ch9kV+uG6DhJYPK9eAgRNtXRA/Fk0DnR6FXL0Mgcz7vwGfmch9xNsz+VYUq4+SBGe4DLYmVm1Hu3ZY7ans6oJNIDU4Dk/b3pYlfxpYji8cUDhQQ+3hLUgqOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z5OJoblUf297H0xUQgFbbC7SpczuJYCleBoIhQuSffE=; b=m9oOzR3iheQtRmsgPRN4gM9sFYIGIXFJQ/onM9BA8mZ1Ei6DQJgm6neL9RhBP8OCkLH7g+1bECDFit3MdzuI2FPYHah+6iJME5+/Tq6sXAHwZsVigU4TOCDRbz8IJk84+jXsPHyknnzcgfMIrioKCUJbifW5NuKE3iQ1nWVOl7AQtL/6PMIUikVOmznHs2tE+VvuxpxB9jp4tdpa/OIWzUujioACJ8slL5wyn8rts9JHkCaj1fMvOpgvO9vY1K2muAmkXxoP3OSoVDz1nKi/lUkKe8lsCPoP/u5fEx4XP+wUythvOVG3AIaTXvULYUbiTY8TzKXea+2TNXsru/Ajvg== Received: from DM6PR12MB4090.namprd12.prod.outlook.com (2603:10b6:5:217::11) by DM6PR12MB3801.namprd12.prod.outlook.com (2603:10b6:5:1cc::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16; Tue, 13 Apr 2021 11:02:03 +0000 Received: from DM6PR12MB4090.namprd12.prod.outlook.com ([fe80::fd19:da7e:347b:87da]) by DM6PR12MB4090.namprd12.prod.outlook.com ([fe80::fd19:da7e:347b:87da%4]) with mapi id 15.20.4020.022; Tue, 13 Apr 2021 11:02:03 +0000 From: Li Zhang To: Ferruh Yigit , "dekelp@nvidia.com" , Ori Kam , Slava Ovsiienko , Matan Azrad , Shahaf Shuler , "cristian.dumitrescu@intel.com" , "lironh@marvell.com" , "jerinj@marvell.com" CC: "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , Raslan Darawsheh , Roni Bar Yanai Thread-Topic: [PATCH v4 0/4] Support PPS(packet per second) on meter Thread-Index: AQHXME9IyjHnh4csZUG0lgiFL3sv+6qyRXFA Date: Tue, 13 Apr 2021 11:02:03 +0000 Message-ID: References: <20210331085405.1445546-1-lizh@nvidia.com> <20210413035046.28578-1-lizh@nvidia.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [139.227.253.12] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 07344580-20e9-4dbd-968c-08d8fe6b91ca x-ms-traffictypediagnostic: DM6PR12MB3801: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Dh0Lknx8d4zsRSV2VwmJ5u/haaH60AMruwXmOmpBG2K1hjF8qLGFK2XUnc9QsuE5J+2de8MEen1J0I3wQsJ4jJc1AQDkQGBpbAda47xecoeR+pzSDvYtW42uBbBEqImkJhOasJeel+Ee8yICOTr/UfIFUf51DFxnShy5skpfIQJLC06TkohWLYdtwXYZxocd6hWMCvtkqfFTTLSQQ3xwY4751bZDs2inK7EUezfTz6/CeB7tTZgOCaPWkTOpP9Wt7KEL0x9sMrfaWsbWOV6qC+HwH9eReARCy90rCHLPiG6jQVbQPensDyTkl1fHsQJD22lHWIWmC8fmURuTqEnaHIXAxJrjwCpz7utOCvI5nMGff7YBOJOdZeXU6/ETv65EvNhdNW6JcuPGVx1CwOBcChu85sI6Q2E67SawzHru+57Vk0M5f89Ryo9wvitc+BhXBg+ageAn6P9ZKR/XqHrzG3C/sOLfzMqg1DdCCuLEhQzxZikizjCYgZxsYGj8fswAm6Fu+y3rXjFUYaiNuW03/HWNmc0y9y/iXfh+jqm3vV29bvC4BLCpUl3ckfZUZW2BOimLAPDOsWkX4wbybX7BctDQ4qh0Elgs+Ur7UzNC9dCSNxL7DHd0WZxWmpUSFnqmfB4yVsOihgNv7ZSrSbr6Mks/XZoNpsyzYo7Qfpu9YU3IxHyMtcoQ3dONq9aNhUdx x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4090.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(346002)(396003)(136003)(366004)(76116006)(8676002)(8936002)(53546011)(66476007)(6506007)(52536014)(5660300002)(38100700002)(64756008)(186003)(7696005)(66946007)(66446008)(26005)(2906002)(9686003)(66556008)(54906003)(86362001)(478600001)(71200400001)(83380400001)(55016002)(107886003)(110136005)(966005)(316002)(33656002)(4326008)(122000001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?/5sxjcEaLwXNf1j2ieMAcgSOnlixuoymk9fYSIVhjypnOeM1/qFOrr5ClQu2?= =?us-ascii?Q?LjHhLpo2XP2ZmwX8WYOfFBWDf65QzR+8bpRXBL08wGl2lqtJHTI6LdxfCLpE?= =?us-ascii?Q?nrre7xlopIoMpGwBYpdvyGmk50g7AZMKhPjKrpph+gjt+3DYvMWMoI7J6rbN?= =?us-ascii?Q?PIKjXtWWPs30QTmoVrRuGTRYtdKkXdNJKBWwaT+hbV1IKRcwx0b/zrfFRT/A?= =?us-ascii?Q?GyVALqJ8EpI3MEBx6akaVyxogCVkbCVDQ+LqBs4VZri1XiH1zMYt3vdI8ZrJ?= =?us-ascii?Q?aT8L5ntzzuA8EfXfGp9E9jjW1CMFXZsv2Ug1Ge8ilCMFMhY8xidL/YKy7no6?= =?us-ascii?Q?ZjFjUgzDOpxK6ugv/Unw1Ag80hhjb42FbeI+VkjuTdr8mfrLhTtVYMBiM+ST?= =?us-ascii?Q?NqSZHrG0bYENud0aFV3UQgFRdVQmXGyVqhVehHikius9PwjvKMmdzHJNnGK8?= =?us-ascii?Q?vl8lRBfgQHje6Lk6flde2Zx9Q26Et8ucv1skdJW3P7BQWK34A6BCPgfXQpSn?= =?us-ascii?Q?EVLatBkuCRXPeNErHS8KxobgIrA4THdpjxiodIJB9vT+s/JWRoaELprpD/hH?= =?us-ascii?Q?Z5/QsoN5mvo+uKqJn92WUQbTGp5Sfv67+ziFvm9TTweQsiPycWroOVTuwig2?= =?us-ascii?Q?1vwkXZWlG6y460+qyc9K1ce+gDvOBs2E7YeTJLyMvw9+lZrvAYc1Ra0tCc5j?= =?us-ascii?Q?wiyymHDlOsTV6w+i5F93YuCydgP4KUXdMyHKTtjPky1sebSslInO3yQmGWHm?= =?us-ascii?Q?slQRfolZTngVkgujBPBY64P9EqEMT1BYn1uR6NVHBLpRemTX9dD70r0tu/se?= =?us-ascii?Q?qJrEXX0qUzGVifr44XEdasmyZIe3PoWZltRehz2fzZt/K3YLoA02dg7yL1L7?= =?us-ascii?Q?4NYQA1hFXF1i14+5twcdK/qwGph1WsHt1QCH3tZpQnZQrCoo8ciPboXKbo8w?= =?us-ascii?Q?KuPbDbXIk16ytJJxaxs3bHTHuIzNgquzhOn4VYgIz1GTuB6r1MnO/TiczYsw?= =?us-ascii?Q?hZrT4StvEvzNdgrXfZ5WFTmkj/Yy48sNGaTHccT8E5uURdOaHYD23TyaUeIV?= =?us-ascii?Q?RjQAgW/IPKzVx2LdPC2YSnSiX+zobCRsI6W8b4IRXTIAHYdegO2L59WbNkkA?= =?us-ascii?Q?QbyO/lBM054EKeQ2DRiNFAvc1bbOHCqoW6jLhW8vie6VKgIYnJqFpshORvjM?= =?us-ascii?Q?+bux5g+UQieD/jtonRvRLzfObKbu9uIjekCNTP0m+LTVOeLqT5z9sfUS93Ru?= =?us-ascii?Q?Psqe8uKT7Q5QpnXX9sdrh+CiG8mZFjCkiZpmuiwv663sP8Bpr1U8n30sceak?= =?us-ascii?Q?+bKFPQOrFpi0/DMZgIpbphda?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4090.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07344580-20e9-4dbd-968c-08d8fe6b91ca X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2021 11:02:03.2529 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0jRK0ksqE/42d23tgQNrO5Abj8hlyAaUhUPGVaE3swmH/Kfg4OG+RtzD8ICWUoEW X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3801 Subject: Re: [dpdk-dev] [PATCH v4 0/4] Support PPS(packet per second) on meter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, > -----Original Message----- > From: Ferruh Yigit > Sent: Tuesday, April 13, 2021 6:25 PM > To: Li Zhang ; dekelp@nvidia.com; Ori Kam > ; Slava Ovsiienko ; Matan > Azrad ; Shahaf Shuler ; > cristian.dumitrescu@intel.com; lironh@marvell.com; jerinj@marvell.com > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon ; > Raslan Darawsheh ; Roni Bar Yanai > > Subject: Re: [PATCH v4 0/4] Support PPS(packet per second) on meter >=20 > External email: Use caution opening links or attachments >=20 >=20 > On 4/13/2021 4:50 AM, Li Zhang wrote: > > Currently meter algorithms only supports rate is bytes per second(BPS). > > Add packet_mode flag in meter profile parameters data structure. > > So that it can meter traffic by packet per second. > > > > When packet_mode is 0, the profile rates and bucket sizes are > > specified in bytes per second and bytes when packet_mode is not 0, the > > profile rates and bucket sizes are specified in packets and packets > > per second. > > > > Add the necessary checks to the existing drivers implementing the > > rte_mtr API to makes sure that profiles with packet_mode set to TRUE > > are rejected. > > > > RFC ("adds support PPS(packet per second) on meter") > > https://patchwork.dpdk.org/project/dpdk/patch/20210125012023.1769769- > 2 > > -lizh@nvidia.com/ > > > > Depends-on: series=3D16301 ("Support meter policy API ") > > https://patchwork.dpdk.org/project/dpdk/list/?series=3D16301 > > >=20 > Hi Li, >=20 > I am not clear with the dependency chain, can you please clarify, >=20 > 1) Is this set depends to series-16301? Because it compiles fine after co= nflict > resolved, I can see in your repo there is an order, but if there is no > functional/logical dependency you can set this patch exactly on top of HE= AD > (removing the series-16301 in between), so the CI will be enabled. I will delete series-16301. But it will merge conflict when series-16301 merged after it. > 2) According its cover letter series-16301 depends on mlx ASO patch, this > makes all ethdev patches dependent to mlx5 set, I guess that is wrong, ca= n you > please confirm? >=20 > Above (1) is more important, since series-16301 not fully acked, it is bl= ocking > me to proceed. >=20 > > V2: create a unified patch that contains both the series with > > the API changes and the series with the necessary error checks in= the > drivers. > > V3: Fix comments about commit-log. > > V4: Fix comments about Depends-on and rebase. > > > > Li Zhang (4): > > ethdev: add packet mode in meter profile structure > > app/testpmd: add meter profile packet mode option > > net/softnic: check meter packet mode > > net/mvpp2: check meter packet mode > > > > app/test-pmd/cmdline_mtr.c | 40 ++++++++- > > doc/guides/rel_notes/release_21_05.rst | 12 +++ > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 31 +++---- > > drivers/net/mvpp2/mrvl_mtr.c | 6 ++ > > drivers/net/softnic/rte_eth_softnic_meter.c | 8 ++ > > lib/librte_ethdev/rte_mtr.h | 90 ++++++++++++++++++--= - > > 6 files changed, 159 insertions(+), 28 deletions(-) > >