From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA245A0579; Thu, 8 Apr 2021 04:32:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E1CA140F53; Thu, 8 Apr 2021 04:32:23 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2051.outbound.protection.outlook.com [40.107.243.51]) by mails.dpdk.org (Postfix) with ESMTP id 65C3740138 for ; Thu, 8 Apr 2021 04:32:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ahBUuJ91Gwai8jfz18+ywe1lZ1ZA+6zgtThvk+w5Clza6NTtd7cUwHz7KNGqBK8H2Lf7hiwE+mbi9wY3WtIiV+EfHxw8i4y7eViIzaB9FHWF1/m2IOqs2RA/S5B7z5dX5SYB+cIfENLEbHQn5h0Gvhy3B22TPXPnPvKtSnD3KAfqigTVV9rVuC1U2dWvw9/sVEzy4Y2bNpQPPqu0dyK1u8ZxzzGufbJ2ht+eemQVsalz5YY8T/GasLOEDXaUj6zf07v7bpZ73KzoKlSPENKPkMDuSjzMY0DRyhlER4AKgJl6T1WNoD6+uQ+DxEnSeBySxZsXj572wxi8/WfsKfVSeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=46BV4BiLvz0xCIm0x2UzrqUsuqWVK6PEqqgCnkU2cIk=; b=gJ0xx2yzVzw8QarLPs7RxuWIC/xLxmP4pLqbgBO0PJYzWFAW6p6cX76xcqy6D+lR5SfHuKp1CiFtfCpsEKR6okxawzjtp4U5x4AhcIrQqmZhcyvVCrSBBphfmiIeT/yoKlCV7abTABIjTBPHM0kV8Z6glFuRGXaYNjEc3XsY7r6o+B29Cc8Ww0UZnzjZN78rcwT2XoiZ+lKtobGQn4j6EaeGUXQSdLIwV8Qx3naalcHsmnVr05zSevMvLTqHadGk5TijS1E5yk7T3batBQk7OCB45wo2dS1X8nTeORjSati8wfek8HZ5mGaids1B2EdF/2c9CMcPJ53VebSJKxFx6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=46BV4BiLvz0xCIm0x2UzrqUsuqWVK6PEqqgCnkU2cIk=; b=dbysI8XM32hu+gCTr6T1oQg9cRW5zDk8d6mHXfCrn29BxLdUHJ2YjO9bSFUaQCeyaOb9oiNwckHXH3xNsRwdeqTuqCITALrMx3N3RUsWHRkNmfm2K5lmvDvVpzYgad15KV0Vw04HuFJWQ0IZJOzg1IJI9FjpgJ3kNa/TGgd27UHtceRuX7iV6I1h8wTc+XXcpLNd1q4+KpjhISLFimtgKZcxFkXA5RwbbP68ginZaymtcoAysZ3XfLWyuNDw3ayvl3IEsu71xQz+jjMFEbvtz6VlqPqT0rfobynkXdlIErDyHAtnfrrrvyg2hPDlU93HCWUFeXNuWO1AXt0G5KEoYw== Received: from DM6PR12MB4090.namprd12.prod.outlook.com (2603:10b6:5:217::11) by DM5PR12MB1275.namprd12.prod.outlook.com (2603:10b6:3:75::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16; Thu, 8 Apr 2021 02:32:19 +0000 Received: from DM6PR12MB4090.namprd12.prod.outlook.com ([fe80::fd19:da7e:347b:87da]) by DM6PR12MB4090.namprd12.prod.outlook.com ([fe80::fd19:da7e:347b:87da%4]) with mapi id 15.20.3999.034; Thu, 8 Apr 2021 02:32:19 +0000 From: Li Zhang To: "Dumitrescu, Cristian" , "dekelp@nvidia.com" , Ori Kam , Slava Ovsiienko , Matan Azrad , Shahaf Shuler , "lironh@marvell.com" CC: "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , Raslan Darawsheh , Roni Bar Yanai Thread-Topic: [PATCH 2/2] net/mvpp2: check meter packet mode Thread-Index: AQHXK+qCSbKC0eoH10GyQ7UsgHDjPaqp5tLg Date: Thu, 8 Apr 2021 02:32:19 +0000 Message-ID: References: <20210401061618.1478961-1-lizh@nvidia.com> <20210401061618.1478961-3-lizh@nvidia.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [139.227.253.12] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8ef856dd-668f-43b1-40f8-08d8fa36885f x-ms-traffictypediagnostic: DM5PR12MB1275: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QILjPBc3MSTuMp+MfjZfr9itNvDnKlxD94LavL6P3SdZfDA0ioOVcU4TOgewHTD+v6e4rK0yA+CInmKuR16iE38B6KIpZPlK7dHm5Io7HONhqN5sy6o7HJXRfPJitV3oum1DhCZPFKHf5/vjHgBE2lrHcNVkHHVnlaCGWo8Ya2ElDsuUQrVTyrEtiWo2OaBOnypTsCZu/h9+z1vRvhd+BoBnqsHbx/PejzAKnJK0dBHIAWDRTguGBpyv9gf4xFGB6USW4DGBpUOevSMbdqokpeGwH2KOiuoV6Q+dMdcIcO2S0XhdwF+O4kNLIsEiSnqboElJXbeo4GUKn1gXcnfUDFoR7iAG4RQQsn/OoPuu0l8qIRHP8IPZYDjkXD6Qtd7vTRmwelujbGd6Pe8oHAOGH3MYkAPA+SlaSz+sRb/G8/TiooAPTeLfRQGoN3sIKC2y35SrhHA+6KUXW+1IsgUI2C+vsP7vrPNuyeZ7lboJXc60qa8I3Wgw42k7mTBjCQKxHQxNerB19lCsyZTramVCv/9/WPRt20JzW1lXFHraLh/r+BUVc3QnV78gHHg6WQE7xiKDmXM0WNWCdBB+E8uDBf1ClujVIPISSzTuuXkaniwWrPbe1+YG777bPSjlryAjO62faZLmvK0RMzfr0ouMaQfaYVAgPxFLL177e9RCaVg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4090.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(376002)(346002)(396003)(39860400002)(86362001)(478600001)(7696005)(8936002)(4326008)(6506007)(52536014)(53546011)(107886003)(186003)(66946007)(5660300002)(8676002)(64756008)(38100700001)(66476007)(66556008)(316002)(9686003)(54906003)(71200400001)(26005)(2906002)(76116006)(33656002)(55016002)(66446008)(110136005)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?iC9SmK08g02sPOMVMwwYVu4LOb2dKnlGYi2vNnlJrQW+/wG+DUia4Kg1+QWW?= =?us-ascii?Q?VeqceX37msx6GPm44mQZpD1NTgIftSagSY4InWOOg1xXgdnbCpzLt/YDEjy2?= =?us-ascii?Q?UwoDbQqpiXjXH8MmvAPQ6mwb47TkyVbo/v+iF/zmOa4vg2NRKEVkfzkvjLxw?= =?us-ascii?Q?TbD3eLLPZHNFb9IoREmIRqSLouxsyy487sIyFAvlpaMvTf4kiHuRjKU+vu95?= =?us-ascii?Q?hHg7lFMZOIptzSBp5DcNJZAjV4F8XLu4dt2MLcmfKy+bZMkealytzbteoZJr?= =?us-ascii?Q?znJKKW3McOzMaHDHUfcABSzZXpHXeobCy7Bjihrb3rMc/nEuEzkJHDrvg95F?= =?us-ascii?Q?tLrfVAWQJgP+RskhPl6klYzxDq4p+RDE4Z41iEGkdWuvavS6DBh7/bZm0ZIN?= =?us-ascii?Q?rC4fz2DuHezAlz6FQuLkQylXJraOM75wt21ifuXYrxZfmUB03Stdxl7c/MnB?= =?us-ascii?Q?AR96KCNGwW3eaPxLR+Ci96DWO/rFJg8QZJnS9L3LGSEFzSmNm1J9enodnwe9?= =?us-ascii?Q?aCIK5pm1T3r08dotLfHo6xwprjxhYw5HzDaDc+IyaaIxpEw4cWkbNNknf9eG?= =?us-ascii?Q?8H1/F/HUR6kO7O0X5h3+LTf/MYIXkzsmcfBzVwXpfPIB0fafHL6arGpM3pWR?= =?us-ascii?Q?FJKl3bssLAurb/mwkHPz882Z4wM0OIHaSGP3uvJh2VhO5CGsL6AUd/piuvDX?= =?us-ascii?Q?qIOQlVIxQ7pNlC5jT+qije7zcup4gajm4+ceOQtvgdMAMI7PEo/Z641FmsuF?= =?us-ascii?Q?hh6tK0hgq1n/qXn1XDorAcNHGIavcJwwundADw7dds0YeUNh7Sf2gV5v7Ds4?= =?us-ascii?Q?cJHBLDCcwZb0vT0pu9KrZlxYbIBGYnf2R/pI60m4v9o13asBkVWNwQzMYk8y?= =?us-ascii?Q?Uj0HSi4jW4y0C5t+Jszyny6klbrkCsMaQNRchQnP+XtgZDH0dRZgWxo+4/A4?= =?us-ascii?Q?MuxUtgwjX2d4LqinTqL9MW2u9TckU+j/EqNxBH/pDoMM3MD+wOrgi8SZdfiq?= =?us-ascii?Q?NPityUz0ECfZ+w1z3nqZYV0g95cfX/x9bp26A55CHH3jk0NNrr/1DWQzlsPa?= =?us-ascii?Q?nBXb8snTPYnPEBdLFDzOet1++KnB9wbUAqSL4H+hm7TiRPQlD609SBRzapG+?= =?us-ascii?Q?aFM8Qxl+YUwvUaoex6a5D0bxSOaXaRurUl1j1HPdMY2C5Qj4+iZjjpj8zCy3?= =?us-ascii?Q?ZDSPxPmuI33tot2RSLE9UyEWgyIIQtkkQg2+/4KVMu9sF2I56l2chytiPmmE?= =?us-ascii?Q?l7c8jNP5GJNQPBrpcCwQ+YVG18oTF5DNyQdnL6TfqEmA/43hG8YLbY3jNExa?= =?us-ascii?Q?9WixWFmAUYg7ziVAfV6Fo3e/?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4090.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ef856dd-668f-43b1-40f8-08d8fa36885f X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2021 02:32:19.4324 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kqudKKYmOffP4ofL0n+C607yMQzgwYsSo/W67anuk+lvzcPX80AykDA5MqiK6IM/ X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1275 Subject: Re: [dpdk-dev] [PATCH 2/2] net/mvpp2: check meter packet mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Cristian > -----Original Message----- > From: Dumitrescu, Cristian > Sent: Thursday, April 8, 2021 4:14 AM > To: Li Zhang ; dekelp@nvidia.com; Ori Kam > ; Slava Ovsiienko ; Matan > Azrad ; Shahaf Shuler ; > lironh@marvell.com > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon ; > Raslan Darawsheh ; Roni Bar Yanai > > Subject: RE: [PATCH 2/2] net/mvpp2: check meter packet mode >=20 > External email: Use caution opening links or attachments >=20 >=20 > > -----Original Message----- > > From: Li Zhang > > Sent: Thursday, April 1, 2021 7:16 AM > > To: dekelp@nvidia.com; orika@nvidia.com; viacheslavo@nvidia.com; > > matan@nvidia.com; shahafs@nvidia.com; Dumitrescu, Cristian > > ; lironh@marvell.com > > Cc: dev@dpdk.org; thomas@monjalon.net; rasland@nvidia.com; > > roniba@nvidia.com > > Subject: [PATCH 2/2] net/mvpp2: check meter packet mode > > > > Currently meter algorithms only supports bytes per second(BPS). > > Check packet_mode set to TRUE are rejected. > > > > Signed-off-by: Li Zhang > > --- > > drivers/net/mvpp2/mrvl_mtr.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/net/mvpp2/mrvl_mtr.c > > b/drivers/net/mvpp2/mrvl_mtr.c index 2fa5cb43ad..055be6f6b1 100644 > > --- a/drivers/net/mvpp2/mrvl_mtr.c > > +++ b/drivers/net/mvpp2/mrvl_mtr.c > > @@ -88,6 +88,12 @@ mrvl_meter_profile_add(struct rte_eth_dev *dev, > > uint32_t meter_profile_id, > > NULL, > > "Only srTCM RFC 2697 is > > supported\n"); > > > > + if (profile->packet_mode) > > + return -rte_mtr_error_set(error, EINVAL, > > + > > RTE_MTR_ERROR_TYPE_UNSPECIFIED, >=20 > Can you please add a new error type for this specific error case, i.e. > RTE_MTR_ERROR_TYPE_METER_PROFILE_PACKET_MODE. >=20 Thanks, I will add it in V2 patch. > > + NULL, > > + "Packet mode is not > > + supported\n"); > > + > > prof =3D mrvl_mtr_profile_from_id(priv, meter_profile_id); > > if (prof) > > return -rte_mtr_error_set(error, EEXIST, > > -- > > 2.27.0