From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9A5BA0C47; Tue, 16 Nov 2021 20:15:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8495841142; Tue, 16 Nov 2021 20:15:00 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2072.outbound.protection.outlook.com [40.107.244.72]) by mails.dpdk.org (Postfix) with ESMTP id B1D0C40141 for ; Tue, 16 Nov 2021 20:14:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rqj5OWOvtF+W4QRvQ2xPXTDHKHK5Ee6itc+E6WwSgSzdGEtYIdrPgo7e77xkxWp29aObofdoiXNxFgahH+nOFc/R5r/5o8zkSbOdfo244KNdiDl4IDmtqQ3YiClPYmnmS8+iH95/bS9euI7hOzJ7F5L+kbAVcbsZFIWXclTW0ZYhhbgyqsJ1WU4jArcz75RgyfGGSDjs44BhkmIhUF0NxA/9XXNgP3E+EizrI/Iken9Vo/+y6jrBZu83+qFY8FttJQA5Ln0gUuE+KhQ9jReRzZFbUkqk9cipNk/q6hq9x9j4N3dSny44l9NX5N7vicrEEFPwjWcwc9WO4nCfXRQQ4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zfPEzwKmvuOg7RI0oO5bOo4R6tptFyssGB4/YLpc80s=; b=VRdOZ7AmAGwa13LY5sTqMDurjYFalwxATZaONeKJ3jIp9NzCLpTQvAEnA2u4Oc++OAv7AD2FROgMT7polqfvvQxmjZAFfLiH0sKp4P+HNy3xH+m2tL9zTC0wXUkjlVU90I+ri34co2VRkjOR0VLeQ1Nr7YIh1L5V1DQyS/Fs9m4VoqHXmxCe82s4CijkTVr0YcPFq/EWEmAnnnAOYam27pT3z1UBGf8FGvM62SuCKsP+S+atatJ6g5HutyA6FR65viNbqRqyLIBqGnetCf39Ve4PcWLUWWZe5dqkJyQHFqmhL/+EP01fErMc1zS2W1ygqlFG3Ax/1e7SWwF/w3z2iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zfPEzwKmvuOg7RI0oO5bOo4R6tptFyssGB4/YLpc80s=; b=AK62RtX2PwV8+vqYl2UqjpY4fJgzqHgD8uK4e1UYRoGQ5OkEAZ5qBOATicwr2Fj+ig3nxybE7c87hsnJuI/t+VFgUsWE26X5tute4KtOSBj2U3y3bej73G8p6y51GaXcUXbxVyzcTxCaL2BsgmXdBeA+JtRcyTU+JAOaj59u0zBZ/0Vk1JQ8V7UTHCRjE/gvo/CotF6w4onek1Xx3JjTTbpqHFNF4HBXYV9nEpZ6sSgqdE717FRWYKm5OIwK7vix0NfykvNOZbQhNFxtMQE53B3WzxKg91D8a718iQR5OmMpA0uBxtikgYz/hmsbEUjtQrv2teT+9rhmhUOwoXFwjg== Received: from DM6PR12MB4107.namprd12.prod.outlook.com (2603:10b6:5:218::7) by DM6PR12MB3882.namprd12.prod.outlook.com (2603:10b6:5:149::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.27; Tue, 16 Nov 2021 19:14:56 +0000 Received: from DM6PR12MB4107.namprd12.prod.outlook.com ([fe80::98ea:e961:8212:62f4]) by DM6PR12MB4107.namprd12.prod.outlook.com ([fe80::98ea:e961:8212:62f4%6]) with mapi id 15.20.4690.027; Tue, 16 Nov 2021 19:14:56 +0000 From: Elena Agostini To: Jerin Jacob , Ferruh Yigit CC: "dev@dpdk.org" , Slava Ovsiienko Subject: Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine Thread-Topic: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine Thread-Index: AQHX1wB5uV4YZTE2eUiW76jkbL7kjKwGeCwAgAABmbeAAALdAIAAEFKAgAABXgM= Date: Tue, 16 Nov 2021 19:14:56 +0000 Message-ID: References: <20211029204909.21318-1-eagostini@nvidia.com> <20211111214141.26612-1-eagostini@nvidia.com> <20211111214141.26612-2-eagostini@nvidia.com> <569619d5-12fc-4338-3042-3581074ad3a9@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 35a300c6-c559-4fc8-e9d3-08d9a9356047 x-ms-traffictypediagnostic: DM6PR12MB3882: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SWN+gz7OTxZ8IztA8vsXI3ZFnfP2tnpbRv/j90FYOS/CYu0cwvHd2a+Gdl+DLPg1X5u3o+6K/zyXH8ytECkLHLCy3cEa1gYA0BFtgDuERpfo+cPlrsQ54IhjvaV1GCCayfBdh8agxFndg5KFzsrAZzw03n76eGuj6u3liiRpA+KVvB3Ghl+BQKz9Am/4JA64MtL1l0rvgVt3QcGVNhYYHIFeGSTGyN8J71333EUd6/7ADNmSImEG62H2U7X9QSE3Vt8MaQ9uFLZDSZs9cFDS82VFtvhpb+OFDzuDZw2EBt9zf7+K9b7Jui5Et7knPXYq81Z+x67DT1E8ST6DpUp0SHhdA4EXc3n9QzcuZJhOZB3+94PrhX61lQUPax/08/fR8vU+teSRr74vlZZQZF4AVbW9082zTEl3vmfkRXPr+JQbpjF5B7v5H55NpIorhVHU4iA6FRhjP2SFuCwrJkVuuxwCjbvHk36LFEuhIR0MoH3E0Dcgfxx3E5Q565h0homsTJrtGhmLw6MU8/iqWcdV9a9pb9J7Rd71r0gg0t+rv/mcYPjgUHkmnaMfGjEEUSBKJi/0TxS0LbcsiXVgXx0qFiBv8u4HAFpbmPU2m1/A+dJh5t9zD/m6gVk/s0OuoXRU2w25fqOrU+TYtjATTWwgjJ3FE/TXoAvKj5V+gBArL9AWyXg+S+jrPUYDCmvwqaEYTau8MYMHL5HdEZ3T919NRw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4107.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(4326008)(508600001)(66556008)(9686003)(7696005)(52536014)(5660300002)(122000001)(8936002)(33656002)(8676002)(38100700002)(66476007)(38070700005)(53546011)(316002)(54906003)(6506007)(86362001)(55016002)(71200400001)(26005)(66946007)(186003)(107886003)(64756008)(91956017)(76116006)(2906002)(110136005)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pF4o8iHZsTQXzrV9cRB8/8nvnimz7NGJs2Xqx+3l1tv2lm4HM1FA19v4P3fW?= =?us-ascii?Q?phESGVB38jV/b4Rabd81I+JmohU3Xv4bzv+JKSXfX+gHMJgeZqf6xd37JRDF?= =?us-ascii?Q?MhAWnMsdwWRSEZyGwBrZpxCyOWyUU/YzjsPGru3oojgsWR4sYjBcdKhgcLGR?= =?us-ascii?Q?1TIx4g/H2+GgSfw5l5VHH09/JyMIHOvCSSXmH2D9sAJNZSPQeZv4EjmxlrLJ?= =?us-ascii?Q?2Q9OISiJjOUIE+peLTQAsPb85eV1Fe1zKnP+ntj/bmEB6yuzrEgD5xsKWGq6?= =?us-ascii?Q?2nbkqIc21TIIOBFokPu1ItVY+w2KU58ibdzIdYg1qw5Di4wZoadk1tq8St+/?= =?us-ascii?Q?ZU27uNIK5yAOsVgKCa1QVL0elIx+Oe5MXSuewbauknHnxNgPDOk7AJvQf7JR?= =?us-ascii?Q?92+qvXm13X7pR2v8KnVeYbKh9cgSZFBG61jWsOduJsblHCZJGApDn+wMorIg?= =?us-ascii?Q?kItH10J10BkkPXZ60w3DH02egKMzEUrPHWCk/77ZngcmUHLqsI3y5qhg1Evl?= =?us-ascii?Q?CPhUWhLifKmMREdu99b91sTzogBTQrVIjAMGvFH182MXMVpke2RZAitA7oZu?= =?us-ascii?Q?ZjXyaE7vlubRYRP6dGQ+ldCr9gsKfqKn4qTdmVG+5p275+Pz+BSKY1dNxQN2?= =?us-ascii?Q?SEEena2b7V/YEZlBxhfY9q/1JkR+JjbdQwPgeM89CCpnTNjmka9drsKQ8ACg?= =?us-ascii?Q?FPHbXux8DHMDr3OtxZt4o4Gk8S1+E1KSAomBu4yfyhheSzFAstMijBo278U9?= =?us-ascii?Q?rO2K9cJv2L3xrqZ2bxF/YcPf5r39VlMVn1Ny+m6zT+ybLGslERI1SScMsVei?= =?us-ascii?Q?vkS/hodLCCQ8W83yTNTgiIWn5t1LZjbWxZPg1nLQ10moHjKcX3pXJUQImWrC?= =?us-ascii?Q?QwTJFRQ1+5iQ3eTB+6EvA3PRUf/grfu+padh13oMDjJybrMHDlZYhBqdZLqS?= =?us-ascii?Q?v/58CSF7veRh5R3W1kwzChlJvxHn8OFzxO7fHxW8K62QNiyeqa4d/rP2WB5D?= =?us-ascii?Q?AlKU5Tf42TmSdDBeOEVJ0lzlyDPltWdm0NGUajJxThX64GmmsjirxkxGQT2j?= =?us-ascii?Q?0bYeNG6F01FpV4P7PkYd8+rxsRSbvrV3W0tFgcwD9hFIcXL1rMLjxt5/Ef4R?= =?us-ascii?Q?y4NA5ECNfdrt+ZVcDG+Wq9RDL1lrYPFvotpIFXr1BPCBH9MzxxGnE7naZKcS?= =?us-ascii?Q?OkAn+zh09jThUvPoYe9RTIOt8KVBxC0qqZkhc9HEJaVdVQNEdqevPopQqpSd?= =?us-ascii?Q?ypkOAV6NJHkMCtiNn+Rlml1UQfzmmtKFT4TcCfFPHq5MTXJP60ri+l5eYbwy?= =?us-ascii?Q?WyfioAn180tyVybDb78D9Oj+2peUdaGJqflyukjIDP1wXMODDLtA3JQPL93r?= =?us-ascii?Q?l3KR2Jieb1tFZ0LHrnLA4BDaBRa2BcAQ51qs/Qs6rqgdnFpbP9BpWdhQBWbh?= =?us-ascii?Q?HIrnJo9/Dq/XWcAaSd5mZlaKkO3IOcUCHCwFkX7a9W1N3f9YmVFoZHVEvxjY?= =?us-ascii?Q?gvL0xqxI/RsCE8R6/aPLquEwP/kFgRyeNtcBWzYYzBgdjQtp+inYZsJvm1Tg?= =?us-ascii?Q?TAw/SFahnYx6olEEceTAmrBBS9w2uvAJqstfvIAPeO/yLEx9HPqHC8YtS+51?= =?us-ascii?Q?05Mz7riJfiKOAjtACQ8zV8GHIp0Wv4CWErtO2SL3cmCI?= Content-Type: multipart/alternative; boundary="_000_DM6PR12MB41074A1938ED4FC3E37D3C34CD999DM6PR12MB4107namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4107.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35a300c6-c559-4fc8-e9d3-08d9a9356047 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2021 19:14:56.2545 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rA09JzRNSvAiK1SJxoURmollJWu2/PWQOyTg4DhBkpEre2D8DgmqUDFkR//kXdtQ6Mhhy61g5da2+4VtsBAqiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3882 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_DM6PR12MB41074A1938ED4FC3E37D3C34CD999DM6PR12MB4107namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > From: Jerin Jacob > Date: Tuesday, 16 November 2021 at 20:09 > To: Ferruh Yigit > Cc: Elena Agostini , dev@dpdk.org , S= lava Ovsiienko > Subject: Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd e= ngine > External email: Use caution opening links or attachments > > > On Tue, Nov 16, 2021 at 11:42 PM Ferruh Yigit wr= ote: > > > > On 11/16/2021 6:06 PM, Elena Agostini wrote: > > > > From: Ferruh Yigit > > > > > > > Date: Tuesday, 16 November 2021 at 19:00 > > > > > > > To: Elena Agostini > > > > > > > Cc: dev@dpdk.org , Slava Ovsiienko > > > > > > > Subject: Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in = iofwd engine > > > > > > > External email: Use caution opening links or attachments> > > > > > > > > > > > > > > On 11/11/2021 9:41 PM, eagostini@nvidia.com wrote: > > > > > > > > --- a/app/test-pmd/meson.build > > > > > > > > +++ b/app/test-pmd/meson.build > > > > > > > > @@ -32,7 +32,7 @@ if dpdk_conf.has('RTE_HAS_JANSSON') > > > > > > > > ext_deps +=3D jansson_dep > > > > > > > > endif > > > > > > > > > > > > > > > > -deps +=3D ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'bus_p= ci'] > > > > > > > > +deps +=3D ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'bus_p= ci', 'gpudev']> > > > > > > > I didn't review the set, but in a very high level do we want to ad= d > > > > > > > 'gpudev' as dependency? Isn't this like adding 'rawdev' as depende= ncy. > > > > > > gpudev is a library that can be built without a gpu driver as all the= other libraries > > > > > > and itis actually used only in case of GPU memory mempool. > > > > > > Reasons for this patch are: > > > > > > - Have an upstreamed benchmark tool to measure network metrics using = GPU memory > > > > > > - Test some DPDK features not really tested anywhere like the externa= l memory mempool feature > > > > > > > I can see the reason, that is obvious, yet again why we are not adding = rawdev > > testing to the testpmd? But adding gpudev. > > It is easier to add it to the testpmd, and for some testing perspective= it > > makes sense, but still I am not quite sure about this new dependency, I= would > > like to get more feedback. > > I had the similar concern earlier. IMO, It is better to have a > separate test application for gpudev like > other device classes. For eventdev cases when it needs to work with > ethdev for Rx adapter cases, > We have enabled such code in app/test-eventdev to make testpmd focus on e= thdev. gpudev already has a test app in app/test-gpudev. gpudev needs to be also test with network card and today another applicatio= n decidated to test gpudev over the network would be very similar to testpmd = io. At this stage, there is no point in reinventing the wheel --_000_DM6PR12MB41074A1938ED4FC3E37D3C34CD999DM6PR12MB4107namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

> From: Jerin Jacob <jerinjacobk@gmail.com>=

> Date: Tuesday, 16 November 2021 at 20:09

> To: Ferruh Yigit <ferruh.yigit@intel.com>=

> Cc: Elena Agostini <eagostini@nvidia.com>= , dev@dpdk.org <dev@dpdk.org>, Slava Ovsiienko <viacheslavo@nvidia= .com>

> Subject: Re: [PATCH v2 1/1] app/testpmd: add GP= U memory option in iofwd engine

> External email: Use caution opening links or at= tachments

>

>

> On Tue, Nov 16, 2021 at 11:42 PM Ferruh Yigit &= lt;ferruh.yigit@intel.com> wrote:

> >

> > On 11/16/2021 6:06 PM, Elena Agostini wrot= e:

> > >  > From: Ferruh Yigit <fer= ruh.yigit@intel.com>

> > >

> > >  > Date: Tuesday, 16 November= 2021 at 19:00

> > >

> > >  > To: Elena Agostini <eag= ostini@nvidia.com>

> > >

> > >  > Cc: dev@dpdk.org <dev@d= pdk.org>, Slava Ovsiienko <viacheslavo@nvidia.com>

> > >

> > >  > Subject: Re: [PATCH v2 1/1= ] app/testpmd: add GPU memory option in iofwd engine

> > >

> > >  > External email: Use cautio= n opening links or attachments>

> > >

> > >  >

> > >

> > >  > On 11/11/2021 9:41 PM, eag= ostini@nvidia.com wrote:

> > >

> > >  > > --- a/app/test-pmd/me= son.build

> > >

> > >  > > +++ b/app/test-pmd/me= son.build

> > >

> > >  > > @@ -32,7 +32,7 @@ if = dpdk_conf.has('RTE_HAS_JANSSON')

> > >

> > >  > >   &nbs= p;   ext_deps +=3D jansson_dep

> > >

> > >  > >   endif

> > >

> > >  > >

> > >

> > >  > > -deps +=3D ['ethdev',= 'gro', 'gso', 'cmdline', 'metrics', 'bus_pci']

> > >

> > >  > > +deps +=3D ['ethdev',= 'gro', 'gso', 'cmdline', 'metrics', 'bus_pci', 'gpudev']>

> > >

> > >  > I didn't review the set, b= ut in a very high level do we want to add

> > >

> > >  > 'gpudev' as dependency? Is= n't this like adding 'rawdev' as dependency.

> > >

> > > gpudev is a library that can be built= without a gpu driver as all the other libraries

> > >

> > > and itis actually used only in case o= f GPU memory mempool.

> > >

> > > Reasons for this patch are:

> > >

> > > - Have an upstreamed benchmark tool t= o measure network metrics using GPU memory

> > >

> > > - Test some DPDK features not really = tested anywhere like the external memory mempool feature

> > >

> >

> > I can see the reason, that is obvious, yet= again why we are not adding rawdev

> > testing to the testpmd? But adding gpudev.=

> > It is easier to add it to the testpmd, and= for some testing perspective it

> > makes sense, but still I am not quite sure= about this new dependency, I would

> > like to get more feedback.

>

> I had the similar concern earlier. IMO, It is b= etter to have a

> separate test application for gpudev like<= /o:p>

> other device classes. For eventdev cases when i= t needs to work with

> ethdev for Rx adapter cases,

> We have enabled such code in app/test-eventdev = to make testpmd focus on ethdev.

 

gpudev already has a test app in app/test-gpudev.

 

gpudev needs to be also test with network card and t= oday another application

decidated to test gpudev over the network would be v= ery similar to testpmd io.

 

At this stage, there is no poin= t in reinventing the wheel

--_000_DM6PR12MB41074A1938ED4FC3E37D3C34CD999DM6PR12MB4107namp_--