From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 943D6A0C41; Wed, 17 Nov 2021 12:26:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 826A1411AB; Wed, 17 Nov 2021 12:26:56 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2063.outbound.protection.outlook.com [40.107.243.63]) by mails.dpdk.org (Postfix) with ESMTP id E0D4A41174 for ; Wed, 17 Nov 2021 12:26:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lIN0UKpHElkGT0o0RIlt3i6mvWtfaoNhl4LAerqMbWdVdtT3qFkFWjhASQqvL9BUv14TU5PFuB0TOwCMpANt1cZoFdeeVGoWhp2IKz053osPm3wW6QYQiy3f1G3yAtNjdkRFgS4bbsoJhkbuMKbMhI7lcJKyyk8LoGKzyF4tN9hieR70zKAmRH+07HQac2jYg4zT5nGQkt7ZlEzwBeTLJzYkG0bfEBxeMCMkIea8I4EzRpe90jTeR2YUoSrjYTj2n0IeWnTr3CUSe6adM3myLg7RVR2sI7orR34easuh/xNXfNjeG1pj1+Tu960zZn22IcZOTuIwDAVjsrORQE0nTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mEKqqDtU/ikfFEaf5J91um+e75nnsrTWp5lVI5ZHkWc=; b=EXnUe4u8+i3IFP+6u9mqi/OnF1lUqeXYp/zlBcrUoklyARECMJtDHUx+se72oST407JabgCyDEzNXup1Ik+J/UHsbKFnnr91XkgVpFaDBKCvD6GVjeQ4GHLdMV9mSHvm9KEsBBF59Ip6GvLhBYyNC26fY+yz6UyNF/k/WF8/ZGbx2a46/b5L5RsVQkxJsOYJRYSuizdxssA2q8Gj7fYSfm9VcgUKdBeVwXdYtdAPu0AHlLMzEguqiNM3sQf4+U+yLvsCpuNEMN+I3cf3Om/LImdAbfIjKLLw5QUhC4ZijQXAYAt5a4wfb4/siK8svKbvrEaLReAgDBHNlWQq5VK4fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mEKqqDtU/ikfFEaf5J91um+e75nnsrTWp5lVI5ZHkWc=; b=LRqTAzQP8skPFCOGew8SXcH9/pjsfFZsgj5g1/xXszpm68dd+EiIfw9Prhi4stRdJ5ytyrAZkm5QHkL1+wGgaLWdjTmGi+T1U3LzsVfrNPJuEqzx9E0LesW69nMMwhHBKSHPKLODtgxwv82Fav3SnBWqYOIHP8rUJGk8WXKsFPssj5hNPJgwid9O/bLcmd4IX9fafuNmbCv8PjFsn8s5WuuaAbiqnLgwUEmQRrP0Yj87bmFaj6Habh5i9UjEKBuu3QOBG7G//+AISBreSQSSiDoMx/hF83wZ9SB9z+j84pWpFqFgoULdvOLgzVHCN6Znf8WYzXNt0xuUm2JHv1IycA== Received: from DM6PR12MB4107.namprd12.prod.outlook.com (2603:10b6:5:218::7) by DM6PR12MB2682.namprd12.prod.outlook.com (2603:10b6:5:42::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.27; Wed, 17 Nov 2021 11:26:53 +0000 Received: from DM6PR12MB4107.namprd12.prod.outlook.com ([fe80::98ea:e961:8212:62f4]) by DM6PR12MB4107.namprd12.prod.outlook.com ([fe80::98ea:e961:8212:62f4%7]) with mapi id 15.20.4713.021; Wed, 17 Nov 2021 11:26:53 +0000 From: Elena Agostini To: Jerin Jacob , Ferruh Yigit , "Richardson, Bruce" CC: Stephen Hemminger , "dev@dpdk.org" Subject: Re: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools Thread-Topic: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools Thread-Index: AQHX2xtuLnccivIdaEyRk5cICPLtBqwGrVmAgADi4JqAAATLgIAAAH8y Date: Wed, 17 Nov 2021 11:26:53 +0000 Message-ID: References: <20211029204909.21318-1-eagostini@nvidia.com> <20211117030459.8274-1-eagostini@nvidia.com> <20211117030459.8274-2-eagostini@nvidia.com> <20211116133449.7b7d21d1@hermes.local> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0762d958-fd6d-4627-abe5-08d9a9bd2803 x-ms-traffictypediagnostic: DM6PR12MB2682: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7NlCkJpP8iOvCowU7WMJtKgdeWV6PHlGDiJS+ZMsiEbttBsvyh7vnPX5/0uNK6VN4LUdxk9wnfJvnR5A0Hn4quCpozK3IoRlQxlt7PBkF6ptTyvKPBHyvwkJ5GMqGxdYRV0MTSaj3t742BGJHdK9KMIU9SeQU5yYEKKtQ+hxZQhDDeytv7XayciwBtImPYNxGhf7PJO0MsJASu5py81aNghjaCTN3Z1hDj4DVt53UTVktHlD3K1qvwYmTuZl7i4L4awRKpyI81lHVyWWM8YsnH9D6uMEwRs8YvToHi4BtO4ZtHhjrD1yOPnzOhYwTLPhfhfOKnBGg1k9Cmsg6OWsyXk+dtPTCUPL+Q7JxShKmdbhrKc4JigeoJIUUn6uzprL2e7/3V9kT6RbWFH7YHcnZ8aB+ZbXsKvBcNuIMFDA7ywXJ01UnwHWBwlwC8ACc+fSOxo9QOYSjvbf850wwBhrROLWAqR+lRCcyb8vSB9wdLaEtsi7x2LPcl2Ai5Rd/x89lK43+Mw0vZ3p8eXvdbyfB2QyvWel6tBP40k/FRLJNeDSu3tkNqRLPP4QjzOtOXCKoyCciFeHbFQYdDlnotG0fIP12sr1ijKZj8ZIQ3iyD8/F3ukmirq5NJKvAlYmecLAKCiY8QEEMW8VPnZeMy4zeSpONVBUgZG5SDepVXV5gt8ifB6uQboxP/MPLEIwqVInuIZotjcEszAN3GqywPj6rQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4107.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(83380400001)(33656002)(4326008)(66946007)(38100700002)(71200400001)(122000001)(66476007)(66556008)(64756008)(54906003)(91956017)(76116006)(8676002)(7696005)(110136005)(86362001)(38070700005)(508600001)(316002)(5660300002)(52536014)(53546011)(6506007)(55016002)(9686003)(186003)(26005)(2906002)(8936002)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?P3h4xdgUmN0OY2idgMst0tcVWSlFdux2bJHjA6c2Mb1po4w1EpK0Hc9wRclY?= =?us-ascii?Q?Icjyo5JXHY9anIX0VODPUzq5m3nERqaqXBgT+vL0aSGJwkly85MvKyTz80kW?= =?us-ascii?Q?XxQygf6LrbKMGQuOhsulLwwgI3Z1L7b1yTqPA/itUaiE1XsxEKwSJ7XT1piG?= =?us-ascii?Q?R7ZNKfMTkH+q8D9SqyjUQTndWdOZe+wTM0UVy2G3sD3I4//MnywOgIsGP2cS?= =?us-ascii?Q?0p0yWDlZiljG6TZW+G+PQYFdt1xIBfI/NhlhA99l3uNewJ6PNIfiQy/qamI4?= =?us-ascii?Q?nTmK9j0PHbm3KhEx2SjQOP7Blv7+1S1GimAQxejbQLKGGXPS2bRBUJwLK3zf?= =?us-ascii?Q?58j4qj6U7OTkcxH8QkKeARx2TW+LCQWmfp6WU4Pvns5zVDj+HXyne7NW865Z?= =?us-ascii?Q?y+i+fORHGUBbciVYV1VjCIYbtLlYkGGqyEkaPmSG7QKhRlsKRCwDh3OHIgKR?= =?us-ascii?Q?U8uDGMHMpvLOtWbj6KWE0FqkALzKghTDD1NxVC5QTohz4fzWacn7riFdZQwZ?= =?us-ascii?Q?YJ47GZbCfudL8RQ48oCZ+bdVBELWipHrIspmcZzR66nyIjFIEts52S50OE5c?= =?us-ascii?Q?qwOZyCVV4he4A4nkf9H84stThjMAKw52BnK0VGDO6fYppO4PA6CNxIT75+b+?= =?us-ascii?Q?Bm+JdlZ0vp4jgl3i0UQAhv1prVxCi5wRRNSV6+6vY/4zjl1+qhm6E1G/vKFj?= =?us-ascii?Q?oHfTTK6qfKN/27WgAHkdeRhkKXY06wR+JAa5Bz6hGCD05CiHFVIL8BrI0964?= =?us-ascii?Q?V7So66jvpjh2RktMzWz8jd8myujO+plSfwVxeFLIFfgEhSFbVFJtv45kmSQB?= =?us-ascii?Q?fXa+i1SQ8da0Ulu6lflzErYgTHuaL03OzyihQU5uQuDQZoKe/m394N10X6/z?= =?us-ascii?Q?g2gs93yyZUd4mRX3vF8+wcZKVpHWvgNJzvUjF2ShPw1Tteqq1E56oZznd70h?= =?us-ascii?Q?oJBJOtqfceJ5JnUGTLYic7vXzfAlU7WcS8rS1+G++6yL/JCEJ/k7jYP8tSXG?= =?us-ascii?Q?COohHQTNECVxC39udMfO9yGKXNj46E4O3oJZQUrxcDgW5KYKC6MwL/5eEBhj?= =?us-ascii?Q?kf7clBxq9mLLdCyooXDGRENsTb+pzIjRRLI5UZ34Oh4jADn9T8oY2pH+XmBq?= =?us-ascii?Q?e4bVZiLFSaJLXAVZtfoiqMEVI25+BY5Dje9oAnOJghM9OADI+h8F9QKx4viJ?= =?us-ascii?Q?yGsUQEe5vAfxQ4hIcXEvk/76wEsbcvwLe+pEym760ZyWjNcAH3AtL7PrKd9K?= =?us-ascii?Q?0f0lhSyd249b1LDDM8Uh+n0yLcUCm/TBPqhEwXhzPyXwx0MM3MsA0uvlJ6aF?= =?us-ascii?Q?tFVMqop3LRcpiQi/BGryOIXn2BZhuoYL84wHAvkTmts3RjrFmAhML9OFm2L6?= =?us-ascii?Q?zhkSK5uYi+nvBQdNbP9TmwzGE2NPvhUwKAfsK/WLC2A9McUC9iS6saqxwh7y?= =?us-ascii?Q?7pSrsKzkbmkYt6pZRHqD4YhkVLPD3BlosmC8OX/nZFvqFZQSN814yf4Nvud4?= =?us-ascii?Q?5sT27D+Kv6T7oW2ZdG3CcOvCwqDuxrYIOMYLnV5ms7KMc/rnVcDWf35Q11rm?= =?us-ascii?Q?mJPVJ3RmS1JqrXKXZnVttP4MOGnYi6BS/vgkz9p8xVpoKrqaDqGViepMTHxJ?= =?us-ascii?Q?EJz0JdxIw0F4kaTL7/aJd5++Zprs1VPfvHhthlNyBI5a?= Content-Type: multipart/alternative; boundary="_000_DM6PR12MB4107585DFA949264D9C7A79ACD9A9DM6PR12MB4107namp_" MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4107.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0762d958-fd6d-4627-abe5-08d9a9bd2803 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2021 11:26:53.4519 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +AQJPZlSgUo7/rMX92RbtqHxMXlB9kADEeFVJusB8JTi0LjPB9skbD4rWiHR3TvaU7+A1oprdrSG1DPtu4XgKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2682 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_DM6PR12MB4107585DFA949264D9C7A79ACD9A9DM6PR12MB4107namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > On Wed, Nov 17, 2021 at 4:38 PM Elena Agostini wro= te: > > > > > External email: Use caution opening links or attachments > > > > > > > > > > > > > > > On Wed, 17 Nov 2021 03:04:59 +0000 > > > > > wrote: > > > > > > > > > > > From: Elena Agostini > > > > > > > > > > > > This patch introduces GPU memory in testpmd through the gpudev libr= ary. > > > > > > Testpmd can be used for network benchmarks when using GPU memory > > > > > > instead of regular CPU memory to send and receive packets. > > > > > > This option is currently limited to iofwd engine to ensure > > > > > > no workload is applied on packets not accessible from the CPU. > > > > > > > > > > > > The options chose is --mbuf-size so buffer split feature across > > > > > > different mempools can be enabled. > > > > > > > > > > > > Signed-off-by: Elena Agostini > > > > > > > > > > Won't this create a hard dependency of test-pmd on gpudev? > > > > > I thought gpudev was supposed to be optional > > > > > > > > Sure, let me submit another patch to make it optional > > Why to add yet another compile time macro everywhere in testpmd and > make hard to maintain? > Adding iofwd kind of code is very simple to add test/test-gpudev and > all GPU specific options > can be added in test-gpudev. It also helps to review the patches as > test cases focus on > each device class. Test-gpudev is standalone unit test to ensure gpudev functions work correct= ly. In testpmd instead, there is a connection between gpudev and the network. --_000_DM6PR12MB4107585DFA949264D9C7A79ACD9A9DM6PR12MB4107namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

> On Wed, Nov 17= , 2021 at 4:38 PM Elena Agostini <eagostini@nvidia.com> wrote:

> >

> > > Exte= rnal email: Use caution opening links or attachments

> >

> > >=

> >

> > >=

> >

> > > On W= ed, 17 Nov 2021 03:04:59 +0000

> >

> > > <= eagostini@nvidia.com> wrote:

> >

> > >=

> >

> > > >= From: Elena Agostini <eagostini@nvidia.com>

> >

> > > >=

> >

> > > >= This patch introduces GPU memory in testpmd through the gpudev library.

> >

> > > >= Testpmd can be used for network benchmarks when using GPU memory

> >

> > > >= instead of regular CPU memory to send and receive packets.

> >

> > > >= This option is currently limited to iofwd engine to ensure

> >

> > > >= no workload is applied on packets not accessible from the CPU.<= /span>

> >

> > > >=

> >

> > > >= The options chose is --mbuf-size so buffer split feature across=

> >

> > > >= different mempools can be enabled.

> >

> > > >=

> >

> > > >= Signed-off-by: Elena Agostini <eagostini@nvidia.com>

> >

> > >=

> >

> > > Won'= t this create a hard dependency of test-pmd on gpudev?

> >

> > > I th= ought gpudev was supposed to be optional

> >

> >

> >

> > Sure, let= me submit another patch to make it optional

>

> Why to add yet= another compile time macro everywhere in testpmd and

> make hard to m= aintain?

> Adding iofwd k= ind of code is very simple to add test/test-gpudev and

> all GPU specif= ic options

> can be added i= n test-gpudev. It also helps to review the patches as

> test cases foc= us on

> each device cl= ass.

 

Test= -gpudev is standalone unit test to ensure gpudev functions work correctly.<= o:p>

In t= estpmd instead, there is a connection between gpudev and the network.<= /o:p>

--_000_DM6PR12MB4107585DFA949264D9C7A79ACD9A9DM6PR12MB4107namp_--