From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8D24A0C4E; Mon, 8 Nov 2021 20:07:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2EA3D40DF7; Mon, 8 Nov 2021 20:07:46 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2045.outbound.protection.outlook.com [40.107.101.45]) by mails.dpdk.org (Postfix) with ESMTP id 0A69440040 for ; Mon, 8 Nov 2021 20:07:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jkTXaXDDkrqY2dEXVy7uNbxB7W1nNAggSlpDqf8BV+brKYfKy+4ZzPk9K6dyBQJAONFqYKlbzIBY+oUATf8uPrMLfl72uLX3VHZM4fi4uQKIK3noqT9NRCtfvbAMpbFVABCm6C2CTP+zR6S7msZqcXwG7GRiaEHv0LycOmjGV/EklfxckMsafltPXtOQ+Yb4aFEZQj+qxAMdhaXIppJJEI6HARz8pF1hs2b6ZtcWukWJYgOgr64hSanlQ1CzH6GDFCIIRsfq9wlSGDObpHAwwTIT+hkUia9OLXYpnFBEcIsjKH8vI4EW2AfjPBXcfug4ygkMN3DRFE9Gl5udvch8ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QPfRGRT2KKAxm9Dr5VcOI4Y/crDUA0tEIUvNLA5nE/8=; b=KQ8S4k188JGJLskEbUGcTUlFgMktZvvK9nmc0+dG2D6hXLTXdZ6heXREn89KvSEvoZRYh7nUdSYeNE1fSDjEtbiNyn2KU4VXKbBgsgT7Uexlb/ddGZvgwI9Kt4JhOwZ72m1nMSVfv7hvQBPQq5JNZGXLmJiD8e6H6b2OhyZjBrpiqECJjxsgK4K37ad6hl5I1FiDULfWq+X3Hf2uVcNo7U8I+B4rF0KD288MFw0gi2pmnFHYnEkQwqyXlFrxAEszXdakR0yQsnsB7j9Zjb6tw0akW/YWererXM8jTvxV2PL+Mv98jOcQAvhTS2kuVzLGstjrSw3zuE0oQmEBcPU9aQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QPfRGRT2KKAxm9Dr5VcOI4Y/crDUA0tEIUvNLA5nE/8=; b=qxL3LdowI/3Z6KWBP0oy9ighx1hutjmYpFeN0oZrSkXgXb3rB+ITzZQEUnCXiyRpb96uUQSAE0B7bazaXQeHaQWwGcb6VnnrO8zlBn9Zi2BMtzyV+IiBP3hNUxhS6/Ss2+iBHau0b803tUgLTbP9VYUiAGi+8GE5nnZl5ErEGT7ydjLzEc0eTdd0ztN883D8hqobIwusapKRJwOwUAxu5PCqUH+wqjdKPFVhqefs6NEE4kBuhSEOa2/lTXkunhQ+AU5qstIlMa4yR33nlyeEYhKRT27Kh+FOMJtO1LD3GczXb2FQSDEiRWZhyxtkBu4PnG34bwNboB4Sdpi1lDx/Tg== Received: from DM6PR12MB4107.namprd12.prod.outlook.com (2603:10b6:5:218::7) by DM6PR12MB2954.namprd12.prod.outlook.com (2603:10b6:5:188::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.15; Mon, 8 Nov 2021 19:07:41 +0000 Received: from DM6PR12MB4107.namprd12.prod.outlook.com ([fe80::98ea:e961:8212:62f4]) by DM6PR12MB4107.namprd12.prod.outlook.com ([fe80::98ea:e961:8212:62f4%6]) with mapi id 15.20.4669.016; Mon, 8 Nov 2021 19:07:41 +0000 From: Elena Agostini To: Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 1/1] gpu/cuda: introduce CUDA driver Thread-Index: AQHX0NtZpw31DMDY2E+67RD2sxiMXav5/RiAgAAAbKiAAAZGgIAAAeCM Date: Mon, 8 Nov 2021 19:07:41 +0000 Message-ID: References: <20211005224905.13505-1-eagostini@nvidia.com> <20211104020128.13165-1-eagostini@nvidia.com> <20211104020128.13165-2-eagostini@nvidia.com> <20211108103529.41007024@hermes.local> <20211108105927.4a19d086@hermes.local> In-Reply-To: <20211108105927.4a19d086@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 60935d8b-c61a-4098-21b7-08d9a2eb09b4 x-ms-traffictypediagnostic: DM6PR12MB2954: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Uk6sMmw7lxEaIHSKt5CVKegy/kZYEt2uZowy3yjKwe/LWTSZ49lNbtfZOEbJVzJZnwXdLPt7DFeXlLr+P6vyX1Dk5FezpmEmBDpJkbNbrfu+LcJNQ56A9+YWbraAxJwmX0CsnGJPSwJgg+DxnZY1ULil+TX04qwypLeafZ0RAoUUaOaHYDmrCHLHm4mocPP33GqMwRGE9fS4zZk5LTTsSDWATcToMTh/WHuKcgE4I6DbTHm13Yz2y9b0/DKVAkJ5V/F3KZfTr5qMNQn18rNACpHnzjgajDxJkko6duRL4HdbdWkX3leHgUhquylDS0nPo4VkvHzUeebQ9nCZHfEbMC6bBiHEn222meaiGGXkaljnnMaeijsN4p3CQulKYrVYxkaxWjGTH74Na+SiC5YjDmRErEukR2yU/W7x/eNXlKj14qNS8P9DkguF6K+YyNY77fXX8JSpR8YlLnOv3mkxg6bxJbdGI4N4WUl+4Z8LgVcR+ozfJpTXt6aFbzpcgPZiHB27HjYzRv4bFhAfPzoUpS/CiQPCmC3CAYH6y/0vp/ahdb8vLB/QsBYIn5Ms4NKWmbmSJzWRUs+8Tw/RsOrVcdP5lRUVo+Sx+deX2voYGT/fL1qHsmPIxGPfPsCUDEtABkFgtLGL67xl3Is3d976IShkWb4g5bcYLPajPvXVtqulrL+hkHjzEYmASmSIUXa9G8TmTD9QPjQatc4LHCpKdQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4107.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8676002)(55016002)(9686003)(52536014)(2906002)(66946007)(64756008)(66556008)(66476007)(5660300002)(91956017)(53546011)(316002)(38100700002)(38070700005)(66446008)(122000001)(8936002)(76116006)(33656002)(508600001)(86362001)(7696005)(4326008)(71200400001)(26005)(186003)(6916009)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?au55gv57LcWND+b0iH+wezrj34hxy6nIpdwNY6DUFpeUpDXYS7klrriO?= =?Windows-1252?Q?t30TdyZ9zPd0qWufQey8Lt16ZWI5rYVcHHsxp0EiwJYlbLmWHXB34fPD?= =?Windows-1252?Q?9Lwxqw9jPWamJIsMp7e7VA197v1e716ARLQXs0kdLJ38FMbLzpCdyf/0?= =?Windows-1252?Q?QbwYPoWBW82FMBvaOkrn81dFaYlHk40yynCl28oAeAcF242N23VLRoUA?= =?Windows-1252?Q?VUTDEn4tOJtaK4+Vwif+uj/8RQNFoG0phou1ou2vycETxePWGd63yyvm?= =?Windows-1252?Q?9O2QDouiQM7ilNpg+iB/svASanpngLYBb03473+1bgyEPa++/hJMF3Bo?= =?Windows-1252?Q?xjoTDfZjfHm2+C1PUGFoRQmSmp2zyRHO0fBOqDuUhBuH1ZprG3tVhZdf?= =?Windows-1252?Q?9cUPib6R28JAcmAzLriRgfT0/Rrnoji3SoPhq+Rm9pBwE16Si4+vEEPz?= =?Windows-1252?Q?iX2iZvCMAD3cOPA/9r/Y1Xn9DY1bwcr52AkcvFB8t9Q9TPPlBHm38ZN5?= =?Windows-1252?Q?ldvSydVrDXYEmX1ULm8HqIywpAK7xjplNbAB24F71C1Sn6LM5Jfdmi4h?= =?Windows-1252?Q?dDx4bpY8qKuUKbLtliLzvE3+Wz9erDwQcww3IYDmkp1jgZjhs1jY8HBl?= =?Windows-1252?Q?4kr5BzFBRCReCMZLzzxuKKHR8BOrxPR1U5Mn7RbvxY5PF6+LbvulGD+I?= =?Windows-1252?Q?lF2DSB4T3OtKk3W55TyflWsEWIkjDSGswICfXxKJEpPbgMipkgs8Ni3U?= =?Windows-1252?Q?kOqd+I9b9tNrSjUyhfmUcyDkuqGk77JtkY4I1kq+BJjk+tvMK5S74Q42?= =?Windows-1252?Q?jxF5e2P7gxo/qAFTkPwW3If4YmXnl41APSMlPa4/Vb+uDtTmmNDOiM1o?= =?Windows-1252?Q?NBYXVeZVbGnUfmNElxxGDIBeY0X+W4AjnfNXOHJ9BAGRpYzO4aOwiDbF?= =?Windows-1252?Q?R8clT5Lvw5n/i9UR38gM6ntIctwMsfNO6vX8S5wZX8xVcrTqIup5Cpx+?= =?Windows-1252?Q?bih5lqz5iY3pmYVU5Oka3b2c/z3OPuj42Vdd6mDLB3pLo8lTf21+9C3I?= =?Windows-1252?Q?EJZ0JLZLOd1+rg117TalTdJ+YbJf68osetYzbxqUbavFSg9+ogibkYJN?= =?Windows-1252?Q?WykV9kMsVp0dU38dUs5Mn3dwgAa1Qg6UDkiUuhnlelLVLGvHYakrT70t?= =?Windows-1252?Q?PiKLm43qWoEiSxtMrYvanfcquGyhsltmFCrmWA1h07/vJN3NwitI2rpT?= =?Windows-1252?Q?/sfSQB9AH3IVYPPo0iFRRVwIv/q+Szbu866H/JmF6nQnd1xpIq2t0W2R?= =?Windows-1252?Q?KqO/PbCfXm7vEhsvwJAXReQ8dclicBzBv5Hh27E65HkkuPVHODQK3wUa?= =?Windows-1252?Q?iirbJNDJRVwuhhxp65gUvzwPDroTIUrRqLjIDm4i0ElV4nLlSVsa1KSQ?= =?Windows-1252?Q?0y+CwW7MmvdJ4rnnA2JiC/K7nP5eMpNnYjJ2yDsHdczrUYJhxE0J0MaY?= =?Windows-1252?Q?jHTgUfJ3wc7zT/oKLwJ/Cz0qdheWiDgIX3BkZ1flNJFWOJ/cKoQ1QP8a?= =?Windows-1252?Q?eMoopmL7RJcmxndVc4Vwy/gGB3z9mlq9B1cdRLpc6SHgWiyT161tJRwP?= =?Windows-1252?Q?iWngtfy4cvQivAE+HdaN8OzPcz3/8nI9r3w4K5U4mf0zu7HYMkgYFM6D?= =?Windows-1252?Q?A/jS5txyDigKCCRkp0I0JtdMT4yvllT2UVCFNpJUDkwKGGOYpWABDCSu?= =?Windows-1252?Q?QHJwcWbt583gm6HMfsm0VriqobChfBpgJAWzrPw2?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4107.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60935d8b-c61a-4098-21b7-08d9a2eb09b4 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2021 19:07:41.2125 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 814NTh3K8hjS6lu6jxbFATtK5ZvXl8lPkiS8eYR9NI7DOj5lohd0QHroOP8RwRJt0vwxdbWPvBSBaenGHAQvWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2954 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v2 1/1] gpu/cuda: introduce CUDA driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Stephen Hemminger > Date: Monday, 8 November 2021 at 19:59 > To: Elena Agostini > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/1] gpu/cuda: introduce CUDA driver> > On Mon, 8 Nov 2021 18:39:36 +0000 > Elena Agostini wrote:> > > > From: Stephen Hemminger > > > Date: Monday, 8 November 2021 at 19:35 > > > To: Elena Agostini > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v2 1/1] gpu/cuda: introduce CUDA drive= r > > > External email: Use caution opening links or attachments> > > > > > > On Thu, 4 Nov 2021 02:01:28 +0000 > > > wrote:> > > > > +/* Single entry of the memory list */ > > > > +struct mem_entry { > > > > + CUdeviceptr ptr_d; > > > > + void *ptr_h; > > > > + size_t size; > > > > + struct rte_gpu *dev; > > > > + CUcontext ctx;> > > > Not sure where these types CUdeviceptr and CUcontext are coming > > > from, but the code looks like Windows style not DPDK or Linux.> > > > Please don't introduce CamelCase typedef's and never typedefs > > > for pointers. > > > > These are CUDA Driver API specific types, I can=92t change them.> > Could you at least avoid using the pointer typedefs. > When a pointer is typedef'd it leads to confusion to readers and > some dumb static analyzers. There is not pointer typedef here. The typedef is about uintptr_t