DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ali Alnubani <alialnu@nvidia.com>
To: David Marchand <david.marchand@redhat.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Leyi Rong <leyi.rong@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
	"Bruce Richardson" <bruce.richardson@intel.com>,
	Wenzhuo Lu <wenzhuo.lu@intel.com>,
	Andrew Rybchenko <arybchenko@solarflare.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ice: add AVX512BW flag check both in build and runtime
Date: Mon, 2 Nov 2020 08:22:23 +0000	[thread overview]
Message-ID: <DM6PR12MB4618AF0A6225CBA792CE9E55DA100@DM6PR12MB4618.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8z8BBvqV=ka=-P=AyiHfOgnftYP6kqct2jRe+ZMvE9=AA@mail.gmail.com>

Hi,

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, October 27, 2020 3:17 PM
> To: Ferruh Yigit <ferruh.yigit@intel.com>
> Cc: Leyi Rong <leyi.rong@intel.com>; Qi Zhang <qi.z.zhang@intel.com>;
> Bruce Richardson <bruce.richardson@intel.com>; Wenzhuo Lu
> <wenzhuo.lu@intel.com>; Ali Alnubani <alialnu@nvidia.com>; Andrew
> Rybchenko <arybchenko@solarflare.com>; dev <dev@dpdk.org>
> Subject: Re: [PATCH] net/ice: add AVX512BW flag check both in build and
> runtime
> 
> On Tue, Oct 27, 2020 at 12:57 PM Ferruh Yigit <ferruh.yigit@intel.com>
> wrote:
> >
> > On 10/27/2020 10:19 AM, Leyi Rong wrote:
> > > Intrinsic function __mm512_bsrli_epi128 should be used in the
> > > environment which supports AVX512BW, so adds check for this flag.
> > >
> > > Fixes: 5dd3b8f3af34 ("net/ice: add AVX512 vector path")
> > >
> > > Signed-off-by: Leyi Rong <leyi.rong@intel.com>
> >
> > Squashed into relevant commit in next-net, thanks.
> >
> >
> > Andrew, Ali, David,
> >
> > Can you please confirm the issue is solved in the next-net/main?
> 
> Tree with HEAD at 5e12432f4be4 ("net/ice: fix Rx offload flags in SSE
> path") looks good to me.
> Thanks.
> 
> --
> David Marchand

I can reproduce right now in net/iavf on latest next-net/main "3197a1371 net/octeontx2: avoid per packet barrier with multi segment":
"""
drivers/net/iavf/iavf_rxtx_vec_avx512.c:1:0: error: bad value (skylake-avx512) for -march= switch
 /* SPDX-License-Identifier: BSD-3-Clause
"""

- Ali

      reply	other threads:[~2020-11-02  8:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27 10:19 Leyi Rong
2020-10-27 11:57 ` Ferruh Yigit
2020-10-27 12:47   ` Andrew Rybchenko
2020-10-27 13:12   ` Ali Alnubani
2020-10-27 13:27     ` Bruce Richardson
2020-10-27 15:36       ` Rong, Leyi
2020-10-27 15:57         ` Bruce Richardson
2020-10-27 13:17   ` David Marchand
2020-11-02  8:22     ` Ali Alnubani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB4618AF0A6225CBA792CE9E55DA100@DM6PR12MB4618.namprd12.prod.outlook.com \
    --to=alialnu@nvidia.com \
    --cc=arybchenko@solarflare.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=leyi.rong@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).