* [dpdk-dev] [PATCH 0/2] fix build error on lower version GCC @ 2020-11-03 12:56 Leyi Rong 2020-11-03 12:56 ` [dpdk-dev] [PATCH 1/2] net/ice: " Leyi Rong ` (2 more replies) 0 siblings, 3 replies; 15+ messages in thread From: Leyi Rong @ 2020-11-03 12:56 UTC (permalink / raw) To: qi.z.zhang, ferruh.yigit; +Cc: dev, Leyi Rong These two patches fix the build error when -march=skylake-avx512 is not supported on lower version GCC in both ice and iavf PMD. Leyi Rong (2): net/ice: fix build error on lower version GCC net/iavf: fix build error on lower version GCC drivers/net/iavf/meson.build | 21 +++++++++++++++------ drivers/net/ice/meson.build | 21 +++++++++++++++------ 2 files changed, 30 insertions(+), 12 deletions(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH 1/2] net/ice: fix build error on lower version GCC 2020-11-03 12:56 [dpdk-dev] [PATCH 0/2] fix build error on lower version GCC Leyi Rong @ 2020-11-03 12:56 ` Leyi Rong 2020-11-03 13:28 ` Bruce Richardson 2020-11-03 12:56 ` [dpdk-dev] [PATCH 2/2] net/iavf: " Leyi Rong 2020-11-03 13:51 ` [dpdk-dev] [PATCH v2 0/2] " Leyi Rong 2 siblings, 1 reply; 15+ messages in thread From: Leyi Rong @ 2020-11-03 12:56 UTC (permalink / raw) To: qi.z.zhang, ferruh.yigit; +Cc: dev, Leyi Rong Fix the build error when -march=skylake-avx512 is not supported on lower version GCC. Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path") Signed-off-by: Leyi Rong <leyi.rong@intel.com> --- drivers/net/ice/meson.build | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/net/ice/meson.build b/drivers/net/ice/meson.build index 7d54a49236..ec8933aa1a 100644 --- a/drivers/net/ice/meson.build +++ b/drivers/net/ice/meson.build @@ -46,12 +46,21 @@ if arch_subdir == 'x86' if ice_avx512_cpu_support == true or ice_avx512_cc_support == true cflags += ['-DCC_AVX512_SUPPORT'] - ice_avx512_lib = static_library('ice_avx512_lib', - 'ice_rxtx_vec_avx512.c', - dependencies: [static_rte_ethdev, - static_rte_kvargs, static_rte_hash], - include_directories: includes, - c_args: [cflags, '-march=skylake-avx512', '-mavx512f', '-mavx512bw']) + if cc.has_argument('-march=skylake-avx512') + ice_avx512_lib = static_library('ice_avx512_lib', + 'ice_rxtx_vec_avx512.c', + dependencies: [static_rte_ethdev, + static_rte_kvargs, static_rte_hash], + include_directories: includes, + c_args: [cflags, '-march=skylake-avx512', '-mavx512f', '-mavx512bw']) + else + ice_avx512_lib = static_library('ice_avx512_lib', + 'ice_rxtx_vec_avx512.c', + dependencies: [static_rte_ethdev, + static_rte_kvargs, static_rte_hash], + include_directories: includes, + c_args: [cflags, '-mavx512f', '-mavx512bw']) + endif objs += ice_avx512_lib.extract_objects('ice_rxtx_vec_avx512.c') endif endif -- 2.17.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] net/ice: fix build error on lower version GCC 2020-11-03 12:56 ` [dpdk-dev] [PATCH 1/2] net/ice: " Leyi Rong @ 2020-11-03 13:28 ` Bruce Richardson 2020-11-03 14:13 ` Rong, Leyi 0 siblings, 1 reply; 15+ messages in thread From: Bruce Richardson @ 2020-11-03 13:28 UTC (permalink / raw) To: Leyi Rong; +Cc: qi.z.zhang, ferruh.yigit, dev On Tue, Nov 03, 2020 at 08:56:28PM +0800, Leyi Rong wrote: > Fix the build error when -march=skylake-avx512 is not supported on > lower version GCC. > > Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path") > > Signed-off-by: Leyi Rong <leyi.rong@intel.com> > --- > drivers/net/ice/meson.build | 21 +++++++++++++++------ > 1 file changed, 15 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ice/meson.build b/drivers/net/ice/meson.build > index 7d54a49236..ec8933aa1a 100644 > --- a/drivers/net/ice/meson.build > +++ b/drivers/net/ice/meson.build > @@ -46,12 +46,21 @@ if arch_subdir == 'x86' > > if ice_avx512_cpu_support == true or ice_avx512_cc_support == true > cflags += ['-DCC_AVX512_SUPPORT'] > - ice_avx512_lib = static_library('ice_avx512_lib', > - 'ice_rxtx_vec_avx512.c', > - dependencies: [static_rte_ethdev, > - static_rte_kvargs, static_rte_hash], > - include_directories: includes, > - c_args: [cflags, '-march=skylake-avx512', '-mavx512f', '-mavx512bw']) > + if cc.has_argument('-march=skylake-avx512') > + ice_avx512_lib = static_library('ice_avx512_lib', > + 'ice_rxtx_vec_avx512.c', > + dependencies: [static_rte_ethdev, > + static_rte_kvargs, static_rte_hash], > + include_directories: includes, > + c_args: [cflags, '-march=skylake-avx512', '-mavx512f', '-mavx512bw']) > + else > + ice_avx512_lib = static_library('ice_avx512_lib', > + 'ice_rxtx_vec_avx512.c', > + dependencies: [static_rte_ethdev, > + static_rte_kvargs, static_rte_hash], > + include_directories: includes, > + c_args: [cflags, '-mavx512f', '-mavx512bw']) > + endif Rather than duplicating the whole static_library call, you can just do: avx512_cflags = [cflags, '-mavx512f', '-mavx512bw'] if cc.has_argument('-march=skylake-avx512') avx512_cflags += '-march=skylake-avx512' endif and then use avx512_cflags inside a single static_library call. Much shorter code. /Bruce > objs += ice_avx512_lib.extract_objects('ice_rxtx_vec_avx512.c') > endif > endif > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] net/ice: fix build error on lower version GCC 2020-11-03 13:28 ` Bruce Richardson @ 2020-11-03 14:13 ` Rong, Leyi 0 siblings, 0 replies; 15+ messages in thread From: Rong, Leyi @ 2020-11-03 14:13 UTC (permalink / raw) To: Richardson, Bruce; +Cc: Zhang, Qi Z, Yigit, Ferruh, dev > -----Original Message----- > From: Bruce Richardson <bruce.richardson@intel.com> > Sent: Tuesday, November 3, 2020 9:28 PM > To: Rong, Leyi <leyi.rong@intel.com> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] net/ice: fix build error on lower version GCC > > On Tue, Nov 03, 2020 at 08:56:28PM +0800, Leyi Rong wrote: > > Fix the build error when -march=skylake-avx512 is not supported on > > lower version GCC. > > > > Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path") > > > > Signed-off-by: Leyi Rong <leyi.rong@intel.com> > > --- > > drivers/net/ice/meson.build | 21 +++++++++++++++------ > > 1 file changed, 15 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/net/ice/meson.build b/drivers/net/ice/meson.build > > index 7d54a49236..ec8933aa1a 100644 > > --- a/drivers/net/ice/meson.build > > +++ b/drivers/net/ice/meson.build > > @@ -46,12 +46,21 @@ if arch_subdir == 'x86' > > > > if ice_avx512_cpu_support == true or ice_avx512_cc_support == true > > cflags += ['-DCC_AVX512_SUPPORT'] > > - ice_avx512_lib = static_library('ice_avx512_lib', > > - 'ice_rxtx_vec_avx512.c', > > - dependencies: [static_rte_ethdev, > > - static_rte_kvargs, static_rte_hash], > > - include_directories: includes, > > - c_args: [cflags, '-march=skylake-avx512', '- > mavx512f', '-mavx512bw']) > > + if cc.has_argument('-march=skylake-avx512') > > + ice_avx512_lib = static_library('ice_avx512_lib', > > + 'ice_rxtx_vec_avx512.c', > > + dependencies: [static_rte_ethdev, > > + static_rte_kvargs, > static_rte_hash], > > + include_directories: includes, > > + c_args: [cflags, '-march=skylake- > avx512', '-mavx512f', '-mavx512bw']) > > + else > > + ice_avx512_lib = static_library('ice_avx512_lib', > > + 'ice_rxtx_vec_avx512.c', > > + dependencies: [static_rte_ethdev, > > + static_rte_kvargs, > static_rte_hash], > > + include_directories: includes, > > + c_args: [cflags, '-mavx512f', '- > mavx512bw']) > > + endif > > Rather than duplicating the whole static_library call, you can just do: > avx512_cflags = [cflags, '-mavx512f', '-mavx512bw'] > if cc.has_argument('-march=skylake-avx512') > avx512_cflags += '-march=skylake-avx512' > endif > > and then use avx512_cflags inside a single static_library call. Much shorter code. > > /Bruce > Many thanks~ Fixed in v2 patches. Leyi > > objs += ice_avx512_lib.extract_objects('ice_rxtx_vec_avx512.c') > > endif > > endif > > -- > > 2.17.1 > > ^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH 2/2] net/iavf: fix build error on lower version GCC 2020-11-03 12:56 [dpdk-dev] [PATCH 0/2] fix build error on lower version GCC Leyi Rong 2020-11-03 12:56 ` [dpdk-dev] [PATCH 1/2] net/ice: " Leyi Rong @ 2020-11-03 12:56 ` Leyi Rong 2020-11-03 13:51 ` [dpdk-dev] [PATCH v2 0/2] " Leyi Rong 2 siblings, 0 replies; 15+ messages in thread From: Leyi Rong @ 2020-11-03 12:56 UTC (permalink / raw) To: qi.z.zhang, ferruh.yigit; +Cc: dev, Leyi Rong Fix the build error when -march=skylake-avx512 is not supported on lower version GCC. Fixes: e0dcec9074c3 ("net/iavf: enable AVX512 for legacy Rx") Signed-off-by: Leyi Rong <leyi.rong@intel.com> --- drivers/net/iavf/meson.build | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/net/iavf/meson.build b/drivers/net/iavf/meson.build index e257f5a6e1..ee0a882126 100644 --- a/drivers/net/iavf/meson.build +++ b/drivers/net/iavf/meson.build @@ -46,12 +46,21 @@ if arch_subdir == 'x86' if iavf_avx512_cpu_support == true or iavf_avx512_cc_support == true cflags += ['-DCC_AVX512_SUPPORT'] - iavf_avx512_lib = static_library('iavf_avx512_lib', - 'iavf_rxtx_vec_avx512.c', - dependencies: [static_rte_ethdev, - static_rte_kvargs, static_rte_hash], - include_directories: includes, - c_args: [cflags, '-mavx512f', '-mavx512bw', '-march=skylake-avx512']) + if cc.has_argument('-march=skylake-avx512') + iavf_avx512_lib = static_library('iavf_avx512_lib', + 'iavf_rxtx_vec_avx512.c', + dependencies: [static_rte_ethdev, + static_rte_kvargs, static_rte_hash], + include_directories: includes, + c_args: [cflags, '-mavx512f', '-mavx512bw', '-march=skylake-avx512']) + else + iavf_avx512_lib = static_library('iavf_avx512_lib', + 'iavf_rxtx_vec_avx512.c', + dependencies: [static_rte_ethdev, + static_rte_kvargs, static_rte_hash], + include_directories: includes, + c_args: [cflags, '-mavx512f', '-mavx512bw']) + endif objs += iavf_avx512_lib.extract_objects('iavf_rxtx_vec_avx512.c') endif endif -- 2.17.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v2 0/2] fix build error on lower version GCC 2020-11-03 12:56 [dpdk-dev] [PATCH 0/2] fix build error on lower version GCC Leyi Rong 2020-11-03 12:56 ` [dpdk-dev] [PATCH 1/2] net/ice: " Leyi Rong 2020-11-03 12:56 ` [dpdk-dev] [PATCH 2/2] net/iavf: " Leyi Rong @ 2020-11-03 13:51 ` Leyi Rong 2020-11-03 13:51 ` [dpdk-dev] [PATCH v2 1/2] net/ice: " Leyi Rong 2020-11-03 13:52 ` [dpdk-dev] [PATCH v2 2/2] net/iavf: " Leyi Rong 2 siblings, 2 replies; 15+ messages in thread From: Leyi Rong @ 2020-11-03 13:51 UTC (permalink / raw) To: bruce.richardson, qi.z.zhang, ferruh.yigit; +Cc: dev, Leyi Rong These two patches fix the build error when -march=skylake-avx512 is not supported on lower version GCC in both ice and iavf PMD. --- v2: - Simplify the judgement by extracting the avx512_args. Leyi Rong (2): net/ice: fix build error on lower version GCC net/iavf: fix build error on lower version GCC drivers/net/iavf/meson.build | 8 ++++++-- drivers/net/ice/meson.build | 14 +++++++++----- 2 files changed, 15 insertions(+), 7 deletions(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v2 1/2] net/ice: fix build error on lower version GCC 2020-11-03 13:51 ` [dpdk-dev] [PATCH v2 0/2] " Leyi Rong @ 2020-11-03 13:51 ` Leyi Rong 2020-11-03 14:42 ` Bruce Richardson 2020-11-03 13:52 ` [dpdk-dev] [PATCH v2 2/2] net/iavf: " Leyi Rong 1 sibling, 1 reply; 15+ messages in thread From: Leyi Rong @ 2020-11-03 13:51 UTC (permalink / raw) To: bruce.richardson, qi.z.zhang, ferruh.yigit; +Cc: dev, Leyi Rong Fix the build error when -march=skylake-avx512 is not supported on lower version GCC. Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path") Signed-off-by: Leyi Rong <leyi.rong@intel.com> --- drivers/net/ice/meson.build | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/ice/meson.build b/drivers/net/ice/meson.build index 7d54a49236..47d21678c2 100644 --- a/drivers/net/ice/meson.build +++ b/drivers/net/ice/meson.build @@ -46,12 +46,16 @@ if arch_subdir == 'x86' if ice_avx512_cpu_support == true or ice_avx512_cc_support == true cflags += ['-DCC_AVX512_SUPPORT'] + avx512_args = [cflags, '-mavx512f', '-mavx512bw'] + if cc.has_argument('-march=skylake-avx512') + avx512_args += '-march=skylake-avx512' + endif ice_avx512_lib = static_library('ice_avx512_lib', - 'ice_rxtx_vec_avx512.c', - dependencies: [static_rte_ethdev, - static_rte_kvargs, static_rte_hash], - include_directories: includes, - c_args: [cflags, '-march=skylake-avx512', '-mavx512f', '-mavx512bw']) + 'ice_rxtx_vec_avx512.c', + dependencies: [static_rte_ethdev, + static_rte_kvargs, static_rte_hash], + include_directories: includes, + c_args: avx512_args) objs += ice_avx512_lib.extract_objects('ice_rxtx_vec_avx512.c') endif endif -- 2.17.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/2] net/ice: fix build error on lower version GCC 2020-11-03 13:51 ` [dpdk-dev] [PATCH v2 1/2] net/ice: " Leyi Rong @ 2020-11-03 14:42 ` Bruce Richardson 2020-11-03 15:29 ` Ferruh Yigit 0 siblings, 1 reply; 15+ messages in thread From: Bruce Richardson @ 2020-11-03 14:42 UTC (permalink / raw) To: Leyi Rong; +Cc: qi.z.zhang, ferruh.yigit, dev On Tue, Nov 03, 2020 at 09:51:59PM +0800, Leyi Rong wrote: > Fix the build error when -march=skylake-avx512 is not supported on > lower version GCC. > > Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path") > > Signed-off-by: Leyi Rong <leyi.rong@intel.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/2] net/ice: fix build error on lower version GCC 2020-11-03 14:42 ` Bruce Richardson @ 2020-11-03 15:29 ` Ferruh Yigit 2020-11-03 15:37 ` Ferruh Yigit 0 siblings, 1 reply; 15+ messages in thread From: Ferruh Yigit @ 2020-11-03 15:29 UTC (permalink / raw) To: Bruce Richardson, Leyi Rong; +Cc: qi.z.zhang, dev On 11/3/2020 2:42 PM, Bruce Richardson wrote: > On Tue, Nov 03, 2020 at 09:51:59PM +0800, Leyi Rong wrote: >> Fix the build error when -march=skylake-avx512 is not supported on >> lower version GCC. >> >> Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path") >> >> Signed-off-by: Leyi Rong <leyi.rong@intel.com> > > Acked-by: Bruce Richardson <bruce.richardson@intel.com> > Squashed into relevant commit in next-net, thanks. Indentation added to match 'ice' while merging. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/2] net/ice: fix build error on lower version GCC 2020-11-03 15:29 ` Ferruh Yigit @ 2020-11-03 15:37 ` Ferruh Yigit 2020-11-03 15:42 ` Ali Alnubani 0 siblings, 1 reply; 15+ messages in thread From: Ferruh Yigit @ 2020-11-03 15:37 UTC (permalink / raw) To: Bruce Richardson, Leyi Rong, Ali Alnubani; +Cc: qi.z.zhang, dev On 11/3/2020 3:29 PM, Ferruh Yigit wrote: > On 11/3/2020 2:42 PM, Bruce Richardson wrote: >> On Tue, Nov 03, 2020 at 09:51:59PM +0800, Leyi Rong wrote: >>> Fix the build error when -march=skylake-avx512 is not supported on >>> lower version GCC. >>> >>> Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path") >>> >>> Signed-off-by: Leyi Rong <leyi.rong@intel.com> >> >> Acked-by: Bruce Richardson <bruce.richardson@intel.com> >> > > Squashed into relevant commit in next-net, thanks. > > Indentation added to match 'ice' while merging. > Hi Ali, Can you please test the build of next-net/main one more time? Thanks, ferruh ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/2] net/ice: fix build error on lower version GCC 2020-11-03 15:37 ` Ferruh Yigit @ 2020-11-03 15:42 ` Ali Alnubani 2020-11-03 15:57 ` Ferruh Yigit 0 siblings, 1 reply; 15+ messages in thread From: Ali Alnubani @ 2020-11-03 15:42 UTC (permalink / raw) To: Ferruh Yigit, Bruce Richardson, Leyi Rong; +Cc: qi.z.zhang, dev > -----Original Message----- > From: Ferruh Yigit <ferruh.yigit@intel.com> > Sent: Tuesday, November 3, 2020 5:37 PM > To: Bruce Richardson <bruce.richardson@intel.com>; Leyi Rong > <leyi.rong@intel.com>; Ali Alnubani <alialnu@nvidia.com> > Cc: qi.z.zhang@intel.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/ice: fix build error on lower > version GCC > > On 11/3/2020 3:29 PM, Ferruh Yigit wrote: > > On 11/3/2020 2:42 PM, Bruce Richardson wrote: > >> On Tue, Nov 03, 2020 at 09:51:59PM +0800, Leyi Rong wrote: > >>> Fix the build error when -march=skylake-avx512 is not supported on > >>> lower version GCC. > >>> > >>> Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path") > >>> > >>> Signed-off-by: Leyi Rong <leyi.rong@intel.com> > >> > >> Acked-by: Bruce Richardson <bruce.richardson@intel.com> > >> > > > > Squashed into relevant commit in next-net, thanks. > > > > Indentation added to match 'ice' while merging. > > > > Hi Ali, > > Can you please test the build of next-net/main one more time? > Build is passing on "5b5f87681 app/testpmd: fix max Rx packet length for VLAN packets". Thanks, Ali ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/2] net/ice: fix build error on lower version GCC 2020-11-03 15:42 ` Ali Alnubani @ 2020-11-03 15:57 ` Ferruh Yigit 0 siblings, 0 replies; 15+ messages in thread From: Ferruh Yigit @ 2020-11-03 15:57 UTC (permalink / raw) To: Ali Alnubani, Bruce Richardson, Leyi Rong; +Cc: qi.z.zhang, dev On 11/3/2020 3:42 PM, Ali Alnubani wrote: >> -----Original Message----- >> From: Ferruh Yigit <ferruh.yigit@intel.com> >> Sent: Tuesday, November 3, 2020 5:37 PM >> To: Bruce Richardson <bruce.richardson@intel.com>; Leyi Rong >> <leyi.rong@intel.com>; Ali Alnubani <alialnu@nvidia.com> >> Cc: qi.z.zhang@intel.com; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/ice: fix build error on lower >> version GCC >> >> On 11/3/2020 3:29 PM, Ferruh Yigit wrote: >>> On 11/3/2020 2:42 PM, Bruce Richardson wrote: >>>> On Tue, Nov 03, 2020 at 09:51:59PM +0800, Leyi Rong wrote: >>>>> Fix the build error when -march=skylake-avx512 is not supported on >>>>> lower version GCC. >>>>> >>>>> Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path") >>>>> >>>>> Signed-off-by: Leyi Rong <leyi.rong@intel.com> >>>> >>>> Acked-by: Bruce Richardson <bruce.richardson@intel.com> >>>> >>> >>> Squashed into relevant commit in next-net, thanks. >>> >>> Indentation added to match 'ice' while merging. >>> >> >> Hi Ali, >> >> Can you please test the build of next-net/main one more time? >> > > Build is passing on "5b5f87681 app/testpmd: fix max Rx packet length for VLAN packets". > Thanks. ^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v2 2/2] net/iavf: fix build error on lower version GCC 2020-11-03 13:51 ` [dpdk-dev] [PATCH v2 0/2] " Leyi Rong 2020-11-03 13:51 ` [dpdk-dev] [PATCH v2 1/2] net/ice: " Leyi Rong @ 2020-11-03 13:52 ` Leyi Rong 2020-11-03 14:44 ` Bruce Richardson 1 sibling, 1 reply; 15+ messages in thread From: Leyi Rong @ 2020-11-03 13:52 UTC (permalink / raw) To: bruce.richardson, qi.z.zhang, ferruh.yigit; +Cc: dev, Leyi Rong Fix the build error when -march=skylake-avx512 is not supported on lower version GCC. Fixes: e0dcec9074c3 ("net/iavf: enable AVX512 for legacy Rx") Signed-off-by: Leyi Rong <leyi.rong@intel.com> --- drivers/net/iavf/meson.build | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/iavf/meson.build b/drivers/net/iavf/meson.build index e257f5a6e1..099b6a725d 100644 --- a/drivers/net/iavf/meson.build +++ b/drivers/net/iavf/meson.build @@ -46,12 +46,16 @@ if arch_subdir == 'x86' if iavf_avx512_cpu_support == true or iavf_avx512_cc_support == true cflags += ['-DCC_AVX512_SUPPORT'] + avx512_args = [cflags, '-mavx512f', '-mavx512bw'] + if cc.has_argument('-march=skylake-avx512') + avx512_args += '-march=skylake-avx512' + endif iavf_avx512_lib = static_library('iavf_avx512_lib', 'iavf_rxtx_vec_avx512.c', dependencies: [static_rte_ethdev, - static_rte_kvargs, static_rte_hash], + static_rte_kvargs, static_rte_hash], include_directories: includes, - c_args: [cflags, '-mavx512f', '-mavx512bw', '-march=skylake-avx512']) + c_args: avx512_args) objs += iavf_avx512_lib.extract_objects('iavf_rxtx_vec_avx512.c') endif endif -- 2.17.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2 2/2] net/iavf: fix build error on lower version GCC 2020-11-03 13:52 ` [dpdk-dev] [PATCH v2 2/2] net/iavf: " Leyi Rong @ 2020-11-03 14:44 ` Bruce Richardson 2020-11-03 15:28 ` Ferruh Yigit 0 siblings, 1 reply; 15+ messages in thread From: Bruce Richardson @ 2020-11-03 14:44 UTC (permalink / raw) To: Leyi Rong; +Cc: qi.z.zhang, ferruh.yigit, dev On Tue, Nov 03, 2020 at 09:52:00PM +0800, Leyi Rong wrote: > Fix the build error when -march=skylake-avx512 is not supported on > lower version GCC. > > Fixes: e0dcec9074c3 ("net/iavf: enable AVX512 for legacy Rx") > > Signed-off-by: Leyi Rong <leyi.rong@intel.com> > --- > drivers/net/iavf/meson.build | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/iavf/meson.build b/drivers/net/iavf/meson.build > index e257f5a6e1..099b6a725d 100644 > --- a/drivers/net/iavf/meson.build > +++ b/drivers/net/iavf/meson.build > @@ -46,12 +46,16 @@ if arch_subdir == 'x86' > > if iavf_avx512_cpu_support == true or iavf_avx512_cc_support == true > cflags += ['-DCC_AVX512_SUPPORT'] > + avx512_args = [cflags, '-mavx512f', '-mavx512bw'] > + if cc.has_argument('-march=skylake-avx512') > + avx512_args += '-march=skylake-avx512' > + endif > iavf_avx512_lib = static_library('iavf_avx512_lib', > 'iavf_rxtx_vec_avx512.c', > dependencies: [static_rte_ethdev, > - static_rte_kvargs, static_rte_hash], > + static_rte_kvargs, static_rte_hash], This is an unnecesary whitespace change that can be dropped from the patch, and doesn't actually clean things up, since the extra indent is useful to show the continuation of the array. > include_directories: includes, > - c_args: [cflags, '-mavx512f', '-mavx512bw', '-march=skylake-avx512']) > + c_args: avx512_args) > objs += iavf_avx512_lib.extract_objects('iavf_rxtx_vec_avx512.c') > endif > endif > -- Acked-by: Bruce Richardson <bruce.richardson@intel.com> ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2 2/2] net/iavf: fix build error on lower version GCC 2020-11-03 14:44 ` Bruce Richardson @ 2020-11-03 15:28 ` Ferruh Yigit 0 siblings, 0 replies; 15+ messages in thread From: Ferruh Yigit @ 2020-11-03 15:28 UTC (permalink / raw) To: Bruce Richardson, Leyi Rong; +Cc: qi.z.zhang, dev On 11/3/2020 2:44 PM, Bruce Richardson wrote: > On Tue, Nov 03, 2020 at 09:52:00PM +0800, Leyi Rong wrote: >> Fix the build error when -march=skylake-avx512 is not supported on >> lower version GCC. >> >> Fixes: e0dcec9074c3 ("net/iavf: enable AVX512 for legacy Rx") >> >> Signed-off-by: Leyi Rong <leyi.rong@intel.com> >> --- >> drivers/net/iavf/meson.build | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/iavf/meson.build b/drivers/net/iavf/meson.build >> index e257f5a6e1..099b6a725d 100644 >> --- a/drivers/net/iavf/meson.build >> +++ b/drivers/net/iavf/meson.build >> @@ -46,12 +46,16 @@ if arch_subdir == 'x86' >> >> if iavf_avx512_cpu_support == true or iavf_avx512_cc_support == true >> cflags += ['-DCC_AVX512_SUPPORT'] >> + avx512_args = [cflags, '-mavx512f', '-mavx512bw'] >> + if cc.has_argument('-march=skylake-avx512') >> + avx512_args += '-march=skylake-avx512' >> + endif >> iavf_avx512_lib = static_library('iavf_avx512_lib', >> 'iavf_rxtx_vec_avx512.c', >> dependencies: [static_rte_ethdev, >> - static_rte_kvargs, static_rte_hash], >> + static_rte_kvargs, static_rte_hash], > > This is an unnecesary whitespace change that can be dropped from the patch, > and doesn't actually clean things up, since the extra indent is useful to > show the continuation of the array. > >> include_directories: includes, >> - c_args: [cflags, '-mavx512f', '-mavx512bw', '-march=skylake-avx512']) >> + c_args: avx512_args) >> objs += iavf_avx512_lib.extract_objects('iavf_rxtx_vec_avx512.c') >> endif >> endif >> -- > > Acked-by: Bruce Richardson <bruce.richardson@intel.com> > Squashed into relevant commit in next-net, thanks. Indentation change dropped while merging. ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2020-11-03 15:57 UTC | newest] Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-11-03 12:56 [dpdk-dev] [PATCH 0/2] fix build error on lower version GCC Leyi Rong 2020-11-03 12:56 ` [dpdk-dev] [PATCH 1/2] net/ice: " Leyi Rong 2020-11-03 13:28 ` Bruce Richardson 2020-11-03 14:13 ` Rong, Leyi 2020-11-03 12:56 ` [dpdk-dev] [PATCH 2/2] net/iavf: " Leyi Rong 2020-11-03 13:51 ` [dpdk-dev] [PATCH v2 0/2] " Leyi Rong 2020-11-03 13:51 ` [dpdk-dev] [PATCH v2 1/2] net/ice: " Leyi Rong 2020-11-03 14:42 ` Bruce Richardson 2020-11-03 15:29 ` Ferruh Yigit 2020-11-03 15:37 ` Ferruh Yigit 2020-11-03 15:42 ` Ali Alnubani 2020-11-03 15:57 ` Ferruh Yigit 2020-11-03 13:52 ` [dpdk-dev] [PATCH v2 2/2] net/iavf: " Leyi Rong 2020-11-03 14:44 ` Bruce Richardson 2020-11-03 15:28 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).