From: Ori Kam <orika@nvidia.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Shiri Kuzin <shirik@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
NBU-Contact-Adrien Mazarguil <adrien.mazarguil@6wind.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"NBU-Contact-Thomas Monjalon" <thomas@monjalon.net>,
Raslan Darawsheh <rasland@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH 1/8] lib/librte_ethdev: introduce GENEVE header TLV option item
Date: Tue, 29 Dec 2020 10:12:41 +0000 [thread overview]
Message-ID: <DM6PR12MB4987628212C5454DC3D3767ED6D80@DM6PR12MB4987.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201227092517.64d9da46@hermes.local>
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
>
> On Sun, 27 Dec 2020 18:06:16 +0200
> Shiri Kuzin <shirik@nvidia.com> wrote:
>
> > +#ifdef PEDANTIC
> > +#pragma GCC diagnostic ignored "-Wpedantic"
> > +#endif
>
> Please do not introduce pragma's for pedantic in standard headers.
> It just clutters the code unnecessarily. The rest of DPDK is not guaranteed
> to be free of pedantic warnings, so starting now is not worth the mess.
+1
Thanks,
Ori
next prev parent reply other threads:[~2020-12-29 10:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-27 16:06 [dpdk-dev] [PATCH 0/8] ethdev: " Shiri Kuzin
2020-12-27 16:06 ` [dpdk-dev] [PATCH 1/8] lib/librte_ethdev: " Shiri Kuzin
2020-12-27 17:25 ` Stephen Hemminger
2020-12-29 10:12 ` Ori Kam [this message]
2020-12-30 8:22 ` Shiri Kuzin
2020-12-27 16:06 ` [dpdk-dev] [PATCH 2/8] app/testpmd: add GENEVE option item support Shiri Kuzin
2020-12-27 16:06 ` [dpdk-dev] [PATCH 3/8] common/mlx5: check GENEVE TLV support in HCA attributes Shiri Kuzin
2020-12-27 16:06 ` [dpdk-dev] [PATCH 4/8] common/mlx5: create GENEVE TLV option object with DevX Shiri Kuzin
2020-12-27 16:06 ` [dpdk-dev] [PATCH 5/8] net/mlx5: create GENEVE TLV option management Shiri Kuzin
2020-12-27 16:06 ` [dpdk-dev] [PATCH 6/8] net/mlx5: add GENEVE TLV option flow validation Shiri Kuzin
2020-12-27 16:06 ` [dpdk-dev] [PATCH 7/8] net/mlx5: add GENEVE TLV option flow translation Shiri Kuzin
2020-12-27 16:06 ` [dpdk-dev] [PATCH 8/8] doc: update GENEVE TLV option support Shiri Kuzin
2021-01-05 17:53 ` [dpdk-dev] [PATCH v2 0/8] ethdev: introduce GENEVE header TLV option item Shiri Kuzin
2021-01-05 17:53 ` [dpdk-dev] [PATCH v2 1/8] lib/librte_ethdev: " Shiri Kuzin
2021-01-05 17:53 ` [dpdk-dev] [PATCH v2 2/8] app/testpmd: add GENEVE option item support Shiri Kuzin
2021-01-05 17:53 ` [dpdk-dev] [PATCH v2 3/8] common/mlx5: check GENEVE TLV support in HCA attributes Shiri Kuzin
2021-01-06 9:23 ` Slava Ovsiienko
2021-01-05 17:53 ` [dpdk-dev] [PATCH v2 4/8] common/mlx5: create GENEVE TLV option object with DevX Shiri Kuzin
2021-01-06 9:24 ` Slava Ovsiienko
2021-01-05 17:53 ` [dpdk-dev] [PATCH v2 5/8] net/mlx5: create GENEVE TLV option management Shiri Kuzin
2021-01-06 9:24 ` Slava Ovsiienko
2021-01-05 17:53 ` [dpdk-dev] [PATCH v2 6/8] net/mlx5: add GENEVE TLV option flow validation Shiri Kuzin
2021-01-06 9:24 ` Slava Ovsiienko
2021-01-05 17:53 ` [dpdk-dev] [PATCH v2 7/8] net/mlx5: add GENEVE TLV option flow translation Shiri Kuzin
2021-01-06 9:25 ` Slava Ovsiienko
2021-01-05 17:53 ` [dpdk-dev] [PATCH v2 8/8] doc: update GENEVE TLV option support Shiri Kuzin
2021-01-06 9:26 ` Slava Ovsiienko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB4987628212C5454DC3D3767ED6D80@DM6PR12MB4987.namprd12.prod.outlook.com \
--to=orika@nvidia.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=rasland@nvidia.com \
--cc=shirik@nvidia.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).