From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC5C9A04B5; Sun, 1 Nov 2020 08:50:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4BEB972EF; Sun, 1 Nov 2020 08:50:14 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 3F8C672ED for ; Sun, 1 Nov 2020 08:50:11 +0100 (CET) Received: from HKMAIL103.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sun, 01 Nov 2020 15:50:09 +0800 Received: from HKMAIL103.nvidia.com (10.18.16.12) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 1 Nov 2020 07:50:01 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Sun, 1 Nov 2020 07:50:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZUYt7Ee+STTkyYDgSymPzt9KjDS52qfg46VvO4yKYC9DiKHOGM2mCeYTnkcH1UU9AyDUE+s/mJg8HJpxi/zYGazafaKGcPL6GPY5WcP9q9aZ/l5+wW7uwDxJJT1zdZM1EGvw1K0fihZwLtImtjyQobHzwNDPh9ofQ6f+y3GRI4KOWGBCRdyoMVdXvVl0fFXuLkPjG+3uwPnfHRdBk2M7mxMy2y4aedelpYfjxRLA5siko548QYyyiJ+fC/SDQEUSxuiHI8oeNARL1bV15quiqC+k/CN3MqvADsoybjMQ94vD9mIs+PPuJCmfU79Fn3fYvhWJHwUcox6kY/IYznPhdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ecSjFwmDKxN5tFa+KhBWnd5tGFht/YlbtsUER2HATGc=; b=kAstyq6f0ND/oM+7L13QR38yUCb0QVB3mRajsfsNRXtgjCHas7BV2tb5p9lgaPGFwgpvB1Yuinm1RNDCOmrPJFQMwo3KfDfAUAKL314kJSXObdGo/RucBTNJtSb6vtIlqZfWJah7eB6Zc8npO5M5m8fhH5CfG5Wvo5hg482Bv9CmOvd6GVL/R4UQNc7sqdMzugrsIMZP6RGfkTpXyD1lEi0B3YFuDBrgwJ69NeuuKzjYM7FbFDRPtjfjynHjMEvyw1orUG+n49iz9R51Wu2Iqa+k34Vfo/LLy/LVatlVLEhdzcgBqxrwbeR2+KqWEXLgio0g67ErbXO9o8PRrL2vOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB4987.namprd12.prod.outlook.com (2603:10b6:5:163::31) by DM6PR12MB4124.namprd12.prod.outlook.com (2603:10b6:5:221::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Sun, 1 Nov 2020 07:49:59 +0000 Received: from DM6PR12MB4987.namprd12.prod.outlook.com ([fe80::cf2:dfd0:1877:bf3a]) by DM6PR12MB4987.namprd12.prod.outlook.com ([fe80::cf2:dfd0:1877:bf3a%3]) with mapi id 15.20.3499.029; Sun, 1 Nov 2020 07:49:59 +0000 From: Ori Kam To: NBU-Contact-Thomas Monjalon CC: Andrew Rybchenko , "dev@dpdk.org" , Andrey Vesnovaty , Ferruh Yigit , Ray Kinsella , Neil Horman , Andrew Rybchenko Thread-Topic: [PATCH] ethdev: deprecate shared counters using action attribute Thread-Index: AQHWrdEB0zXIv7HhnkuWHfQb7+UaPamuohIQgAAepoCABCoDAA== Date: Sun, 1 Nov 2020 07:49:59 +0000 Message-ID: References: <1603961577-13264-1-git-send-email-arybchenko@solarflare.com> <2047036.ch1fFInd6B@thomas> In-Reply-To: <2047036.ch1fFInd6B@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [147.236.152.129] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 862f72a9-7173-42c5-faee-08d87e3abbdb x-ms-traffictypediagnostic: DM6PR12MB4124: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bPAnMoCTOF8AJykFXfolpOdEPyPKFUliiSSkO0JHzdJfXHczjy6V7nOjwbbfXLXXkMQmnUbBWtp67tw/mj3hMVnv3ykd3HhS5XzLU0t6Bnu4f9hc6nGhnE6UYZerpkPzPnZWPchyvaQlX7u0CbMQ5NnzWT4+NMJrxTIFZeY4Poepo9e1JoV6PLEN2DaTXkgDetEVgDgHB0R79imXbEhO1BmGIFoyXP0n+TaeQSnx7WEOime0E+1O5WvEsOrQpyY7g9Ae+aO2wKehggP5e3JSqscihiGkqao+2uZBFr340mcnlyXnf3vKk2iAYHBfuG+1V3QczQKa4i0ONc5CDz4kzA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4987.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39850400004)(366004)(376002)(136003)(346002)(33656002)(71200400001)(6506007)(8676002)(53546011)(2906002)(7696005)(8936002)(478600001)(6916009)(4326008)(9686003)(66946007)(76116006)(83380400001)(66556008)(86362001)(5660300002)(52536014)(316002)(54906003)(66476007)(64756008)(66446008)(26005)(186003)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: q4DoO+dAFuko4rvLG/Z6GFpwFkmj4M8L6ZT0vBYFvm4GTlYy2nG+mvmDy4mfVoUJYXc6CY6vOHuoCUdiDDVGWYkthfHpVGsxwp1kV++Ud0KYHlPPDVBamCInS1Xv17mA8i9GDIclCLjo6VuwopavlUJc6hsZ36phNEsaFabR6F3WscUt47qmjJlKF7/Aj1O+RYSD8O0Go6m69bolNlWGwoslDUJBU9xOsasGDB2IFZuG0WcQROTMlBqzfQTEcM7APXxFgaHwKMkawbuFB6D5sZ2vZQcHhoH3g/VFcgGvTEX6Qit9TJnFdIsJKTHlLRgKP6kZ62xRg1a8YzQUwTJO/+5t6Tk64648aQ0otV6ezEcxo9Y6H6aOOHYwt+zCsxhShzJ9FmfNYPpyXT1b8RiJeg/pWmWCm3GrnhU+jmKkOWJQrpGDtq0v9CpC9Cc2Tp12hVaMdBbBTNIPfDaSsjtgnJexSiag1CPe5HPliQIwHyhgGhHQRP2nlWGw7Fl437HdExRXy3NUNls5iD+sqKeIJB+y7Cme2owLYWnMSUxOjRr2RGftiyYPlfKRHPhod8x9fP972kGDeiuOqejKdq8sBNuBOkUQMGEE/Cx8epmtvHlQp49HuZxo1JRb8bKMZZMsvXIEDyjAMJkqD/60aeMLXw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4987.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 862f72a9-7173-42c5-faee-08d87e3abbdb X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2020 07:49:59.7414 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gAvbSf8JBPWpYu/pUrWR2M5XH8DL7Zw6BFYq0mSUMnnfDLHgIdpbvtGZAqwOBWsc79+tvO/gl9t53ht6Xv146w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4124 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604217009; bh=ecSjFwmDKxN5tFa+KhBWnd5tGFht/YlbtsUER2HATGc=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=Swq0CxD4cYVy4EglyxlxZOfPmbcm9R7QA49/11GjPUmHCDgngjVrjKpWIMKGqtS9G f6TCQ4QSFKRnizEwJhJB2yK3WExTJPNrjEYrQ1J5Y+MeUIvaAuptCfhL/cyAkvWPce keyXkhMKnGr6WNuF8G29z2nE8gOqNwloYQUQZS0y2gBaGYmuEH6wYA9bz70suPpF1o NSeOgasTHthTfs3J+3a+cGeV7gSy8p03IoAoIvXpMZ6EE+RPL40iBAejKGBZge9h62 iMfacJ+9g4g1Fym9AbFe5NOukCngrnZj6O5kAjmVjCQd3KYj08mGxsbOvVQSZtbMQz i19T4eTfz8J/w== Subject: Re: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using action attribute X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, October 29, 2020 6:12 PM > To: Ori Kam > Subject: Re: [PATCH] ethdev: deprecate shared counters using action attri= bute >=20 > 29/10/2020 15:39, Ori Kam: > > Hi Andrew, > > > [...] > > > A new generic shared actions API may be used to create shared > > > counter. There is no point to keep duplicate COUNT action specific > > > capability to create shared counters. > > > > > > Signed-off-by: Andrew Rybchenko > > > --- > > > In fact, it looks like the next logical step is to remove > > > struct rte_flow_action_count completely since counter ID makes > > > sense for shared counters only. I think it will just make it > > > easiser to use COUNT action. Comments are welcome. > [...] > > > +* ethdev: Attribute ``shared`` of the ``struct rte_flow_action_count= `` > > > + is deprecated and will be removed in DPDK 21.11. Shared counters > should > > > + be managed using shared actions API (``rte_flow_shared_action_crea= te`` > > > etc). > > > + > [...] > > > + * @deprecated Shared attribute is deprecated, use generic > > > + * RTE_FLOW_ACTION_TYPE_SHARED action. > > > + * > > > * The shared flag indicates whether the counter is unique to the fl= ow rule > the > > > * action is specified with, or whether it is a shared counter. > > > * > > > @@ -2299,7 +2302,8 @@ struct rte_flow_query_age { > > > * to all ports within that switch domain. > > > */ > > > struct rte_flow_action_count { > > > - uint32_t shared:1; /**< Share counter ID with other flow rules. */ > > > + /** @deprecated Share counter ID with other flow rules. */ > > > + uint32_t shared:1; > > > uint32_t reserved:31; /**< Reserved, must be zero. */ > > > uint32_t id; /**< Counter ID. */ > > > }; > > > -- > > > 2.17.1 > > > > As much as I agree with your patch, I don't think we should push it sin= ce > > not all PMD made the move to support count action, so the application s= till > needs > > to use this API. > > > > I think this patch should be done but in next LTS release. >=20 > The patch is not removing the field, > it is just warning it will be removed in next year. >=20 Yes I know, but I don't think it is correct to issue such a warning without= support. The application still must use this API, the warning should be added as soo= n as at least one PMD support shared counters with the new API. Best, Ori