From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8B80A0C4E; Tue, 2 Nov 2021 09:24:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57C894069F; Tue, 2 Nov 2021 09:24:18 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2062.outbound.protection.outlook.com [40.107.244.62]) by mails.dpdk.org (Postfix) with ESMTP id 9A0804068F for ; Tue, 2 Nov 2021 09:24:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GjC/e2eeh7AYu4i+BlMG0uUIp7yjcEe6BhtM6obONB0w/cephLuQTBpihd+5KoZhkoJOYFK0b4Y4gaLqgO1iWAxYXDXamDWfyoBn+Qpv6YUWY7MLIA+xjT8YX/rbOH1o8FcjgU4vc/v/xBFb/m5RVGNu5CR6/D6c4S835Uh+duJoT8j5tD9FQiIFHL39SFa2VdfSWUgcEOmj32oTMORmwkHngU7XbBYHNAsfWzy5Pr/WpG7Hsr0jDLI8gy5NQFFmipIAxVN1Fts8bb8G0XTb9UvylOFt7Y4RY2CsaVCdLK+x59X+41apPpM96iPF3uFXTgsMvXTK/QpSP21D/fg1Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MD481D5nvjB4eefDOB3hRimZruD4K6+fiC0xTXRzcxk=; b=KIUGpsIuUSKLPh4cpms2WPVbutaIJFEG5c9uolMWcNcpbGbV8vIp6Tk3tffRXfwBzmjm0Ai0CuUDt1z5aZ+pYr08EI7wMj/MUvhF6xT8AY1KNsHIY1BhXOcr4IpyYe2qzoLRmLVInu/7lCdGeg9bpsayaXCjIK/28QH4859NwhSDfWQsqzXc1B2Rjg91hq7NlmoCAuHy8QstddmRod2oe9Iy5gQOkvAznZzdudAmUTdh0RcL8K4JPp4GPgDVGAPnwPCMkWZgVgWa4RrQ0rI4F/QuZAsxMzO5T64aU5jfsGb5VYdLRyIEBm/9PscGgNR5YvZC+392sZjEL/tZNOnrzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MD481D5nvjB4eefDOB3hRimZruD4K6+fiC0xTXRzcxk=; b=JBr+oePnwiBHnx0if9VAKY5d99b7lkgoo9lDK1XrlYhf/+85QIjFLP79oLT6GGYeTlNSjNPZJnCUiQZevRJMS8kEi2zIte5O+fB+RSaL32BX37ZdMQ5TSxlAiRt2fE7vS6NbO/suE1Nruv3ijrId/Nd5h9SSxtrAWVJOqcW5NIO6Pic04gvBQqAoN3xzmL/lbkjEyfZzTmgbb93ZLoMougubhWHXVeAytfowhkty4zgoBbhRfEe3tF4rMXEa8CgvjYEBTdLGPk1WegT5Ecj7Qfyj8fxwXa9HEOY0YPilNDosmZcOa1+fuJr97a2LD5Rv/WTrI9WUJ9VxYhWEJlGhfA== Received: from DM6PR12MB5520.namprd12.prod.outlook.com (2603:10b6:5:208::9) by DM6PR12MB5565.namprd12.prod.outlook.com (2603:10b6:5:1b6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Tue, 2 Nov 2021 08:24:14 +0000 Received: from DM6PR12MB5520.namprd12.prod.outlook.com ([fe80::8817:6826:b654:6944]) by DM6PR12MB5520.namprd12.prod.outlook.com ([fe80::8817:6826:b654:6944%6]) with mapi id 15.20.4649.020; Tue, 2 Nov 2021 08:24:14 +0000 From: Rongwei Liu To: Bing Zhao , Matan Azrad , Slava Ovsiienko , Ori Kam , NBU-Contact-Thomas Monjalon CC: "dev@dpdk.org" , Raslan Darawsheh Thread-Topic: [PATCH v1] net/mlx5: fix meter policy validation Thread-Index: AQHXz8KMmQW4x8DagEyyxy2BOvdP8avv5mFQ Date: Tue, 2 Nov 2021 08:24:14 +0000 Message-ID: References: <20211102072240.1073955-1-rongweil@nvidia.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e34f6668-a3bd-4ec9-0ea4-08d99dda27e1 x-ms-traffictypediagnostic: DM6PR12MB5565: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Agx83E7+ksoabFmu6g8pHCNwx5tLGYU635CS3YkOup5jc/1Kx3LiUohKqR1rBgBSV2Tizmjy6ynoQB0Om+jwAkPf3JdqXQaMToXtNZc8moV32YyoKgpml1Vp32VRUVYNdIIsMW7RaX3o4vWpzqGOaIBMnQEQc9dnrQ7r3INO3V4tgL3WtieL8Y5FQPdGshmUQdqcFlk1/5NbBZSRhiN2exWPCpMVZy1Et6g01fr6IOUICvQFHWIdN7YVIMnhKD+MuHaOA8kZw/cRV2bv03HDJmecRR9t8llAGF6dMdPOGf7cPev8Z0sG4GfS4FSGoSQbhoQXJU2EW+Vr7q3EEZPT2fgkrgvKuFJcHLgLjFymzVL52rQXTQrYDnfVZPzHsr26JJSPACriW3HsHTfPQiMg5kgK7NzFoSX04z1RMOwdz/Q4b+/Jn0VuZRSiF28XynYZ/kAq8pSSnmY1CCavXWrnze5XfUZJCSjWqEFgwtQjYucqAY8FThcKe/oo3X5BYsRc0MxrW8KMEgd8Gk0dkRf1oRiSky57FgHQBdWkxYy/Fp9q/HpU5E9bjmYPmPrgmtOtCqHj07kj1l6AYPcw1jTV42syBGuP0NcS0XxGg3Xh6Rm+NXeqntPddCBfZTsDGa/rcSyOqfJsirIqc91u3W9AIuZCxt65f1lBv2l1DDwwPRXl8MXo04Q73eMzdaqnY3oUg4aoQY9QbBJPflFyUZNhKQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB5520.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6506007)(53546011)(8936002)(508600001)(107886003)(83380400001)(38100700002)(122000001)(110136005)(316002)(5660300002)(8676002)(2906002)(54906003)(64756008)(33656002)(4326008)(55016002)(38070700005)(9686003)(52536014)(7696005)(86362001)(71200400001)(66476007)(66446008)(66556008)(66946007)(76116006)(186003)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EZd5p/TW6H1DWwv8f2G22kYlvccXg7EA5WH5l314Wpsop81AXKtIqMaQONX7?= =?us-ascii?Q?KNJEozi8tVrPzFv4QmMXmFdK4rQGM4TwAopOg0OEVfzQKCN8BZgLM3NlCAug?= =?us-ascii?Q?g1kmtTHIgWFZv3vJZ1d+CopyLfperfRqG5a49kvNd/7iBWXQcXwv1gEFO1Pt?= =?us-ascii?Q?PS17GQBk2ryhLans2d29dZnXW/4M6QTCYfEw/AN/wz515Wv2S2Gsh0EivKjD?= =?us-ascii?Q?6RWA0gLfKWDYCMYTM0kXW4uvEkf4mxj3jDTSSysNkarqRdeZ2O8/3z3C6t5/?= =?us-ascii?Q?7lyfSRr3HLVHuePu/oe87Qz9A2zunALyE/27RI9/IAjze+/ltxygi/72uoFV?= =?us-ascii?Q?oV28AQYLKLCteb+hZ4guYugryz//G2z+5SdZKlIwHpwM0cOMUj6x7uv4zzkk?= =?us-ascii?Q?Kr+FZ7R74Lkm1yOXgIbRqkQnvWhp/O3pdeJYJYsqLxfo4ujZpzKX9kIJKowW?= =?us-ascii?Q?54BQDV1naOKC4TiOmQ8nhGsEaymXjUvPOAEcjfof5W6E31QfOwcpsIYrF4BL?= =?us-ascii?Q?i97elKM2OMuAMGTk5t1HZnv9O0PIARHBte1FO5lJ+Pwdh5LsQIKyLtQLtGx2?= =?us-ascii?Q?7yaZpbn2xou+7khvViVpWIYt/S1tTNSVKSlk7Y9X3kZLldZ5h+df5ShaS9ty?= =?us-ascii?Q?YFqQFHk1g3HkIt9CYs8r2unsWiZJbF4eapcpppZlMsapNO0LGsLK6zSa5s6/?= =?us-ascii?Q?MaXDen2HVDrSb37T9m+X8aWDPhnBBBvbHGgmsbCYRz7HQN8Ks2k4A6w/Au4o?= =?us-ascii?Q?WrCctIwDns7bIgOzNWVoBKltC7eVcV1caIho0PwqNuhhjrFSyPWrRUqGTpRC?= =?us-ascii?Q?nibEOJNmKlhTP0kMmZ2LV7Uvv2ydoQjNi5qTdCgHcCBTvbYWOhsvVjw5xZqp?= =?us-ascii?Q?fdFB6Pek1FkJKZgkpjSQVTW8xn66ZjhXuuVI2Lons7heV/DHlAo/Df7ZC2W3?= =?us-ascii?Q?T0bo33d+DfE0PGDnVgBkuxZ0eKzBln5JkdvD1qrhPqj/GM8YYG6IeLEb7/6E?= =?us-ascii?Q?5Gv7hUIw8/yQ2XMWYcA8mCzPCDUVQE3X2QrVHRQTa0wRfUjH0lfuP4QAg3Vh?= =?us-ascii?Q?yDDQYWPTkx81JP5t+33wZcj9Qo5LamViFkL1rS+7W4l2JjuqRZMoNSMUx9DY?= =?us-ascii?Q?2k2/IRl6unfP55iOAZGo07w+oWQOZtfsLptroprveqwi+N4ZtlqV7nHUdrHZ?= =?us-ascii?Q?MMj9PcMlOKYF8GHqy0r3yb8D3attZggSAapDVH7jrddI66qAH1MCENAcKlwj?= =?us-ascii?Q?9ywTGdDzbaA9mnihypMefjKazSFOVRgUl8URsXmf1ZIslN+8SHQwrAv9yeAw?= =?us-ascii?Q?Im6pXfX8UtLfUlRHW9rc6AcY+VZPlb0FmhDToSyCLtdK+/dgPWZbmsSeia4t?= =?us-ascii?Q?2ix27f7luqCXBBAKE9tDN6TBL1RgWYdRQoi3btRubFH5bjIp9qDzPuiIFOZD?= =?us-ascii?Q?HQPak6sOUMzxzu6FejljRF06Mqp7VcEoAfs3MaETbKVVmNSxpFtRjih/u9mK?= =?us-ascii?Q?xhRh33eOy1VOrykHYzAZspaAULWxm7zCmKPy9s1ISGd/herJqsR2fGe0AUtP?= =?us-ascii?Q?hOJKNxl1fBuV0pLMvQe1CiGciuEgWgIMpLiajuoYaOqKk2Ee00eJtYdBVKGW?= =?us-ascii?Q?o7Af3OOkUxGo+tG9g0SQgN8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB5520.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e34f6668-a3bd-4ec9-0ea4-08d99dda27e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2021 08:24:14.6640 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CsZiFjHusFzqHU29/a2P89BgDEyRl9q1kQPPxWhWFOkZSzPnc8rtydyVNTbUgFoMypbmP2/H5qXyNfDcH8XnOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5565 Subject: Re: [dpdk-dev] [PATCH v1] net/mlx5: fix meter policy validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bing: Need to backport to 20.11? BR Rongwei > -----Original Message----- > From: Bing Zhao > Sent: Tuesday, November 2, 2021 4:21 PM > To: Rongwei Liu ; Matan Azrad ; > Slava Ovsiienko ; Ori Kam ; > NBU-Contact-Thomas Monjalon > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: RE: [PATCH v1] net/mlx5: fix meter policy validation >=20 > Hi Rongwei, >=20 > stable@dpdk.org should also be CCed. >=20 > > -----Original Message----- > > From: Rongwei Liu > > Sent: Tuesday, November 2, 2021 3:23 PM > > To: Matan Azrad ; Slava Ovsiienko > > ; Ori Kam ; NBU-Contact- > > Thomas Monjalon ; Bing Zhao > > Cc: dev@dpdk.org; Raslan Darawsheh > > Subject: [PATCH v1] net/mlx5: fix meter policy validation > > > > When a user specifies meter policy like "g_actions queue / end > > y_actions queue / r_action drop / end", validation logic missed to set > > meter policy mode and it took a random value from the stack. > > > > Define ALL policy modes for the mentioned cases. > > > > Fixes: 4b7bf3ffb473 ("net/mlx5: support yellow in meter policy > > validation") > > Cc: bingz@nvidia.com > > Signed-off-by: Rongwei Liu > > Acked-by: Matan Azrad > > --- > > drivers/net/mlx5/mlx5.h | 2 ++ > > drivers/net/mlx5/mlx5_flow_dv.c | 2 ++ > > 2 files changed, 4 insertions(+) > > > > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index > > 39c001aa1b..591ae2764a 100644 > > --- a/drivers/net/mlx5/mlx5.h > > +++ b/drivers/net/mlx5/mlx5.h > > @@ -622,6 +622,8 @@ struct mlx5_dev_shared_port { #define > > MLX5_MTR_TABLE_ID_DROP 2 > > /* Priority of the meter policy matcher. */ #define > > MLX5_MTR_POLICY_MATCHER_PRIO 0 > > +/* Green & yellow color valid for now. */ #define > > +MLX5_MTR_POLICY_MODE_ALL 0 > > /* Default policy. */ > > #define MLX5_MTR_POLICY_MODE_DEF 1 > > /* Only green color valid. */ > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > > b/drivers/net/mlx5/mlx5_flow_dv.c index 8962d26c75..e516c11d9a > > 100644 > > --- a/drivers/net/mlx5/mlx5_flow_dv.c > > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > > @@ -17617,6 +17617,8 @@ flow_dv_validate_mtr_policy_acts(struct > > rte_eth_dev *dev, > > *policy_mode =3D MLX5_MTR_POLICY_MODE_OG; > > } else if (def_green && !def_yellow) { > > *policy_mode =3D MLX5_MTR_POLICY_MODE_OY; > > + } else { > > + *policy_mode =3D MLX5_MTR_POLICY_MODE_ALL; > > } > > /* Set to empty string in case of NULL pointer access by user. > > */ > > flow_err.message =3D ""; > > -- > > 2.27.0 >=20 > Reviewed-by: Bing Zhao >=20 > BR. Bing