From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76301A0547; Tue, 20 Apr 2021 10:36:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BFF54163E; Tue, 20 Apr 2021 10:36:20 +0200 (CEST) Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700129.outbound.protection.outlook.com [40.107.70.129]) by mails.dpdk.org (Postfix) with ESMTP id D6C6A413DE for ; Mon, 19 Apr 2021 20:34:32 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iu1Bz44Aw27Z/usNVVs7AHXwC0bywxVeefegdaKAy8mkgaVoRgAjFO0vuaHm5LiLFk3pcUas8c+znQFJCmiaL1/IV8qE3WilYSH0TTGhvZ5Q+00ooOATYV/ibgtdQRSFOKqd+UI3rxFdHTS9uva+AiDfMmJpI15S4IlboeIjbEtJbXALXC+2zw9MXh+kSPbw12b2gW9NekEt139eLIEb9cYeceSQ43PIf25hvCA7HreXVZ4UvhdJ2MnIxAk0n5F2MHrNQk3mc+XTQE1Lug+CxJ1AHn47pzHfJl3Vjm8q46mIJRD7cKRxnx8BBW1Vjxdk0x/UGOaG/oje8V9xekHNSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZXGC3PSG462OI2bCm5kBrUxz3LLsMM9fxQ0IODCCBrQ=; b=Bg5nLzGUpaINdivtUr55SGifEF1ejQ8p9N6lLOC9ng7Vz59Ug6INrGjSz5+7O/qpzpZRKr/1rZ5hAbJQxVv4KjqElKbjv6sDvQ4af2x+JE7C5Gdq83UHg9fQC0NLSWlLQ8VAqvQzQMWxwbpw/7SYp2ll2uIGj2DGEE3b21KhxxnJn/lJWdzoUf79dAa0hl5Sp9ldmMxkfnsg0LxZoZr2u17yQhQ95MWtrbekpMVI/rvgSjOXZnOaBbPtXS3bahVlc20F92noMkD29baB4IisgHhgqhjTLGxF8OcggO6m8wNM6+BEAvSEfzkRxTF+ToNjGsgCIKgYFFL9Ed9qMa33hQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZXGC3PSG462OI2bCm5kBrUxz3LLsMM9fxQ0IODCCBrQ=; b=fKWJqbZZnwnYg1UdDgJJT+nlu6PRlRgPQvnWUhNqyaAxqHD2UtXQTlYumZYX4vYj6DBPouWwlHiPx6dHHccv1ORmpp6CPk+H247MdAgN4lKicOEHekZqRsjwWiDRiDUcvMG0x77aEdWO7rH1qTal+oJYubp7N9F94MoYgVtL8a8= Received: from DM6PR21MB1324.namprd21.prod.outlook.com (2603:10b6:5:175::11) by DM5PR2101MB1047.namprd21.prod.outlook.com (2603:10b6:4:9e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.3; Mon, 19 Apr 2021 18:34:30 +0000 Received: from DM6PR21MB1324.namprd21.prod.outlook.com ([fe80::842c:ef91:864f:d9f]) by DM6PR21MB1324.namprd21.prod.outlook.com ([fe80::842c:ef91:864f:d9f%4]) with mapi id 15.20.4087.013; Mon, 19 Apr 2021 18:34:30 +0000 From: Tyler Retzlaff To: thomas , Jie Zhou , Dmitry Kozlyuk CC: Tal Shnaiderman , "dev@dpdk.org" , "xiaoyun.li@intel.com" , "Kadam, Pallavi" , "bruce.richardson@intel.com" , "ferruh.yigit@intel.com" , "david.marchand@redhat.com" Thread-Topic: [EXTERNAL] Re: [dpdk-dev] [PATCH v5 5/9] app/testpmd: add clock_gettime_monotonic Thread-Index: AQHXMuodV2g2xxYw4kyo/O0wvShzvqq6hf1AgAGhCACAAAKfgIAAArHg Date: Mon, 19 Apr 2021 18:34:30 +0000 Message-ID: References: <1618594501-23795-10-git-send-email-jizh@linux.microsoft.com> <20210419180422.GA19684@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <3990047.YzQW8q25Qq@thomas> In-Reply-To: <3990047.YzQW8q25Qq@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=8854ac8a-ccb4-40d5-a52b-3bedb04e40fc; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-04-19T18:23:23Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [2001:569:f858:9100:348d:cf8e:963a:2e83] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 253f7e1c-f210-4744-d2ab-08d90361c55c x-ms-traffictypediagnostic: DM5PR2101MB1047: x-ms-exchange-transport-forked: True x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O1fc8+aOkqtET30HH44P75NtrHEDjXsRD3bTm/CY9X0Fwq/f2xu8xn+NA4Cn/L3Ex5GPyydHAAvPPSdwfyANZfye+lsTPmwHPQW7Zm4TePVz+FnvDNdlCA/mx5zlhSinfa8f2yNfLQR5wpXbkLMbb0WmkSCbvAA31ASCKvpKp7/8LmbC9q1sQbamikSefxjZUrz935cRIIlZjeLMWyK8fXtxkoblE1lUdj+gst3jldj+oXc3BchKSiabryISHAWhifPjhKTmgjp7G1+7P3k6sPSC5nT/T502FoISfI9Rz+4jcF73yKtvOQzEfOH0q/f2SxoqbY5ALBP+OiaqBBGBojLoOx9pExJE9lJm4SbFdukZibRkJefaKcYoa8BZpoQOvnPLn6SarnJGwUG0EPX5CrqJTGnMTEWxm1+WeHzm9GAFPyRzk09YVP2Npgq996vkbWqNq1XRUDRXkji/rwWjVVqbu+f2Z88na64dtDLBmT4bE39h8edybNhko//AlcCtHjeSzTLfcQGpPqfjxIS2o5XBa/0h9qj1syJ50ySRltoacq4iWBm3jVKnHAo+9gysnUwbi73YtscFfSiqVIKlaO9jQSol2ZjFYrrZGtOUSKg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR21MB1324.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(54906003)(71200400001)(316002)(110136005)(8676002)(5660300002)(66476007)(8990500004)(2906002)(76116006)(82960400001)(10290500003)(186003)(86362001)(52536014)(4326008)(8936002)(82950400001)(33656002)(122000001)(55016002)(478600001)(66446008)(83380400001)(7696005)(9686003)(38100700002)(66556008)(66946007)(64756008)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?17s6yEfza0zNE92SYqVA36FNthycfWvwFPFyJtPDUkQZsEJ4l1iC0/ep+xZd?= =?us-ascii?Q?3dMZ63QnE60UoWhVlbmzSgwjSWvapAwRQdl25QFoW0T9Bt9BwypbBR4WMcsc?= =?us-ascii?Q?DMOUUobVGqKdk7wZXpw3AZFrP2Q7dIeyPMnLNro9QBufYxJB8uR2fBPMeicT?= =?us-ascii?Q?X7Ii2rleZuXPPIxIj9tmzSlZN6Lo0K3XmLFY5l8ArXp2DUpphuQSFnXbsRdY?= =?us-ascii?Q?sLoAclrLkVTcQHrtJVD0hG3mztEm3kb7IYaxeGnJTK0To9jBUaMQYBdaK8W/?= =?us-ascii?Q?u8mNmmfmfl27/J7I4XM6g9wzdGv9LN02lUl81ua4VqrxjnFGe8xaTizzHyuR?= =?us-ascii?Q?JDugaJc14fapujtMH8FgJ3wyBfqlr47eE6F8kTYsVHXmb0YP1n5LYx6iosel?= =?us-ascii?Q?tSKj5NjFfS2WiKwH21KSIavw8unyjJ5wLTBMafGCfBa+nnUwGLsLe3eyIgx5?= =?us-ascii?Q?LUBIErDAmaOahJdpmTvSwHbhXot66z3VKnBsjvbKP6tW8hHIbbfVqKTVcWw/?= =?us-ascii?Q?48xurC8ipFNnUdGHDQV3S3pkXDiy/qDuPe6CkE7SzmsdoxkTqC5hvW1x7tdw?= =?us-ascii?Q?ifYTEOsqEFLRMtOa1y/VXCGwb62a04reBaBJ4VFIKsrub7/djjI+PckKODaD?= =?us-ascii?Q?QQMIAdnVMoA5NQadbV4+QQmkQUtSfi6SSKl30GDuoOzMXvY+aep7b/oT336/?= =?us-ascii?Q?FLIQ1Wd+qf/GBGWgJOYRnX+Z73QJXPDJc56b+bEzZosXnsDlW0oLn/4KX6+C?= =?us-ascii?Q?v7F8uXsykWNdv13tnmgQ06b28EavyWL2TT8RffNo+cj6+/BMPkBCLBgBEenD?= =?us-ascii?Q?2pjDEXBEL+J3yJbRLD5EWd93TDuBu1uyFAPCurX2amN3/DkYmlH9yprgddTx?= =?us-ascii?Q?+g17i14JxfwYSU//E4dNIUSQgn4XYlET+2W5xwe9rFPueYBxV2R9BweC+EK8?= =?us-ascii?Q?BVEIeApA6lkWOY4xUA3Rs2dRNSuZ1X53PXh8OVWOrvggNMyZzbp/ld4mJkiq?= =?us-ascii?Q?vm8osgCh3GdnrnDEQOF3tS3kR7IcsUde0E/nGZ6A/JbLhIhOb1PRJ+ky9pxm?= =?us-ascii?Q?9grYEPTVJjQewNw0Kzdwk5+itCBLK2CpGedw7OguI02NAakl5gKzKZc2cAJr?= =?us-ascii?Q?lni3IM+U3pkXQ51QhdoRxEq39wKiLkNiXsZnuOiRUmLqXwjgiSaHNL+1rBJ+?= =?us-ascii?Q?3vF2z1k2Bqa2UQ9jmsKH415wt/QMJKkL3J/6zCuKf9TTsYWNlfM9XNnkb9Ga?= =?us-ascii?Q?X+pxC0hHlKmQUC606Ohy1gzpb7lZ33Hbu4UqrsMxP0inGWrW0+G4ZAm0IcFf?= =?us-ascii?Q?+34ozCVpBl/5LmZShKniE8wdxKhw1O9k04gv7MuZw6uf0qFz5yp/Hk/PhbR5?= =?us-ascii?Q?0dPiNNnHnNcydZyocWISWl/eO4SX?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR21MB1324.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 253f7e1c-f210-4744-d2ab-08d90361c55c X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2021 18:34:30.6585 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YMttq1E2wH2yHNjbtcXR2szgk5ZgGc0qR2VPVAYFBd5uxv8wcXeKqvCKMnbNq5qmjRX2HBY6ah9rokaQ64oNow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1047 X-Mailman-Approved-At: Tue, 20 Apr 2021 10:36:19 +0200 Subject: Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v5 5/9] app/testpmd: add clock_gettime_monotonic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- From: Thomas Monjalon =20 Sent: Monday, April 19, 2021 11:14 AM \eal_timer.c Unix implementation in=20 > > unix\eal_unix_timer.c >=20 > Originally and internally, the function was added into eal. But then rest= ricted the functionality just inside testpmd to avoid currently seems unnec= essary version change, per a discussion in community meeting several weeks = back. If we believe eal support of clock_gettime for windows will benefit o= ther drivers/apps now instead of future when real need comes up, I can move= it back into eal. DmitryK and Tyler, any conern or inputs here? My point of view: A test application is also testing the API availability. Here it shows something is missing in EAL. Instead of workarounding in the test application, it should direct you to f= ixing EAL. I think we have discussed to some degree in other threads but the more POSI= X interfaces that get integrated into eal with an 'rte_' namespace pasted o= n to the front of them causes the scale of making DPDK portable grows. If = individual applications need portable/cross platform APIs like they should = look to other packages tailored for the job instead of trying to put everyt= hing into DPDK. Threads is an example of where this has gone wrong, I don'= t think doing more of it is going to be beneficial. Shouldn't EAL be in the business of being DPDK and do it well instead of an= all encompassing cross-platform application development kit?