From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DA27A0547; Thu, 28 Oct 2021 12:34:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4871740DF4; Thu, 28 Oct 2021 12:34:34 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 1750B4067B for ; Thu, 28 Oct 2021 12:34:31 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10150"; a="211149373" X-IronPort-AV: E=Sophos;i="5.87,189,1631602800"; d="scan'208";a="211149373" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2021 03:34:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,189,1631602800"; d="scan'208";a="466079366" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga002.jf.intel.com with ESMTP; 28 Oct 2021 03:34:30 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 28 Oct 2021 03:34:30 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 28 Oct 2021 03:34:30 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 28 Oct 2021 03:34:30 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.46) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 28 Oct 2021 03:34:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lw5ngnUWXQ7AgboGIvahInE1AKvttxGPuWbcjhXtoap2/YakB29UaSX4MqAEjknPsd7nsSLBXsxT0mjMoxrT4Vjnder4hk5YFiCosGAEFGR/iYGugBMUyAdhltdpJqkEvKRA07iC2cNnymU9w7z69opQosKqhfS5GGe10TV52UmDPvHoy8jqrpUeYIU7kWGOgEVFH3uXEjpLxB8YREFvB2u1X1YDELNmYxUx9iSrI/+as7RExtsh7YBTYiOE8bIBV1j+CKG+owz8uZubpzOcuLrc4wQE+c9oOtFpvWUhIOAiXmZEYH1dL3AOSeRXod/vi6fzWyOSt2AlGvsn9lBaoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZZ+OyQD2ajb26qhJ9LoRLrhbjNW5OCXHlsYuk5aQNgw=; b=R/Yl0aFp2DnqczZPEAIigszufq1Q24cC2vaegW56ISRHIvBhN9rS9sXdWFahIBKZbEEhW/wFco9cQrOP3NYfmUj78qKsu6uSbcpEUaYZ52N/WkwbUGQJcgiILv6XgJlqkOXrZisaqICp0gXB8IChH0w3e8v2eZyPhOozQY2AmMnfdpbcZdNArdSwEvl3D1e/Wa8pqbv3gHLbBBGUpvRvcwy3bWkONw+dZaKovqoIeKwOOZnSOo+ImLaUzRRWu/1dIHo5D3vjKb28+Cbzmk43snp9s4pI5VK1h/ZrIgDh/mzQcaud6hvKtAHpwNzzK7ZGBHAyErM8WDm6XC6GD+iErQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZZ+OyQD2ajb26qhJ9LoRLrhbjNW5OCXHlsYuk5aQNgw=; b=fgOcfS/Xz9Du5fA4QPpRJiAcijzhk9dp5a70z58Zxpf5Mtw2j+T5aZ8VDQjf54sA0mAfQaMtepZJWxP57/UwC8XcTce0+J54edFmvvMsmPdS6uIaMHmlLtqqpA0T2PLi7AzfKe+6s2zwuMOqBr6gAsS0pO2Ob4dqSCR2dnBNUGY= Received: from DM8PR11MB5575.namprd11.prod.outlook.com (2603:10b6:8:38::17) by DM8PR11MB5671.namprd11.prod.outlook.com (2603:10b6:8:3c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Thu, 28 Oct 2021 10:34:29 +0000 Received: from DM8PR11MB5575.namprd11.prod.outlook.com ([fe80::2daa:3d15:d5a7:15c4]) by DM8PR11MB5575.namprd11.prod.outlook.com ([fe80::2daa:3d15:d5a7:15c4%8]) with mapi id 15.20.4649.015; Thu, 28 Oct 2021 10:34:29 +0000 From: "Coyle, David" To: "Troy, Rebecca" , "dev@dpdk.org" CC: "Power, Ciara" , "Zhang, Roy Fan" , Akhil Goyal , "Doherty, Declan" Thread-Topic: [PATCH] test/crypto: refactor docsis to show hidden cases Thread-Index: AQHXxzMFA5lmanTpjESPx4qBU7zUqqvoOInQ Date: Thu, 28 Oct 2021 10:34:29 +0000 Message-ID: References: <20211022105302.3652-1-rebecca.troy@intel.com> In-Reply-To: <20211022105302.3652-1-rebecca.troy@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b683069a-0831-49c8-daea-08d999fe859a x-ms-traffictypediagnostic: DM8PR11MB5671: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: g+GrOX81lIzeWbSMbtGKabdey86ZasusTmpeV8ox4G7gnGyNYAYWktzPQo9z72Ttofg1iF3gfMMgjrkLZ1Wz9qn8iHKl1OCmdEiML91wVd8OgyGiziC0t+1+bahzDric/4ufKah2lIIMlgD7q2RrRoVZ6Vb7B3SoyqzKwlw93sBRmTTSgQTYDIuJldvrgYw5fyD8VT0rypKPphOC8T/F3VH+4U9wUfzTzrjLCId1zOiNKsZdH5vxS1BVqsQgZh8zdhVA3BpnNzR9ASQTnduBc1e8cCnjXnpKR4iU7rSd74CKNded42U003AKXKNIeXGnvm6o6e7AyVH3Pyztb8IEb9mMm4hXJkpPO9hts19ICbnBqh9EB6dpe9XZCZdtBlQJ2QMUtafvsOTRH/6AxZl4DLy0JhpdF49TtBum8USLPZjfjK8t0BOC9S9/obEga33QtMM7prUSGsKe07rRWvWxCjVHGa7Hi8q1TDtW3Rpy6WN+J7bldJYYAgSdjRKCTg+evYRL8rMCl38o4jAHiDV6UMt7+ZhocszsJEVzrRPy168n4paEYKyw3Wty5mdfI4IYTAQE2/oaW79uRuBn8r9ElV3l2EskSWCIgF6do12AALtvteaCORDMPa1xk2hBjHUn8VFXI4DydM1mBl05YH48hcsaX0TMQG3D0pT/BVNGWePLyKYIMSgDdbr8P0zpSzGeGJCGZ5vH9R8a/oSYqUoQOw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5575.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6506007)(8676002)(33656002)(8936002)(83380400001)(4326008)(38070700005)(76116006)(64756008)(122000001)(2906002)(66946007)(66446008)(52536014)(5660300002)(66556008)(66476007)(38100700002)(55016002)(9686003)(110136005)(7696005)(54906003)(186003)(86362001)(71200400001)(26005)(508600001)(82960400001)(107886003)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zIPMIuPAh7G+Jzz+9JXlYSi4mD0/cceYYRNm6iJDoLayl/1ms8TLWtdyaOP0?= =?us-ascii?Q?7bIDazyFFzZRVQOUaIEUp/VAZ9Yk5SLNH6XuCJgKYc/fAsL0aw1+phSAa4VV?= =?us-ascii?Q?eUzy5IzqVGApa/zby7N8rYB3orWnE0aPzRVVHKB2F8UAyc5s81LooL5kk58W?= =?us-ascii?Q?5MYHa/FN5/zmz+NdtP1J1MagDw2DMROBzHDt5t3ydmp4OydVdQj0Cx8G5gpu?= =?us-ascii?Q?haxBklYwBmeIIQL+Pq6tmkposRXpq6MEMpjan+jZfxuj2mgIDNvQq65w1QLz?= =?us-ascii?Q?vA0t+BWO/5mdqEln9003RIjsdVaC9omBJk1HDIsXoQiYsmlFDN/+0/NY7EtU?= =?us-ascii?Q?VqVkDlm0IzHfyWrYcrdTSCCAnei5+s+LUVhQ1qeJQyPRNvugRBZJC4dvUBYj?= =?us-ascii?Q?0F1XdUVt+XhLtXA0+TP7IJ4G642dCb29DqQjpxKK/zTZfUBgBhb+qEPVIs69?= =?us-ascii?Q?kxKWq/rw+Ypw2z0TN/dZy8C/m53ytO7KWIUVaVaJxFXjlSU2+xcwybsaymyk?= =?us-ascii?Q?WcnWApUsPXgNS6fYqYkGCwKH8cOkylUsXyLGlP4YQA3nNpphcTZ9PJ03IsqF?= =?us-ascii?Q?4ogjck15wIUGHI7u9TypscTnmxja7IK3XhDet6mWbUB61Lj4vmGA4CCmMUi/?= =?us-ascii?Q?vEPdiQjaUzlazq+8MOksyZSuk+/Jb4cBgsdWQDRL8pnsqFsin/1NmMDgUy8Z?= =?us-ascii?Q?ohEEfWgi3l90BJI9KnKGcKvx5skAAPsoZPrAre2qLqX2DsN2MWUcP/DcvUuq?= =?us-ascii?Q?TYdAvdeZhrvO7sjKAX2oWk8FsSJxF8f83+PQ3xQiYeSfgGxAYiVfZh2NJtZz?= =?us-ascii?Q?RJAduPhVMjgIwu5KirbAP/gj5DXCgTgN9kaycaWp7TXC4uiS5aXSfMPKjJ4U?= =?us-ascii?Q?R4Z0+T8Wlv+uzW3Bx0xgTs5VnNk+M3egFWaI0N14zgK6QIQLCssYSrYEOWnL?= =?us-ascii?Q?pPMPyuLYohQRYnxHfx7Q7txXOs1jAfGm30VJiub0z92GpGP8/XumZR9XIwmb?= =?us-ascii?Q?9F2Tbza9L+XGIUF2CNAmw6THLzm5i0Glu/xE0zP1KGidcHft3yh1SwM7aT7H?= =?us-ascii?Q?8EwqMUGc7uRF701WPl3UVtjXsbUnRoso/Y3zSMJRGuHrSSgsE8narvCNVFnp?= =?us-ascii?Q?v+aPDNWm5aQNt5tkfSkOHN7bCpeMW2Gkpb+1HF19JcWypb8zUbJg0SfVAR5Q?= =?us-ascii?Q?PtxavfczFIeiiwbEF22/Y8pOui76OrQfW25iO1WqgHFUJJOXS6AXwi6At3ic?= =?us-ascii?Q?p8XllFbLCZKOf0oupawlPg19uqLRnqlF9T8f1aeI6+LAgijDVwNDtbacdGCD?= =?us-ascii?Q?NBFv+dAI/HX/Sp9CgZafGVSuVpfxzSKRLXwLj8DvWK+O/dBErVtj7lDo9WVG?= =?us-ascii?Q?t65j57A0A/PzTMpD6JmKnbMLzmX5Ckse6J9N0SwJ2mQhMXJLrMoo8gucGbon?= =?us-ascii?Q?RoGB9T/tDr8uveQcnbfcODQzCOQnwVp04zMoglSaPz2NHvg7N0dwSzF6scAy?= =?us-ascii?Q?OSRFvkCJi+cEueNHLWOhlidamGajEWxG4DDm9/SBOY2WHuGruJk8xyBDtkhi?= =?us-ascii?Q?XOQqsZQwLdhTB1lt0s0bk1gAJSXv1/cCfHoDBWJlZet6J5zQqts7sGINx/DO?= =?us-ascii?Q?qg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5575.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b683069a-0831-49c8-daea-08d999fe859a X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 10:34:29.0991 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: veZ+iOixdv/MwxqnagNds7bV4kiT5qHfABycPg+n9vU5pmRLIKAhnebmB+K2bndzYxNoHLNh1oWpLvbAyIuCkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5671 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] test/crypto: refactor docsis to show hidden cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Rebecca, see below > -----Original Message----- > From: Troy, Rebecca >=20 > In the current implementation, the docsis test cases are running and bein= g > reported as one test, despite the fact that multiple test cases are hidde= n > inside i.e. "test_DOCSIS_PROTO_all" runs > 52 test cases. Each docsis test case should be reported individually inst= ead. [DC] Should make "docsis" all uppercase in the commit message - "DOCSIS" >=20 > This commit achieves this by removing the use of the > test_DOCSIS_PROTO_all function and statically listing the test cases to r= un > when building the test suite, which are then reported to the user by > description. >=20 > Signed-off-by: Rebecca Troy > --- > app/test/test_cryptodev.c | 265 +++++++----------- > ...t_cryptodev_security_docsis_test_vectors.h | 159 +++++++++-- > 2 files changed, 241 insertions(+), 183 deletions(-) >=20 >=20 > + > static struct unit_test_suite docsis_proto_testsuite =3D { > .suite_name =3D "Docsis Proto Unit Test Suite", [DC] Outside the specific changes of this patch, but "Docsis" should be all= uppercase in the suite name too - "DOCSIS"... could take this opportunity to fix up this min= or one > .setup =3D docsis_proto_testsuite_setup, > .unit_test_cases =3D { > - TEST_CASE_ST(ut_setup_security, ut_teardown, > - test_DOCSIS_PROTO_all), > + /* Uplink */ > + ADD_UPLINK_TESTCASE(docsis_test_case_1) > + ADD_UPLINK_TESTCASE(docsis_test_case_2) > + ADD_UPLINK_TESTCASE(docsis_test_case_3) > + ADD_UPLINK_TESTCASE(docsis_test_case_4) >=20 > -struct docsis_test_data docsis_test_case_1 =3D { > +const struct docsis_test_data docsis_test_case_1 =3D { > + .test_descr_uplink =3D {"AES-DOCSIS-BPI-128 and CRC Verify (24-byte " > + "frame, Small offset and runt block encryption)"}, > + .test_descr_downlink =3D {"CRC Generate and AES-DOCSIS-BPI-128 > (24-byte " > + "frame, Small offset and runt block encryption)"}, [DC] This one is my fault when I supplied the descriptions, so apologies ab= out this, but all the uplink descriptions should say "decryption" instead of "encrypt= ion" Also I think all the descriptions should say "Uplink" or "Downlink" at the = start. This can be inferred from the order of AES-DOCSIS-BPI and CRC in the descri= ption, but when I ran the test cases, I still had to think are these Uplink or Downlin= k tests. It would be much clearer if it's stated explicitly Regards, David