From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C39EA034F; Wed, 10 Nov 2021 12:23:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A4FA410F2; Wed, 10 Nov 2021 12:23:50 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id EFF40410EF for ; Wed, 10 Nov 2021 12:23:47 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10163"; a="293481195" X-IronPort-AV: E=Sophos;i="5.87,223,1631602800"; d="scan'208";a="293481195" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2021 03:23:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,223,1631602800"; d="scan'208";a="452287851" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 10 Nov 2021 03:23:47 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 10 Nov 2021 03:23:46 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 10 Nov 2021 03:23:46 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 10 Nov 2021 03:23:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CIvsyVW9DWFavvDhp5CIPHp2F5QtgpaCB+yiwEnWxlczqlIX+Ra+bT2O0jQUmrPrDb5h4y/qWtWPlC5+gVRwXpy6BPW2A3F6WOYaA3fQD9KP2QuLgdtst88FXPVs5MtuEE0V7DAK/2x26jGaK2x81QOAVa5/VryPux0/zObOmcO5C73TmeFCBaIex0SUL4AFMwDUsMB7DtUO5FhdGTGb9sHMUgieivqvdPRi7JgL+UffjWmJz44M9v6dUvY2/JQ2i3FRLoWbMNtkndQCMye81RquuSKs5Yzu3JvDsKjjFmCO2Ews5c2AuYWQkz6DW7QD3xHUgGhK6vMGU0U1llJL4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C6u4dKqcSTqRi/bifJ8MPn95g2/i2Ra41qMhFG3w4pk=; b=JcQtUGDiemS2SEU+pMur9aoP5vXlN9W+iq/LiQsk1PmmdJ7q69oHSPar12blgc96Xw93EyZ2MWDUDezwY/D3tYj7Z1u58U0NelKwfUG20uvDttOXRlmp+JH+o5AfNfTSof87oyZJg0ifiSn4Nes4C8N4YI7WmxBMSP0rCooiTtrHdT3F+urpYie9Ag9FQ5MyBs1oB76CBKCYJHNyyA1mRzQy1Ek72VTtCrlK0wfriBfz/3WNOlkbQn+KZGc40Qx+eM6327ZYMCK8fKyXp+tDjqIcd0eTsET/mB/A3YBkGro3qcaNA5pxl5AngABPEBa/HiLxXGr9lIj/bADgkh6/RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C6u4dKqcSTqRi/bifJ8MPn95g2/i2Ra41qMhFG3w4pk=; b=diHrTKZRXNNwLESeNrWaPiKAQf2jGk6dw+umYTqmq+d3LflE9951k+JxOFpqkCa2IGDqTJZ7FhoBPV+4lPsSvfXBhWliYV/hRUf88asP+UPp52OJdSqyW+eTRvS3fNaroRlMrhmDVmNuX1bY6E/SPQ2tbeIo02aQYwCl8knrZf0= Received: from DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) by DM8PR11MB5621.namprd11.prod.outlook.com (2603:10b6:8:38::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.16; Wed, 10 Nov 2021 11:23:45 +0000 Received: from DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::3d47:b590:aa2a:d5cc]) by DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::3d47:b590:aa2a:d5cc%9]) with mapi id 15.20.4669.010; Wed, 10 Nov 2021 11:23:45 +0000 From: "De Lara Guarch, Pablo" To: Anoob Joseph , Akhil Goyal , "Doherty, Declan" , "Zhang, Roy Fan" CC: Jerin Jacob , Archana Muniganti , Tejasree Kondoj , "Hemant Agrawal" , "Nicolau, Radu" , "Power, Ciara" , Gagandeep Singh , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] test/crypto: skip plain text compare for null cipher OOP Thread-Index: AQHX1LQ7s8T+oV2hpE+GJw6qZSj0E6v8nKRg Date: Wed, 10 Nov 2021 11:23:45 +0000 Message-ID: References: <1636384791-157-1-git-send-email-anoobj@marvell.com> In-Reply-To: <1636384791-157-1-git-send-email-anoobj@marvell.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 48c01315-b422-4632-7462-08d9a43c8efc x-ms-traffictypediagnostic: DM8PR11MB5621: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rbINaElaD/YzZLhe/TryE2B4LWuvPWyXYNqO5CzwEBex0OYui0KbQNqcvwdsfpjoER2C9E7SDHdNmY/ZOqpEtQ8+XYjJrKHKJhN7q8NmGYouvQyHultn+K9W0H04GTit6BKqsHjwRYLetwz+Pjn8A9cu3eNQWQaUZGFM2q9TazvWVwUFk37wm8wNEZP27WpJoay3OUB3osDhnCZOvzJS0Y+s+anAxvqqXtRFbL4xvMLRAy7c8MeTSq2GSi8GIFDN7Rgvx4vkRxb36nZz/p2y0vlilSEPo1GIMFytWcOs7v/qHGvXW8kAmvfkHrbQPC0X3DR6zT8wEoKQVY8Qi2vU1y2flbaWeB0CyfhYhybSoXVdPUUjKvPBHXFT+yQCYo452v3H09pKKXQ2Bm/xaSTXer9JZpFGmFxEwCJLH55rWawCzxLvPk9am1bGsID5g6va2Br2L7FeAkRyWmTRn80ehDAzNim5y30TH2GI2lMqJoSLUoX9GfPkpq0XY6wzQEVXD9xK/n4AWZLYkX61IT+JdnmQSC0OqkMkW/WXlrZKsDmSQTsQ0CvRgrxB9PoKAWJe7PSkuxTM4TG+LWEWknF/8MoI2d+Ka/c/qdn4SoKBlbfda39Iy5S0fu9vHpW2Xm+BQZ4iAclvptZ/4CmNrziO/9DVVBTE+jeqJTNPF1d2gaRazZpMSRO/7TEo97qeMMvFjANO6erywMZKlI7AP+i2vg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5591.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(5660300002)(122000001)(53546011)(83380400001)(8936002)(8676002)(26005)(316002)(2906002)(38100700002)(33656002)(508600001)(54906003)(4326008)(7696005)(6636002)(71200400001)(66556008)(86362001)(64756008)(82960400001)(52536014)(66446008)(55236004)(66946007)(66476007)(186003)(76116006)(6506007)(9686003)(38070700005)(55016002)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PJsX1gW1oGCX9GYA9pGLq60ynUaCWlHghGnzLFXmmpdv468yyDx59aBt70dO?= =?us-ascii?Q?1dCVHh+BBv30CeFoVGgFhzUxiXHRKhAsPurbP2p9a+ngh7Fkgd6DoxWSzguU?= =?us-ascii?Q?UVgMMdd7BJQkZb6m+SsYpv3uANYZAO441qE9cNhmh3qfYwmEq0/Qlglm1ltF?= =?us-ascii?Q?qyivbWarezosMsGmIu/m4ddkSqDpSqMtipcdEjATNtyda3ecdX55RfdZ2UA7?= =?us-ascii?Q?xzNHT9Me55/N0S97W5T21qA9NygEos/P7I+rjj4umwDm2cJtt5GP/kJXlFpF?= =?us-ascii?Q?lJuO6QSedvJNbRHE9skjp20o/w0vc1fhI9f0H/SuJJAsU0nEDML4qGJJi/ZX?= =?us-ascii?Q?P4DGMfH+5Pvnc1CgZ1mBQTis9FBMwon/VaahBimShEc8JJ0+WlxFmIeSaD6s?= =?us-ascii?Q?rgdB1f7H46uTlokISZlR+9ivHVRd9QKR/uBZGK1mtmR/wUXn8RRodki+B2fy?= =?us-ascii?Q?Y/+4S/OKe2afOwUcfdZA9wM+zRwR9tDJDxponcavj16bNHZz5e1HjXDJOOyC?= =?us-ascii?Q?s/9DaIdk+OJxEh5vixH3i1eV2E1u9DDzprKZ/5F1WGySeyHiQV5eaWCN2O8J?= =?us-ascii?Q?LgBdTOGvkXXByzipFv0VUGCXqePEYe/61m8/6pzGq99hZhaM6tGfN6o1vl8M?= =?us-ascii?Q?MKAFluzMEgDpi9h1GdtztX9AEBZD8YkZsj/Q7qOrBa15DSqx41pGBBddinh4?= =?us-ascii?Q?UkZ/lmAH9p0Ctm//EvKovor+TNSxAmJlp0RL61glCusnE8wJqJWvM/VNDaFc?= =?us-ascii?Q?+W8c5mvodydYxQqaHJuOvUs/hC7xYSxLpA4uqur88kIT/ZvBffZz+cdHi3Kh?= =?us-ascii?Q?IKy8apimBYgmZjDTmOSidEYlxu+Ud+nB3gWEBFb9ASLrA2E5Wh3MKebOPaTv?= =?us-ascii?Q?qyJ77h0BXOjli0efPW2Q4+OD/CdHOK+H+CyeeYgR7lY1HbzzaHUSxib5G2RV?= =?us-ascii?Q?F3Uu+DPJ4o4wL+mJVgklx/SGZKDQpWSSmou0wRosbzySB88fdGDj8633M4Am?= =?us-ascii?Q?rDyngzQFF6Ls6gAI2qeUla+BoQdRivgYsZgdQgGzpDFKrVf2SEL8zmRUR1MU?= =?us-ascii?Q?0P5DK5NBH08mxBabTKKM+wpN/WujkWA6t0XX6f+JReoNYgcWNKSB/72/v0nX?= =?us-ascii?Q?IFgZDRdr1lafwnvFMHXXIl7zOk9iZf7+xwwq9Br+O2MRunKWn+y9py6Fa8jM?= =?us-ascii?Q?JwJWhh37usJJ8IKkWV8uGka9TsjjT6lfe5s2WkVpRaeEI3gWZS6m3WYO6QDU?= =?us-ascii?Q?8H0L/R5p25hW3ZZVuoPCL399BQmalfdOlmwcGDTQSrc5O04Rip528Qrniy+m?= =?us-ascii?Q?dKhanxy5HtXAqmH4IPhcHP7fXCVpliZ7/cyyALqt8ZfE4iZGWsgaErKHoYnV?= =?us-ascii?Q?rRWoUJ6ON6A0Fj4f3U7SaYPvr8cx5x5o2fiqFdDDp/5sYQ6iwrEb84BQVw2M?= =?us-ascii?Q?7N76ItiK7CNsd3NYMFZWfXcmzdGLpY+shNFYC4EbcJVF4VE/y2NdnoXiCpq0?= =?us-ascii?Q?eZW7MoIYqYNATArVZHQGTCjM+Elllqum5GBrBSpUkA43/1qpQGVK2IbxYAPr?= =?us-ascii?Q?HnVzHj1SF/nl5l0v7W73R2l90nPdisrTbi8Wgm6UH6XGhbZHq6wd3ugCuyK+?= =?us-ascii?Q?JK3V/XWoShmMKbSDBIOphqHHmenpPFT1PEhS/dXGIWrTGgPfafAI+9OIR7vV?= =?us-ascii?Q?YNtTvg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48c01315-b422-4632-7462-08d9a43c8efc X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2021 11:23:45.2443 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m+cTkLPaIgCP0qi9DQiTigEOxh927d3GHpE45+ips/uKP2c5G0Bo6dBEOwuHPqoUBjMo1ajaZT4Qbr23RA/Q82Rm8Ie4zxeFwBczLk9aX5k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5621 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] test/crypto: skip plain text compare for null cipher OOP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anoob, > -----Original Message----- > From: dev On Behalf Of Anoob Joseph > Sent: Monday, November 8, 2021 3:20 PM > To: Akhil Goyal ; Doherty, Declan > ; Zhang, Roy Fan > Cc: Anoob Joseph ; Jerin Jacob ; > Archana Muniganti ; Tejasree Kondoj > ; Hemant Agrawal ; > Nicolau, Radu ; Power, Ciara > ; Gagandeep Singh ; > dev@dpdk.org > Subject: [dpdk-dev] [PATCH] test/crypto: skip plain text compare for null= cipher > OOP >=20 > NULL cipher is used for validating auth only cases. With out of place pro= cessing, > validating plain text should not be done as the PMD is only expected to u= pdate > auth data. >=20 > Signed-off-by: Anoob Joseph > --- > app/test/test_cryptodev.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) >=20 > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index > e54a1a9..964f44f 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -7490,6 +7490,22 @@ test_mixed_auth_cipher(const struct > mixed_cipher_auth_test_data *tdata, > tdata->digest_enc.len); > } >=20 > + /* > + * NULL cipher is used for auth only cases where only authentication > + * is done. With verify operation, MAC would be validated by the PMD. > + * With generate operation, verify MAC generated by the PMD. > + */ > + if (op_mode =3D=3D OUT_OF_PLACE && > + tdata->cipher_algo =3D=3D RTE_CRYPTO_CIPHER_NULL) { Why only checking for OUT_OF_PLACE? As far as cipher algorithm is NULL, only digest should be checked. Also, looking at the code, there is this same check, but with hardcoded tag= length. Could you rearrange the code to have less lines and generic? Something like: if (!verify) check_digest if (cipher_algo !=3D NULL) check_ciphertext/plaintext check op status Also, I think this change is applicable in test_mixed_auth_cipher_sgl. Thanks, Pablo