From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 198A5A034F; Mon, 11 Oct 2021 07:20:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6FD8410DA; Mon, 11 Oct 2021 07:20:26 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id CB95840E0F; Mon, 11 Oct 2021 07:20:25 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10133"; a="213945793" X-IronPort-AV: E=Sophos;i="5.85,363,1624345200"; d="scan'208";a="213945793" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2021 22:20:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,363,1624345200"; d="scan'208";a="441303354" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga003.jf.intel.com with ESMTP; 10 Oct 2021 22:20:24 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sun, 10 Oct 2021 22:20:24 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sun, 10 Oct 2021 22:20:24 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Sun, 10 Oct 2021 22:20:24 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Sun, 10 Oct 2021 22:20:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fg/6nea0INE9JkzItLjdLPypM3OBzAPqikNV/KpxcRfMVkuPT+1XzoewqaoMUE694LvmdHOa+QSNp/RRb4WvQSvdnbSApbW2PM3tNamsu+JbMjWU4Mb8842cGfMKDm5G80Msdx4ji4KQ1lBlJEEFBLyxBXpfCfMBlGUzZ1oPFMJikV7EQVcnfJE25Z/AupiMyR+m/btD+bsAnEzxz55r7mfhZ+oDCyv64g+1jduoA+Kov6zn9kYUIXF+ZMkvaJKpudoZgRyrYztzejK1Uwxw58+TDh6xH3BlS7nhHC1m/q1M2sZi89mwIo8dwGAtftxXKZTx6fGRCYALnglK7Xsz6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y5bgHecj9xlzUFFeuIcYsnPr2MvdKY+6/BjuCktbNEQ=; b=aUK8zYlPDyR6Y8Ff/BOYEMRg+bsQCJTNCMcVXTMJ3011U8vdVFHNoPN06xHrydZXSZN2fN4maedXTcC9jDLK9HEnF2oC99PAJWCc7Ygbp9SgGjKAVAkZL5O9Glr8i/BAe2vQH+KbXc976KGR11z7lx9Uosg2zHBFzwL4ZuZzjeTT65TTspSU72IDOUHAqT8kQuph+VZNy7sQ6ddY98zoAkADoSzS7CKaBTu/+KXpuYHLJCROO7MvDKDLUUsuNP/I73ZuXq91M5w+qmhqEYWaf9p+6DE3yp1h490gpmSKjLQ92ZJbbLAJLIVrShs6S0qmjzoBmVGD4LtsbCksu8zsYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y5bgHecj9xlzUFFeuIcYsnPr2MvdKY+6/BjuCktbNEQ=; b=DqGfOxnLC4y4Ja4EhJCBkdgDThMlHRr8oy5CDY9/YUzkVHYlKsrf8t+7/uWy6Od8rOOZxWvo3MVY30j5Fg5Y0rkdNC05j7dS6tOGT/7u3ooVySXZTBHoCvElrV8Fg3notpEmPX0+6dw/5HaILHRCvELIQH62grmIhSafJseT8yU= Received: from DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) by DM8PR11MB5637.namprd11.prod.outlook.com (2603:10b6:8:33::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Mon, 11 Oct 2021 05:20:22 +0000 Received: from DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::3d47:b590:aa2a:d5cc]) by DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::3d47:b590:aa2a:d5cc%9]) with mapi id 15.20.4587.026; Mon, 11 Oct 2021 05:20:22 +0000 From: "Peng, ZhihongX" To: "dmitry.kozliuk@gmail.com" CC: "dev@dpdk.org" , "stable@dpdk.org" , "olivier.matz@6wind.com" Thread-Topic: [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit Thread-Index: AQHXvBEDWyRtANFDaUWd5Nf4RvsfEavNRqFg Date: Mon, 11 Oct 2021 05:20:22 +0000 Message-ID: References: <20210917021502.502560-2-zhihongx.peng@intel.com> <20211008064131.369133-1-zhihongx.peng@intel.com> In-Reply-To: <20211008064131.369133-1-zhihongx.peng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b370e110-d24a-4593-ae06-08d98c76d349 x-ms-traffictypediagnostic: DM8PR11MB5637: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8EZhAF+cnQGqSfBAjQjuf3uEIhtW72R5cHKtUI0zZyq6m/jgdrvdykAlqKpbeDklw4/YEQis4MbzL57mpWaNtrx4Yzdz9E6BbgKVPWe4OwxrQQp3BDQY+RB1ophB2Goob+4+P7JOUCMdCCfms1/4KuAO5sJhVxtTW6Qfz0QxcClZd0591FPlwuzvgYrQpmbvjqe3m407puzf1Y4/QeCPWJf0y5nTgTkcuQ0HNxnHpMFASysDLz0ghRyEFiSBDPk+4VtrULNzM8mHXaDqQkS+tzniMa/hpEtK6MtxTEwLvD5OMQu2lG0a3jCfCCwf1cm/I4JYSxXkGB58uknGePxWVAMBkKpMS0rByOVfhhC9moqolZdDybQ/2u736Q9HGonbueJ3ElGueQWta7lKOuR8/Soept9EF6LZbvmg6LNSevH5p5wPg2MloGslEI6AAvC7Z/KRcUUXqbSwSbVgfaRwugUOoCEt5vozP34Dq+VZMTD3zA+OFhiIY5otKnN5lJ2DXg4OFnf9CSCrJniQOMUGnlny1ntPuNhlXyaM6kKwnhExVA4CcKFsR42GvvUilOrzVYNpDdzc4Am70cIGLSwq62mfXvwsvOWl8cy1tmxubyeWO+CaryEAaWguvWR4pdGT9V+GH2ecXxpRKnFU+WSw7mLZpjzp0Pv4RLEgE3ioQZUHeoHDJHyy0uEIopX/Veg/IEjJ1Z9aNV2eaLn444i4Lw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5591.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6506007)(53546011)(2906002)(38100700002)(26005)(5660300002)(8936002)(9686003)(186003)(71200400001)(7696005)(122000001)(83380400001)(55016002)(66476007)(316002)(66946007)(76116006)(66556008)(64756008)(33656002)(66446008)(52536014)(8676002)(86362001)(38070700005)(54906003)(4326008)(508600001)(6916009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ggKD/bSuj4CH+cYda/N6yG/Bm3+fgqZS6sjmt7vYt7nIVkPJuRS/88I5HL5i?= =?us-ascii?Q?XFK7lb4ZNVBiSx91gBR2gp7CHbQy51erJED8n6adaQWvD7RHZpGXGIC0jVHF?= =?us-ascii?Q?0GOXrsSEx9LFuaO0NvT4yWczDC0wWS+N4poA8sWD/9SeXsl5aQeDiKZTWIFu?= =?us-ascii?Q?Kz9cdWdyYxR4X1dTHXcEBYbPKOBVtEF7tnnY/abjYCk7YTEK7omVNTFI6X7P?= =?us-ascii?Q?ySf/lgCQDD4v6Ys5Q0BPoxSUxlPo1Q1BaAdMGd0Cp0IwqxTaS0VO8a5aDljY?= =?us-ascii?Q?OfltKHQY9oKeAZXZA6d/AnwCcKoSWs7N55pXAAvl79hGGFPu4TnUC8ewQQ57?= =?us-ascii?Q?GpR53wC8qlp2uFBJSvKHW7SuI2Pcbx9aVxzGL5ei0xbCb3lvXqi4Y0nskWwr?= =?us-ascii?Q?qdDRUUm0eOWI1gBoNnNGO0JysFSNV7EOX7A2Gekh7Tiz73Qihh25HmffyN8h?= =?us-ascii?Q?K/9S5jU/9Os5uSr5Ln1ActW6pVzypimeAu1iX6B6lt1UyxEn6oQoYwmX+fPR?= =?us-ascii?Q?PR0fAEO55N5HSpUbBM1+nG86g+89qE0FFt7dzbW39Ta1gh2nqckFB8b2lHtv?= =?us-ascii?Q?oQaW10eY7ZybQ9Jcte4HZhhz3ogTa2qApF/vhakBeKXgcXyZh47ovwkN2o2Y?= =?us-ascii?Q?xlAhABVsGp1K/FFltcXOV33Yfs8BmXM9OZdhNtOHIW78Ykm0vld6wGUQn3kD?= =?us-ascii?Q?Quzqyx8WziKCaeNiUQZMAU6wL9xnfFsEscjjztUBO/sdld1fouSR/tW5mMjv?= =?us-ascii?Q?2BiCRKbnIfg+9Ms/S1sIk1hiseSTh4h3bPslVGeZblmhEA9zeAvF5su20mIa?= =?us-ascii?Q?zFXnLow2zmZLOWCsSSHgnymL5tZ2tgzOk7mKXL7Bw9u3sDtOBnXjJVQjO/dF?= =?us-ascii?Q?q9xRT3FyuvNyfnrolL7AvLkdXLKlyhaVjBSOsRP2PsRDce39iMc8E9aA4dCq?= =?us-ascii?Q?FlP6gjEn6MnvNj4LfRHmVsN0OEBcbbml7kpIGHqMpIMPtoezqF/U/HqTJHIZ?= =?us-ascii?Q?TSX1wRmLNJUiBwcIIDsjAEY7PureG28+htlBw2P9jTvi7v4yFYEBlAFLhwRi?= =?us-ascii?Q?Ua/yLFf9dK2DgkuFuW/TuU6g6az7jFaVjLaAxg1+YoXKN/yfMHJxENi0Sfty?= =?us-ascii?Q?SJKXKJLK69xDwmRm1wfFdXpQfh/kkv2cqkz9QWB8kErCfZD0f9F3gtmgddni?= =?us-ascii?Q?b/6lGlrU7MUeWa1pF0e0Imclb4aGbspR6aX8WGig0vyfdeE8xYF++VGsPhkS?= =?us-ascii?Q?b7JpJ07GbQb8uEqh6c9bTTxhty+xY5cnV+hXYLjfBpC9yvTvlXYDSEYgvrJW?= =?us-ascii?Q?KcI=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b370e110-d24a-4593-ae06-08d98c76d349 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2021 05:20:22.7192 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4L1dOE+m5V3R3hMtRQL/RCgc1Fxg/MsUQzgRKoOAi3Imq/GDeotsVXe7nojTI6ZBmO2LvIuJcgx1DCZj9xHj1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5637 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Peng, ZhihongX > Sent: Friday, October 8, 2021 2:42 PM > To: olivier.matz@6wind.com; dmitry.kozliuk@gmail.com > Cc: dev@dpdk.org; Peng, ZhihongX ; > stable@dpdk.org > Subject: [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit >=20 > From: Zhihong Peng >=20 > Malloc cl in the cmdline_stdin_new function, so release in the > cmdline_stdin_exit function is logical, so that cl will not be released a= lone. >=20 > Fixes: af75078fece3 (first public release) > Cc: stable@dpdk.org >=20 > Signed-off-by: Zhihong Peng > --- > doc/guides/rel_notes/release_21_11.rst | 5 +++++ > lib/cmdline/cmdline_socket.c | 1 + > 2 files changed, 6 insertions(+) >=20 > diff --git a/doc/guides/rel_notes/release_21_11.rst > b/doc/guides/rel_notes/release_21_11.rst > index efeffe37a0..be24925d16 100644 > --- a/doc/guides/rel_notes/release_21_11.rst > +++ b/doc/guides/rel_notes/release_21_11.rst > @@ -191,6 +191,11 @@ API Changes > the crypto/security operation. This field will be used to communicate > events such as soft expiry with IPsec in lookaside mode. >=20 > +* cmdline: The API cmdline_stdin_exit has added cmdline_free function. > + Malloc cl in the cmdline_stdin_new function, so release in the > + cmdline_stdin_exit function is logical. The application code > + that calls cmdline_free needs to be deleted. > + >=20 > ABI Changes > ----------- > diff --git a/lib/cmdline/cmdline_socket.c b/lib/cmdline/cmdline_socket.c > index 998e8ade25..ebd5343754 100644 > --- a/lib/cmdline/cmdline_socket.c > +++ b/lib/cmdline/cmdline_socket.c > @@ -53,4 +53,5 @@ cmdline_stdin_exit(struct cmdline *cl) > return; >=20 > terminal_restore(cl); > + cmdline_free(cl); > } > -- > 2.25.1 Hi, kozliuk Can you give me an ack, I have submitted v3, I have added the release notes= .