From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C90EA0510; Sun, 8 May 2022 16:39:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09DC14068F; Sun, 8 May 2022 16:39:46 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 3083B40395 for ; Sun, 8 May 2022 16:39:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652020784; x=1683556784; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=TLGEyna9mDmjIUiwKRHp6XIpw+gMz76z00uycY+XBiM=; b=LZbmO2NtcMzoxLudstRKwwkpFv0S53ZnKj/KwRGJdOe1ffSZzo8WNj+a Qc74nJG/XIsaTI9/ZBrSbrMB5bRZE9TnALpAY2JGH7e5eQ+paOjyA0G/Y FKVHWUPdhNM0AEmS4ixXUwPa2+k0M2+Tgv67WnZ6axia6OyoOxghKw8rl zoLKwE+sRXP3p2Fvj56jzaxOHAv17HxbIM4DC3nRNZHqkX6sV9V7VAdiZ Soml3BEXxUeN4aI8qxvToRJOkzH21YObTg2g8GN6dxRiHF5yrsb5P/xaX n2w4cp6o09u1tWPRNGspLlcKlOx6z8abJ3eZkePhfmvwtB1FRL1qcSIWw w==; X-IronPort-AV: E=McAfee;i="6400,9594,10341"; a="268985797" X-IronPort-AV: E=Sophos;i="5.91,208,1647327600"; d="scan'208";a="268985797" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2022 07:39:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,208,1647327600"; d="scan'208";a="590727145" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga008.jf.intel.com with ESMTP; 08 May 2022 07:39:42 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 8 May 2022 07:39:42 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 8 May 2022 07:39:42 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 8 May 2022 07:39:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a8tsyQfKOAAT75JunIHIsfzlMVf+JPgjW9nlrzxPWY1ApeuUFwtsPEkK01s0goW2AeqqLeryEBBBZq9nIB+cQSEFplSsuIOY0I5tmYt996n2mBj4ZVzqYvLLryUWHKGWLiZkxStjAIT4w6B7BqY/s7sDMif9jdYBjAEYxukx6f65qzR+R4TmiZxUA7zrHaksr9JolvN15O35HqPtwYxFRhOsNcsWZz81q2r8wQoHXLvxs7Ex7WE+0DdxjJ8KNAhQ+tFl3JZARdgh/+0YGNbTKMJU8eE6LBVz097PlNNL3Cm7769uEhvcAnEscg/D0pNt2pA+B42SqUmKqJg+NA3f1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZGjENOuOEGEEVwzKKu4+TSJtEGyCY48yVBc6U6RFe44=; b=Ia1IT+9eWZBFxj6zuG7Hj2HezIAylAW6vsqgL1FiUS5QRdo8Y+L++K+C3mnufFRGnguzYVZagEBr6bHE3DDNTiX6/VEhpTSLeheB7bx061rNUpxE2QrxsWuI/KjXi+DOtrWWJuxA3XddN/5oWDFXqXT8yjzmCtK0xbsAvI+EnSRh7IrdnnVTVkGcn2l8X0zh4qu4PSXAwYbdIvTJUjVikmLSaqbGeVm61ufaIK9dScpEvu35SNG3M4mhpF9U5Nco+5Tsnd5RZkOl6aEVbPsfC0VHvZAdDUNNBTmnUslveLbbS+R+oU/4KUzUfQ5Y0L2Kidfqo2Q5FpF+200k1j1qzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) by DM6PR11MB4281.namprd11.prod.outlook.com (2603:10b6:5:204::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Sun, 8 May 2022 14:39:35 +0000 Received: from DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::b4e5:eb4b:e2f0:ed0c]) by DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::b4e5:eb4b:e2f0:ed0c%6]) with mapi id 15.20.5227.023; Sun, 8 May 2022 14:39:35 +0000 From: "De Lara Guarch, Pablo" To: "Power, Ciara" , "dev@dpdk.org" CC: "Zhang, Roy Fan" , "Ji, Kai" Subject: RE: [PATCH 1/3] crypto/ipsec_mb: add GCM sgl support to aesni_mb Thread-Topic: [PATCH 1/3] crypto/ipsec_mb: add GCM sgl support to aesni_mb Thread-Index: AQHYSmqeIz43HtliYUqBhrV2KxynPq0VOn2Q Date: Sun, 8 May 2022 14:39:35 +0000 Message-ID: References: <20220407103041.4037942-1-ciara.power@intel.com> <20220407103041.4037942-2-ciara.power@intel.com> In-Reply-To: <20220407103041.4037942-2-ciara.power@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7f6a0c4a-3160-4611-faba-08da3100926f x-ms-traffictypediagnostic: DM6PR11MB4281:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kY7Wmhod65bBcYIC7LpJ3kcCf5WSxv764q6hnywRMauPV+aiNSw03sRgq0f9R4eobbu2Gl0otEdt3HhqhTjqZBOxuqnkAdj/9BwptDCTUKHWH3Q4RocYIwPdZTJJsTOURBmOLGOXun4kbm2QHufjNGDC27v74+25h6hAegyag/Sy2z13c5WfJHTU43/sBWOE7auB2zAhTEYtAaGMSZ1dyUYBSJAp+rfqtjG8crr9xVKMimaMkWeG0dr7y+a16uT5aFIdN4qe9tyvvuH92yYbqiIwC/oX+NYcy8eLf2wEVgmG0FO38iw5036b5V/6vWArX9H05o9mIXMfaVUq2pOR+tMV2p4JYsvNfgW5yipWmTtAg7R89VN32pcyrw33QS8M+RVLEJoL2EgFRZExz0PgyCBFM5Mam0IKr3eT+r8HeTgufS+X1On5cTC1CDlcJV4Eb+6qPuN6FSlCgF7jDdPbaRBXyy82325k+sucguht9uZoEDwcMuCwUL/ujV8BMlLz8Q/+KjDkk+tN+uGMwF8jUor3YF9hzVEsvd8ZpiIDkA5DMpvdC09QesT+lshC1WjlAW8kgsVhtIQ4kis3DxNCPdcRvWpnTryihfk7pvikrSSUwx61EP9hElzb0m8MK0G+6qTDFpaHnOf9eDz1rkEHN+bRY3HJ2zMl+Iy7Z8pm+hlAGIyQWXQVzd/3R+gHAMyGclTv83RHjJGMjzI92ytGQw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5591.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(83380400001)(26005)(9686003)(53546011)(7696005)(6506007)(122000001)(71200400001)(5660300002)(66556008)(33656002)(107886003)(186003)(2906002)(8936002)(508600001)(52536014)(38070700005)(38100700002)(76116006)(82960400001)(55016003)(316002)(66476007)(66946007)(66446008)(64756008)(8676002)(4326008)(86362001)(54906003)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kWFnp13x8Bdb7yYGd92+Rcw6Hxpoi506hNu2lZNEzyQVgl0uKUwEYBJh4nVX?= =?us-ascii?Q?VmUZ+jnNIzeeeQvFF6S5IwDKnlTXMocjkUF5BeuqWpcpY5AzUW/rrFQdAfIx?= =?us-ascii?Q?Z9v+czR93tJtx8aor4APlcES6JA+aqZoTfCWsOi2UoAQS+9OFI1e4nfvhqU8?= =?us-ascii?Q?5+kvLu7bU+vMEdzVU2F2YckroQsNgjy5xewU2jKO1MsUYVsvne95wrCyGGD/?= =?us-ascii?Q?m3R2P2qP2OsKuchyc/LIiPeb1yAPUupx6wRvjqQcT08zYjrWvcOn/s7kpnFW?= =?us-ascii?Q?jVojA+OO+2zgCz+uzYAPhaft3dcgMiZisBI+k7hULvfTsESdvRCu5MykMAIU?= =?us-ascii?Q?v2mho9LIAMm6QkpQt3deUgM3T47AVyBsILgDFVLV/65amxHvFTYw3VFKgL1W?= =?us-ascii?Q?La9158Bd+OqxWVSWrDejaBe4x2/3RpcaPxoaEXbZlksOjJAlw20BeMTIo0fD?= =?us-ascii?Q?qoIqH59XM3hCtTEIm2J2mqymobpOjGUpXyMo5bSnkZe2UXBKTdzKC4EvHI2Z?= =?us-ascii?Q?iB7LSSg8WLNQmjtySbfX9wCgxMuW5NusH4VD20ZJEsHs4Mlo75cKvgLV+4Rh?= =?us-ascii?Q?wqfeGAKDumaryvQre9EZQuCDELBBcxlJeOTCgfMmvTZCvlPgdP7l0m7Pb0//?= =?us-ascii?Q?VLoxpx/oUu6VktRsuqySLnwQ+zOl97b7Adj6rJWnI/PKEZQCHuly8duZEFH+?= =?us-ascii?Q?k/Y2yBVxCNJd3Cwz9STW2EW7Xqrm+d7evsBqRTl5lApZEuchS8djS4b9cWS+?= =?us-ascii?Q?cNFzSQL52jQ9Yj06ykZJDjp++DEtRl/jGJK7ETQOVJMaIOe0t5UyYSvlnC7E?= =?us-ascii?Q?ZMYlywEmRRRR6teJyZz9jVHaPd0UVACdiRLCntfNYMBi04bQ8sPbJmd321mf?= =?us-ascii?Q?nW8NVT8kqtmEduWrMTItSHjMvm/w3leidWtVxrdlg5FZLx2lLlQsMz/4jSx3?= =?us-ascii?Q?Znbbt5z47P6rQ8RI9SbTRxjiF8k1ZhWw5oD2VJCmWW9dHbub+FnOShBdE6bg?= =?us-ascii?Q?DWkfBo96lKexRf+o2e9TSHITtbyQ0M+0JEkGCo7mo9rxx3ePO0KL/FFhqZe4?= =?us-ascii?Q?qxDk+bw3H2gvI2v4wJ+2LRZWki8Lb8yrA3c5ajC+/F6/JE0qgSDJ0JOBvkEd?= =?us-ascii?Q?ViiJ1KGUZegkmZeUuJDuxrOkOOc1LJ2JITvMAxqB2dlJ3gKtGhft7cuSVv8B?= =?us-ascii?Q?Ne7Oci2/fjq0aRyoi0sW1Qj/vncNQSjhaZSmgarTGNUPSd/oIEbVrFqcLGmG?= =?us-ascii?Q?HQ87/A7kmzei0el13nt7XGwQV0Kqox/1HG3TNB0aDhRvxVUYCwzNiP5Krw5F?= =?us-ascii?Q?hbURcFpGGmCLGKDeY2U5WwN8R2dEyTmZmkWqb0WA+bPkjZndw5Vdwf9/w/mJ?= =?us-ascii?Q?X9ZC2yVohrw/JMh+qmB8wgXLlO7Gck3P8PSed74fTe5TbgXkf0vhUcfQAWe+?= =?us-ascii?Q?Cx+lqbH/Q25FOVXc2DjMBVwr6f9slEdf5yaucsDdk9daoLPWNzSv0ZdywuKK?= =?us-ascii?Q?lWd1kaoNVFjrqgLqqVX6O2tBmCO6lk30ZIjkkpk2z8DlNmXasSeWpUFbTH0A?= =?us-ascii?Q?dLD8LDDczfQ8V4S1jHhX9xfITI6wb3Bja9rizbs5R1yT7mq1DpgDtMv3a4Qt?= =?us-ascii?Q?E6ZdvIOZtl/BEIIIl4RDpihmMJIzxMIdkhuitAG2vHaq2I0SdTdelKgD6Qla?= =?us-ascii?Q?DSDV9A25mTed8XfbM4JAemtrLhhlDdckBGxgnB9nOlTGOkcy3tTZcVVWVZUo?= =?us-ascii?Q?AIMR6QOjcDWCEwT/GN9xo2iZ0Huc2hk=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f6a0c4a-3160-4611-faba-08da3100926f X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2022 14:39:35.2607 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fzyTBcl9ebw6ydCj9yPylB3hJ3wLHXyVHVVzwlDFulMw+mBEWZP3n+uVKewh09HAxDwM4L5whFS0cio7r1CKUhMqRG14EJngENx7ui3qklQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4281 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ciara, > -----Original Message----- > From: Power, Ciara > Sent: Thursday, April 7, 2022 11:31 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Ji, Kai ; > Power, Ciara ; De Lara Guarch, Pablo > > Subject: [PATCH 1/3] crypto/ipsec_mb: add GCM sgl support to aesni_mb >=20 > Add SGL support for GCM algorithm through JOB API. >=20 > This change supports IN-PLACE SGL, OOP SGL IN and LB OUT, and OOP SGL IN > and SGL OUT. >=20 > Feature flags are not added, as the PMD does not yet support SGL for all = other > algorithms. >=20 > Signed-off-by: Ciara Power > --- > drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 144 +++++++++++++++++++- > drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h | 2 + > 2 files changed, 142 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c > b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c > index afa0b6e3a4..09a0cc5ace 100644 > --- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c > +++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c ... > @@ -1410,6 +1509,43 @@ set_mb_job_params(IMB_JOB *job, struct > ipsec_mb_qp *qp, > /* Set user data to be crypto operation data struct */ > job->user_data =3D op; >=20 > + if (sgl && aead) { I'd say you don't need to check for aead here, right? The only way to reach this point is if cipher.mode is GCM or CHACHA_POLY, which guarantees that aead =3D 1 always. Is this correct? > + base_job =3D *job; I don't see sgl_state =3D IMB_SGL_INIT being set. I think the code here is relying that this will be set to IMB_SGL_INIT by d= efault, but it is risky to assume that, so better to set it. > + job =3D IMB_SUBMIT_JOB(mb_mgr); > + total_len =3D op->sym->aead.data.length; > + > + src_sgl.m =3D m_src; > + src_sgl.offset =3D m_offset; > + ... >--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h > +++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb_priv.h > @@ -946,6 +946,8 @@ struct aesni_mb_session { > struct { > /* * AAD data length */ > uint16_t aad_len; > + > + struct gcm_context_data gcm_sgl_ctx; I don't think it's necessary to have this context data in here, you can declare it inside set_mb_job_params, unless this causes a performance drop. Thanks, Pablo > } aead; > } __rte_cache_aligned; >=20 > -- > 2.25.1