From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68B5FA0C4D; Wed, 13 Oct 2021 05:12:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F00B840150; Wed, 13 Oct 2021 05:12:22 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 9479140142; Wed, 13 Oct 2021 05:12:20 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="207449493" X-IronPort-AV: E=Sophos;i="5.85,369,1624345200"; d="scan'208";a="207449493" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2021 20:12:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,369,1624345200"; d="scan'208";a="486720719" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 12 Oct 2021 20:12:19 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 12 Oct 2021 20:12:19 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 12 Oct 2021 20:12:18 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 12 Oct 2021 20:12:18 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 12 Oct 2021 20:12:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fL/UYpj7wNUDbKynKGq2O67BnOXdCyU8XuL1Hv75hjp9yHsLqL1V8qHve4lIkjm5md6dqpLHv4C7q3S3fu5JUKIK6Rmy4rAzl0r8dwIj07KUHsDQJ+Nsa9fG3E6Kxc0ov1srPJ8QT8T5JEXTJxbgT6k57GWrYmJq4PY+89Iz6sTHzOr3YqSQXeWe9x0irmzITEEJCiPnwjRIuwS4P9rYoDjISENQJ2mZ6vPVAWbxSmeEO6v0Vc7dDMYpf3RNGuEFoLoxyGr/UJTkEucf9uJVxaqmqWyZjT1hi6RCFk4z1VDnj/W6KNgyjbIsC2zCovxpeY0XzICc7Ik/hNU2nLm78g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pTkkQYHu+MC+G/hO9iZXDzdnvJ3YRqeBNM2woyLImbU=; b=ULjJW9/iSXsm54obTmyOn4F8xcQMBM17M8WGSTW/ClqMakfxvzNXjUmfDP2HpzFG37lTIILRvzFSlyHlh3oqLs0FtE3eqgP0W1hefUwXiXJ7+NiizmldvTp/IH7wtQJpBFX9m8jiMWHAIwX6LjV9Pcb4S1qIxcWh1V44bUrWN9QSO3TxJsqPjG7vBKI45RkdLEevfNsfFSEFSJYI3Ip6FcT53A5htDpU/kjzOJhtdtS6sg+TM+5rBQtqEI3gLHZWWUtXLUItSeZoR0hLJChCAg38HjhIkfud0Rb9LHQ2xdncuaKrdsS3h72rn7ORoDygJxJEn/DaJ6wGBk6pm9Dakg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pTkkQYHu+MC+G/hO9iZXDzdnvJ3YRqeBNM2woyLImbU=; b=MxQxobjd88lru/6drZX4yxZC48erf1V3OwMe3Uin8fKKK3NFjimAdLmyJKeOk+hZah/YhfZeQ6EUwCbEcnqnQU7q2sby2oP5Hjnisq1WzK22MBCPwEqf6nk9ApQ9zZRa69nZDR6ydsIN7vhs0O5OX3cptkvcNaIA/ltEi1pPKyc= Received: from DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) by DM8PR11MB5671.namprd11.prod.outlook.com (2603:10b6:8:3c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Wed, 13 Oct 2021 03:12:16 +0000 Received: from DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::3d47:b590:aa2a:d5cc]) by DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::3d47:b590:aa2a:d5cc%9]) with mapi id 15.20.4587.026; Wed, 13 Oct 2021 03:12:16 +0000 From: "Peng, ZhihongX" To: Dmitry Kozlyuk CC: "olivier.matz@6wind.com" , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit Thread-Index: AQHXvBEDWyRtANFDaUWd5Nf4RvsfEavNexkAgAK1jsCAAA1mgIAACLIQ Date: Wed, 13 Oct 2021 03:12:16 +0000 Message-ID: References: <20210917021502.502560-2-zhihongx.peng@intel.com> <20211008064131.369133-1-zhihongx.peng@intel.com> <20211011112558.21c68bfa@sovereign> <20211013053615.1ae63b13@sovereign> In-Reply-To: <20211013053615.1ae63b13@sovereign> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bbbe92ef-2cd0-4aff-ead7-08d98df742ee x-ms-traffictypediagnostic: DM8PR11MB5671: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7Ez4kPRBRpdV1iQCvE0fxzEvlEFexST6ithI34voLpO8EgkfMSRqjZ7ABXioF3yUReHragUv4f8EQb8dsAnYP5WiDHEFf6MAT+h+K8YUJXTGELBVy0tOVXP10BJBjWlQGHKv3YJVuKc2fEV7aZaEylsV2ld3Nie2+H4P5wh8DmOJpnjcCyA/V9vvAC6pI/Lv+Z3StR649/ko73z1L9WDCMWXfZdPS3oXJF+dx4623kHNBzeWQ5OT/d9Kbctms0ATgxCdFrZZ+NvTKwpIAmrm8fJVrnqvZGQ3BIfPETNYkt5X4G4/MGbjtvFfUjnnpAwxdpvI/utcLSTEa/13J5tXbw+ki5zRze5DlxMDk5AUTPtZh+3KpG80rhNjyX/j98S/HrvRCVnRq9e8R2SImMpHBD0zYiZ1piqBQW1h0tWNPIOIvorrd6JYIeuAvnuyRjI5LB9LIwXt+l+nZtMJe1xwQ2pSxo//pld/YpXS/sRi6b/WJv079sf336t9vdrTBkhNmbjyPdf+7GC26Byfj2jyfDJGadRtwhEIWbL+K8+EUDuvbvMb1wAm39j/85lnvV8FOrxbTaEJcKxN60STsVqztzEX1ET7gbawm43pkDLs3DaH+y0/yTVxWuFaihzbwzS75Dl0c6DymOKZEd2UqTm9B1w9ecVqGTZQJDFET8+OlzqbPyu5p8SSTfQNAR9NS6xLyPmpElQ7of7Z77bBqzUcoA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5591.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(4001150100001)(5660300002)(82960400001)(38070700005)(54906003)(33656002)(2906002)(316002)(83380400001)(6916009)(52536014)(66556008)(66446008)(9686003)(7696005)(64756008)(66476007)(38100700002)(8936002)(55016002)(71200400001)(4326008)(86362001)(26005)(186003)(122000001)(53546011)(66946007)(8676002)(6506007)(76116006)(508600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dk8mJueKywjdRsy2RQv+6WFGFK1j7y5FiwdIWM/IZmbwJc+R0Y+5KHI3ZUWB?= =?us-ascii?Q?rjMwBFCE+fMeTfvQI3zVgHoqvZ34tNFlINzLHjrvC3QSMx9tR+SrpwFqIJTa?= =?us-ascii?Q?u8Tgc/btBEiUY8sJQmGId83kPf6WSs3yFC8foQmwkF6WHXXztf2G47nFUskm?= =?us-ascii?Q?i8BnkK3coORL1yc/o98SfuHVN7SxxFRSZYdnSZWzagHt7UcpC/M+A8yKkLYi?= =?us-ascii?Q?Zh7fqkwQ6FZUeOHveeemiWiRA18TLhzKYHiTqt1GKBznGQ2SoerYSLb8rYJ0?= =?us-ascii?Q?dWxPirfcUnmKxbYQGJ/ErK1rOisfgqmpsuGHpNPb3JpvpLmWsa3rdtrsBfRO?= =?us-ascii?Q?pqb437g7I0SSuAEH0wupKMixC4AUqNAKrl82A+VkTQw4L3fcBp1OcoCqs1yC?= =?us-ascii?Q?z+76ieX8IflsGb9rndku1Wedd4cNLRjxiaC6F4lJmjK+ENmHEJfWlRDILSeK?= =?us-ascii?Q?X/f3IQeyMXb+irr5Su8k8loYmVNKW604frVr8XQQgzPwySSKnz7pN+4DJnv7?= =?us-ascii?Q?Ft1hoNChsmp3xVrmqUZ3pH3/c8FgZForlX0nt2gYtHEpkuI5eolGhS6JVPgO?= =?us-ascii?Q?ggB0KZ9CQOswFWuh/bLOO0cAa0buLP85lSsgJYtL1no7OB6SnT4zLyfXsswB?= =?us-ascii?Q?uG1FuFXAHpRhZ0EEE6eBuVkN+9pFsrOKBwVfBKDVbWjD3Ko7YvPWPizJ7tco?= =?us-ascii?Q?WrqeBMfxgapI9fgoDUNWIXsyUNQLz05Sf0Y3NW0lDwBP/Pi77dTdNcdrlgpz?= =?us-ascii?Q?Skxb26bdqNY8ix/W3c7BxKfmi7lZ03rQXrDK1O5z1KSA9bria8/jUsl8/mLK?= =?us-ascii?Q?kCZWJ5wVCDZLU7wDBd2/Vj4JTo9oY3On/lo1FvMLpfeop5xqM1RQ3Bkb0Lpk?= =?us-ascii?Q?729CQW6aa7N9qsfy07Xnm5qe/IMAI2OgFIm7+RUAhCugRE/KHz3bUnQ6XKj/?= =?us-ascii?Q?gH6vFFangp/tL1DNb2w2jUU6T0Q+grSqxrqllmkrkyBXsjz401gUb5UZ9fFb?= =?us-ascii?Q?qsYrXkKXv2E0cReUeenUdFLMtE0DcHeSKd5MuqRiMlX8Nh8UO2HQfwb7zFGq?= =?us-ascii?Q?c0Zp/L3olVN08VqqnrckeUzzwLBVOn22P/QYK+EsD6d/AFJcbJ6R9VJmdUpj?= =?us-ascii?Q?LFGoxG5CFi+4Ebc3ATKXkYHSA29augruSWTstLmeH1Dcs9mNnZB+PnGu/lOf?= =?us-ascii?Q?MTKNyYjbsIzrkrxbtrLXHPxjk33C6ZEPkefKCQa9G0x2NFqlVeXtUHGso3Dq?= =?us-ascii?Q?IZBR+XpbyZcusb7svtMbkKnGCj/yIR2oINCG1dLd5oDSrd/dT0P64bKKTR/7?= =?us-ascii?Q?c4I=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbbe92ef-2cd0-4aff-ead7-08d98df742ee X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2021 03:12:16.8311 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dtZHOJ/kO90vJprb4/O/GAlGtqiqnOFxVlIZVvWIWC8dz4PrsXJZcjgUhB3mwZFDRkpNbERmQT/8P1X7E8hrAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5671 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Wednesday, October 13, 2021 10:36 AM > To: Peng, ZhihongX > Cc: olivier.matz@6wind.com; dev@dpdk.org; stable@dpdk.org > Subject: Re: [PATCH v3 1/2] lib/cmdline: release cl when cmdline exit >=20 > 2021-10-13 01:53 (UTC+0000), Peng, ZhihongX: > > > -----Original Message----- > > > From: Dmitry Kozlyuk > > > Sent: Monday, October 11, 2021 4:26 PM > > > To: Peng, ZhihongX > > > Cc: olivier.matz@6wind.com; dev@dpdk.org; stable@dpdk.org > > > Subject: Re: [PATCH v3 1/2] lib/cmdline: release cl when cmdline > > > exit > > > > > > 2021-10-08 06:41 (UTC+0000), zhihongx.peng@intel.com: > > > > From: Zhihong Peng > > > > > > > > Malloc cl in the cmdline_stdin_new function, so release in the > > > > cmdline_stdin_exit function is logical, so that cl will not be > > > > released alone. > > > > > > > > Fixes: af75078fece3 (first public release) > > > > Cc: stable@dpdk.org > > > > > > As I have explained before, backporting this will introduce a > > > double-free bug in user apps unless their code are fixed, so it must = not > be done. > > > > The release notes have stated that this is the only thing we can do, > > and this unreasonable design should be resolved as soon as possible. > > And the user apps change is very small. >=20 > Stable release means stable ABI, which means that a compiled binary can u= se > the next minor version of DPDK without recompilation. No code change is > possible in this scenario. If the behavior changes such that cmdline_exit= () + > cmdline_free() worked before and now cmdline_free() cause double-free, > this is an ABI breakage. Simply put, DPDK .so are replaced, the app resta= rts > and crashes. Users can do nothing about that. >=20 > Release notes are for developers updating their application code for the = next > DPDK version. I may not understand what you mean. I want to know whether this code can be merged, and if it can be merged, what work do I need to do.