From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF6D742DD8; Wed, 5 Jul 2023 14:42:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6ED62406B5; Wed, 5 Jul 2023 14:42:41 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 3BB694021F for ; Wed, 5 Jul 2023 14:42:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688560960; x=1720096960; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jSFPlnJQh5jZymKUguroQ0NK4Aoup3HmMPeP4Jwmd7g=; b=mJ1qjB4maD7ji7kNtE7dU0MltH1H3kK7ZKQfr9dmyS5yGDILiA2CDdjn vXWgb4HV49Ch6B3gUtDZXWxL19O6ijY6hK3z3kPFY/MinZvTagT53uQQj UVozICiTOsgzSHw/T3jKSBYxkw9m/+BL1E8oqmC5C8FSuSlVomXK48NvC gr8L3VrAPuTREdNTko5YIb0bAINv7WS8mzvyKD8zgTM09hJNhff3tsvbU xp28R7xlnNLVtu6HhKczK00Pz+IjsOdGLe0ssfO6BVn9F1bPbidHw4mrY RqP+OcriEeXIrfpxlf/z5lufXU/vda7MFQQeF2DVnsfXD8A+jlXl3gFm9 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10761"; a="353159171" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="353159171" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2023 05:42:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10761"; a="669394661" X-IronPort-AV: E=Sophos;i="6.01,183,1684825200"; d="scan'208";a="669394661" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 05 Jul 2023 05:42:38 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 5 Jul 2023 05:42:38 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 5 Jul 2023 05:42:38 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 5 Jul 2023 05:42:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hhb4t3vMTpKIgPaeR3ZHa8X67NH+l7hraI6308Dn/pBznUA5QDk9l+3bwoJCPiV+/+CNd1PgHtZ6qFjgKd9+mBaF5/ukCxPwFz4QSygGX5jd2UsStDf9M45kYyYdBqTbjA9EH+R0+jd26tHNUiRLrnZCDRoQCbum2qTLR6RHCdLM/aBqCusWP104VTSYQV+DySNL02pPTfNVl+QAtBtddHzJxOBPBm67Cr+tZJtr5OvXB11NLpK7NZJvfcJJGRcgBv4SRTolllyESQeyNTmYoQe0Q7dnhmBv25AgV/EAM40WrV8gq2qzYZovX4RP4Iaaw1x2MVhZsv7QGG/7ILm5RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jSFPlnJQh5jZymKUguroQ0NK4Aoup3HmMPeP4Jwmd7g=; b=UdVrSEme2R7s1Lzj048gl1k91h5H3CMyppUGBG9Ia8iCs1FYakvYLnjXPqlpm+sjbEy8H8/SU9yPxwXjRBtNEosV+AoIEIfn4xcabz7hM+uFex4vR8c/Of5OvQf7XfHnHv2LjD4ahCwM/SyLAGRPnR+6GZcbV0EQ4ZvxWpGyEgvCbJZhGHWTdRsxVJ9BihfcHD5q4MZq+BrtXx4IQVUYbkZNGDZGJ9t6lmjCWX+z5dESo5ms2pJkiZptRGeWI/cwNwuNW3//PAyXU5O/SHcKzlJSQkl7csgsr0dpl1eqkrpyA+dqFg3xRjgREIkhcQtO/KwkcDUL4+etUu7kq3EbLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) by CY5PR11MB6188.namprd11.prod.outlook.com (2603:10b6:930:24::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17; Wed, 5 Jul 2023 12:42:35 +0000 Received: from DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::9bfe:f2ec:37ee:f29b]) by DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::9bfe:f2ec:37ee:f29b%7]) with mapi id 15.20.6565.016; Wed, 5 Jul 2023 12:42:35 +0000 From: "De Lara Guarch, Pablo" To: "Power, Ciara" , "dev@dpdk.org" CC: "gakhil@marvell.com" , "Cornu, Marcel D" , "Ji, Kai" Subject: RE: [PATCH v2] crypto/ipsec_mb: fix jobs array used for burst Thread-Topic: [PATCH v2] crypto/ipsec_mb: fix jobs array used for burst Thread-Index: AQHZrysLScBwEdIb9ke+5o6+ZaYpSq+rHeng Date: Wed, 5 Jul 2023 12:42:35 +0000 Message-ID: References: <20230705101521.1126253-1-ciara.power@intel.com> <20230705102530.1127021-1-ciara.power@intel.com> In-Reply-To: <20230705102530.1127021-1-ciara.power@intel.com> Accept-Language: en-US, en-IE, en-GB Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5591:EE_|CY5PR11MB6188:EE_ x-ms-office365-filtering-correlation-id: 4fae34ff-09ed-4303-40cb-08db7d554ef3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dfKDQLRielMRFxM6OHrTPusQ5sr4ok3b0jx5xuTN22acLuwu1o0qiUL+i9zGiNhDJ90GEj88Phxaf92oSU3uSWbj9zHiZ0kfyCusctPufCvWdwvsM1JjMBrbCdmOwJuOhHmvg1G3uowo8Toa7Grw5G3kC7mpDDDXSnS1jc7D7+0Foac0qNnMSGcPhZlA6pbPRI9nQetqOb2Efk00PmI4V9W9uAgKJA70Y/Cj4PLpbIg67sLonfoMa8EcviVuimR/8FDZ3wwPMWKzQgQ/LfGCiYDeXpOQrb/RNs1BJly07K1aNNS2UsXbpoGJbQ/IZn8yA4tcGuaQBoAkcvK9aveedLOw40HL3MNwFQ8f8mJLUYhsvTlWkOBIjUZsVHY/YXlKPgoEc/PmdJIN/xabgeVFcTlpwYaZwBkmtTfWmiFyFTwIvE7Xki3eq+6FWVI4EujkRYniMOHmOuaRX527wyLb2dw7q+fgELhk56AiokSOiT+OTRo0ErSiPDwOUxModOPQVZWsjeWvPIi9sEbdL8tPhwo+v4KGtSwNKZwklU0N4nDeWZ//qGFuYJwI0Xun5TA1AnM+roNd2OqcKvo0xheAhgdGFver+T/j+w6KyyyYjIHp3fdqIvUhTrddKYKfdxO+ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5591.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(39860400002)(376002)(396003)(136003)(366004)(451199021)(7696005)(9686003)(478600001)(54906003)(110136005)(2906002)(55236004)(107886003)(6506007)(4744005)(71200400001)(186003)(26005)(53546011)(76116006)(33656002)(66446008)(64756008)(5660300002)(8676002)(8936002)(4326008)(66556008)(41300700001)(316002)(82960400001)(122000001)(66476007)(52536014)(66946007)(38100700002)(86362001)(55016003)(38070700005)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wmFLrNGSUniP2E1mF6GvqXFJDxpbnil6YMLxZJrQI6QIhCdVKMjioxhPYxYQ?= =?us-ascii?Q?eRBekRGmR0C8ug3wCTn9R5stdAb0KTd3gjhhPXLpMYgWPgwWlDr/mMR0quC6?= =?us-ascii?Q?pWw6irxS0L5dH7OTe9WMUHciUH8hrZw/5R3vC1pAuLrB31M2yT6qLneeNXsN?= =?us-ascii?Q?WBETCqHiiAFM30TM9b2MMG/P+OZsHSwkvs0wIaRJuDbe5BqyYhxCdw1eU+1F?= =?us-ascii?Q?Iqi+NFadsST3J3O+ohgBFPab4eS7kTgSAWE0cvwbyiUVfvwIBt+ybxhAd9f9?= =?us-ascii?Q?J63jZ6O22mvd4vKXqS+NiNFK2dTEFZGZU0rJXHqqOiHf31Gl7qLr58biYuYl?= =?us-ascii?Q?mu6nW0L1uOPb2rAZty/Fu/VgZV3rU/QjqRXZB2NW9TGt75mxpGSglWTA/WRk?= =?us-ascii?Q?+ClJD1ZblZO1Pt6Fv6uuNa0LBE25alqPjWOljBNkGpakVW29okBzp6t0UdQ+?= =?us-ascii?Q?f5x6zVw9zRXFH/e7wsUlFYbdo35JyF1nQOxEbi4qGENvunE3jp3fYdrZ3DDc?= =?us-ascii?Q?5BMS/WmsrZAfh3H7AS5RpGbJYxIj/QFCECkqClOuV7y/uGPc90/aXmNX0ViG?= =?us-ascii?Q?/38GDVXyiGwuXz0YIQyE31QXnG1cAkdWxhUGmZHroidHTnP01nCHmeOej014?= =?us-ascii?Q?J2rIqUoGo8MWXzNm45WgCRwAidcYkfrf6K8y6C9EgrFJQWwx6raMsPXNtj02?= =?us-ascii?Q?KFPBcRjfloCialFoDNf2cAnB9awKnDT+/y2K6TEvBfdOuWSPXLkAFwNT9K/F?= =?us-ascii?Q?/36ve8zXoKVTMy5sO7rytOZpq/08J/6Zv7g6fm4PrF09tyvac0g6uDYTrkGT?= =?us-ascii?Q?O2ob0UYVo8c6EjyXgqe76PFfBHVuQmgrNkd61t5ENQ4uPvjZmsi3UzSMwINf?= =?us-ascii?Q?BKi7927lvdxrO8kXgzqxL5ke5DiWRxxkQU0nQVqlJdWLof8OJTA8C+vmsb4A?= =?us-ascii?Q?eY2dllWgczkWX31lgQd++YG0CHth7Z7b60ys9qWdONC7apVXxpAN+vLFb4VA?= =?us-ascii?Q?dtoWLEmdDbuTzqHbpk/or3pSFI59WpXoDjuEasJC1tz4QFSKc6O9s+NI0qDE?= =?us-ascii?Q?6rPdLJnr5CNyOnDpPT18EjIcellNUvhUi9m8+V+tFtEfS4olgB21pAMIwetf?= =?us-ascii?Q?6Usdw9bdpRrGShrk9G8+0hFI14QMO2bwUdez6vRpyJ7h0GTBLkbe3iMzvEem?= =?us-ascii?Q?40FWYlln9NQKU29R2/I2icej5F9ZpFUZEywVaLfBJV02eNKHMSz5etkPcNXQ?= =?us-ascii?Q?CT5nA+DwNQUVDQC6NBDWnOezJKIQmx3yXopap/W0AmyJ3Y5OA4wyD+nrysEG?= =?us-ascii?Q?KOnI+wAn2ETzfyzVB+hZVUCYxHTfKwk2cnI/RwZxA6IO7gtklxgxSlV0HSS/?= =?us-ascii?Q?o6RXKRg4JmRKD0ooVNeVofGRyEhICOCtpcIhO5Sbhnzx42bzp4RZvi/AlgJv?= =?us-ascii?Q?+BDjpxaEtZdvbyXIfSL465BQOZ2whPelMC5N2Sh2QHdmfVugXiTTigJvF5Ip?= =?us-ascii?Q?i7DfOec8rvntU5ZS+3+45w9gocP54SRaOcVEV3oV6kfeh+SKFmo9ziTpbprA?= =?us-ascii?Q?jxOfZh/uvEkN3/we4/yJPM7JXk8cMC7Q5y8XrcgPoDPlZ3qWtqIOPMgK/KFB?= =?us-ascii?Q?fA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4fae34ff-09ed-4303-40cb-08db7d554ef3 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2023 12:42:35.3146 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3WVmqI3E8oQr5aqda4sytqm+BUBiRMwaALu2Rign26JUISjoM6dOswTZ4uE1XfqVQgDV/kKgd14dq5knjE0pfcuYcE62gR8DFn58OeCSjyk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6188 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Power, Ciara > Sent: Wednesday, July 5, 2023 11:26 AM > To: dev@dpdk.org > Cc: gakhil@marvell.com; De Lara Guarch, Pablo > ; Power, Ciara ; > Cornu, Marcel D ; Ji, Kai > Subject: [PATCH v2] crypto/ipsec_mb: fix jobs array used for burst >=20 > The jobs variable was global, which meant it was not thread safe. > This caused a segmentation fault when running the crypto performance app, > using more than one lcore for crypto processing. >=20 > Moving this to the dequeue function where it is used fixes the issue. >=20 > Fixes: b50b8b5b38f8 ("crypto/ipsec_mb: use burst API in AESNI") > Cc: marcel.d.cornu@intel.com >=20 > Signed-off-by: Ciara Power > Acked-by: Kai Ji Acked-by: Pablo de Lara