From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E004A439C5; Thu, 25 Jan 2024 21:11:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8738B402AB; Thu, 25 Jan 2024 21:11:10 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id E7AAC4029B for ; Thu, 25 Jan 2024 21:11:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706213469; x=1737749469; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=9Nq7R2WiSpsxOVsKvt5pd2SFFxzPXNOGT/T21cDOiIM=; b=kxiDFspt6j8l8HPvj4xTTAmcP7b8QWbWNFoZo9zTkya5mxy1hSuMf8G5 bsXUGGiJi3x8lqI81/xxcJAtDjYYe3+VfJdJB7mV/7jh8UiEXWOJwtyXt uOUHLK7a2noiuLsZYNrocE7jgZCbn5HKV+rFnImsIeAoGAXO/PvDEC6XU C+48kTZd5HCpD3f4qcy4m49qUVZMgtEgWeGxuBEITfYtGL1PYWAmsVs9j 2FKGoxxiHvO+Bwb33rN/G6q21bSSvhkFNfPU2vY6cgflh3BMfurGiSAQf 2j/wG95/MbQtSx8Rr7FaJCCDByeUPArRN4UJWUG3z8Ppo4+FkXEmEF/wn Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10964"; a="401937370" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="401937370" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2024 12:10:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="28880236" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa001.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Jan 2024 12:10:43 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Jan 2024 12:10:42 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Jan 2024 12:10:42 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 25 Jan 2024 12:10:42 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 25 Jan 2024 12:10:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RDrNpj04WYaqa+/WEh9vmyjRGCotUqwQB8DIBfnxERdU772quuOuDKxd26oQfL+PV57avziNjcBsA1eyJECLeuWpIkDKUQVM+3bPWWvDIVG3WgxaGXd89iF+Dvro1VcfrXtHPCb6/IvA42c5WDcJu4JUVlW+TpIlEXDqT2cKTe0kIWvLzwLWzKPYnQDDr7xCgUfzciiavxeFFSiCJhyljN5rZT4Z2DSjlVUZH2/MwK4P4diYz+YFtnWEHcL10trTgFW9ZPw9QJ7B4GTnzaYddnarvSLAkSgx6ut4OuVD1QLoH6IevxJNJN4nBvqvjODqoxMHkyZVRjYl1kE2qCwK3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Nq7R2WiSpsxOVsKvt5pd2SFFxzPXNOGT/T21cDOiIM=; b=JdOz4gZGFZF9bXynalSHaSiOdKXDxfbNRCpZ2DibBcqkwXzMz7YiEgANIWAb7LQjvblsqLzpkwc6tfLtExprh2Gc5GmtvWiFMwdx8ZwFsfI2JQDHUf09zJRT4RIxBOhi/ukKOIwnSZjL5qPdH6BXX8Um7a/GIZjTtMizEE5HJqhdijaC/u+LOS4hhTJKB2doYjiJ8OnO71Cg3bMrz5Nml3kY5zP7xx54DBU2jpYGYkFvHI6uQIuGjm+GEmo+MUEAxgwDodtfxC0nhMffsln6jW6IFmzHwYa/nIbEHal+KaFziMdEfWWAwBwaWZqZJciN3aYT9OdmkmisrNgQ1LwfZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) by BL1PR11MB5525.namprd11.prod.outlook.com (2603:10b6:208:31f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.26; Thu, 25 Jan 2024 20:10:35 +0000 Received: from DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::e8c0:4431:b656:db5]) by DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::e8c0:4431:b656:db5%4]) with mapi id 15.20.7228.026; Thu, 25 Jan 2024 20:10:35 +0000 From: "De Lara Guarch, Pablo" To: "Sivaramakrishnan, VenkatX" , "Ji, Kai" CC: "dev@dpdk.org" Subject: RE: [PATCH v1] crypto/ipsec_mb: upgrade IPsec Multi-buffer to 1.4 Thread-Topic: [PATCH v1] crypto/ipsec_mb: upgrade IPsec Multi-buffer to 1.4 Thread-Index: AQHaSsxY3ani+cVuP0Smk6LVCtpG4bDq+TkA Date: Thu, 25 Jan 2024 20:10:35 +0000 Message-ID: References: <20240119114026.1552305-1-venkatx.sivaramakrishnan@intel.com> In-Reply-To: <20240119114026.1552305-1-venkatx.sivaramakrishnan@intel.com> Accept-Language: en-US, en-IE, en-GB Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5591:EE_|BL1PR11MB5525:EE_ x-ms-office365-filtering-correlation-id: 58c80cc4-2545-489c-f3ef-08dc1de1b0ee x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: T+Ub0MbGpGda7CXCrf8YFqjN03X5ZRuSeEeLe9crg9teKT6No3k2sA1CXB6Hz97o23pJOxvCMZgI664I9HTj0VuMXUl2C41mI26ksWutP2mGT5I2eq1tCzkVba1wzr1QAdof6G9lCY0Yf8GOpHU60npCFKldX/ZfA0Yx+biYrEtaSm59nzu0WaLEMEr5Ak3moyzr4rF28PV18hCmXGWK2v6I39rlZg+aqsw6VeH2u32SDuiVvn0+bpbEu/RfQBnI4RQajN0m5SPEOtCTJS/ZCmeW8sY3r+E1dJzJ74sahAUmu7KOX70iEVLSLSx42my3sGSS3k4m6XKNNLblq1F3vtg3fkQyco7nKTQBczKP1nsP9V6vKTa0IwPyIiOOKAafLbX5ZQghIrQScO7SmJ1u8w6clkwkMYzTBJCzSqlJR/hVBX5ZtSZqs9LgTovVN5XUa7QuRQ99hVDSgvwhwbzEarSZJOEAMvzrpjY0bzQ3WTg8xLsC49PpinRBgLj87vJ9nltrnecmaTvpXP4/JvXCRGPJIkV2D9u7svYJQAUUStySgaUQ0WqGz9h6NCii2CtlmFPFDUMjEOqxhrD5f1Fq9kyWJ2MxwrnppuoZxCthv55vqZxGg/YUBXVc+dfOmt2D x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5591.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(39860400002)(136003)(396003)(346002)(376002)(230922051799003)(186009)(451199024)(64100799003)(1800799012)(8936002)(64756008)(52536014)(8676002)(4326008)(5660300002)(66476007)(110136005)(2906002)(86362001)(33656002)(66446008)(66946007)(66556008)(76116006)(6636002)(316002)(38070700009)(82960400001)(38100700002)(122000001)(7696005)(55236004)(9686003)(71200400001)(53546011)(6506007)(478600001)(83380400001)(26005)(41300700001)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rgZUsVOMnlR67fX/eIEnnkyxMN3WuArIvGdZyv1fgOYcqkRNwS4CYLakWkXg?= =?us-ascii?Q?KzhWFqSbxudDimyyAEU2rMiVGep2ws9w0JTZRz8UmuJN5lQLTlFvnbTo4ykH?= =?us-ascii?Q?6uWuIwOyJb4JwgJjA5LBiw3+85wIYRvSchGY4eIbyJjzYpPF/oT5sKbz7wUv?= =?us-ascii?Q?rmatQb1qsH+WYWaxyIssMgY38BtSk+Ni6yU9l/lDkRmyV593hPsk3bwRwlIw?= =?us-ascii?Q?BAHvh4VyiMDjK974MHF/TbvSF7/N2zwAAytAJt15wJsuVacytR3KnIN1Q3ed?= =?us-ascii?Q?0eSblMPIze5idumDGCX3MmTG5DmC9bmNEYhEgQXrZCkS8E+O3r7DJclz2mrY?= =?us-ascii?Q?SklYYmSDfoFE6qXv3OMPp/z8nselu2ecJHU+quJm8x8EYOZpSW2T5dGo6/B9?= =?us-ascii?Q?KHSxXjD9wh6SQwlPYlfap45eLFlzNgiNgiAnE6NLJQpHxHc5O8HVuys/haQ5?= =?us-ascii?Q?gmkm03rn3L0zxJaNuepIz84XGUVYwn9qZZgRxrX/dbvaCC3FHJ7MVIrl4PCf?= =?us-ascii?Q?9B8OMa79nr60JvFF7NK4pKG2h7l39I8xNdq3Gozn0rKUhsKg7Hv2CNwZ/PAN?= =?us-ascii?Q?+3enka/UUU4fM8woinT+GkwlRKoDQdiwyPdzhJHiulYbwqJsV2MLp8Z7A3j3?= =?us-ascii?Q?dM9p2sdRcrAh6TFIkeA773PW0N2P+FBscTOlj9dlegp693rNxrPbhZ/7uM61?= =?us-ascii?Q?ioTeKt6nNXgbFaupcY5p8SScI6/CeKH5WLW0S4a9xn95gM3GIM3QWSjIS53v?= =?us-ascii?Q?YycCzUl5vGNiHZbvThwPEQ4/AnHQkJu/ocA5dkXCV1WvaPbbEq7fiEyWoxxx?= =?us-ascii?Q?Zva2v0dVEoOseUXFQsWs3IyBK529HhsHFwSTXgQmjytsBxF5KGSa4QUwcKo+?= =?us-ascii?Q?VXfNqYmspCk04b99z/O15qQ6MSjDIBsHO6bSPMIgac5QTm/BP1XBHSewOGo6?= =?us-ascii?Q?LCXDb9NlSOW4I2K/hOk2gpzyTw26Jry7KCWkQho9aId1fLi5Qcx1IFYwGBcH?= =?us-ascii?Q?AzIWqcYi9c4A2+5HAC+6vlQ65o3n0aG40cMsRP9chRBl/z0hOcQtaxpZhjLf?= =?us-ascii?Q?IndO4fuDIv5otVM9of25qp++on1qGUZQ+hPmD0bujyeImmo+KvGRj0KkrlmU?= =?us-ascii?Q?KjtbaYOHdJdVHJy+6Hlb6GVrRwuRVT47p51uUchJhI8mRDBPa25X2HKtwCHK?= =?us-ascii?Q?yW0017hgpbMTpoXUreaUWBjtJPp3IRNH4WnBTVq9uoUFieyEzWcvYhQct7s5?= =?us-ascii?Q?jlTtqHdA/AR8IXC+ujIUiRAdqh2+FoJbjSZXnwAlz3CfzlOlXjDf2fewsfCq?= =?us-ascii?Q?Wfb1KfqLx0tnOlASYPJQzDkiJEE8Rc1RsrEQzCaWMrA1JCXZhXHiw32MHVrc?= =?us-ascii?Q?6rnO4A9hWaXSmmcx5ntvBLnO9BuWlTDR3mbrWQsF6latE6d+RVagYWoyoMnj?= =?us-ascii?Q?ayX1AG8m3ZNebbpOI1cUjZ28h5eRS4QkobcNhEAS0cot+9X3AX44sXLv4mgI?= =?us-ascii?Q?o4FPgota0lNl6+2gqaSHmGtu2s7W0JFqEDPpDc5XfIJDfpAYCMG3nFpDE8Yw?= =?us-ascii?Q?8/8z7ze0MOLQV9ka+iYkxvaIblrJWl1GKG+KegMrAk2cN7zzLmoD/sK7zrCH?= =?us-ascii?Q?kQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58c80cc4-2545-489c-f3ef-08dc1de1b0ee X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2024 20:10:35.2661 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YOZLJLyARsUZ26y67NnkcWzG9tECNRSqoTfrLXtx2CzNZAi6DeUQaEuLoSmjrZNOVCVDPDK7m/5R4AOZHd9K1CPjDG05tLixVHpfh/M55Nc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5525 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Venkat, > -----Original Message----- > From: Sivaramakrishnan, VenkatX > Sent: Friday, January 19, 2024 11:40 AM > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Sivaramakrishnan, VenkatX > > Subject: [PATCH v1] crypto/ipsec_mb: upgrade IPsec Multi-buffer to 1.4 Could you change the commit title to "bump minimum IPSec Multi-buffer versi= on" >=20 > SW PMDs do not support IPsec Multi-buffer version 1.3 and less. I wouldn't say this is correct. The PMDs support these versions, but this p= atch is bumping the minimum version to make the code more maintainable (it's simpler) and to force user= s to use a newer library (which includes bugfixes and performance optimizations), with more algorith= ms enabled (win-win situation). =20 > A minimum IPsec Multi-buffer version of 1.4 or greater is now required. >=20 > Signed-off-by: Sivaramakrishnan Venkat > > --- A couple of things more: - Could you update the AESNI MB (aesni_mb.rst) documentation to show this c= hange (the version compatibility table)?=20 - There is a macro not needed any longer in ipsec_mb_ops.c: IMB_MP_REQ_VER_= STR. Thanks! Pablo