From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EDC8B423B7; Thu, 12 Jan 2023 14:22:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D90C342D22; Thu, 12 Jan 2023 14:22:18 +0100 (CET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id EE6BA40E25 for ; Thu, 12 Jan 2023 14:22:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673529737; x=1705065737; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=R8xqp6bPm3y1jNMsL51Gx1+B/FFMMF7g/D/s00isLaM=; b=OG0LmkUcN23wnWAbDOl7qnnh+9bTov+qBqVEFpBod9SWn1xqk+KtDkmp TjEyPUr9O4czlF6ydDw26uhEKQPuaHqz+E1FVaecyOLc6Y+aYZIgV+mRR F3cVNPOiIs1DTATJht7LHrLkMeX27vOBJmoW2wwP5UmBK5jHPteQ4IQZu s9z0xpxo//UkZ+vqjVOZY+TGLdP/oVW7HyJOBGojEBiL2XOp+kNkBXEfD rjNTnWC0lrWtroKho0aOyR6qF8JKhGznE3lps4lVgMvmp9Wgy0MW2fEIF xMOeZpVxQ3d5wGBKC7lowIeoqhXgBMGfR771wCatFQcrdtJPGEKuDi7B/ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10587"; a="386016228" X-IronPort-AV: E=Sophos;i="5.97,319,1669104000"; d="scan'208";a="386016228" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 05:22:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10587"; a="765616715" X-IronPort-AV: E=Sophos;i="5.97,319,1669104000"; d="scan'208";a="765616715" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 12 Jan 2023 05:22:15 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 12 Jan 2023 05:22:14 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 12 Jan 2023 05:22:14 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 12 Jan 2023 05:22:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rcbmx1WzVPgZu/qnGmCxZoEFHmD59udJQ+h1tmqQeRq50VD5ptPP6sH4rAA26S1WWn61KiyuLeXMr1bTDI6Bv3ta2jjaM1piQxN0F+ZK+2KotKtfvQlXjxQNhC6yZ8fKwr1MwTxdRNa1zZ0nwEFzFdD8RpoZ1l0iCw7XE5r168cQRtOBRWt3W0OeoDdfE/3fL4gh6nEqyLQQNfa9z286j2sW46GUBwRxrvD+i4z9YTCokGJfgjDR1tkMjQ2s9GM280q6kOReHtqFRRmDO3dmoG57bvhAVddaARgeTqc0nDIkuifAfg+PnfxBHmu9WIfEYFkO/xslV6fd05z3TxxBCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R8xqp6bPm3y1jNMsL51Gx1+B/FFMMF7g/D/s00isLaM=; b=PTI5TvHyR/sggjpd/U2fm0MFM7E+/KRVyqExZJ7M7v0EcLMHuEl2xXlVeqbTLbp29f+3y+8qzsRhvfwCwqeTgOPk18e5VDFLUcZkYN81d+yLR0xIHG04QMFk3pJWGiE7RfgaMuqddzn25DWI0wjKDtOrwF2B38j9ai2Hag6bOleB3d8Y17/JzwOQbvZpz9iVz7FYQ0pp8zewNcGiR71Cj8oXxr+sIbEqFyeF64E3rKH06jDrNsEXoXIIqfapTzvHVNQj1JR1V+Nqv95lx+QpCJP6yrIOveuJiU5cqnMVWGVtIF/JYHSM3yDP5UmitNkHUvAzERFPT8VFIxwr5L4YtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) by SA3PR11MB7525.namprd11.prod.outlook.com (2603:10b6:806:31a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 13:22:10 +0000 Received: from DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::b143:be9a:805a:ed11]) by DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::b143:be9a:805a:ed11%6]) with mapi id 15.20.5986.019; Thu, 12 Jan 2023 13:22:10 +0000 From: "De Lara Guarch, Pablo" To: Thomas Monjalon , Akhil Goyal , "Ji, Kai" CC: "dev@dpdk.org" , Tyler Retzlaff , "dev@dpdk.org" , David Marchand , "Dooley, Brian" , "Power, Ciara" , "Mcnamara, John" Subject: RE: [PATCH] crypto/qat: fix build Thread-Topic: [PATCH] crypto/qat: fix build Thread-Index: AQHZJhNcV79QCwzYkESRSoN3kDxi/a6ali6AgAACSoCAABlXUA== Date: Thu, 12 Jan 2023 13:22:09 +0000 Message-ID: References: <20221230210728.86920-1-thomas@monjalon.net> <9337009.CDJkKcVGEf@thomas> <3685739.QJadu78ljV@thomas> In-Reply-To: <3685739.QJadu78ljV@thomas> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5591:EE_|SA3PR11MB7525:EE_ x-ms-office365-filtering-correlation-id: eb70219a-fac1-45aa-1c71-08daf4a00279 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /6FzhaA8PDCsCMGoQdzLGkV4+ZmWz+Uv9fknSkXa1EhMvqNbSV7h36U9t9Qd05KgVhK8u56yEdCeSdVSc4RBrdM54g8fdFreUNoqKRqMdOFsqSsIQT72ED5OUnXVqLTldMoARWHSV4tvPl5bkMXqhzSPEwHF07R6xz+TP8TBZfG9RDmW9nef6gqemXDreNrPP1i1p+jBiFJ9K1MWctETcIQOb83FlAnVvSlEgCn6ii7FAhMTqwmz8pvQT8+d2fsA+Rk+3eKcr7woJpaGbtKPMLq+RmlluaBDWlkA2rNTY29jOyFNy1yUBUr12rOGVg0Jp7LPkFXd2L8yowVAb9t2PyDxgD4loUo41TPRYXVywwtwavWn9QhaS1H4QUsj/DFTzau3gOkvkBoVCqk2B9aFp7Oryjcb0+0qknhdR9MURwqR69Nqz292rxQQPxkmeLtpAS+C2uW+pgplohqk7R9fcT09mSrPSpamN+qO6oEoXji6pmp8jRg484hgLFiXloO7uaPqb75XYlYGwMg2MY5FWOciSMYjdHmgOqjvcMx58ooB0nz8LaPWqYiFaALcIACiWpGpv6v0WaDOqgq8yKrmtAkSWfxgi7Lt9WkvTank+lYT9WXxnY9/AKfWgxdpuzuwTo4sEzmwg5FA7m28Kh32Zym4Io9EaNAOi8kgIZmDOOQK0uevOd9Yl8W1GQx9Ff5uBPO0XsYiH2TNvoKvMv7cIA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5591.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199015)(122000001)(82960400001)(38100700002)(33656002)(38070700005)(86362001)(6636002)(83380400001)(54906003)(8676002)(41300700001)(66476007)(110136005)(66556008)(66446008)(66946007)(4326008)(76116006)(107886003)(2906002)(478600001)(7696005)(55016003)(5660300002)(316002)(8936002)(52536014)(9686003)(6506007)(186003)(26005)(55236004)(53546011)(71200400001)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FY5memg02eIfRZKMAPIA7/jPJWHGRXbz81TxMAQ5CQEj5hie8EQnu/tDINQX?= =?us-ascii?Q?2JC3Zildo0T+MHMx3+yrIxqdcI3E2ZjTK8Ma1/G14Sh/tTWUM5qFmlrCDXfX?= =?us-ascii?Q?xLKHT8hlZXn509rTny+GlEnnSAcKKowXEkjw0KPFMyj/Xr3flzBiL3b1Oz4d?= =?us-ascii?Q?Pg9Qjst/9AGsFefvRv9ee5kt3ivklI5zGOtwWBVDM7d1t7dVRLQTvEPIYMN1?= =?us-ascii?Q?0cho64ECLtqvvK0dgi4Q2TyDMxOcCUD67oFPO8S16wVAttpyWs12ybyA64aE?= =?us-ascii?Q?gkTdU8ebzoZvmtaEUl5BiXl1c2CfsMsGiAERFD7I/2WOslCkVKASAfQ39VtS?= =?us-ascii?Q?oVFgZBx6mdJkuNeMy2hiYay4q7ZKlxvWqzscqzHpDqDjWI2ZY/Be/T5yYz9W?= =?us-ascii?Q?39w44l0UyGByJMH5oIDvN5UKnVfMW57mYMOm1dVBpA56knVvEm1d6uhZ0u+D?= =?us-ascii?Q?3ZmpRh8ACER9hfh+bi5SxBB6hBWnlZq4mbG665CckWt1f3rvYRI7yPB4fc5Y?= =?us-ascii?Q?lw4UImeFrQddPofCQS132B3fIOQV5TfeFo9SLPVJvRATYaHPRYMvAetC8s6D?= =?us-ascii?Q?Gt1U+GxxG2tZuia5Sk/D52p04nsP1h+pJRDVoZn1ywqHhI+/x1NZ3nWwR3gh?= =?us-ascii?Q?GvZ8G7P0NzzFOoe6/vJxeVp0GGmN6XDNHwShjPw5T27O0HtnWfnaoAd1QIlI?= =?us-ascii?Q?Np4i3cspQWmaiz3frDkvv/4Z1GTvCUfRIEVJe3nli9Lg/08fUpBt7K+/yk8b?= =?us-ascii?Q?3nHbKhRlGlalb96toRtflFydC8mLSS24jvEKfNU0OGQ55r32/Jo0UGihzxOL?= =?us-ascii?Q?V7Vvy808UBkEQeg4/LXZF7Y8EmnZmdcKc2HoOFbqF1L9LS8BUObX0kZrwAU4?= =?us-ascii?Q?CxOVBvcZB9PS47+OrXVs17KwAg9Tvf63xMoe7RA7tvrcwpkKs/TO0SgZyopg?= =?us-ascii?Q?J5xvooziw+tf4UGmDjfDlbQ5knk62y6SKuI063qYA5R8D7Vu26yR+E9KvjRx?= =?us-ascii?Q?ElHt756CyBLxZh8pFijlpy24h95dod6a8RWXmGnNwMwP8SzlwVhaL6fDH0lb?= =?us-ascii?Q?BdmaA3lg71isHnBrr1/zEBJqJzwmnkxBSvTNSMI5Cfpibs7etKv7jJ/Xgbzd?= =?us-ascii?Q?4hTNqoKwUbJN3tE2ZQSKeQBQE6cmY/sap3MxE5n18r2/zMlrLRGFoTyq3UH+?= =?us-ascii?Q?XErp28QYrkTLoRzLwRYdFv8hL5vLhJSYkbygHc8Le6Rgh1r1d+KG9wOQ9fC8?= =?us-ascii?Q?rjzNj+gnRozqFIjYmvd+HaUFd2WQVb6wZZ37G81dUe52bhmNTKr647u0dqaP?= =?us-ascii?Q?bZJWLupRix4f+QLpiktXQRQJ4RS+m3QxOTJgDvVFm1sUi1j9tCg6uWNay+QI?= =?us-ascii?Q?N/UkAgEocP6KuPK3EyTtQ7htBXo1rtYD+/odtYouF3GDjgFsS/D+eod1cL/l?= =?us-ascii?Q?q6rD9D9JCPWeDtc7Pn4DsnO3ttR41lLtlC9VWviwBrYHIrvZYWYszHuTxmJ1?= =?us-ascii?Q?yzrI3OE/Ya8Wxh5zGia+spdw/5AfrGb6Lvac+tvOs5t1E3sj+pZqlwTDK3oK?= =?us-ascii?Q?CnMDxQob62MOKEt5Q577jEpedjHHuKT33baFqtNrAgrSFk/WZZ0V2vRXli54?= =?us-ascii?Q?VQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb70219a-fac1-45aa-1c71-08daf4a00279 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 13:22:09.9314 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CtLZYiXv34C63CPDY5ELim3XJP7uD68+ueJRCTqwGR4ZqjcJEPsmPHpEYRoHNr8F7mWwo7x8ydzQHvQ/rnqhxjgt7TI6EniYzn01N+EfNyE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7525 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, January 12, 2023 10:41 AM > To: De Lara Guarch, Pablo ; Akhil Goyal > ; Ji, Kai > Cc: dev@dpdk.org; Tyler Retzlaff ; > dev@dpdk.org; David Marchand ; Dooley, > Brian ; Power, Ciara ; > Mcnamara, John > Subject: Re: [PATCH] crypto/qat: fix build >=20 > 12/01/2023 11:32, Ji, Kai: > > Ok, a long story short, this issue should only occurred when > RTE_QAT_LIBIPSECMB is enabled. > > It was intend to remove Openssl lib dependency in QAT replaced with > > ipsec_mb lib, but the work was partially done due to limitation of > > ipsec_mb by the time (FIPS certification) > > > > I'm happy with current fix and please cc: stable@dpdk.org >=20 > I'm not happy with this fix. It is a dirty workaround. > It would be better to have an #ifdef in ipsec_mb. >=20 > Also I would like an answer to the question below. What triggered this er= ror? > Is it a new thing in the lib ipsec_mb? > Why defining AES_BLOCK_SIZE while IMB_AES_BLOCK_SIZE can be used and > have a proper prefix? Apologies for the late response. This macro was renamed to IMB_AES_BLOCK_SIZE, as you already know. The problem is that, for compatibility reasons, we had to keep the old macr= o as well. However, we added a compile time flag to remove these legacy macros, for ex= actly this reason (NO_COMPAT_IMB_API_053). I think a solution could be to use this flag in QAT, so the legacy macros a= re not defined. I will send a patch to fix this. Thanks, Pablo >=20