From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3F6B432D3; Mon, 13 Nov 2023 12:38:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A2D3E402B7; Mon, 13 Nov 2023 12:38:52 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 5974E4026C; Mon, 13 Nov 2023 12:38:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699875530; x=1731411530; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=VdE34OiaL1p1F1lwMu+3qYlXmRAK1cJHvpzwL+xy3Fc=; b=OQjaJ3mvVywDByRjAOU3Fq7yzN+kOHTDH/yp94scpsvTN7XaKbQo+5Oz +bFUwuUx+s1eCQn2f9N9/rwQvfi7rDo+HtIZOMgZzzX4Fh96+y4PADB+0 eyVEGWDZrhpfmNo8eY941wtqctkUPPrf0kFrrvOan8AsiM6F04qfOCejM GdvOjJqldhgiF+t2v9YhcL6ZYZwJD2g1SEh9fRA7ixRtonca2/knyF/aa SgTGPaF6Cg9Dnt3J1+aWjHwfvcKvVBOnomO5VK6YKFcg2Ku/Xz65ee0Wk fAvTim0SRWaXCMCwyi1MFEF6d9N+coQQgdWK8opfRdffK5/hPLBOIZ+Lt w==; X-IronPort-AV: E=McAfee;i="6600,9927,10892"; a="390226604" X-IronPort-AV: E=Sophos;i="6.03,299,1694761200"; d="scan'208";a="390226604" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2023 03:38:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,299,1694761200"; d="scan'208";a="12082974" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Nov 2023 03:38:49 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 13 Nov 2023 03:38:48 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 13 Nov 2023 03:38:48 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Mon, 13 Nov 2023 03:38:48 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Mon, 13 Nov 2023 03:38:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nuld1lcQmrpNEqJgOyC9h433elrUfaZcRlFv8Nz9LdS4ReMSyxgqstS9G+Nf10uGBvslJJmpKcsKRc7Mt576DbZg2hRMeyqJlrs8rkUrbBe7za3098MwngzbE5SjPqxSfSBxIVEb60+ULzJkqCB+SNnpyDBQ0u7FMafsKmtHwUlY4BXZvoIloagi9ijK/I/Fv21h7XKG4vwv/EsisPGDClHSKJONz8bncq6nax0/u+NRwAfoVKbtwVvh3x3EN7qk08Lpim1T9P5Cw7JMp44HkGoPRlUDE72r70e6bFDYcVQgyhEjVQW4Woy9Wa4whmvTzXMZ442yyUzReko5shNLnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VdE34OiaL1p1F1lwMu+3qYlXmRAK1cJHvpzwL+xy3Fc=; b=mdhewUNrXiNWpjmex/2JzOQ5qQcSybudQ7mKlKwkAXVvcAvwBovO9l4elogRXmgIGpe+9YYkrDTx6W9wjhNBhp9IeE6qKQzZJCeRnlvkpONwRlp065ptBTSSOrEvydohkK3Dg2bpxns6TnOnbrzBN5QYqvmJrFseTnJwkFsAI/HT3uX6AaYOQMfUBTmZY1wjiRDlgOqS+0uajiX8t0dpuk6v+McTjyzjcm4cBTHHrgRv4246RKh5LBE/ip+v2TMR0SNCnx8JM1zp6ebYMPFWsc2oCP+bXvF/v74pCV1KpBdMQPqCs7bCFkKJZTc9xzu621q8oXcsKekuZJTdBgNkpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) by SJ2PR11MB8322.namprd11.prod.outlook.com (2603:10b6:a03:549::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.26; Mon, 13 Nov 2023 11:38:46 +0000 Received: from DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::562c:9cac:9327:79c3]) by DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::562c:9cac:9327:79c3%7]) with mapi id 15.20.6977.029; Mon, 13 Nov 2023 11:38:46 +0000 From: "De Lara Guarch, Pablo" To: "Cornu, Marcel D" , "Karas, Krzysztof" , "Ji, Kai" , "Power, Ciara" CC: "dev@dpdk.org" , "stable@dpdk.org" Subject: RE: [PATCH v2] crypto/ipsec_mb: do not dequeue ops after flush Thread-Topic: [PATCH v2] crypto/ipsec_mb: do not dequeue ops after flush Thread-Index: AQHaFggLsfcWc0ugT0+6V5nSxFUji7B4GJgAgAAHLjA= Date: Mon, 13 Nov 2023 11:38:46 +0000 Message-ID: References: <20231113080158.3872440-1-krzysztof.karas@intel.com> In-Reply-To: Accept-Language: en-US, en-IE, en-GB Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5591:EE_|SJ2PR11MB8322:EE_ x-ms-office365-filtering-correlation-id: 98534bf9-f68d-45e6-6575-08dbe43d18a8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Xxlr91L1LK7YQlFqVe/cvqabxY7T+NHXwB+/6H81RBq31fMrvdzbGCzNF4LtkirjtKs93xKX3cuggC0XAdK4t057wpLM983Ypfp0FFCeH3EjDZ0vyvWRi2Z/42My5Rx+Zi68PBTZTZh1iwZ7ejT86Fo0YAtE1uc/IXLHTbzhMfiaHL6AQ+Y3vdnwxohbwcxgX9Jhdt7Zwwzm+RatsK0Bw/yo5aR3noSuQ5dagPnVLvn6mQDN54SnXjb9yb2XYPCjIBjR0nMKyfEjuKpc0lzEzAbsASYZ5ESSF69uZlfB/Bh7Mf2wF7xX/osKHeOSxXDL4w9JmW8ILMJGyHBjhp6nPxZn994fqrY1ff6HvSZvqAfzkzul7RLyr8Rq0tmBlohCm/ZaME9jZd7mXAzyCHWcteXATI5en82K4fz0lEmyZOE9CgfS4yJHdJVubzN8gOGHZ3HP7zUE+WT/B/m4MCXbmEBjbNMJkmvHF5vcei+nVVPswW19Z+1QGJDzSkuamYFtpn8Nnepv+0IFsUSd8zMagAdgS6bGnFJGxQUIAdIs1WXW/ZAP0KHkixKP+2GykVlyHjExx4SNm4XwFUrqcYhnjcFyU3hN+WtQ9x3PKWKSl2E= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5591.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(39860400002)(396003)(346002)(376002)(366004)(230922051799003)(451199024)(186009)(1800799009)(64100799003)(38070700009)(2906002)(52536014)(71200400001)(5660300002)(86362001)(41300700001)(33656002)(26005)(82960400001)(110136005)(9686003)(54906003)(66446008)(66556008)(66946007)(66476007)(6636002)(76116006)(316002)(55016003)(64756008)(38100700002)(83380400001)(55236004)(478600001)(122000001)(7696005)(53546011)(6506007)(8676002)(450100002)(4326008)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WHwvfdm7/RdfIX86wFGxsWvXsySFmX7dSMqw+o0CV9signj7tQL7eqJmJHg8?= =?us-ascii?Q?GkQ8bDDWTmv2h0gRU27Buw9AkMEXOQQvNtNH9FiIaHoOtcG7o9wauH5fAhMe?= =?us-ascii?Q?lpG+Ou6JZ3YE4BwMKTpEvM7H0sg+IcQDpvjeuNnKXiSSKjrcj+w20vWdNn5G?= =?us-ascii?Q?cOtK4gobBK7l2v3Ue6aXss/VOzclgOt0cj/wPe3+/Do8OcJojypp6MO/Y5Kf?= =?us-ascii?Q?FEViUZmQcpwQbM8wAOqHOlsdChS0ybsDmHTtZxtVgZk0nB1ArfVBTvJA4rBU?= =?us-ascii?Q?y/foPY3pjkZEQ+6E8AcbBTdLUgmTsh463RVp0CFgipZk3DgjLZB2de7y12A8?= =?us-ascii?Q?Fn3f1HN48RgK1mOuj0jtDlaFHgRXuifb5PphLthMgmbrJIpZjnRe6GUc8G+U?= =?us-ascii?Q?OiOSk2tsTFjfpm2RHBd1+LcR8fH4UwPPs7asmgvk/s5UmMFlvmpyAp49k+on?= =?us-ascii?Q?9In8ITs8l9X6JByVhArRJlMiCgHmJWUYtVSPQmFODJAcwo759mwt0Gc5n9/H?= =?us-ascii?Q?5qgeibye7vfBZFtKCeiR9wA5xrIgzssSFq0twB4zTGlWHJsJCz5EArhLFXvz?= =?us-ascii?Q?tA6zZOhkrcq1F++utEFMiB4JRcRYYLsYtbN0MC9Z7QHVYOt427gL4XWcl4NG?= =?us-ascii?Q?u6skLSYsW1XWCJN8sg/9P4ACDc3sdAwNNijC84mGloBejDed/0hx2jH4qbat?= =?us-ascii?Q?DxYWg0PbYI/6Zeot20TdrYdn7ETWDG0PSGqEC+l45OMRggfR1hnREO2gV1ni?= =?us-ascii?Q?mgTiCqU61sqhZEz9LCcFpUys89SaZE2PU8afDwtXlnhgADvqb9vImYSr/jwR?= =?us-ascii?Q?ohoISqovtTaXkP3R3cpdhHOo8qAaqs6wZxvMlgjiTNiyIONwhfEFRWvG2cEU?= =?us-ascii?Q?0EmnEjoeU1kwfxv7XZVawSY3jDcEMOkTYsJPe3Vm505gjAFG/EeGROvDMygK?= =?us-ascii?Q?S+dW5d+XBCZKVt1BpuUHM7BpWbu65SjpTUJG5aeWP6SC26HSp4wSmrJ41FqL?= =?us-ascii?Q?Mkk0+vWgf5zuBOgGNZXZZHRkCns2RSpMfhxOy7EdOeg2+PQrqEf63n3ohIh0?= =?us-ascii?Q?1ScxrrQi7QKB7ibjrr/iXEZKWb7RwBgkS3nu4XZOBvlKiizZpsY/+r8tQEte?= =?us-ascii?Q?/6/X1q+/XGr9hFvLUg1+GZ8RK2vWWcAAzwxSPICHezzIQz0xB/tvk/H0ZJC3?= =?us-ascii?Q?dIZ1wGnCjNGuXrRkphcA5LJjjfglrEFlvKQtoRxPay6eBSt3j1Fpxtp/7bML?= =?us-ascii?Q?nFsE1oOwG0IZPWet3r/O9SwevYZKfyW7cwFq2kCKuiEpF5ZA+DFmY3LSQX7X?= =?us-ascii?Q?lA20NIdEgKpA/WN87yUUtChwVa2E+cwqGCWPW9XTZAQ1nNTYcLMxeV+vvB9J?= =?us-ascii?Q?KVgi20sF6ncH+zs0kO42lSe76bbqVUGHUMMKQ5EynM9nxURJpXeAMPvO5zSD?= =?us-ascii?Q?k4qQUQm+4ywOV6xggHEU9Oa86LQgbOuxiNERxlhtJX2AmFnSZvOQ5IoBnoKm?= =?us-ascii?Q?Sjftvc4oKXW+cDbKVofQU5ZR2JbDVrPOPSycmqMD7bakuw0/QJYlkC5I24CX?= =?us-ascii?Q?icv1eOeH7rRIyYZlc0uLnwbJjhv77OxNUgR0H58Jd9G8Gr0RF77DFQctVHvc?= =?us-ascii?Q?Aw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98534bf9-f68d-45e6-6575-08dbe43d18a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2023 11:38:46.0395 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JFltoOotXpWjdORXcQOCEk2GuyvOIPQBqhaXih73GReCR4WGvSH8tZB8pEAujQrEHeDBC2ihpUFHusXyqe2LbGbAEf1qi1w0DRyxG6fzSg4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8322 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Cornu, Marcel D > Sent: Monday, November 13, 2023 11:13 AM > To: Karas, Krzysztof ; Ji, Kai ; De > Lara Guarch, Pablo ; Power, Ciara > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH v2] crypto/ipsec_mb: do not dequeue ops after flush >=20 >=20 > > -----Original Message----- > > From: Karas, Krzysztof > > Sent: Monday, November 13, 2023 8:02 AM > > To: Ji, Kai ; De Lara Guarch, Pablo > > ; Cornu, Marcel D > > ; Power, Ciara > > Cc: dev@dpdk.org; Karas, Krzysztof ; > > stable@dpdk.org > > Subject: [PATCH v2] crypto/ipsec_mb: do not dequeue ops after flush > > > > Previously it was possible to increment `processed_jobs` to a value > > greater than requested `nb_ops`, because after flushing at most > > `nb_ops` jobs the while loop continued, so `processed_jobs` could > > still be incremented and it was possible for this variable to be > > greater than `nb_ops`. If `ops` provided to the function were only > > `nb_ops` long, then the `aesni_mb_dequeue_burst()` would write to the > memory outside of `ops` array. > > > > Fixes: b50b8b5b38f8 ("crypto/ipsec_mb: use burst API in AESNI") > > Cc: stable@dpdk.org > > > > Signed-off-by: Krzysztof Karas >=20 > Acked-by: Marcel Cornu Acked-by: Pablo de Lara