From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87EC5423B8; Thu, 12 Jan 2023 17:20:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 68A2442D4F; Thu, 12 Jan 2023 17:20:57 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id DE9C040FAE for ; Thu, 12 Jan 2023 17:20:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673540456; x=1705076456; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=11g9gnM+z+iN3EnlbqdMN2o5zwuvp53bbs50No5f+HM=; b=abbV1E4zc95lF8C5r3b8qt4flNjnHnMLnJPLEP3SH8Fg9E1Tap4hsqpZ ZsmS/M8nwTCQVP/Ama/2lv8AM0Cqwt6Wza1lYWm22G4JTIyD3kSDYPNvv 36Fo/3iglg0PFEnLts48cQvfXRvBdkVBYQDVSVsvyFnQz4AwtQEbeju15 kBrFxgkBQmjmKFOe3HpljB0sZLI+yWhgb8QHRT3bqlXY0hhatjU3/lAyK gyG4IDANdMJXvlo0umauGB2MymvD/CMXS1oTAHwB4QUoN0xoZhZUxh80G yn3ska38nA7KTQnuNJOUCTniV2GbF5tM8RiogFGdIBswBAYqpRn+3JECT A==; X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="409985179" X-IronPort-AV: E=Sophos;i="5.97,211,1669104000"; d="scan'208";a="409985179" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2023 08:17:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10588"; a="800260482" X-IronPort-AV: E=Sophos;i="5.97,211,1669104000"; d="scan'208";a="800260482" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 12 Jan 2023 08:17:00 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 12 Jan 2023 08:16:59 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 12 Jan 2023 08:16:59 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 12 Jan 2023 08:16:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VJWHq8bjTZ6lT/pw3nTguQOzIJ42PU7ou23UIxdGYRFAyHtyeOlhlYH7Uieeak6xW6lh9r2mWxJp7Qd74cRIrDoWoqa3PjPl6XnOkVQ8BC/IjjY0iQBiM+k6yQgaYg/MAsjttnSkFw9GVXSJ/iRvEg4knCbxUEKKkvXn/Jt5UWSeBsl7vad0iHmGOLY6VY0wVb9K2LNmgD1cSGyAl/eqgYuR5VuD3/h7gPu6EqJZud8kMX4/Iax7YqoIFx63p7F4CGXV6PxF7jBWrRFTvPx/rYAkefsG1J5vQN7uEhFenER+L3YV132yniYETgW+C12A2GnFQJMyW4QgAIFjKKH6mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=11g9gnM+z+iN3EnlbqdMN2o5zwuvp53bbs50No5f+HM=; b=ddvFmlY8LKiZddpb60+DR7tL+F51dkQ699+rVViQjUEHTM2Kdq+aDKpZtcu/gDjGkC0jJegf7Daii7cX9azKn7jNWk1sDroQjFR42PtEz2tSCLaJQ+lYfwWcokhXfSXy5ZUIoKIyfz3dYW1AttCCOqwpvlb4eCyLwKh0PGnIakgnTlYn0wO7HyZOwSbPl7mFFJMz5hcZ2WPTt9LiFEDr3KXo3iJvVAivgAatFsm3gnJbOQ/zwvm9FaYKCSec9Q0WdKw3AAP8MrLPfBZhzGFSMKlmPBrMkv9sAjum9lkNMuKYNpTLrnXOoxVIl4GUnQOdC9OYM+1h+/eM1/FGZK3b4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) by MW4PR11MB5869.namprd11.prod.outlook.com (2603:10b6:303:168::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 16:16:55 +0000 Received: from DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::b143:be9a:805a:ed11]) by DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::b143:be9a:805a:ed11%6]) with mapi id 15.20.5986.019; Thu, 12 Jan 2023 16:16:55 +0000 From: "De Lara Guarch, Pablo" To: Thomas Monjalon , Akhil Goyal , "Ji, Kai" CC: "dev@dpdk.org" , Tyler Retzlaff , "dev@dpdk.org" , David Marchand , "Dooley, Brian" , "Power, Ciara" , "Mcnamara, John" Subject: RE: [PATCH] crypto/qat: fix build Thread-Topic: [PATCH] crypto/qat: fix build Thread-Index: AQHZJhNcV79QCwzYkESRSoN3kDxi/a6ali6AgAACSoCAABlXUIAALyWAgAAU7tA= Date: Thu, 12 Jan 2023 16:16:55 +0000 Message-ID: References: <20221230210728.86920-1-thomas@monjalon.net> <3685739.QJadu78ljV@thomas> <23216321.6Emhk5qWAg@thomas> In-Reply-To: <23216321.6Emhk5qWAg@thomas> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5591:EE_|MW4PR11MB5869:EE_ x-ms-office365-filtering-correlation-id: 27954238-8852-48ec-0aec-08daf4b86c69 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ofKDULa4ddzOS4JknCE9N4AGgtfXxpCROU6cIHA9zYlo7woIF55FTlH/NS8icdBMdQGfEyn0L6OhT3rWwEGtzuWwOa5m/qajYxtAk7fJYkQLamLt4CfDICEBaHYDFBUhRGRqusK6cVYex1w3dhJpgTQQNJKNGvQFDpbiZUW31ipzv1xLhLZKJy68lTUFxAm9UqxqOAEkCdrC0FjEH3cXqQXYkVcsrZzpWFQ/bg7s9iqJ4IQ9vlyuMNlAYKGWEZdnH/EmGPCImswYlGPj5bKNZIW7S0AQtrCB1P63Sz9M+0jyY8shFyeuqYOoVkxTIOG7yIJa+EhUw2mMTzu/QI7W6DkSC1RPSQLZzJfnJx2TzV6Q+qCmFm0IIV2+v6iUUtwm74R2VrW/y+xFqpqlmfX5ENgxmjrM2YDk7uCDqC262S22pjGWJcMJmR8h+8hdQ8GZemS7GLzh1C1z4PbpFjzsEJpemrtief3oNz00FUmiB2laifuW0NTxK5JFcZkrOVp4I03WF7PCnD2wZFjsVuelqvf7UlFA4hL+ccefvRPVti6mUR4Vg3zvmSk29U+ACoAlf9LRUi8Om9R38LYlEI6bINY1li/Oe0uknnT6lFwh89k2bcujlDmNLfhRYgiWeLRQ9fQAkJuKETSB/Z6LDAfUVX4fnLipukzJ5v/KjRmXwxXrRdHLH8cv0C+4LbdATU7IZvHMJLvP6VdKzl1toIrTjA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5591.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(39860400002)(376002)(136003)(366004)(396003)(451199015)(6506007)(38100700002)(122000001)(82960400001)(107886003)(55236004)(53546011)(2906002)(478600001)(33656002)(26005)(186003)(5660300002)(316002)(7696005)(71200400001)(9686003)(86362001)(83380400001)(8936002)(38070700005)(52536014)(55016003)(8676002)(41300700001)(64756008)(110136005)(76116006)(66946007)(66446008)(6636002)(66556008)(66476007)(54906003)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8ceJ6PBwikr9/9OjbUYBwM2x3haN5U5hrAU89enwQLBWoaRJ5fhePzHVTBOB?= =?us-ascii?Q?+6gzKLN5aeDDpQ0FsBFCDv89TrVYUbq4PAS7jHUQB/S9vC71qvPFe+vXOpd1?= =?us-ascii?Q?tX2H1uPm5FbKkhxa7oO8aNpgUskByuT2upxuLEw/Q4FEa9UnUAG22xeBqDa2?= =?us-ascii?Q?j05XOEQkBsnVVQrpnb9eKnDGv/EekYAFyAOoP6xBMQOuq462xmOCrPZXx7cB?= =?us-ascii?Q?s34cXoKC1TMYDGSnvyIt5fQcuYFNsUD/p+jb58vU+iarAe8e4D9rdWgR9Vcp?= =?us-ascii?Q?6JKh2tD/7h/YDAAI2vNpOQCTdrKsXqcE/QB9h+vFNeivHxYWVzUkcZzCBuA2?= =?us-ascii?Q?uXPoNkdLnlcy38fRiN9TRT1XLV1yDQcjrb4BRyl960mlc6H38bP9P7eOqXkp?= =?us-ascii?Q?xH8JVhGDmWacQG0A0uzXb4ETYST9FAUyqKTsvLn3FO5oO2xHfq42XanchOgV?= =?us-ascii?Q?Ri8LaJbGrbYa4wz/EJnM1dFSi+dPOnFxgsze1xQKpnbcA9E2YHwip9ME6QVJ?= =?us-ascii?Q?7oTKdv/UfLZ6awsCc/hMbd2UG+ajno71WXU732RE9nptbsHGlS2uKGxpdqPt?= =?us-ascii?Q?kYJm/fg2arawIHO9CTYld383MAmkUUzgmqq2UmqdB8wcMwk9T6OBoOiOzYrF?= =?us-ascii?Q?hJfn1W34YaFG+SFa2pkHM1BN4zOzDv6am1EJ5QDq5KgVMVslP7I5sYkSalPv?= =?us-ascii?Q?lmoiC7hO2cFN2dEK70KP6aoZuD3Xh7RuNEs2GCAyatNJykP5rpOmdfju5ehU?= =?us-ascii?Q?FnIkN1GriWtkmSxexZXaEzcnv4pSa5figc69WMaWkatChiFDuF4T8maYjzs5?= =?us-ascii?Q?uBmH2Wdi98rgs7LY7hI3MT4UbO+cXRKlZqcPyKoFGAGeARrFTyrZaHKE8hBC?= =?us-ascii?Q?mrolk7r1txUFvA8Jf0T0ILs11XZVyvJDKmgLwuBwYXJyC8AwttJzFt1vmA2D?= =?us-ascii?Q?eFtoRgpixExDOTqDOBLp5ndllHkImhJeYFL72b9M/r5aA63VqsG5RNLzsUsD?= =?us-ascii?Q?C61NpI7Jsm3x2ZFeYlfpk14FgKHS7XOkJF+u7Wl2R8MdrXxYBoT5/uK5BtYp?= =?us-ascii?Q?n9c5HZXkJOOREdYnDPzDJVO3iVrI7B6OsyPIXgD8/j2sD83FfL52NA+me/K4?= =?us-ascii?Q?vM9M4QWlZWxkjQL+RVKS23Pi4I9z5lmF5unLKoUdK+83Hhi2EsBQBUm6PcG/?= =?us-ascii?Q?CbZoJBEQkpi//AiLF4yOAWLQ6IJuBOjtamJsG9H/gTDut+4UQbWE3wwgKUFY?= =?us-ascii?Q?O4bREa1EJdFA8tPIz4yDhufQqbhmnyya2888x6qaj32z61zxG/d44pYbVC/W?= =?us-ascii?Q?qUPoP8Povd/2J7dHVzN0JmpeerZjBa30SfuGKVFmSnt7l6Xc/FL0ZMDvhfGL?= =?us-ascii?Q?bwPYahpao02H5UdA5BFMDC3s4pOPH1uPeqyoZf7Mj9P8G37RWZi81QAP1Wyn?= =?us-ascii?Q?Q46StgUVBn40KbUEa03q7Bgw0O+aNWIBZGlqNVtV3T7YON6o4R7cOZvCM+zc?= =?us-ascii?Q?zGebMvdezvMTWU43RZlXNQRCgsV4esOKH8J+SNbUSxa1CV4PNzq2e9e2atxJ?= =?us-ascii?Q?SgSJHCFrmpE1i+ybj/0/Xto8mPk8PWIxCPbE9+1p48OgzRx9kRO1MAcXbf6X?= =?us-ascii?Q?yw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27954238-8852-48ec-0aec-08daf4b86c69 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 16:16:55.6017 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: F2sKYlCWtDlTPSZ6X5QUuUQZPcyHjj8dZGM1MaBzuCtwe0WI3gPNfgGRkaEYaHXoEJuBzVVeYvbzDIuXcbSLEAhFVWkhlbmrnXf61zYewIM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5869 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, January 12, 2023 3:00 PM > To: Akhil Goyal ; Ji, Kai ; De Lara > Guarch, Pablo > Cc: dev@dpdk.org; Tyler Retzlaff ; > dev@dpdk.org; David Marchand ; Dooley, > Brian ; Power, Ciara ; > Mcnamara, John > Subject: Re: [PATCH] crypto/qat: fix build >=20 > 12/01/2023 14:22, De Lara Guarch, Pablo: > > Hi Thomas, > > > > From: Thomas Monjalon > > > 12/01/2023 11:32, Ji, Kai: > > > > Ok, a long story short, this issue should only occurred when > > > RTE_QAT_LIBIPSECMB is enabled. > > > > It was intend to remove Openssl lib dependency in QAT replaced > > > > with ipsec_mb lib, but the work was partially done due to > > > > limitation of ipsec_mb by the time (FIPS certification) > > > > > > > > I'm happy with current fix and please cc: stable@dpdk.org > > > > > > I'm not happy with this fix. It is a dirty workaround. > > > It would be better to have an #ifdef in ipsec_mb. > > > > > > Also I would like an answer to the question below. What triggered thi= s > error? > > > Is it a new thing in the lib ipsec_mb? > > > Why defining AES_BLOCK_SIZE while IMB_AES_BLOCK_SIZE can be used > and > > > have a proper prefix? > > > > Apologies for the late response. > > > > This macro was renamed to IMB_AES_BLOCK_SIZE, as you already know. > > The problem is that, for compatibility reasons, we had to keep the old > macro as well. > > However, we added a compile time flag to remove these legacy macros, > > for exactly this reason (NO_COMPAT_IMB_API_053). > > > > I think a solution could be to use this flag in QAT, so the legacy macr= os are > not defined. > > > > I will send a patch to fix this. >=20 > OK good, so we can reject this patch? >=20 Well, this patch is merged already, but mine will revert it and add the new= flag (pointing at the other commit to be fixed), so that should be OK, right?