RE: [PATCH v2] test/crypto: skip plain text compare for null cipher

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

Hi Anoob,

> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Wednesday, November 10, 2021 5:01 PM
> To: Anoob Joseph <anoobj@marvell.com>; Akhil Goyal <gakhil@marvell.com>;
> Doherty, Declan <declan.doherty@intel.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: Jerin Jacob <jerinj@marvell.com>; Archana Muniganti
> <marchana@marvell.com>; Tejasree Kondoj <ktejasree@marvell.com>; Hemant
> Agrawal <hemant.agrawal@nxp.com>; Nicolau, Radu
> <radu.nicolau@intel.com>; Gagandeep Singh <g.singh@nxp.com>; Ji, Kai
> <kai.ji@intel.com>; dev@dpdk.org; adamx.dybkowski@intel.com; De Lara
> Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: RE: [PATCH v2] test/crypto: skip plain text compare for null cipher
> 
> Hi Anoob,
> 
> >-----Original Message-----
> >From: Anoob Joseph <anoobj@marvell.com>
> >Sent: Wednesday 10 November 2021 13:04
> >To: Akhil Goyal <gakhil@marvell.com>; Doherty, Declan
> ><declan.doherty@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> >De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> >Cc: Anoob Joseph <anoobj@marvell.com>; Jerin Jacob
> ><jerinj@marvell.com>; Archana Muniganti <marchana@marvell.com>;
> >Tejasree Kondoj <ktejasree@marvell.com>; Hemant Agrawal
> ><hemant.agrawal@nxp.com>; Nicolau, Radu <radu.nicolau@intel.com>;
> >Power, Ciara <ciara.power@intel.com>; Gagandeep Singh
> ><g.singh@nxp.com>; Ji, Kai <kai.ji@intel.com>; dev@dpdk.org;
> >adamx.dybkowski@intel.com
> >Subject: [PATCH v2] test/crypto: skip plain text compare for null
> >cipher
> >
> >NULL cipher is used for validating auth only cases. With NULL cipher,
> >validating plain text should not be done as the PMD is only expected to
> >update auth data.
> >
> >Fixes: e847fc512817 ("test/crypto: add encrypted digest case for
> >AES-CTR-
> >CMAC")
> >Cc: adamx.dybkowski@intel.com
> >
> >Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> >---
> >Changes in v2:
> >- Made the skip applicable for in place also (comment from Pablo)
> >- Re-organized code as suggested by Pablo
> >- Made same change in test_mixed_auth_cipher_sgl (comment from Pablo)
> >
> > app/test/test_cryptodev.c | 63
> > ++++++++++++++++++++++++++--------------
> 
> Acked-by: Ciara Power <ciara.power@intel.com>

Wonder if this patch needs to CC stable, as it's fixing a commit from 2019?

Apart from this:
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>