From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BB77A034F; Wed, 10 Nov 2021 18:16:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EE1534114B; Wed, 10 Nov 2021 18:16:22 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 7A4674114A for ; Wed, 10 Nov 2021 18:16:21 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10164"; a="231440128" X-IronPort-AV: E=Sophos;i="5.87,224,1631602800"; d="scan'208";a="231440128" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2021 09:16:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,224,1631602800"; d="scan'208";a="501487212" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga007.fm.intel.com with ESMTP; 10 Nov 2021 09:16:19 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 10 Nov 2021 09:16:19 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 10 Nov 2021 09:16:19 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 10 Nov 2021 09:16:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dl2fqosTUJTAZO8afaNbJ2IZShPEO0DsSwBDCaP48yX4K+GgmIeYYj51dEiojDfXbTdGOcoZsolWoZ0G/FD3w/ISDdC4qMgMxZP9tvUURWB9scieSP0mTe4Cj5GfSyPK3Mr0+WrQOExMwfVXpj/BOWdpgN14laOVdzehU/pBJ0fCsm5vGK5Bdfh3ztMEjlXw5VMIMqWSEUL+ttRKzr8/KjYrseLCfri6Fg3oF7bXaZcg+s6IVBwfhWh7h5jNPfebnxhQoKsgHIA2rk3EeNCp5jSjJ4zxbe1s3FSnlRU5aXZjrjKqnzS/XfJjuvm+XIXLnn9QlqOdUrmKjr+Xuiwr8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L/3gkntbmJxP7lCofJCKduc/1sgba/f9P5/6VZUIkCo=; b=jdWyurkdQsmhUhsGeUX23X7l2iGs5InqGXYWIhFo4F2dUMqv1Awe6MpAWPF0Y6hMS+dDqGkEVeq738EzMXISm1RMBbe4VkQQd+dmmb4Y5MEHx2w3B9LBATpbaeJzFYMASpf4KwwwCIbUXfdMNb3AR0lZzOyECDJ8fhOgyPY848jP7uN7+p+FLrwjgOehn5e/cmSBATxpZj1VU2BcZSWhyovfXjrU+otQt5eBLgK8P4JjhtgKSahD0/atdP9aMqCJZK0PrrmLarKmjIi5D+l7xn88tyZ0Bt+Xk6EnIWO82xEVmeAZz2eq+J7Lf8qyCLkxjKrZIlcRlEUO2Wbd6Y16Jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L/3gkntbmJxP7lCofJCKduc/1sgba/f9P5/6VZUIkCo=; b=yIf6yyg7spJrM9xYYpiW2mA8EP365qUT+RFZvNueAddQT+vf4yB+ls8zc15xpUPe0YkH1aMa143AJdWAlgphtfaSNm5G7gIxgmO1D8CuCwf0C/eg5ER/acwg9YWtSeGXc1sn1MjjTrWS1Q75S7MqxlA0DZPv+SFA7qB6nftUyLc= Received: from DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) by DM8PR11MB5637.namprd11.prod.outlook.com (2603:10b6:8:33::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Wed, 10 Nov 2021 17:16:17 +0000 Received: from DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::3d47:b590:aa2a:d5cc]) by DM8PR11MB5591.namprd11.prod.outlook.com ([fe80::3d47:b590:aa2a:d5cc%9]) with mapi id 15.20.4669.010; Wed, 10 Nov 2021 17:16:17 +0000 From: "De Lara Guarch, Pablo" To: "Power, Ciara" , Anoob Joseph , Akhil Goyal , "Doherty, Declan" , "Zhang, Roy Fan" CC: Jerin Jacob , Archana Muniganti , Tejasree Kondoj , "Hemant Agrawal" , "Nicolau, Radu" , Gagandeep Singh , "Ji, Kai" , "dev@dpdk.org" , "adamx.dybkowski@intel.com" Subject: RE: [PATCH v2] test/crypto: skip plain text compare for null cipher Thread-Topic: [PATCH v2] test/crypto: skip plain text compare for null cipher Thread-Index: AQHX1jOjKHqwi4rAmkSFyLHaDUqq8Kv8/IcAgAAEE8A= Date: Wed, 10 Nov 2021 17:16:17 +0000 Message-ID: References: <1636384791-157-1-git-send-email-anoobj@marvell.com> <1636549448-643-1-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c802fca2-faf9-485a-bcde-08d9a46dcebc x-ms-traffictypediagnostic: DM8PR11MB5637: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1303; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FTFL1L5oLYGyBHZiQqHrXKTL2tO9q0sCPhxChSlqIbx0qp8OHQsY2E7+gxepFmZEh0+16uZEK6V19gCbtqqlJp6PjbUd7tW9esDxN2QqJhheBpiCxf1yuKbJFS+AN/Z2D3UMpDLsC07cnek9An1PLsR4VD7+qFVJaQAU26mREIZ1nftKnw3aCnJq5b7RkrG0vGs7gZNZsq/cVSXwI4wnUoLWkSXEVyyMyYFHSJ03p1m6ilzgsbMNNCSgByKSofkX6CrWlpssPiH1b737VO5fjp3uadpACNSq/xKbn3nLUY5Q/vyTiMgIQYT80Em+KfDj553q4SBBN0rs6RQ0/X9GvlutOqjVc/qSv2gvLc6QpbBQRo+XXElW6uFJh6jlq1tKB2Y7TrHn7rMeAk1xAKfJ9Ot7CpCuGEQ8r/Rnqytek9F23nAAmkPRIa13jxDxnySQfbfx9IUwIxbq+aWs3ttp5ONK/0FwkOPl8HGvcMdMvHLwaK8dFu0leCauNUIqrpU19vr1QTrU+5ooDlRRr8Q4xzJkRQF31NKoqarpuimFXYfTc7Z3jITZ55Rg3QCnaqYtVzeyRC5m3ZvDaxMH+m28zdBYwp0FQk/3a6X4VMfBFkgnBFvLs9NXL0zzjkn/iLjnEbtOJcsCabKNsJe3cH7CulzNJH5xacp/26lAjW1uGP5dsHlrmDVu/W1mDtFKagsGsbalEgmq2523wDGLex+qSQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5591.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(26005)(186003)(66446008)(55236004)(76116006)(38070700005)(7696005)(66946007)(64756008)(33656002)(6506007)(71200400001)(54906003)(316002)(508600001)(8676002)(55016002)(5660300002)(4326008)(8936002)(66476007)(66556008)(110136005)(86362001)(83380400001)(53546011)(82960400001)(52536014)(6636002)(9686003)(2906002)(107886003)(38100700002)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?s6d3pzR9d3t6etaxYWvsHSwzq4GiS6bN7fd/eJDiiSHJVCa8EsPj4iabZBux?= =?us-ascii?Q?IFet1QPtvWV2EoFtAtRi6h75gMsdOEgGHSvBwesSv58vW3bHO4bvCAMFwGAA?= =?us-ascii?Q?H2rUvPjoXy6vo0AHegbeQQq8vG1mF0cDMVp2K8MlgplRl6UlGBzGZ5uMQPlt?= =?us-ascii?Q?OUiAIsTRbDub9z7F7fHm1qnX0sbOX6lArPzoedY5fcID9UC/x4o+XkP6CWJd?= =?us-ascii?Q?54iPkBEzJSYtsadbS7s5fMHQOr3GOekUHjkCj33YJfBNkNwqUXlVgLDAxtzN?= =?us-ascii?Q?4Fydyu7WT3wIhm4g8aghFkjmQAXKAUNeTe7PNKMpwsSnpDMdxMZ/51xF2vTw?= =?us-ascii?Q?+EtK+tSXpGTMgrVFweuvdMEapv4AwgA2Ew5anp16pFo3gYg6FfmoerCBaj+7?= =?us-ascii?Q?cJuJ3Xa9u/i2TIbSAeCa0rQ4IrGOHUTf+oNOcihaqZ9c3HI3Z64BMetkUcSp?= =?us-ascii?Q?wV+v6be3JXBHGQoZutN2KIlv9UpdDMbYwLobJ45g6DskrjrCcpCQ9XynUCFr?= =?us-ascii?Q?RlH7eDP/uQfwPjJXU6kpS1SE5kSROmDYRs3JhfVPMJjJaoPW4Qd48pMWep8y?= =?us-ascii?Q?/qkxXvRgg590B93WlyqCkKajQR5vnVXR/MXNdci6xDoNAso73c313n5QH+tZ?= =?us-ascii?Q?ZYKJbYtIRzokVCzwEesd6HYAbG/djjoMJvt5pUBpxshn18+hPUNlrc412xVa?= =?us-ascii?Q?bmhmDy1iQfMKZPlyFidjBs75E0HEUu+1/+YuiiFPkgoesduOSO3zIeu5VA79?= =?us-ascii?Q?nyjKmoRPQ6UhAIFGJUp8wBCVon5EB/Xk2vyhmzbujfmTXKbaltCCG9G7tCik?= =?us-ascii?Q?MvP+fNAaz3rBxCHLl+R379UEOgkxc7nbzZVJxrhl5w7O44CQrgiPOwI6WIaZ?= =?us-ascii?Q?neoonnIPNb7d72QB+1k7tVUagAbZ+SE/brBHiWgqkomNt6g0NfeEYyZWLgkt?= =?us-ascii?Q?gxtl2+i1keIdxZDqlYeyZAYdxaJS5EWaqXXjhHyB/NDDGTeD/1Grw3SvW3Zd?= =?us-ascii?Q?Xwfa4IwqxSTS/zdO+zRAn/8jEx/kcrFsAJjWvuE3lwjgJVFh0hQjYv4cO9yY?= =?us-ascii?Q?UsKit7TPfP9b5fr4+8g1vPxz26J+g5grNQm9gIDb4utz4VdReI1wTTOHdhRe?= =?us-ascii?Q?tgxuQVTvDRoqpzv7pyfRri9BR+82tP04lI3JdmcFmvDhoLY1TnbduB50Dror?= =?us-ascii?Q?V72L8GZwigVvSo5RAIUbEP0Ukj3Ck8X068LFLJ+Ng9qJz8kbQSJ37SuAvQS1?= =?us-ascii?Q?dNz7IotXhaNcHpVi+W8XYioGAheiJVDjfuWP2Mc9eNLH/+vO5PmNBnRanr5a?= =?us-ascii?Q?ExFH+8qrE3sV2WLOMBSIK+DQxoCb80WKdtHl9HJP/YPwlE2tbqV7xLGlH/6L?= =?us-ascii?Q?0efv1T0tuMksL10UZsM47vZFA3Wj2h6QbY6i8hFPO/IPPHVCkiEeQLhqyWs2?= =?us-ascii?Q?xZfzf3Y1OD1jxMZ/ffdQfOFUIXGdHryhxT/chcQRi7Oh4a0yF6ipKQkIGFSi?= =?us-ascii?Q?IklACiCBpiy97rVSEtrLcke8uw/o5SfZg9mGpko9hwJXqDDYDBh2yiZOrbuN?= =?us-ascii?Q?90dC32Wqcxcq0mRL3QxRRYMJimkbQP6hcx40z5oPY1qdZOzTWFDMMx7uepW+?= =?us-ascii?Q?ecwsqofI8Fb9a7S7rhn3uX5sI1Z04R284/oq+iuEdrZOU2AidOUJNR3MBaYQ?= =?us-ascii?Q?gq9p1A=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c802fca2-faf9-485a-bcde-08d9a46dcebc X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2021 17:16:17.5217 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VZf1f/8opG9VEQk2qJUylEAHpOP9LdN1Epp7kE2anCQR+nCS6VOLehDafjc+xU2UPmcoA9alB3LdWrWUbKa8AevSeJwBqb4PGr3b34cnlJY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5637 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Anoob, > -----Original Message----- > From: Power, Ciara > Sent: Wednesday, November 10, 2021 5:01 PM > To: Anoob Joseph ; Akhil Goyal ; > Doherty, Declan ; Zhang, Roy Fan > ; De Lara Guarch, Pablo > > Cc: Jerin Jacob ; Archana Muniganti > ; Tejasree Kondoj ; Hemant > Agrawal ; Nicolau, Radu > ; Gagandeep Singh ; Ji, Kai > ; dev@dpdk.org; adamx.dybkowski@intel.com; De Lara > Guarch, Pablo > Subject: RE: [PATCH v2] test/crypto: skip plain text compare for null cip= her >=20 > Hi Anoob, >=20 > >-----Original Message----- > >From: Anoob Joseph > >Sent: Wednesday 10 November 2021 13:04 > >To: Akhil Goyal ; Doherty, Declan > >; Zhang, Roy Fan ; > >De Lara Guarch, Pablo > >Cc: Anoob Joseph ; Jerin Jacob > >; Archana Muniganti ; > >Tejasree Kondoj ; Hemant Agrawal > >; Nicolau, Radu ; > >Power, Ciara ; Gagandeep Singh > >; Ji, Kai ; dev@dpdk.org; > >adamx.dybkowski@intel.com > >Subject: [PATCH v2] test/crypto: skip plain text compare for null > >cipher > > > >NULL cipher is used for validating auth only cases. With NULL cipher, > >validating plain text should not be done as the PMD is only expected to > >update auth data. > > > >Fixes: e847fc512817 ("test/crypto: add encrypted digest case for > >AES-CTR- > >CMAC") > >Cc: adamx.dybkowski@intel.com > > > >Signed-off-by: Anoob Joseph > >--- > >Changes in v2: > >- Made the skip applicable for in place also (comment from Pablo) > >- Re-organized code as suggested by Pablo > >- Made same change in test_mixed_auth_cipher_sgl (comment from Pablo) > > > > app/test/test_cryptodev.c | 63 > > ++++++++++++++++++++++++++-------------- >=20 > Acked-by: Ciara Power Wonder if this patch needs to CC stable, as it's fixing a commit from 2019? Apart from this: Acked-by: Pablo de Lara