From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56BDAA04FD; Mon, 4 Apr 2022 08:57:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD98140698; Mon, 4 Apr 2022 08:57:17 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id ABC124068C; Mon, 4 Apr 2022 08:57:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649055436; x=1680591436; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=rqvNsz/SPKNZI4JyOQccNgXDsXd6HKmK8EmJWPL7S9E=; b=mvlbotAeD2ko2wXwaMQVKV6nVVXQoDNTSZFLvyQFYW9QeAafimq6uRRN 2dIPvE8jPs0jxGsEZqoFTocS1uye7qn847pNje3vq/KOaZSwQkkcIYGuY 4oMiXCGgYRV5584ncmBGai7TAx6I4TLy1TQTzai5Igy7/D2mSkKXQRclk 1WQEwBxh3ej76W/kbdMwVbT0D0UYQXmpuYQNid4re7XM8i4eG4sLH160A Hs1xWOcHSKYClNWeo8Udj7WXnONTl3sE6eK+O0DkyVUbOGQOca7NCTZlq MhUc4Fa2Z4eJsRZw08cDnSCRa0aC/Te005EJAXszEF/lizgKtowzTGkpZ Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10306"; a="260150749" X-IronPort-AV: E=Sophos;i="5.90,233,1643702400"; d="scan'208";a="260150749" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2022 23:57:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,233,1643702400"; d="scan'208";a="696475725" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 03 Apr 2022 23:57:14 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 3 Apr 2022 23:57:13 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 3 Apr 2022 23:57:13 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 3 Apr 2022 23:57:13 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 3 Apr 2022 23:57:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lszj5Z55LEiE0ujr7/IhXY4wtkYR/O+mkHUPTKYbqZsqQzXW9QpJx0gCrFyE9eVDy2Hig9siQKsao8Ov8bIxWCF3WpAoC3mZlc3S1zzl0bV3HFZ4F9LSbOkxWMByrwGeU7YIBpFf/f60NacEztVa3TVUCi3CbWE1S/qRLQvlCYxqa/4MQNEpgUvUuWBFMWsJGgt/8W8LP8TwD2w73oEUzop5+hnvC0ZGwWimBsByAGPnIhDU2n0G/K1NOUuOpCAypm6l4BPn2ZFgUYmunnrRsDj0bYJWofvZSsWUXLJEyj+TVq35y3AUBnyQMcD/oHFhlqvzZxiy3+3HAvmTIXZgWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MRweY+bLWLEVMkmk5VKlPeWVr9Tvc8j0YZC5zsqwBAE=; b=i6xJTW12vt08Rb7JfCHuYVwMFQ9N4PP/1ZcnLvP+LLccd6FPilbH4pmGNPHAujbBEGa0gHaW3KTl7m/Ql4tYgzB+0i558nFgQNKVJqwv0pricHLn0hk4DsvCaK2FJprJf5Xp6Li+Bbn8UlpkVS5Lk20NRxnkUV/R1QXX4kvOMp7bVC+sSAY0TGXutqmpq5dK6N1BCIf83nd2xMf4RND/xW3Hx5jtWiCyjG93+APYp+hFLXD5vASaeDeJqArO20377K+Afj/Iim6gcUZj6YkHpDYu+Xxr09WEk5FeXc6uEcDzFFvw45YBdUw2pTExR7xmoG8dnut7A38/mb5XgxjL/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5605.namprd11.prod.outlook.com (2603:10b6:8:26::11) by BYAPR11MB2695.namprd11.prod.outlook.com (2603:10b6:a02:c0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Mon, 4 Apr 2022 06:57:10 +0000 Received: from DM8PR11MB5605.namprd11.prod.outlook.com ([fe80::492f:8764:2004:681f]) by DM8PR11MB5605.namprd11.prod.outlook.com ([fe80::492f:8764:2004:681f%7]) with mapi id 15.20.5123.031; Mon, 4 Apr 2022 06:57:10 +0000 From: "Pai G, Sunil" To: David Marchand , "dev@dpdk.org" CC: "maxime.coquelin@redhat.com" , "Xia, Chenbo" , "Hu, Jiayu" , "Wang, YuanX" , "Ding, Xuan" , "stable@dpdk.org" , Patrick Fu Subject: RE: [RFC PATCH v2 4/9] vhost: fix async access Thread-Topic: [RFC PATCH v2 4/9] vhost: fix async access Thread-Index: AQHYRD3j49/+prTYREiNfeu5Xk5MjazfTnrg Date: Mon, 4 Apr 2022 06:57:10 +0000 Message-ID: References: <20220328121758.26632-1-david.marchand@redhat.com> <20220330134956.18927-1-david.marchand@redhat.com> <20220330134956.18927-5-david.marchand@redhat.com> In-Reply-To: <20220330134956.18927-5-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 311c4529-6533-42d2-41ab-08da16085736 x-ms-traffictypediagnostic: BYAPR11MB2695:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Y4FfJcBdBBsQD24j/HcNCBilHhK80StBj5KFpPidpMg7+0aYpyuhBqgE1VSIJRKVRYb12fpMC8qwtQpWbfH1BghzeaxWpvXr4xKojAnVtwTk87Gkj3uGjMFR4egT+MiuXE0QJ7cNCJlJs+9zrZWcxzhbM/6UbdQTZlyQvHUbwl6lu9DdzokALvV+GjvfoqGgbZLcAIQQmaAFo6hIaBbqJWviRRcuzi9aMXCnhvlNG2F+Ju/DOmzfnPegnwRD/IMjGFNWtxN7xqUedOOhcVOPKcc/5qIAnm0HU1DUtEXRjwnGq85RK8HC3PP/1YhcA+TviEXh6/pQtw1Q+R2lS7mNYnUSH1VjVIhL20nU5fF4i5IqLkRvJIxjg3QQH7iIjnb0Cp5II1I6SQD8oFlFFWatRM8epp8B0XNq06g/AEVLiPfKKkZMSXbrdHuqpgbpsYjcdj2OugADZqzNAlgJXyj3f1K4FO/nUi/hYjE0uGzjxXfFzMylcRIzLYlsJiHegT23HYixHh6Q9M98Nt5I6Ku1beV55WDgfeJ/iAJpnJTltc2CgunyfYXvlmGYsX1XOJotFMRs8xNRQnNCcEjnDLOaMJyog6M/pwXpab1ha5Vvks5dje4g5KdhmXHLcezfeQWpSkfGZrKmW/dvQnruJLSLz2dMNcmrhPHNN1n6ADDDheEpjgonrJWbICo/tememnR8jawYBzJSpCTSBOmesuON0A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5605.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(82960400001)(55016003)(38100700002)(54906003)(86362001)(9686003)(110136005)(53546011)(107886003)(6506007)(7696005)(122000001)(5660300002)(2906002)(316002)(33656002)(4744005)(8936002)(71200400001)(83380400001)(38070700005)(76116006)(66556008)(66476007)(66446008)(4326008)(64756008)(66946007)(52536014)(8676002)(508600001)(186003)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YB9BgIGXyFCPDZJzh+zIBKkenp18Ez6F/FouT10Lwo0QWQsjjqI5zADKvJkk?= =?us-ascii?Q?uF4nJJnAwpw3TN7WE5U19tJNmC9LbfajtoduliIOco/HoBE4UIHqmApXRdD/?= =?us-ascii?Q?G4959Aqrq7M9nooKITX+7nyNsXkk602huspFXwKwCkIAG3art9YJonL5H2Dz?= =?us-ascii?Q?oprFm9HPygA1V3tlVy+qRsZ+eVBfy9+BROeJFjfn7VmoosX+fOL+nGAnCOFK?= =?us-ascii?Q?Ei5CSz8bMPdcZA25FFpxOLCKb+ZYQQPPg5R3Ki3xboGH5x+iakIeKBUNxWwS?= =?us-ascii?Q?lTBrJQf9FX8br1F43bAFGj91Vt8rQKwCDLS13xcyWZZN0AdfVMMwM1Jrz5ik?= =?us-ascii?Q?F5HYZpFsXVB3bQKqp/WageekSUiVPTNxIYKJ616SzfY6ljBY1eVdesNmvZki?= =?us-ascii?Q?siPKH4SLSvVSYF38gYQ/GIFoXFOP9PLOeVeHPs89xeGORYaNc7zQpNNygIVR?= =?us-ascii?Q?qdNnZqS1KMtrn27kgFPhEZOB2+52rWOMtAwMF7+eFfTE1qRz2sG980XGlzKm?= =?us-ascii?Q?hg8/OgiYoyWeELKx7Mu/zYLfXnLV1VJUrzXhU+k2H+OjnNt1gOL8SFuyoc9l?= =?us-ascii?Q?bEg0PCnKWPLnFvQ/HGAmUDKIKzoVjjj3ZTSniGn+GFo69MR8qoCpitbyLbvz?= =?us-ascii?Q?m92ZJF4hGS2qLYkZNtMzqzNsIFb8XICBF0sH/xv8cWXmWFIwL0c3yFU+YS2K?= =?us-ascii?Q?QMAIgOwRuy8WEsWt+LWBdMABPlCOqDXmnpERvBwager8u5iaL/VQWyKMfr0o?= =?us-ascii?Q?w6cnVJ9ECr6xlsHJzQg9bUyh0kgLUbTW5gjslcBeIemhBs8L4U8YK2QLTfGy?= =?us-ascii?Q?zuy87z/mKOnHPTtXLSOwj8U9qxCRgjT+GIMa/fAAbvaqnO8ssrqH3YNGL/kl?= =?us-ascii?Q?SNXkEyWmFhNaVWbL0J5H6e/Xh+AmInxiiQ0SYSUT9HobvDC4hX83O4MzUBTo?= =?us-ascii?Q?hl1dSRJQLFDiqtBbFn7RPPb2JWDkGklHMyjX3tcU4jNBFm2PO+4aKSzcMxre?= =?us-ascii?Q?Qh831z8uWMUqOC3rdGLukl9o//c4ntVcYZNAFUqwK8qJe6WTGVF/5rSOCd3h?= =?us-ascii?Q?D/taTOdGBh0FaWU1KLNsvN7xSxVU9HZ8J35fCjtIUcFDu1inD/Kg/9E0bFg/?= =?us-ascii?Q?wf2+vEWuUYGnuoALPzxcWcK1Oa0pf+9Q26P50esMCa1aa8oS9c0yMssriMxA?= =?us-ascii?Q?N5cqhi664LvbrGHHuINkKc+whnnminq4eYuGopBVFoLE9BF+uQTwEyy9T9PH?= =?us-ascii?Q?GC+iH2OZewXunxlNcNNZPIK8Al1/hpHUn/4pK6hRhRKESavdBuVGpMxNlmbT?= =?us-ascii?Q?qooaMF9N0TrI9Hoeq7p0Ey0aBDT+dU+k8MFSIP4r9HmlU0K+caXKNd6o9rEe?= =?us-ascii?Q?GYNXUO9JKsa/Z3r+XyXxOkD/h4w1HjBm+wG/NlB0c0h/QOCBL336M6gN5g6W?= =?us-ascii?Q?PK/DeNqjamCqNJzr/hQVh8idq4N/pr/757OPaw6DzY9JLr0NbEPh/yVLQn4v?= =?us-ascii?Q?7nOqUebOXlHjO/V4FDDDso3pejscZdIMVzZI1yl4Ndn89hDY3lO4RkHu7Cpt?= =?us-ascii?Q?ovKDJlVpwMR5Typtz1yqQGKomk4mO9qwYoYy352M9XX25DjQFTa8KBnTlqCD?= =?us-ascii?Q?fjWwWYLfFVptcJ1TW5Uab6jjS1nFJtoeuvvxo1/YVKzvYlznn2QJ/BHDjucj?= =?us-ascii?Q?3uuFMLVS26N8cJ9dTzBccR9FSVkunFGiwV8pkX9KwhqqyCg2kYAhVKzLU4+x?= =?us-ascii?Q?PU9Qt4ESNQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5605.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 311c4529-6533-42d2-41ab-08da16085736 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2022 06:57:10.4277 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qp+gmWWQqv6HIwJdndRbeOBO0yJVOehJgMfRfGpE1GkUnYJ6lA39b6bMOrx/2azoL7HBGJs/6iIOKbOiCXf5IA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2695 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: David Marchand > Sent: Wednesday, March 30, 2022 7:20 PM > To: dev@dpdk.org > Cc: maxime.coquelin@redhat.com; Xia, Chenbo ; Hu, > Jiayu ; Wang, YuanX ; Ding, Xua= n > ; stable@dpdk.org; Patrick Fu > Subject: [RFC PATCH v2 4/9] vhost: fix async access >=20 > vq->async accesses must be protected with vq->access_lock. >=20 > Fixes: eb666d24085f ("vhost: fix async unregister deadlock") > Fixes: 0c0935c5f794 ("vhost: allow to check in-flight packets for async > vhost") > Cc: stable@dpdk.org >=20 > Signed-off-by: David Marchand > --- > lib/vhost/vhost.c | 25 ++++++++++--------------- > 1 file changed, 10 insertions(+), 15 deletions(-) Thanks for the fix, David. Tested the changes for rte_vhost_async_get_inflight, works as expected.=20 Although I couldn't test, the changes for rte_vhost_async_channel_unregist= er looks good to me . Based on that, Acked-by: Sunil Pai G