From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98FAEA034F; Wed, 9 Feb 2022 08:45:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1DACD410FD; Wed, 9 Feb 2022 08:45:54 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id DBA33410F3 for ; Wed, 9 Feb 2022 08:45:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644392753; x=1675928753; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uRFK2qdQBHX0Q5Vtx+Rx2p0xmquK0v4VkxWbR5FRBIc=; b=OzXodBixekI2fhrgDb/+wQ2LXF/3N6+4o+VjKp8kiKZRBBZvVf3G/em2 37lnteceyM8CCNyopcLRpg7p4v0XZcpaVBlxn4+eh390dDEQtP0VwXWdR dijLudQGsqBDHjZ2+hpprvg9SfYFPBV/OWrqzittnB9uOhJpsiyLhLxMM 34NCYtAC2gYpYBao5ZAQHd7NvvV2HwoymUwCsmpBep172FLUJDwJV6JZy uc0EAAJa0Hl1WSIsSV0NYR08DmlNZzKIKLQFMjjE+/oqyTWSij2QRFsFe 7iS/8RjP3gePFu9yVadAL7R64Yh+N1xwgiKgYMfQgFoa41oYGa3tZhlvo A==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="247981990" X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="247981990" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 23:45:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="536851112" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga007.fm.intel.com with ESMTP; 08 Feb 2022 23:45:52 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 23:45:51 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 8 Feb 2022 23:45:51 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 8 Feb 2022 23:45:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bqbt4qmj5zPORIVJrIiWtov8rajYQqkaMyZGDOVQ01oIfamplr1S+9XPtTG4g99Ec3HrPNRi7PT8z+ZTLLb3nIwaUj56ilojfE0wiz21gIIKtrI13nK/sccU4kLASOI108T9SbqtrlFJe2NR+x4G0OS5rn7j8szlGA0rRs96t1VfMUQq0vTv2hXWrwWhSdrFzYBvu2VoGT1ok5tt1U7NbWJ30t5UKiM+oebFX/2EkLqzvp9PBBaKKX4R7vfngvDZzun6gnxX+hgqwe5xyjhVd4VaV7GH6UdnaVWE+ri5T/Fy1wRbyEBqSmuGCdqG4izvqp7Wz6Yc3VU12bEhh4xgCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O3VT2mpRj0wEezpvNQhe5RwdoGqCe5y0gN87E36PwNQ=; b=LDO2/dz7yiJBQb4jD1oBClfOO8gAy2l4/bbs2Wa/2UbC0fjG/N56R4/XcaUksYv6FYxiuJOBbvFZ4rwoxBoxwwz6eolLdYDrh+ItI3czSHkvxAXArQk5aKjLz+HxpioUdflECV9Y3X1yjvRQXjsRd0vGhCXqWk+Yw28q8oxciUsjZ98N8oM2O0dqjGJFelIFDv9dbyvDSzcHZUX7N/0pUKvIzeRve6Z7ut9ubaWWVnn0y7zxR3lVrzSj2W6tS4uwXMR/A2Kv3e6b0yG93D50gRG0Cu4cROR/Oa26OAnr0eXwrfCg0Zmj7x1hnGeL62yYttZ55BuOuGJfMgJIdarsHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM8PR11MB5639.namprd11.prod.outlook.com (2603:10b6:8:24::15) by CY4PR1101MB2232.namprd11.prod.outlook.com (2603:10b6:910:21::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Wed, 9 Feb 2022 07:45:48 +0000 Received: from DM8PR11MB5639.namprd11.prod.outlook.com ([fe80::d9b6:bef3:b53b:49ad]) by DM8PR11MB5639.namprd11.prod.outlook.com ([fe80::d9b6:bef3:b53b:49ad%4]) with mapi id 15.20.4951.019; Wed, 9 Feb 2022 07:45:48 +0000 From: "Wang, Jie1X" To: "Xing, Beilei" , "dev@dpdk.org" CC: "Yang, SteveX" , "orika@nvidia.com" , "Singh, Aman Deep" , "Yigit, Ferruh" , "thomas@monjalon.net" , "andrew.rybchenko@oktetlabs.ru" , "Wu, Jingjing" , "Zhang, Qi Z" , "olivier.matz@6wind.com" Subject: RE: [PATCH v4 6/6] net/iavf: support L2TPv2 for AVF FDIR Thread-Topic: [PATCH v4 6/6] net/iavf: support L2TPv2 for AVF FDIR Thread-Index: AQHYHMdnnZ4HoFji5U2UHjHppfagcKyK1FgAgAAD3EA= Date: Wed, 9 Feb 2022 07:45:47 +0000 Message-ID: References: <20220129062434.2455711-1-jie1x.wang@intel.com> <20220208083849.510136-1-jie1x.wang@intel.com> <20220208083849.510136-7-jie1x.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3fd276b4-e44f-4b70-f408-08d9eba02fe1 x-ms-traffictypediagnostic: CY4PR1101MB2232:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vHEQAzTmZGQF23slu3PlVNUw5XRiuVC5zaSO+uOWBSD7/fHFxPwg71qmD2WdkCvVrYUw8yJ+AzWH33JgmeqtyzMz9uOPbf1vWjpxM7OZLq3eeIugiNdwuO0V41baEt7W6JLYlYh+I8dp1cQ8EDbXol9Ws0QpYo203+KT7VSm6uE8mZ9LXdqx0Xslj2NTgDp65vMrmvBYHTbP1G3Ze82R8zSSLmSPoaxeTD5DhogoS/PsYpthldV+Y7FEGncqYqbQnZLNImWeAExl0jGu/Zu5+a64Qn1N8IiUVpxJW7RlJ2mO5UrduU1en54bzAPjElPaFbrhsDcC//bhDPznvlsjOcK1J9EMpIfnI8OTkuImb3LWP1ieTboyW78jL56hYE916LBKAry50vKVtGGJRco2wGdgpuFDeu4TpTRQJ/ZDjYB5eU3NxyVC3jB18UaQOGrWkoMyDD+LdKgokIseRbkLvsVEJpTbNDhy6MC2vfgb0XvJtjWYFogZjyxm/8eUpUVduCMGZlsi5B7xV/Ub7evzFNN+2XRtwWssiqfgH09WIP4yP1Z6gKT/dWsfRWDllzKTV11CPDeUp4FIyCkR5rXAqE0Odqw16Q0z0w3BFRxnjGFlb5pDUdqOMu2PCedyOeHUJWhVv6BQE33QQggo/R8LnpgecpC1DGMoDesHEKNeWzCeKqTPr5Odz2baO+0w9K/8f4UcyOw2zL3S+zcW7crhFg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5639.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(52536014)(6506007)(5660300002)(82960400001)(38070700005)(83380400001)(9686003)(53546011)(71200400001)(7696005)(38100700002)(122000001)(66476007)(33656002)(316002)(8676002)(110136005)(54906003)(26005)(508600001)(8936002)(186003)(4326008)(55016003)(86362001)(76116006)(64756008)(66946007)(66446008)(2906002)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?whqUW6KIov6ZlOSKSEat1HpwfwMvNvDU7PvQuNHGBA2+xldaDL8uUdNmHEZU?= =?us-ascii?Q?6gea/z/+zmC/tBU3tXBEu12ugztREC1Gkf2LzHwADKP9iU3KwTKvetuN8O/k?= =?us-ascii?Q?ADVKe3gCe10Q/IS27TvtcHH/6uAVbdBRuNj8ZT1Ww4IPHf156htew7nee73a?= =?us-ascii?Q?UqPF4X9zzJVYAaChpsXA79SVJ5Z24SnrMFIOI8k2f5NPHuXcohQQ9mq2mtyo?= =?us-ascii?Q?88XxkT/YzsaNAJ21RLb5UHz6euEd8SKTmiHBzkiEX9ag/sUm7m/AybMSdud2?= =?us-ascii?Q?4TVCmBS/Y2O4SfSmNuDRIuQE8otCcEVk0tSbavziOL6JSoXaUMD47dtBQEBj?= =?us-ascii?Q?zrbsWwPP5CO7RSHjXjnFimX5Noa5U5pM1KbCD5iKV/EmDMA4AVyuuukD5CnK?= =?us-ascii?Q?FNQdvhxcaHf3NB/JN+RLV053ooxAUVhL5tXqEycRBno1hcTXvA+CFwefZmEw?= =?us-ascii?Q?yOk3Y320WPjixVFJ9R2D1rabMblTn3RpcRElswBXCkJrZ4tdrk4+bFS3poAg?= =?us-ascii?Q?aiQ88//gysH9O//cAY4ydMxZSg4oZL/i45XdLQ7DoYcRdn4B4dIeILmZIxEu?= =?us-ascii?Q?MHn36k6ha1mJft9GE5oIfuLWJYAASMLFJGx4NCRk7PA1hIt1syK9hxlArzzq?= =?us-ascii?Q?Dupn1v+aUiaR+1tjCCCdEHq0GbLEEOnqZxz2uPXWypT8HIF7dlMELX+qkiU5?= =?us-ascii?Q?Y3MGHpAhlzd2lcAQ4MMQPGQsFcwyI/CxTW9cBAVo2peZOe0e52BW7WYX8BQE?= =?us-ascii?Q?i3l3fsqsjKq7kTW+f8b13SvyIE4SMNRSYg/pHHtRKHMTUUpeNN6j6KkNjzwH?= =?us-ascii?Q?bpz0s3ABy1udlqFhdIdYs5StYP8UjP1FL87YeHVG/MOb/fcqBZSr/eUFw0Lv?= =?us-ascii?Q?ac6znUAwsuEXCDs1BMBQrIng1w+yas5fTBuPVj/MeAHEOaH35cj/gh2z/WOK?= =?us-ascii?Q?unAHcovszK08MdPs/TNEoPL+RJ1c3DorHqF19JQf9vl4SdPx8H+5wY/fuq8n?= =?us-ascii?Q?rWIWD55LQg6IeHri068Ec9lH/G5qie6OsXgaESQvpatAnPDNtlyMTcT6KDHl?= =?us-ascii?Q?WhcwtxjRGIxxsVIlxETc+yV6LcoMMuyHKAj5wUrTqVEiBjoCjKhums1Bqny1?= =?us-ascii?Q?vFyWle79q1Oacg2zQexebM+KzvcJZ5sJeTW7blU/F/n7aDnDdxfoaZ/ILmDm?= =?us-ascii?Q?W+0GNsby+00YlnvpGoGVtktlXedE5PtF3oGDiefaMG6/niXc7bGruENZzhE/?= =?us-ascii?Q?d8zM07+lt38bCqVTpQD6JyOEyqV2sNVe2+22VusyOd+K2pLCceii72Q7SjZV?= =?us-ascii?Q?9/dDyBWDfd/hjT4baCyXJwezzEGtr7CibFo/jRPp+yGuaxhKgkyPtNY7FXfL?= =?us-ascii?Q?cazAMl8U4c6b6tI1ZwkpLmn1mBWPUzWXnRShUUPTZ9vahWPweVj2DgBhEcZn?= =?us-ascii?Q?Y5v+rUPe87gs1WJZk90XB/CkpRfNBywxW+9vk9s1J0gjl4v3yXFPpbGAu5O5?= =?us-ascii?Q?IJ4hJ7Mj3qdGavpvxW3+EUI01pMOScLnuWew3hDWkyhZVS3mpeYPqCYDy+UT?= =?us-ascii?Q?twMbxq6MQFgdvECcymLzMxrhPvim5qllBBTLr0Yhym1O808dY0aGAvxVfACA?= =?us-ascii?Q?yPusDYaOTsa1fBcLOgN2JFY=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5639.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fd276b4-e44f-4b70-f408-08d9eba02fe1 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 07:45:47.8705 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LTgLO8vrE3Dyv4kDbuBNjTV0cJsaLg5NZj2a5C46/4HoHaNYlZloGFcx6nXQjHH2/bro5BjEWvI8MqI53OESkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2232 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Xing, Beilei > Sent: Wednesday, February 9, 2022 3:31 PM > To: Wang, Jie1X ; dev@dpdk.org > Cc: Yang, SteveX ; orika@nvidia.com; Singh, Aman > Deep ; Yigit, Ferruh ; > thomas@monjalon.net; andrew.rybchenko@oktetlabs.ru; Wu, Jingjing > ; Zhang, Qi Z ; > olivier.matz@6wind.com > Subject: RE: [PATCH v4 6/6] net/iavf: support L2TPv2 for AVF FDIR >=20 >=20 >=20 > > -----Original Message----- > > From: Wang, Jie1X > > Sent: Tuesday, February 8, 2022 4:39 PM > > To: dev@dpdk.org > > Cc: Yang, SteveX ; orika@nvidia.com; Singh, > > Aman Deep ; Yigit, Ferruh > > ; thomas@monjalon.net; > > andrew.rybchenko@oktetlabs.ru; Wu, Jingjing ; > > Xing, Beilei ; Zhang, Qi Z > > ; olivier.matz@6wind.com; Wang, Jie1X > > > > Subject: [PATCH v4 6/6] net/iavf: support L2TPv2 for AVF FDIR > > > > Add support for L2TPv2(include PPP over L2TPv2) protocols FDIR based > > on outer MAC src address and L2TPv2 session ID. > > > > Add support for PPPoL2TPv2oUDP protocols FDIR based on inner IP > > src/dst address and UDP/TCP src/dst port. > > > > Patterns are listed below: > > eth/ipv4(6)/udp/l2tpv2 > > eth/ipv4(6)/udp/l2tpv2/ppp > > > > eth/ipv4(6)/udp/l2tpv2/ppp/ipv4(6) > > eth/ipv4(6)/udp/l2tpv2/ppp/ipv4(6)/udp > > eth/ipv4(6)/udp/l2tpv2/ppp/ipv4(6)/tcp > > > > Signed-off-by: Jie Wang > > --- > > doc/guides/rel_notes/release_22_03.rst | 8 +- > > drivers/net/iavf/iavf_fdir.c | 174 +++++++++++++++++++++---- > > drivers/net/iavf/iavf_generic_flow.h | 4 + > > 3 files changed, 156 insertions(+), 30 deletions(-) > > > > diff --git a/doc/guides/rel_notes/release_22_03.rst > > b/doc/guides/rel_notes/release_22_03.rst > > index 0d1e4a0b61..5a73ccc14e 100644 > > --- a/doc/guides/rel_notes/release_22_03.rst > > +++ b/doc/guides/rel_notes/release_22_03.rst > > @@ -66,8 +66,12 @@ New Features > > > > * **Updated Intel iavf driver.** > > > > - Added L2TPv2(include PPP over L2TPv2) RSS hash distribute packets > > - based on outer MAC src address and L2TPv2 session ID. > > + * Added L2TPv2(include PPP over L2TPv2) RSS hash distribute packets > > + based on outer MAC src address and L2TPv2 session ID. >=20 > Should fix in the patch 5/6. >=20 > > + * Added L2TPv2(include PPP over L2TPv2) FDIR distribute packets > > + based on outer MAC src address and L2TPv2 session ID. > > + * Added PPPoL2TPv2oUDP FDIR distribute packets based on inner IP > > + src/dst address and UDP/TCP src/dst port. > > > > > > Removed Items > > diff --git a/drivers/net/iavf/iavf_fdir.c > > b/drivers/net/iavf/iavf_fdir.c index b63aaca91d..2583b899aa 100644 > > --- a/drivers/net/iavf/iavf_fdir.c > > +++ b/drivers/net/iavf/iavf_fdir.c > > @@ -168,6 +168,31 @@ > > IAVF_FDIR_INSET_GRE_IPV6 | IAVF_INSET_TUN_UDP_SRC_PORT | \ > > IAVF_INSET_TUN_UDP_DST_PORT) > > > > +#define IAVF_FDIR_INSET_L2TPV2 (\ > > + IAVF_INSET_SMAC | IAVF_INSET_L2TPV2) >=20 > The same comment for FDIR: should we limit with source MAC? >=20 It is same as the RSS hash input set. > > + > > +#define IAVF_FDIR_INSET_L2TPV2_PPP_IPV4 (\ > > + IAVF_INSET_TUN_IPV4_SRC | IAVF_INSET_TUN_IPV4_DST) > > + >=20 > <...> >=20 > BR, > Beilei