From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A84CA0032; Fri, 18 Feb 2022 11:58:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3BD3E40150; Fri, 18 Feb 2022 11:58:27 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id DCBCE40141 for ; Fri, 18 Feb 2022 11:58:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645181906; x=1676717906; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=YDgRhReOtOUTu4UDX9FnIhSHMUnY0hvHKkYNAXjSmYI=; b=ZvICzXVruR19l14L5IRyAfWck6OrbKAc1YqzBETPXd7Nng6e+yA83v4p aHEG34QOvyJOkwoy3Ux52aVl+pNTRcvLEBKpwkEZM2MeUxs3OWiqg7oBG y3Su87pfKITcs8qyZVUwYLe6SmdiuHCWqZiicq30bTmu1stjBJxP2gfP9 dAVHtHcyAxDIvQQAftUZ4j9glc9c9w9jhi0J8hezir9us44eqelrRXRGC T8NOwoOLjDX7MAU7tkJ4eA1oBZGzMj5sE0exhcei2l4HcrWxVRG9WhNxc rsxTA1DMKA8st+0qsNl/8F/k3LxK8n0JdYq9RyMlh6ax01qbssQfO/cn8 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="275701484" X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="275701484" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 02:58:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="541869832" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga007.fm.intel.com with ESMTP; 18 Feb 2022 02:58:24 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 02:58:24 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 18 Feb 2022 02:58:24 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 18 Feb 2022 02:58:24 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H9vvgmyjwnGjAXb7X2+j1VtPixR037lNRKcG01hOQEo57V7KxrDBpK75qoMIhXZtG0KUK+5JbH6QCae4j6aklTv7RdzinS3WB0yq4xk4Xb3BWLfDm2NAvcPeTo0rZuPOmXS5lT6GteMEUXT4c7ugAJ4eDP5sbNfXZtkxmD1AbvYHCX1CLS7cAYBA2Lp1oGVj6PYkrr7WlWDlOddpzffvprcPVy1dynlQEdxaKsaNt4NwHEKOeZBhJ2qBnRkVGxZEwDSveRiwi8me4cs/wKwbpYlXeS6bhDIgx9yohkOscwezgYxMBe8F6nuGRpIn9UoCWbdxy/hAXlOofdG4irJ1zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bk1LX4hdcA4NClukhJCHOqhgsPSOkTcKmoB6Vt2B1rY=; b=PhrwWtXb7P45s+BnMfX1a4yYk1LZrSpQwFC8TX7/daKgUxEkwBArS8Grg3FTOo2RIpXayWd1rw43MUyNstcLsYfAC7kLkfMmCNGHZnEWEOicrMDLb3fIl/HSS4bRPJ7AyQ65esGVCS9d+1QwKR7U0PKk5QpLLNZqIIwzsiKXr3gCLR9EgBF3qdM+55quZsbIFXzZqzBfyYHmxJK8OXs6apybZIgl9wzp1lrWKpqdwnpRV29dd4HQEXviGcaQrfp3y0zASvqU//baRV9PgJgd7pKpielgqFMWjiqz9MvKPSF8LcYRsr/Y1hJ/omB12cOGGFSSAdcIRqoCAim2Ct0Xww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by DM6PR11MB3436.namprd11.prod.outlook.com (2603:10b6:5:65::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Fri, 18 Feb 2022 10:58:22 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e9b0:843e:2b39:6680]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e9b0:843e:2b39:6680%4]) with mapi id 15.20.4995.024; Fri, 18 Feb 2022 10:58:22 +0000 From: "Dumitrescu, Cristian" To: "Ajmera, Megha" , "dev@dpdk.org" , "Singh, Jasvinder" , "thomas@monjalon.net" , "david.marchand@redhat.com" Subject: RE: [PATCH v2 0/4] sched: HQoS Library cleanup Thread-Topic: [PATCH v2 0/4] sched: HQoS Library cleanup Thread-Index: AQHYJKsYbmkjmD+7tkqCgOxSfB7KVKyZI0mQ Date: Fri, 18 Feb 2022 10:58:22 +0000 Message-ID: References: <20220218093650.2549927-1-megha.ajmera@intel.com> In-Reply-To: <20220218093650.2549927-1-megha.ajmera@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a7835547-1e91-47de-3b97-08d9f2cd9474 x-ms-traffictypediagnostic: DM6PR11MB3436:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Tlz2Avo52ZYik+/opv1OVk1GwCrIwfcFMZIiHJnXK59GRRsKnw/23NGcW5LbvLmb4rDPKQzvKBd4EfOSl0dl76aISNOfmxSLsKziysmsCfWEVcUA2nPnv3ibAxGF91JC7YZvG8n9RZjk3T1wWuuiGVc5w48elNa7VShSGa338YTyzGdpMMuaFOhu0dC/lTXzGeOXi2H5/5YGzzOOF8aJBFRP2zgw8ky40ZDje8Y1HtvWKp7CKHNH0S8I/Ur172FWt2ElMzlrmC82x8ZoPbIQXD7N3+ZLVh4KbLDCdeL5uvNXCfzkHihVQjdnKf5vVgZTDKefUOhcCB3LUU0Insw6LioHhsRnNdp+pRBFrXnVK+DZ9q3FaSHgGNxl4o7UbtnC2pLJ8Jo3hJjU6wPKKK9GxaTANaO7I4pjYZVolNX1WaQPAtZ0pw0T411R2jwxIxv4LM3bw5TEkOY+4AbwTlEUr3dauTJYMDle6M091IFrIEykYeQeb2ZeEvkrAdl5Ph/27yBx45TQjaSDTP3n+WKA0T+epxluEojNr8or7De76zfeZirCOCaXdKjG/j9DuVE/dK7HYgPbg5rvZpRn52RjMVoO+agy9OIokSeU8wUJw9mJjAwpdUTT/c28i8RcBjyQDbzsxDcXG/TueQzzslLgtzPjneV/R31XIFoqA46G9UI9yQc+MNr+Wf6xHchiJtybpAg3vMNfWeKbU7BpAmghwg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66446008)(122000001)(508600001)(66556008)(82960400001)(66476007)(2906002)(55016003)(316002)(110136005)(38100700002)(8676002)(64756008)(86362001)(52536014)(83380400001)(8936002)(76116006)(5660300002)(38070700005)(9686003)(7696005)(53546011)(66946007)(33656002)(26005)(186003)(71200400001)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?p47RTef5wHvxCtVG4e+tQofuhUysNkBzg1MYdmFxuxrRtmP/VTwdQe9F1Dlx?= =?us-ascii?Q?AkntYaVu10Cr8qBXZT6j173IRlbBaZ9tPP3+qI5vvh9m5K5BxhHN1WJjJsHZ?= =?us-ascii?Q?9w5fEXtrgyATp4HY0sBELtf12JLiNihBVGw43mabAsF9pCa4etuf+4iby6rO?= =?us-ascii?Q?AdkStnfb6MctCPkiFil/RXbt+ghxPWA49LRp5Oq7cG9HJAP2RvYgAzu6h513?= =?us-ascii?Q?oTFEam0IeIAkVf2HLM44PN4BG4uxfYJGgokqwhpoWvbh4sWriiU3XiyIP750?= =?us-ascii?Q?Dm5VYS1nLROM38zlE8qcOPdFtxeTVD8fI4WixwqtGHUhrlvdXS9VglpnDQ+7?= =?us-ascii?Q?nqmuVItKq7T8iO4n+/Wb8vrR09maDsoDn9JT3DI/SZRXzME7crZ8epsd3PZD?= =?us-ascii?Q?8JIuwDxuW7/8nbMLtqElE/dTgRPZhL1Tajp+H/wrVH60Ipx1Qe7wGXLOcAa6?= =?us-ascii?Q?cGEWiB8A10su7CmT0oBP9JKOOsT/ZsVzRwdcH1HGOvW0SqMIHcfvR+jk+ehJ?= =?us-ascii?Q?Qd6pITo+vNrw+FHVZyp1/EYeFS+97NlbR+K2ydfzb3Z/jL11nmtL7nEUWxQ2?= =?us-ascii?Q?DFkZbhRkS7mglpfTneNRjtStLXjir9eI8UBdpaZNP43JlkAvSstEckAefLeN?= =?us-ascii?Q?NrmRF5LYVw/O73tjUmkTBi+V76OlLrMjozhTlaZebizxwg/nw1PU8iGqQynu?= =?us-ascii?Q?+97ucibvCApI4zQm7ou5nyg2Z+DSSdQNzbC0O8lJDSQL4jhaMXUx5qC56kL1?= =?us-ascii?Q?5IiyumlkbpVK/yih7GAJkGsmBf8PIP/TlBu9lLyX3X3BiPMteNYDwAe4I0ww?= =?us-ascii?Q?WAjJg7Q3RpZmkc+VxqJhpTC+8YgowZ9AD/E3IwstJ/FVwl2FONTklW/mZpyh?= =?us-ascii?Q?kkdbHJAZ4PBOlgdL1LphIGFpinEGHcH3tCQqEl9eFY0emAwjRmVXoCKuMUj9?= =?us-ascii?Q?oX4ie22G1PR7uo2qhFBUr5JAdIJ6KdQ4om5urIdFNZXaMUC5q2kKRaIGDVTT?= =?us-ascii?Q?3ddnpOUm0w8rTJJnBm3edR2y88mGlBZJPDT6LdSaYus55AxdZUjMpsJOEh9P?= =?us-ascii?Q?0x+2qbWTqL2Zj47qvXtHtnXl5Vcy0//+KBwTNl7S1xHdiI7ongRghLowc68J?= =?us-ascii?Q?D+kIA2gzFwAuqQfK5Jrjpn03uK2EUwa5gKYtB16ocsAE+w2yo06J9SZ7UPah?= =?us-ascii?Q?GFkHKyJFKb0QQJQPtG48H74uBSP3Dw9atytHspfTPHZ3xly51InLkd8xodhX?= =?us-ascii?Q?WAS+dSG0bnp6RLmWWbyf4E0EXMD+Ap1BTdm7mWp5p+LbsZ4nlUMAAZuFPfua?= =?us-ascii?Q?pZFoZCK1kp/QnHM2DuptvLdnyKnPqpg5tendRpIzOFpwj3bDreTgfBdEcP3S?= =?us-ascii?Q?mPBymTEpt1mb26SzDmKXNWcIawXuYWLw47Shz65jeOhISv6kdVjvGNFtHqg0?= =?us-ascii?Q?ZL7ABTXQe2sZQmE2MtFlraMF5CWAXz7UCfCuPHagA71/x4ztIPKPpM0x5a+W?= =?us-ascii?Q?km1hSexyl7KddVWIJxVWyYOVc0kNQa09uvpzeUbhAvoGyU4O/aIv55cVCaHV?= =?us-ascii?Q?A0Hz2yjwC+NJULtcY24/qY3Fs0sJPSATJofD/hvg6tjYmijFwsi3RsUFgWAe?= =?us-ascii?Q?woE7kxs0MnBPwMFpeof0R1mZYN2RdPESdBaxFcwrVqFM6Nsge0+Qrbb8LSF7?= =?us-ascii?Q?96gRcQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7835547-1e91-47de-3b97-08d9f2cd9474 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 10:58:22.1873 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6iGHCAvafzXVtkGrh9YGfu3RX/MB9OZWQONa5hLvAud6WNu4ND1peGDAQT5S7SqLieEzAOWpNnHSmo5duw9hfb7YzaGiZLwftx0leljjPHw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3436 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Ajmera, Megha > Sent: Friday, February 18, 2022 9:37 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian ; > thomas@monjalon.net; david.marchand@redhat.com > Subject: [PATCH v2 0/4] sched: HQoS Library cleanup >=20 > v2: > * Rebased with latest main branch code resolved conflicts. >=20 > v1: > This patchset involves the cleanup of HQoS Library: >=20 > * Removed unused HQoS #defines from rte_config. > RTE_SCHED_CMAN, RTE_SCHED_COLLECT_STATS, > RTE_SCHED_SUBPORT_TC_OV, RTE_SCHED_VECTOR >=20 > * RTE_SCHED_COLLECT_STATS flag is removed from the code. > Stats collection is now always enabled. >=20 > * RTE_SCHED_SUBPORT_TC_OV flag is removed. > TC subscription for best effort queues is always enabled in HQoS librar= y. >=20 > * RTE_SCHED_VECTOR flag is removed from HQoS library as the code under > this > flag is no longer useful. >=20 >=20 > Megha Ajmera (4): > sched: Cleanup qos scheduler defines from rte_config > sched: Always enable stats in HQoS library. > sched: Always enable best effort TC oversubscription in HQoS library. > sched: Removed code defined under VECTOR Defines. >=20 > config/rte_config.h | 8 +- > doc/guides/sample_app_ug/qos_scheduler.rst | 3 +- > lib/sched/rte_sched.c | 156 +-------------------- > 3 files changed, 5 insertions(+), 162 deletions(-) >=20 > -- > 2.25.1 Do people feel the need to have a cover letter for this patchset? IMO it do= es not add any useful info, so my vote is to discard the cover letter.