From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22F71A04FF; Tue, 24 May 2022 16:30:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E157842B73; Tue, 24 May 2022 16:30:40 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 6B0DB4281F for ; Tue, 24 May 2022 16:30:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653402639; x=1684938639; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ciycqlTnohEr1hzJtbn8gM8qkp/pbAVdSHseDosRX94=; b=mufdkfUlwW0JGq8is0faTWgcjTSaRZjFSGThT+2VCq7t+at1JxDypkZR glKoJzROjs/E+eWlFdPZ8Sro/S8I7IIhl4Li+K4wcsqubGJMiaHelgx2T s7PzU0tPMSv5PKFuRWMnwvH18yTPhn7aljUujhzJsSK2uw9IUAbNNTnlg 9j8YRPDG81+HgDzB8nKm6UjQwx1Yq0PAi3lxPFN3QPaAP8M4S5dJ6cNSZ lPWexiyjNWCqLwsKi0Y+XklveVNbs9S3dkFh40+wHnJWCpxQA9rxBtunK rpWgsI2VjIV8vXu2gb9C2ZJBHZ8Qhd4fyblbnsLhJXFpQJcXu6spfc6P9 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10357"; a="273659263" X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="273659263" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2022 07:30:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,248,1647327600"; d="scan'208";a="901061888" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 24 May 2022 07:30:32 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 24 May 2022 07:30:32 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 24 May 2022 07:30:32 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 24 May 2022 07:30:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bxH4FkgGuP1vE2a6+mV4XnIu8ydJRuMBdbuwvoW2RmoeFlD9azdSUqgLYn3vvx0tSWiBXnz86mxPRrJyeNZ/ZuN+BdG7gzx/Ly25iv1Cj1sycVh1WaQLdK0KxKPKMX/wWkEVHEgzX+VEWT9NAkh9P+3w6nBYeO14ZPcnFZ14sfVd9lwLTVAhKXB0PishvM9vTy6pMyaM7xYfg6JPkYUcl4EY9S6UNmLPiVN+RU6xTgDCKd6aCAks1hIha8HTXuYjX7L1WQAGxCAQZkmbmYcSHALkTSf9TeEV8cwIzNGAycGsB10GXY5E4ezY3trLOMakk5EJuNO9HF2SZq2pUEpCFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uNO0u2kSOhvRE9ccPAi1U7qDWn6EcjpLR67YBu51IHg=; b=al5MduUjkDqxzU34Lj6JGnrtDKkrx43t6XpzvmDb1hPisaF6rJFhXkDyXkjoWnlKi7PDiPLW6Uanfys03UQDSRGOkWDJXJioUnOvza0b1EvP2Z5i1rkpCVl8MODDGCyggQODzsYitNJWOnkubOwmDr0ZOC6LxgPMqTO079+7MujVHos64PFGRoRw9KtCfXQCJcewDkhQ9HaP9hSsszu3yBaOUzae8cseTM/uaPXLx3t/e4djGJPsHmyNSetA1ptTow3mAJM3faj2wuChM2/QhQiGzsueJOKQThNsYwVufGqsVxY8ZG7dQDdcw86JVWX9GM8K5qC3GyoEHKE8HhBAoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by DM6PR11MB2636.namprd11.prod.outlook.com (2603:10b6:5:c8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.17; Tue, 24 May 2022 14:30:30 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b%6]) with mapi id 15.20.5273.023; Tue, 24 May 2022 14:30:30 +0000 From: "Dumitrescu, Cristian" To: "Danilewicz, MarcinX" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "Ajmera, Megha" , "Thakur, Sham Singh" , "Mcnamara, John" , "Devlin, Michelle" Subject: RE: [PATCH v4] sched: enable traffic class oversubscription conditionally Thread-Topic: [PATCH v4] sched: enable traffic class oversubscription conditionally Thread-Index: AQHYb3RJxdA3zlkcaE2KUjxJlDmO1q0uFS9Q Date: Tue, 24 May 2022 14:30:29 +0000 Message-ID: References: <20220427092357.491720-1-marcinx.danilewicz@intel.com> <20220524134332.644318-1-marcinx.danilewicz@intel.com> In-Reply-To: <20220524134332.644318-1-marcinx.danilewicz@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: db65c535-afbb-4158-4e51-08da3d91f407 x-ms-traffictypediagnostic: DM6PR11MB2636:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kZjvaLjOXmuQ1iBvins3GaU+mJ3A3vfn8Ktibs8S0n7yaCnoTo1O5uf4isj17s6VH5VW2z8nxP048UZM5qb6gJs0AydVSrRVe1KvRWE0DHVuehxlqhl+Xj+NX4tWbF3mrA2+3j+OhrKnBpodDGLu9NYrArwwizyHo8cPzbDXJ+UAgvRZzpsaOzL/DiKtHv2b4m/RE0j6Rxly7ad2DAnDDCNreT5zHyPW8ZQL3X99Sem8OR4l9S/qIKorwV++2tCynZ6smPGyqX5XZ85EmNWln5GKDuJPz+5Zkx7u+NJzAO1zAzKt9OJFPpDP4DPl5+Dudt4wiReYRPzIjoSFSux8XjfCnLIbb1eQDoFjjewtGVh0a+MDRl9zroOXdZfWW4R0w/EXm/A8db5hKf1Zl6DS4+alkLiuLWbP4PN5XKA5rWrcw7+4hyvpyoT15R/3+F5Qp9ZWjR5Mi83esvuv6Cm+9mYR+pZU82o2nUdJKirYejT+rCUK+Ui8UyaF56mS5UE/32RAxvOGiQFItoErK85skQYCdck3oKHD88sYVwy+PDA5pWeh96cU/jI6nOQTczQpxpgSYJIruz2EyV/qwMMjEWKU1L96qfyl2PNQo5SEgdeXPc+C/kA0mgXE+r+jsQsf0zvAkkIUfK9qxIONx3vaudxsAVQfwncZEU4uyaBU7/psawu7oEPSf8KQr/nwTNVFcEaABW9Bn9+tE49emTrxMg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(54906003)(6636002)(83380400001)(107886003)(66556008)(9686003)(26005)(86362001)(6506007)(508600001)(186003)(110136005)(64756008)(38070700005)(66476007)(66446008)(38100700002)(8936002)(53546011)(66946007)(8676002)(7696005)(76116006)(2906002)(4326008)(316002)(82960400001)(5660300002)(33656002)(55016003)(122000001)(52536014)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EKJ6A9rT5JsSt1poCxoedxTYCSk8FysgOJJHCR4eTPqPJlIABoy9y1ONz/sm?= =?us-ascii?Q?q/VcrPJ8mvwfZTybuIH0GVjqbC9Assf1tF754pGBNYFOXEwb+OjZute/h9e1?= =?us-ascii?Q?vEV0DPfhtZi71pzr3G1bd3szZR9z0bf3A66fLdteDqtWAz8HJxrw31PteZU4?= =?us-ascii?Q?OdEE3xh9iSxiJyzliIO4K0fXj7sTgDJ8BlyT7o3143QvHheEAg32+Zn6e5k4?= =?us-ascii?Q?7YgLedBhRWfDrLrrMrxK3P8FnH1u5iAJFBfsX/6EoDK71tJW5n+TZ17Z+nv0?= =?us-ascii?Q?W2ISTHLhy2xmF+wY0nY0I4CApswHDo6fLbOdchNVm358PMoKk0XNgYS/31UY?= =?us-ascii?Q?TPDYx4tHDMgg0lzh5+UylPCZ24r/XSAWTLcpUKaYeTVZI52f1Ar3vVQrqGVW?= =?us-ascii?Q?vwZ9HKFB/XHHUrQzgcFSAFPPfQlyKTgWPYgL5dsrYH7SQOoQGZ4vevGzpF31?= =?us-ascii?Q?anl5kYJgemwc7RGv+jchb7BEUgfmfX6ON4KToyHC9tNJdsI17h79FSTp8MrJ?= =?us-ascii?Q?QTsxkgURov4ZwCy+BbgSXvuA/HdtnRcIBHPXyQ1mKkIJFK989lLPsJzmhfSj?= =?us-ascii?Q?8fZla8vcXfQGermnP5IYGHXDfO4eryS8CPGBIfPyazGtddw7foC38cGkD9cn?= =?us-ascii?Q?73n/ErShQ7APkiFviSDwBKvuhq1lgwUOnhMptB748B2mEKU0mQxVvywMxGif?= =?us-ascii?Q?NruRgeQamac3RtKt5CMZnOmcNb6ZVwOJTxKUcriOKGGWeW/3A6qyAO+fQx/h?= =?us-ascii?Q?YXyX9dC9S6tsNnzz65P0zueer6G1qpr3IO0GW91GEDDISjZ7IIYLUCLW3QjU?= =?us-ascii?Q?0NdLIbsHVSL50SWkZH1fJQxYL7MBobpCsnYcbU4Qj3LhDFD/rK5cManNQmN/?= =?us-ascii?Q?lEua5GUJkQ6+V2wqw7/lwn3llJ/MXSn50rwD0TS8miWJZnnMOus5kb2idDQy?= =?us-ascii?Q?lMZT67YGTrQI4CgIYCiS30FmhNoJobouKlgPsEmaIPC8gxtzz8gYP+1/DE20?= =?us-ascii?Q?WALjR5Btvaa/2tdhOAdXRZeD4LaVY2E3Iftwu5nKfzplgQWYajG3fpJU9qDm?= =?us-ascii?Q?cDWptt0VLZiJwixi/LhxJfabNX1AXjoTqkIwr3t18iDisNuhOapPt5EgSUWe?= =?us-ascii?Q?DDGVDhUM5bVe9i6AkGSrOtPyI26o7ZqawN0wQdZa4QpOgGHnzNveVhQf4mU/?= =?us-ascii?Q?DX1E5dFeUVApb0ANAp4oddjHbks9a/lbfgPQI21H458q5k3M+COPmgvm34Dl?= =?us-ascii?Q?I2j4UOamPkymLFet8vp7/+4YUIMN1VN/X7EE0rNLjvWrcfWltlfHbHi0iV37?= =?us-ascii?Q?AAIXC4tYo6LMOfhjwpdJD74nYs2ttAlmtbGMlma/HfHKMwzW4pBN7UMod+Nk?= =?us-ascii?Q?7S99p43iyBzaeAsKDg2VIJI7+Qh1d+oyFle7WiZRum6HhF8V1jYwwQqHhk4F?= =?us-ascii?Q?njw8UYsfA/sH0QEOoK7RlGMwfUdReWge2qMHvQGci8y5sVvFqZU5CcKH6W79?= =?us-ascii?Q?Kq2lwr8pJZ7LrG8U6Ejo9QYALQZaDz1KlMCf9hyNoc8K/1VuvWSnhLHRX+7s?= =?us-ascii?Q?VKradLcfvBBN+GnjufiaG0SX8eK2jEI042Pffg/sOY0l7kUMB3cAIB66BWdO?= =?us-ascii?Q?WWBXy7aYgaI9wUKsDl4UtxtwJr7zW5tNq2ESm29qWcwydx+4Ie9bbTFCzRl8?= =?us-ascii?Q?0QCzdFu2jI9w/pU7NavWTCENZrCP/PwuCMgm7Wv4Zt7MXLWkJh05aZ3ZCUiz?= =?us-ascii?Q?2bp7bo72Qv4jiWmVJBSY7/BrTJ4WOOY=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: db65c535-afbb-4158-4e51-08da3d91f407 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2022 14:30:29.9705 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GqpZtiYNWgOZwva/vfXVL0SBimVZhJglNIxkqe9GJVnKAqktGXlonxHWYMWCV2aVrWqscplrQvi3VXZotny6meF37pci+q6X1ljOac+RKro= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2636 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Danilewicz, MarcinX > Sent: Tuesday, May 24, 2022 2:44 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v4] sched: enable traffic class oversubscription conditio= nally >=20 > Added new API to enable or disable TC over subscription for best > effort traffic class at subport level. > Added changes after review and increased throughput. >=20 > By default TC OV is disabled. > History: > - v1 - TC OV disabled by default > - v2 - throughput improvements > - v3, v4 - changes from comments >=20 > Signed-off-by: Marcin Danilewicz > --- > lib/sched/rte_sched.c | 189 +++++++++++++++++++++++++++++++++++------ Marcin, I don't see any of my comments on the previous V3 version addressed. You me= ntion in the change log that you addressed comments, but I see that all my = comments were silently disregarded. Jasvinder also noted the same for his c= omments in a previous version. Please address the comments and do not keep = sending the same code over and over. This change was supposed to be straightforward, but for some reason the pro= gress is extremely slow on your side. I think at this point we are at risk = of missing the RC1 deadline for this feature. Regards, Cristian