From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFBC1A0C41; Tue, 19 Oct 2021 16:28:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4FD64119E; Tue, 19 Oct 2021 16:28:34 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 284DD4119D for ; Tue, 19 Oct 2021 16:28:31 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10142"; a="314727423" X-IronPort-AV: E=Sophos;i="5.87,164,1631602800"; d="scan'208";a="314727423" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 07:05:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,164,1631602800"; d="scan'208";a="462769047" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga002.jf.intel.com with ESMTP; 19 Oct 2021 07:05:43 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 07:05:43 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 19 Oct 2021 07:05:43 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 19 Oct 2021 07:05:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yw4NmlAf2Lx7GmZOHoK/3lHDtGq9YKQydlZIYA9tCnm5FMcpNQ/ZC7JHCbQCy93CETUAIyw5aWRp4ylm1iXkf4XiPP/RcDtMy8P2Jmr9752/lAtGLWBaEvvNQy/AfdNuar5XPmKf6OiG1zYHI4a1GH43QoEsS4P+/AQc5EZz7J5+6Tpqmjm6wRoFzclAZoe/sFc1B/Wu6ZB1pI8zmot0Q8EkIM9o/uwnFkaWr1JNg0sYldzfosWhtaLNdHq+F6SlRN+PzfgTGegZFVXJQvceeDAnQJMN0RtWi6IuFWf6rjeyejcf5liSph7iU8mLAgsxE4nMumQghuXWvdF/0RGCBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wQh7aKnBcA3lrXDVAbw3HTSR7WYTXgSD51DB57zrsvY=; b=foQMf+sWATkKx2fG8svCsLrS55DkAjkCNYbDhf5xuCHdlqK8g3gcC5K2grqyLS+3UpmChOj5x+DHOg7lnMhsmeTuWryoM2pPpLFFHnOSSQSFLpLhf7qVx7v3tdiHtRSQ/DVYTx3rfuCTlLySpfgv0y/trmuVLvL2o5wleFzEv41FQWoYoPtRLO1TgwJ47EzTH4Hxi0DgoWXJr7Vr42+URe9DlkF9ffRhoUpvYFwZNvbrg63PDA0dmFpRhZA2o8khB7bJF4CG76IxOWST/cY5cWbts2L86UrYkdSyAmpxCutyfuRK+kKKfwny/XHPqSTGRRbAsSrW8CVsNPnsIrUA6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wQh7aKnBcA3lrXDVAbw3HTSR7WYTXgSD51DB57zrsvY=; b=vvc2Mt//tOwt62yk3iirKiLB7sqqQm0J/8VSXUJBYxlLTMixroKppD7ZRn+OzdGkNLG3ky00RECOWgX9RnWTAPuHHOY4J/WBH7ZCR6cgE9GlnQnY2wM7EAT+BENvnG/vlpaRWJLt1fwsKM41Jhnd5/ifDOcY16fGOA91RYmBj/k= Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by DM8PR11MB5671.namprd11.prod.outlook.com (2603:10b6:8:3c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct 2021 14:05:40 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::c0f1:1135:ceb5:ac10]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::c0f1:1135:ceb5:ac10%9]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021 14:05:40 +0000 From: "Dumitrescu, Cristian" To: "Peng, ZhihongX" , "david.marchand@redhat.com" , "Burakov, Anatoly" , "Ananyev, Konstantin" , "stephen@networkplumber.org" , "Mcnamara, John" , "Richardson, Bruce" CC: "dev@dpdk.org" , "Lin, Xueqin" Thread-Topic: [PATCH v12 3/4] Code changes to avoid the ASan error Thread-Index: AQHXxPGR3nW1aMjbYEaWO67m+oRsAavaWhYg Date: Tue, 19 Oct 2021 14:05:40 +0000 Message-ID: References: <20211019101207.1451058-4-zhihongx.peng@intel.com> <20211019135841.2004819-1-zhihongx.peng@intel.com> <20211019135841.2004819-3-zhihongx.peng@intel.com> In-Reply-To: <20211019135841.2004819-3-zhihongx.peng@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5a7b1473-7aec-4a86-6472-08d9930988a7 x-ms-traffictypediagnostic: DM8PR11MB5671: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EQ/dWCExEHvR3DrUi35VqgGI15VntoMGNuzZ81ThAifNJl0Fq8e6mBUG0VoR1ZGDzBrR6five1eyEbFzm27yMeaLB/N34fzjypTLOsqT3u/j5UndrZAU8uF16/fI4FYqEl7YAjwDkpDU/5ujisc8+fMh6gEnSHoU68mOUDoa71XjeR97wi2CIeHb6xJfBHu0oHlf0mT2H43mWn+tVR0AHdCBIyanQaUs0/Aklrw8OBhM3POJ6HjwdeKNEndGnt9QwRK/4sMD+NWQkuwKTCobZn7LU48Z1epNjqccljUmKjDoh70Xq/BWHlvPYOGfSYDWKC4dPaxO7NMtH0OIMGMHK5Grt4WsYOJ3UprPerwquTrjTqhyr7EXv0znoaHrdsG8qi5EJpCoiGK+OL6leX6obc3I9ITjA4A1pYO6m+SUKO95sZaA7f8AwwG0HSkKrlIkKUAonv3aNY4yqeEMxBRedqnV8/buuCVUMNz3ixqMR/dW7wQMGWNnRvPk22bN94h8ZuLEYSPkpmSnykRwou17sB9i9uzf0gy78LwG9ZIn4SbR0zfpZvQPrLWJsuS1KlKBBf4a+kYNzaLhSi4+MFqnADdVPs/AEtm/EedMHSDt2Z/s6EeWtmzOABoXf/jBj97UpNGX2yl1ooXPjhq0hh9aTq2fh7d7XaJgB5f9axbZ1dSBaWSEIEzK4tqSF/ZmkEoCkd0j7dh9yNBWxTk+ioggfUgpePSz7Rmt0ABy1tNvvJs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8676002)(921005)(66476007)(8936002)(38100700002)(508600001)(64756008)(52536014)(107886003)(66446008)(66556008)(9686003)(2906002)(66946007)(5660300002)(86362001)(316002)(76116006)(82960400001)(71200400001)(26005)(83380400001)(122000001)(4326008)(6636002)(54906003)(186003)(55016002)(38070700005)(33656002)(6506007)(7696005)(53546011)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ByiaXnJkGtpcKSq6r461Smyc/Iy0If5dlrwHWePe4OnNj1s+OEUBbbdRxySU?= =?us-ascii?Q?40OIUf0PnZpLaavT0ZtE0zRTYhiFlRWjEQC//prsJGuDpMzKRMn2X9+4U8BG?= =?us-ascii?Q?cCpFMZrxdNSf1kwVd1sam9X7/GGnQrSg2Q+I8BJWE4E8kHjxIA2Y8hTBKgIg?= =?us-ascii?Q?Revwc0bbQ28WcUSIIk+to6MoO0Cc6E9ceHeTts8IlVGw3W3EcIk/0SUMMlur?= =?us-ascii?Q?BUam6szg66GFOeCrvWHXQ9DyuhSpCx7tZm3FjkmE9f9rZz+jrPio/T6e4Mm+?= =?us-ascii?Q?ptmwfBbO5oXZ9D90w/I7xZBXN1iqMa0V0xR3D4obTjNUamemip7V3hpS2rlu?= =?us-ascii?Q?H/zECeHyEinbiZQo6ERIRAxH/BQEgQ6AmpL75vvhVL5beAILlcWChsP8GvEF?= =?us-ascii?Q?HXeXE9mKP1hqY9V+4B0PGllCknmqLcDsk6pS/EUsNAwv6Nww8wMj3eUQaJA3?= =?us-ascii?Q?r+bw/wauVfCkdmM05heWWldFk3Ncbl01Zl4F2K+eURpzsh1odSBA6sTy0sWX?= =?us-ascii?Q?XIhXKT+oxoibJH2NakjP5gWvSqeYX5GNfAJCtOiGIjHO2MEBZQzbNNhTsO79?= =?us-ascii?Q?7MYi2sRgzETj2F3G7rZ2LvgXKGMwFSWENjy/L87lTz88O5roy+seJvmQqCMw?= =?us-ascii?Q?nWa8clFWOKRGDbYboHhMFnl84dKkdXIsfxE87hGMb+ePqOIrOYxmuvubdA2i?= =?us-ascii?Q?Ikn4q8QY1aj4Ck1VNPfkO//1gZdTC2UlaGKinUzyBWvGadQzvlzTsGjEwFFO?= =?us-ascii?Q?A1S83ONK0iLUXK5h4rio3bwvwRbPpDE9NxsEj8wAejkr6oT1vuzjFOBH19sq?= =?us-ascii?Q?jSsTRk/KrUijCMK9OcfsVXXsDE4ZMQcMqMqW8+UgqtUKQmmxRuDNYpxcGyrF?= =?us-ascii?Q?3wMLONcA5nogLD/QCOogvHFg9QVjUo2p4Ix7HTR+zLB/NjiTwN6bRSb1oyuv?= =?us-ascii?Q?xHncHkVD74vhpw+m5KTBvuWS4eI/Mu0kwhY4E3ap5C2xBO50gFDFc0Umcml/?= =?us-ascii?Q?6oek13hYkmd0V8JSu/7ELGFAnuus2EsuASgm4Ve7BUw6Uk3A/dF8heyWlcBa?= =?us-ascii?Q?03WVyIkVXUliV1TiwpNnYLGqzMF6eezXZUNdhqRNteu9wOzlH2rwYcUxiej0?= =?us-ascii?Q?dSJJcWedsK8Sa9aclqBn3la1mrRgoxenVTQp/l0pOLKLDg14L5kFVHsOvtyp?= =?us-ascii?Q?RYHn/0t/P6m9RQiXq6kgtSeB6aiFj2XdiBIwI3u1pCgNLKMJQIQuaso8BW25?= =?us-ascii?Q?lMV6mtnTHk80qbZexEhTsPrEOjmtInwy4vLvspPmgYBsu69FMeWTkl78u/1a?= =?us-ascii?Q?5IIkv9rNTCCxtwTv0vrXlgoU?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a7b1473-7aec-4a86-6472-08d9930988a7 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2021 14:05:40.4613 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Bzo0H9ogF/99iptwWFtWE2W2+z5HLsZFlBV2BKnhNcZ1vmmar8nEqWxMarfUFbcTmh8Wj1yJXW948DWKU5rFAtFhePjCiIyGlhtWc98xpwE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5671 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v12 3/4] Code changes to avoid the ASan error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Peng, ZhihongX > Sent: Tuesday, October 19, 2021 2:59 PM > To: david.marchand@redhat.com; Burakov, Anatoly > ; Ananyev, Konstantin > ; stephen@networkplumber.org; > Dumitrescu, Cristian ; Mcnamara, John > ; Richardson, Bruce > > Cc: dev@dpdk.org; Lin, Xueqin ; Peng, ZhihongX > > Subject: [PATCH v12 3/4] Code changes to avoid the ASan error >=20 > From: Zhihong Peng >=20 > Code changes to avoid the following ASan error: > "Control reaches end of non-void function". >=20 > Cc: cristian.dumitrescu@intel.com >=20 > Signed-off-by: Xueqin Lin > Signed-off-by: Zhihong Peng > --- > v7: no change. > v8: no change. > v9: Modify the submit log. > v10:no change. > v11:no change. > v12:Modify the commit log. > --- > lib/pipeline/rte_swx_pipeline.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/pipeline/rte_swx_pipeline.c b/lib/pipeline/rte_swx_pipel= ine.c > index 1cd09a4b44..0acd6c6752 100644 > --- a/lib/pipeline/rte_swx_pipeline.c > +++ b/lib/pipeline/rte_swx_pipeline.c > @@ -4642,7 +4642,7 @@ instr_meter_translate(struct rte_swx_pipeline *p, > return 0; > } >=20 > - CHECK(0, EINVAL); > + return -EINVAL; > } >=20 > static inline void > @@ -5937,7 +5937,7 @@ instr_translate(struct rte_swx_pipeline *p, > instr, > data); >=20 > - CHECK(0, EINVAL); > + return -EINVAL; > } >=20 > static struct instruction_data * > -- > 2.25.1 This patch changes code working correctly just to please the tool. We shoul= d look at ways to fix the tooll, as this is likely going to be a recurring = issue. Hopefully this tool is to provide value to DPDK users. Reluctantly, Acked-by: Cristian Dumitrescu