RE: [PATCH v3 1/1] ethdev: mtr: support input color selection

["Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>]

> 
> To summarize we have 4 attributes, Please find below the truth table
> 1) Outer VLAN
> 2) Outer IP
> 3) Inner VLAN
> 4) Inner IP
> 
> 
> Inner IP -Inner VLAN- Outer IP-Outer VLAN
> 0                    0             0                  0
> - Not valid case
> 0                    0             0                  1
> - RTE_MTR_INPUT_COLOR_METHOD_OUTER_VLAN
> 0                    0             1                  0
> - RTE_MTR_INPUT_COLOR_METHOD_OUTER_IP
> 0                    0             1                  1
> - RTE_MTR_INPUT_COLOR_METHOD_OUTER_VLAN_OUTER_IP - If found outer
> VLAN
> then vlan else outer IP
> 0                    1             0                  0
> - RTE_MTR_INPUT_COLOR_METHOD_INNER_VLAN
> 0                    1             0                  1
> - RTE_MTR_INPUT_COLOR_METHOD_INNER_VLAN_OUTER_VLAN - If found
> inner
> VLAN else outer VLAN
> 0                    1             1                  0              -
>  RTE_MTR_INPUT_COLOR_METHOD_INNER_VLAN_OUTER_IP
> 0                    1             1                  1              -
>  RTE_MTR_INPUT_COLOR_METHOD_INNER_VLAN_OUTER_IP_OUTER_VLAN -
> If found
> inner vlan then inner vlan else outer IP else outer VLAN
> 1                    0             0                  0              -
>  RTE_MTR_INPUT_COLOR_METHOD_INNER_IP
> 1                    0             0                  1              -
>  RTE_MTR_INPUT_COLOR_METHOD_INNER_IP_OUTER_VLAN
> 1                    0             1                  0              -
>  RTE_MTR_INPUT_COLOR_METHOD_INNER_IP_OUTER_IP
> 1                    0             1                  1              -
>  RTE_MTR_INPUT_COLOR_METHOD_INNER_IP_OUTER_IP_OUTER_VLAN
> 1                    1             0                  0              -
>  RTE_MTR_INPUT_COLOR_METHOD_INNER_IP_INNER_VLAN
> 1                    1             0                  1              -
>  RTE_MTR_INPUT_COLOR_METHOD_INNER_IP_INNER_VLAN_OUTER_VLAN
> 1                    1             1                  0              -
>  RTE_MTR_INPUT_COLOR_METHOD_INNER_IP_INNER_VLAN_OUTER_IP
> 1                    1             1                  1              -
> 
> RTE_MTR_INPUT_COLOR_METHOD_INNER_IP_INNER_VLAN_OUTER_IP_OUTE
> R_VLAN
> 
> Is this above enumeration fine, If not, Please suggest.
> 
> In Interms of name,
> a) We could omit explicit OUTER to reduce the length as suggestion.
> b) or change IIP, OIP, IVLAN, OVLAN kind of scheme to reduce the name.
> 
> Let me know the names and enumeration you prefer, I will change
> accordingly in the next version?
> 

Hi Jerin,

The above table looks confusing to me, I suggest we have a meeting next week to go over it and then report back to the list?

Regards,
Cristian