From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD611A00C4; Mon, 30 May 2022 14:14:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61D8C40694; Mon, 30 May 2022 14:14:46 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id CA62F400D6 for ; Mon, 30 May 2022 14:14:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653912885; x=1685448885; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=swEH6KB4e6FMJONEgrgj7LMLX18LR7TSlJndAbTty+Y=; b=ZtI0ejHw//4uEhOp2odz7PA7juS9iabPY9hw9EGQf2i8kqznudvwJY/Y YFJCRL/ZxFO76+S5G3n7hIW97b66D3vBZh4mABFewsabPM5WA2jz4IXgo KijNfl+2H/PQwBifged5JYpndBVQ45t7sQb44Ww75m9cKSjVI6FyhroHt rwP6AidpcUqaZUkQYcZ0PiOKzmJiPWNhpZJzihpyzy38YRdYtOaIPNlP1 G+FLJBqJLrNBWU3Daa9QvPAQmuckkCEyqUlpxdgR0coP109Q2Wef9Ei38 58BLuXnOSebt0raZkKsa8KWo3BXB8PsQNzsRTjmUqYQCBOJFPSCSSyjM1 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10362"; a="272555583" X-IronPort-AV: E=Sophos;i="5.91,262,1647327600"; d="scan'208";a="272555583" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2022 05:14:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,262,1647327600"; d="scan'208";a="575909992" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 30 May 2022 05:14:43 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 30 May 2022 05:14:43 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 30 May 2022 05:14:42 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 30 May 2022 05:14:42 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 30 May 2022 05:14:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A6eoLaztOk7813FK7ohsdD9lvzO2/ST0KKycjeODC2LX6iFx1ycvNq43aK07IpWFL08WtJW97Gbj6ulwDQ5R9hRpmyD9LGDrrak0pPRAoXskMk3FkgZ6V1rkvnT0fz/MfwpMB6fpblD5l6MgkJwUMe2zIRfgGQ72Csn7zA3+8jol6Pfkq4tm7juDh5sA3mqjO5QIyrjIHHaqx9M7p7TYsy6eE7fK9li1r298QsSFXdh0O39ZoEwZVL1K9A5ylacC8thB3peHJHjdojybQJlyvQKLU8rbr6IrQGQZnalApJLDySJt2H/kYwMgCtgMH/WLcpp/rqSsXcQ0h434Kqt+CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B9VMIcUhT0vRCbwRwZ7C/cSm7DHu8YoFufzzaM/sTBc=; b=Pdkv4Vzbbspepj8HLaJBdMqt7j+lPIiO8yIFoklpBdr1HRWFDWSUEH3z0oDJxBN8G7OsCGJMSsdU5uoRpTkoXGb4EH9zqujSupmyFm3XY1Yw6BNVCpXaJ1ZqmbkYM7dK9pUl8oEamu82/6kJv/Ex7aQIFTH3UePWnN9/SsTVv4P2pD1BIGlp0WsDEUiVs4M9wvFpN+aylG+es588Noz9wtnSj5Ma7fhKj9iorPShQ1I3W4CGu7HvI4pyr/R/AfIZTCtUb53wIThY5LhK0KOuvgjv9FgjsUN7qEJ+jIb0P7M32q2SJ25ltfWKGKXzElbmJBEkcxRL3sevL6zj5lXgbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by BYAPR11MB2903.namprd11.prod.outlook.com (2603:10b6:a03:89::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Mon, 30 May 2022 12:14:40 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022 12:14:40 +0000 From: "Dumitrescu, Cristian" To: "Danilewicz, MarcinX" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "Ajmera, Megha" , "Liu, Yu Y" Subject: RE: [PATCH v7] sched: enable traffic class oversubscription conditionally Thread-Topic: [PATCH v7] sched: enable traffic class oversubscription conditionally Thread-Index: AQHYdBwgzxwMSqXjFEatRQ8L+0zZQq03VKhQ Date: Mon, 30 May 2022 12:14:40 +0000 Message-ID: References: <20220530084520.827724-1-marcinx.danilewicz@intel.com> <20220530115500.829250-1-marcinx.danilewicz@intel.com> In-Reply-To: <20220530115500.829250-1-marcinx.danilewicz@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7e074612-b573-4e98-fb54-08da4235f8dd x-ms-traffictypediagnostic: BYAPR11MB2903:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4B9FXgPsoKvFB1vfuw9MO0rONrBEerVNfrV4GNZ42uwjv9wIMfchi+XiKrz9ZJ4n4MIlqKQ09LQ3P66qi6xz+i4xY7I/MQXXvYppLCq5+Wq1FtB1QqcfIxBpwfm1NXVHGpkxMEtWfs3xUIcIgPBirLloDeVA3O38MrsWL4C0EWGJuic1jd6HfaD16P7rWrDgwX2Gjq5OmIjQidZHC9pPrRPjpOAC1BXSAGni+BcDKFvgZSgfzBl7naH8o1ltxDv3tF3jPY1Qx7jYyjKUBJ7R9jzDHrBtr5lqw47ptLn9qF33E30CKrQeX6oW2/YD/006eE1S8Ec7wK88HW2dntOF+NoHVPp/heBGudeeuJJS0SH08HM4Usxd5fi7pMR6RvIQAABMLic31h6yhhPAL+XVxES14WINY3qTda5rYcOwkk/xu+L2FqW/2fHnZ8tokM9MaKyAUP3h9CCjd0h/IbgDCgIxccRRRKx1XQIyDrQgkKraKaPpytoTuefJw5iSqG5wch/pw9PqI4ONTdV3e4op+jQQauS9ptkG4ZqUJXqYZtvLghEwOG9d8aeVWELOn7QY0go4UKNEXOrrJF/IyUw4JPLlJS2+R6Urs2De2a68NKNKg0WabfZHYimOlAJHyo8ixBHh+uEDgoA+knHStwS+CqceYkmG3pOolMNbK5AQR56cnRKTCm8tDToYZMnMRdlupSZl6UMrxBWJyVi4cHC5wA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(316002)(107886003)(4326008)(122000001)(38100700002)(110136005)(186003)(53546011)(54906003)(6636002)(2906002)(38070700005)(66446008)(8676002)(7696005)(64756008)(66946007)(66476007)(55016003)(6506007)(66556008)(508600001)(26005)(9686003)(82960400001)(86362001)(71200400001)(33656002)(5660300002)(76116006)(52536014)(8936002)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9xhNHHr4VWJLsKTOfg9bhegLjiJTU9QuifCDQFT4YZzmib/VdR9MgGFMLjE9?= =?us-ascii?Q?qCr0ihx1pBzziG4ZJWVFg/4NOrRQXezyitzsbW8J7cBR4smQiml5vWMRfFfx?= =?us-ascii?Q?UzvzsTf6QUo2Yz8emaQq6HgUIROpfZWNlc+B2TmkgSyKIYkoZrySNOO0XwTf?= =?us-ascii?Q?8YEdSeaz8Q3dta6xsVhYxUEg64GLG+Ti2rpAmHHBK//S/h7InUkegQ3EgYkS?= =?us-ascii?Q?ZiPS4DiiAD/8MoDJJx7OgNBL/Ko8NkKwj1t9o+fSJBquLwbIZdeskCn7QHsR?= =?us-ascii?Q?QqITAM9ujYuIAlrbxkPVy0Gq5wihlvX1+HBT88BpaYU1zskIcu85DF9RGH3r?= =?us-ascii?Q?/xue2G/+S4jmbJjxgbOqFAsL/F7f7SPkKbZ6NH0yjxXplguz0NNcckpQ42SZ?= =?us-ascii?Q?lVZMK6jQ5iSlUtx9al//FapiLzjqxnUeXU9sFCdHsLWRjSQrSwG8Iocusm+W?= =?us-ascii?Q?CU19oCqyRHgeI5xRebLy69oAFnCH32Srk9WZbHRl4joynocMfYTAmUjC38yK?= =?us-ascii?Q?1/qMVOnfjPjiZTlXge5jf7cGzR0VrLlHE26pVCQAtkQ0dVK8yCa+ifOl9pAV?= =?us-ascii?Q?VuEbZ86jg1wTx5+98lvLk2uDgrlFJV2caPBC0nr2pGrXYJ9iNBIiCG6Xpsyw?= =?us-ascii?Q?EewRguHyB2BTqCrocpXfZzD1bNOnLgSzDT3Ph+xAwm8Js5w0JoFE8UrK81xo?= =?us-ascii?Q?PEFzwMny4vHbQSjNNRZu0PfME2e7KksonSVZFdJpopJWmIP3YlTfsBHupOq5?= =?us-ascii?Q?kakPmkmlnzMQt2geESlfMLg+wAsoucwUVNuQnQpdC58lAdQHzVusTcBYWesk?= =?us-ascii?Q?7hkhCrCFkS2K/I5OvQnGoF4YtqJJo3iQhhMe92165fY+Jgym1sxhM9EF0btY?= =?us-ascii?Q?Kxs+YwZEkk4/7nz7gYQJAfeLGSn4V3cPT0FIVU6LBJKMj2fk+zANPp1DSTd1?= =?us-ascii?Q?aD0K+x4kCP3nA519WkPJQfnUBfx/fWlN5nS/ukdGqD3uFWKTy9+eX1H2E8cH?= =?us-ascii?Q?gmMkSMtddCCQI04KRnHFOTdaTr8engBe8iHaR+gG24KHxjx25pN5BCKH174o?= =?us-ascii?Q?aOmEbApDM+0E6KBbjGKWKYuMs5hvFdwQq6AMO5q1tM2iQSw+FsZzy1J0QWsg?= =?us-ascii?Q?UOUmNVaK/DP6mn03125csxjJgZEt5EOjb1KOqI8VrIsQgnsJKrIUICdtL7se?= =?us-ascii?Q?OqFU5jXaSzYkJ/j9KL/6jClJ4K5ogJGUVb+U3GMcbgdowk16p4eH4+vu6+7M?= =?us-ascii?Q?gf4hm3perNEDJ65OTKV1JASSmljeZfwW5eFRcjfu+EGxyUmlT1cfZ7J1LuCy?= =?us-ascii?Q?9bscH+qhVHSoJXhLvJlmTIm7fa43kOgU9AJyVHmrMH8RfpMsSJpV9OXJllet?= =?us-ascii?Q?AeVso2beLgStYHxS8wC6gVXa68Oojx19IXifBGAygP+rnrTMFaHMuVhyca2c?= =?us-ascii?Q?jUFVX3+LttDNmmvtfBcTst9KbmPzeqpOZzDUmVGo0nsYPGybReIeY5zQMfaW?= =?us-ascii?Q?numso5A7MHvj0zFNqwQJX0PT7BJset1G0LdbDjmdhDjkeAFi6rglq8vozRGx?= =?us-ascii?Q?u7v+Doe6DdwOzVTI72F0ee2cCG7WyWnfPSdkDzUS6mMksNewTBraCl8FOrJe?= =?us-ascii?Q?qt8RPy3FC5b9DsblJUJ0HVzOcpey2/Ex93+bdF8QjXxXd1GDvb9gSi2lsEie?= =?us-ascii?Q?I8QefcQZbAIWx8gqPUNuk7+SaJ2xbjFn2lz9z6HbqZqzjudaPw2nsYnCugoW?= =?us-ascii?Q?sHSJA8G6rCs9GhLJnCa4u9gzhGCatUI=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e074612-b573-4e98-fb54-08da4235f8dd X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 12:14:40.1718 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bFUrXkH8lguO2Sqr08ergq0I5d5dK8usgHiVxQVl2U9ewSD5rBiqucLn6F1HsruKPXZKXkCZbwAbdnnuvuJM7TKlWheLT1xisyDLz/cEEMs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2903 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Marcin, Comments inline below. > -----Original Message----- > From: Danilewicz, MarcinX > Sent: Monday, May 30, 2022 12:55 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v7] sched: enable traffic class oversubscription conditio= nally >=20 > Added new flag to enable or disable TC oversubscription for best > effort traffic class at subport level. >=20 > By default TC OV is disabled. >=20 > Signed-off-by: Marcin Danilewicz >=20 > History: > - v1 - TC OV disabled by default > - v2 - throughput improvements > - v3, v4, v5 - changes from comments > - v6 - removed rte_sched_subport_tc_ov_config declaration and map > - v7 - changes from comments on v6 I see you moved the history a bit below, but still this is not the proper p= lace for it. > --- This is the place for the history log. Please note the "---" line above. > lib/sched/rte_sched.c | 93 > +++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 90 insertions(+), 3 deletions(-) >=20 Still only changes in rte_sched.c and no change in rte_sched.h for the API = to configure this feature? Regards, Cristian