From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94880A04FD; Mon, 30 May 2022 13:19:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 36BDF42B75; Mon, 30 May 2022 13:19:47 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 9C2CD400D6 for ; Mon, 30 May 2022 13:19:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653909585; x=1685445585; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=tZQzB9GnFYTSnqa8doM5oEjA2Wuv703BPrJLHLEp7gw=; b=c5XVwX0N5jSlC/a/Nl4tf/Sm9pIH5dS8vExpqJw4M5j4cnHrRtnTA42Y AxliTgW1QQSL5bWF6+vExmuaAMxp47pLZP56j9Vtuq9PXlm29o5rrtrUR TZLoO0EMC4vY4LK00rW48gUnJ6D3fAHZ2cF4HV8I6q/MjWgyZhzyvkCYh MHDngKZSnyfbth4xed1dUhc4CkR0RSr9iCjIdxvqi8tBIsw8qHHH1nkbw 8gKkveOT7xRQW5hkrOQIALFo4az+M3nKfxYsznlk2nqD1Wt+uckxDq45D v7M3i51UDj+beSQTNYODbAk8QCOrrpA6Y6/8LOhguuaB+6To+AaHaRKsy A==; X-IronPort-AV: E=McAfee;i="6400,9594,10362"; a="254848133" X-IronPort-AV: E=Sophos;i="5.91,262,1647327600"; d="scan'208";a="254848133" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2022 04:19:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,262,1647327600"; d="scan'208";a="551302697" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga006.jf.intel.com with ESMTP; 30 May 2022 04:19:44 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 30 May 2022 04:19:43 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 30 May 2022 04:19:43 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 30 May 2022 04:19:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=klckulr+mMQAFkSmCowhg98k7JePjYWi2Eq3q7gqSlcwaBvOK15WNV5EzV0bRdmXjoN5FXy/mIcLoNP6pCn9UMwfVwcLhbG5wktIHD/JMU64YN4KfmS6kOebgamavwB8JuOX1wTjA97Hui4m4bhPoc2mkN5MlFisXldnjKYdcrSqUumhv+8iY5IAcpfqaIyOA+IZNJvisCdY+RYA8ABnwKblD/cYskuCDCQsTT/Z3MnHeaizxkuYxjrvACkE2cvKIie/yvuYbJxvV8x5xE07Uq5lnZ0ok/TYCU+RuC8zdTV12YiFZNFjW+Ys/QPF99ITE0A5D0repYeJCSkJthRGbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YRF2luA7eLBL4Ha2QsjfMyzF3DVOBiF4Y2oTkQtb+AA=; b=EsguarLhC8AhNRvH0Viq7lxPeaTyJSuUK6CAcPwk+WAhmeIrspKD9C49cdDBHYVwWm41PfLXxwiD8aB/O4Wzm1a9Gbu7NNq4XM2cv9xmdUS3NtQg3eUQNXK+6iaIizoBQx4aDY8lExT2Nc5e4p5FH4aClmahq6HO/bLic+NLY2p2cLtk7gxpXDBTe3wR4eeYIhKRUh/3JgIyFEuiqzfZnlx2mdzFFKfRLLL3lTREyfO0fccwGDVB3Ge4bnV1S+9F5hWxi8mD5y3JcScMOwsYxulxjq8iiaExqqZ2r+1rcHhsI88kTWZNw1ThyAcPjT7pmGx34gfdgF/1aJsYxWujkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by PH0PR11MB4887.namprd11.prod.outlook.com (2603:10b6:510:30::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.16; Mon, 30 May 2022 11:19:41 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022 11:19:41 +0000 From: "Dumitrescu, Cristian" To: "Danilewicz, MarcinX" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "Ajmera, Megha" Subject: RE: [PATCH v2] sched: enable CMAN at runtime Thread-Topic: [PATCH v2] sched: enable CMAN at runtime Thread-Index: AQHYZgGyjgFuks/050iPI+ktClNfX603YKGg Date: Mon, 30 May 2022 11:19:41 +0000 Message-ID: References: <20220511135304.258809-1-marcinx.danilewicz@intel.com> <20220512131036.507178-1-marcinx.danilewicz@intel.com> In-Reply-To: <20220512131036.507178-1-marcinx.danilewicz@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 84a7bc3e-5884-4ab5-65d8-08da422e4ab1 x-ms-traffictypediagnostic: PH0PR11MB4887:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fX8L2nMwimyMgwv41NreB/dQKRHCbUx/LSqG7/Spi2gKsTxjMzix3YdxarBqzECg+Sdbz9Q07BdtCbGpyDlkbfKyqQRyZcqtEiTwJLmH/HnuG7H0hByZ1l76+VdZx2gN9fVDk80EiuGm7RBBJ9bCTccB8zaSrBoKaSejEFMea1l/QaWfwycYFBdZo1RGxx7Rpfe9Ub2aIxdRnG5kCSDzCc4k91Aa8U63yw+uc1y/7BE8FgtIlJE2gXwauyJBsF8iSEKPxFi5XtalE7T7lEDWN9wjSWPCd1uvWLFX4VuX0L2X8ImKoLoBi0Gl6Zfd2PCdceIl6iCgQjV6huetCPX/auuiSyYc788D/W/bOd8GgYSMPbewcgRYRvraA+Rr1NePaqBX0rQhcBw80eIWq0XwMq9EgCO0EC2JH/A6+VvrV76AqRYv0nZ6d7rNxjbvHvn6GaNm6A/xWOR9upLjst8KDV+IBd0iC1tIvphl9GMC+q298BLSxJU+7RN/CbhPkLvqyqkVYxExgLCHTRzE5KBQXYFlDjfI9gouJpjI7oGxnxUyDHtN4EUwpmh5Y9qZRH/O8PmL9F7sjALWg6Dmp984/goeYovuDe5nmgQrm2dzjo/SLrC1DJQQ5LyZcGYTluquqvxcdGU8PCY7xAMLZAX+0TR9s5/+/rNHpnto5qxjB/hP0obrvaWluYr5MYL657lbIGYqvBSQY8Loh0PO7F2JsQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(316002)(38070700005)(86362001)(53546011)(55016003)(186003)(2906002)(33656002)(122000001)(110136005)(107886003)(6636002)(26005)(9686003)(8676002)(6506007)(7696005)(66446008)(82960400001)(5660300002)(83380400001)(64756008)(508600001)(66946007)(4326008)(8936002)(76116006)(38100700002)(66556008)(52536014)(66476007)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NKoUOkaN3Btn8/yNkbOJ1lfRqfxuvO+4lu8Wd0wx06hzBZc0BCMTyboVlHnk?= =?us-ascii?Q?TVWmFwFDODLJuB9WwXj8ncym1vYgoWxkjk29FgtrGOpuXyPbr2Lf2eKvgBTA?= =?us-ascii?Q?VWFCn8ZhoGYH0ATStkZEyPYoh4rvYimIsaWHV975j36avN1QvoHEX8mCVmAJ?= =?us-ascii?Q?2Rbmf+MF4OpVAf4ZdRyq0xP6TfBrdkkG20K3mjSxUxRAuhMxokhGABG//3a4?= =?us-ascii?Q?5YijcCnud6thdukO3IWDkROnl7YR5SE2PMF/iv4XgcXgASIXwjh4KwPSkQgy?= =?us-ascii?Q?DH8ZkqaqrqQJ/0J/2ZwA170QzjDRkSEaI84d9FBOj7777UUVXaI1zxns9jyD?= =?us-ascii?Q?7nlwA4ry0CLwy4HS3yuvXdtLxMF8djlUdPEX67kku0wRTbscPs+5HWDAgxoz?= =?us-ascii?Q?0C/Y89i9I7a37hpH1AJvEsA71Qwjqor5+s4PdyKswisaQNq/HfG684XC0gW6?= =?us-ascii?Q?kT4/h1Rr2UozogsgMfF/TiGDfcfgTPEsUlb/JqknIthvgRtLK1Ahx7LREk+8?= =?us-ascii?Q?Okg3OtmMq3b1TsRvkC1RXygpBOXTBU0LcX20iB/9GFnghRkCnZv0Vb0QQp5+?= =?us-ascii?Q?+y8yT3dw9ZTOmMjYlr2Jnohqb233KVuWKglOYP6fm6b4dMd6AgDUEQBRSwEF?= =?us-ascii?Q?xkAAigdzC3K5n9pvnmxio48rdaAtYfGADbBa9Vu2wvPJCmVW+Ia6fUgDoJYH?= =?us-ascii?Q?QJYysEtkyrcbfAr/0rWG73mdOsz/thNcBQsMPOBThq1n/ArSCxBu9FIGIM3K?= =?us-ascii?Q?C3hCi4v05zxqPvu0Kk8UKO4RHIXvisBptitwik3rm9/t+S5u1mMPmo0wgra0?= =?us-ascii?Q?vIiaelV21ahC0OmG1vfBKdMR0JpyGCtYBjReZqMV7igkhmu2Z7iZxW7W0uKs?= =?us-ascii?Q?uq3MAnqV6EyRvMZ3t2B3OUU8TAGRo8F62x8TTDiDqitCoXACmPOP52Ofdvto?= =?us-ascii?Q?Dsb2HdtcOV7X+mQlVi6PBHajrGMb1SxgKnRVURitT2ppn86KCknKo+7HT0xA?= =?us-ascii?Q?tgLzRNZVzcSumsCuueDTgjzks6TB/XTn/DE8KlQlMw+rI8nVSxJhAk8zZw9S?= =?us-ascii?Q?4PP5qxKM92uYiwqyqA7zhNL21UJxJZ3JSUZYAeoAaL85t3LXygV9qjeytwU6?= =?us-ascii?Q?Mu92Wb0KPDPotUJeHJbwEd9ADJWBos5MU3G2FTvqF3jneAKmiy57ahEliJF0?= =?us-ascii?Q?00X3/PQ7DFeuOVToSyokf4RI91LFQt+3+6m0lTtC5ipZqlAPG7c7ADqWI+WV?= =?us-ascii?Q?i4V7Q23vJ4na680mGBEwhNofVGotXoZ0Wwe7UsDJKQKNsXR8aZVNcDVIxNWX?= =?us-ascii?Q?hLbMSsCJUzQ3mTO/4EazuUUGUk55qPT/qvNWPVtgWl/pyy7FMopzdTFE87xg?= =?us-ascii?Q?afWWlM7EF5CSRN8x3/DzKakFHfgk8dZmShwfOf9LZmh6KZ8WMnFE5Ky0Z4ku?= =?us-ascii?Q?cXCEe3/iwLXPlr0Q4IUp5fBNy75tKyIjdzlB7QbcvigRmJQmcMi097/vbJux?= =?us-ascii?Q?3mS3GkwpcEFQkdUll42LYMAVc/Jib5yE1CYFn68b7ZbATvalu+JZ0CR2l/LM?= =?us-ascii?Q?ER3wSvFVPp8RdAHTmlCy5O5ptllz8r7DOUohCUjR9CC6a0qM2hqvO6JnqXGR?= =?us-ascii?Q?Lee/U8Wp7+rPUcEBNMDzBPvHn06bYUgsXR7KC8w0fV9HWJuQnjd6jW8hcd/v?= =?us-ascii?Q?A99Ey3C1L7m88EDCNW0FX2s3vew1EpmrBCgphVzorfxSXviHRjt9NLg6aEpv?= =?us-ascii?Q?+51kH7E7Qs1/HSLxd6AFb3SvGLY0GWI=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84a7bc3e-5884-4ab5-65d8-08da422e4ab1 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 11:19:41.4946 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: t6MBq04qff1uFeDI8RvJiHG7bGVrtHPbcrH/P8QiXj9copzqzsxFHBJTmawOsN4pGLGSEG4kA5N90nFdHlHqUrez/Kvh2uAO9ni+cMvCcik= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4887 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Danilewicz, MarcinX > Sent: Thursday, May 12, 2022 2:11 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v2] sched: enable CMAN at runtime >=20 > Added changes to enable CMAN (RED or PIE) at init > from profile configuration file. >=20 > By default CMAN code is enable but not in use, when > there is no RED or PIE profile configured. >=20 > Log: v2 change in rte_sched.h to avoid ABI breakage. >=20 > Signed-off-by: Marcin Danilewicz > --- > config/rte_config.h | 3 - > drivers/net/softnic/rte_eth_softnic_tm.c | 12 -- > examples/ip_pipeline/tmgr.c | 4 - > examples/qos_sched/cfg_file.c | 14 +-- > examples/qos_sched/cfg_file.h | 2 - > examples/qos_sched/init.c | 4 - > examples/qos_sched/main.h | 2 - > examples/qos_sched/profile.cfg | 130 ++++++++++----------- > examples/qos_sched/profile_pie.cfg | 142 ++++++++++++++++++++++ > examples/qos_sched/profile_red.cfg | 143 +++++++++++++++++++++++ > lib/sched/rte_sched.c | 53 ++------- > lib/sched/rte_sched.h | 2 + > 12 files changed, 371 insertions(+), 140 deletions(-) > create mode 100644 examples/qos_sched/profile_pie.cfg > create mode 100644 examples/qos_sched/profile_red.cfg >=20 > diff --git a/lib/sched/rte_sched.h b/lib/sched/rte_sched.h > index 5ece64e527..82aa73ff5b 100644 > --- a/lib/sched/rte_sched.h > +++ b/lib/sched/rte_sched.h > @@ -128,6 +128,8 @@ extern "C" { > enum rte_sched_cman_mode { > RTE_SCHED_CMAN_RED, /**< Random Early Detection (RED) */ > RTE_SCHED_CMAN_PIE, /**< Proportional Integral Controller > Enhanced (PIE) */ > + /* New enum RTE_SCHED_CMAN_NONE added at the end to avoid > ABI breakage */ > + RTE_SCHED_CMAN_NONE, /**< no RED|PIE cfg available */ > }; Can you please explain why you need to add the new RTE_SCHED_CMAN_NONE valu= e to this enumeration and what is the ABI breakage that you are trying to a= void? The library expects the struct rte_sched_subport_params:: cman_params to be= NULL when the CMAN is disabled, why is this not enough to detect that CMAN= is disabled? I suggest to keep the current approach. >=20 > /* > -- > 2.25.1