From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE937A0545; Mon, 30 May 2022 23:13:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6AB84400EF; Mon, 30 May 2022 23:13:18 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 7BA38400D6 for ; Mon, 30 May 2022 23:13:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653945196; x=1685481196; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8DYrWeqcEXjCLHQgIqR1/uRwSxBv/mB5ncrvKZrf7Lw=; b=bhKriWSMYEr52xy/U4UpnA+bZier0XIltG2mCmvWHPJR3/cS05Cqo0qR CFQmhpm9ItEvbqsDMAFHqWYQ/aNCdRkSF3EcWNraeyiJC9ylGRFzCBU3b 4x6MsbURK+JTbquXM3yszmQn8rukkVCAIlGwECdZYcX+BLDVkfNpWCETd 3BpWEmy0/hsMeB01Oqs9eFpmhGJWAa3LE0oQ1ng0mDCLwYd3wqjTUK4m4 912jSaLvw6eYcD0b5mq9QrReJgYUI6vN0jU1omGeK/+vMigkGKQRjLcJf 6SxJfDRyM7elabAJxMXZXEpXOJSRXfNh6onAz2R6HvghMHZNI1IYOhBqr w==; X-IronPort-AV: E=McAfee;i="6400,9594,10363"; a="275081158" X-IronPort-AV: E=Sophos;i="5.91,263,1647327600"; d="scan'208";a="275081158" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2022 14:13:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,263,1647327600"; d="scan'208";a="562045465" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 30 May 2022 14:13:15 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 30 May 2022 14:13:15 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 30 May 2022 14:13:15 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 30 May 2022 14:13:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fvd+4lhpXQq4lAR+W7Y4FjQ8RXHQe/LECYMkML6L0fBZDCc+R6UDEwK4dw4gR1a5eiWVFUecIL8fEP+4Xh9Br5H/GZKAHdtgs1rcrHVdNJI1tKljx/se9cHJr2bNpIopybDM3uNVqgvVMyO0nbS9r75bwUnhXciwyFdNhArpQI2bpuVALTzUcfxWSYHw6Uq8ykNhXjKhGXH7tJOuwX1YhX8iWCp+2z8DFP3oJK/xqhubNZDy37+CPIoQk3sWFj+iwj+PKJ1pnRhjL1lHF/ZJIdSTqocHgeYpMTdjvuVW8bWpoQL3xb/O7/e1oSbrg8muglQOnNDVUoRToiP7hp/BNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ybnR7VDUn/syHETnF3WCHGQgEBB0ix+m889oLkcXs/s=; b=DFATuiwFwJFFTfR5Vp/2JORfn0al9lvZ3Ql6EyNsenXk6uOqVJhgRsxU/bye1pyQ/PAa7eYZhWlZgbmwQKs5IrPhYt8qpI1/EnglNoVxV9xmZjupM3Z482oYHo/YmBKQoYZzvrAY+ANqivk6NudvKxfgad8RWY7eC1ifH3ZIaOaFwOJguVOa6C15xgG4r5/3Aq0GiDeGYWHCyiMvIn7mwsWK/q6ix7P7oM/My3ymjO4bOU/z7jNGm/LxhcYW7oXYReS4U4C+UKKb53DpVGnhsy90494yUci0mLaEQ8NVbHghPJoUkTBbUzAFwEgZTIUfsHiArIWNfhSLzL0p/NBz1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by BN9PR11MB5499.namprd11.prod.outlook.com (2603:10b6:408:104::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Mon, 30 May 2022 21:13:07 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022 21:13:07 +0000 From: "Dumitrescu, Cristian" To: "Danilewicz, MarcinX" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "Ajmera, Megha" Subject: RE: [PATCH v9] sched: enable traffic class oversubscription conditionally Thread-Topic: [PATCH v9] sched: enable traffic class oversubscription conditionally Thread-Index: AQHYdFW5Iul0u+wzu0GWftvBJsVNHq036nxQ Date: Mon, 30 May 2022 21:13:06 +0000 Message-ID: References: <20220530133831.830307-1-marcinx.danilewicz@intel.com> <20220530184714.834764-1-marcinx.danilewicz@intel.com> In-Reply-To: <20220530184714.834764-1-marcinx.danilewicz@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 16271a40-c976-4d54-35b5-08da4281313a x-ms-traffictypediagnostic: BN9PR11MB5499:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LCWjcoCvUgYuIK838UX4QpNteRJXFsD81btaVmvOUi8q5Bo4mzvkcTKYIW0Kx/oGNzg1dwQEg0+iRe1wLdpgrGOXmB8J4C+MOaQ1MgBeuT2JCK+um9DzBgGQMJU1uYiyQyqi+SIgF9qFoe8lWY98+9MVY0VPs8pbOPyfX8Ep1fHqS7Lkr/mMT7tAQGBlxuX4qJi7vxcmJVl2OXYo7FKB9I0u607VC+JcCaZkE+OjeHkoq67a1FHyv3DRW1ADrdhlBPI47qyPSFtdvoWf76bhXGIDwocE0bZEMyB3k/5DEXYBcuPR5c0Ik8mHLae2waKjHNRp4nfDOjOYT7AzyazNbdTPFWYG75ooVfa7Is9dI2EvW0nU/MsCVsVHOvnIlowjj9bSFEPhYZUWwAsmLPE8q2CI31rn/QjQ2WQiaH5TwREt0XWA2M0HQGoUMEQqNXzDsQCLOt6TXE3UDkZ68kGt/lYdzE5K+vHNRREVcPMd2nVrB95EOTiv+pI3P1FigcAho5v6TSbOTz+Go3U/28iroVByjIuI58K3gezJW9KTi+DPgljZMJR+49pKKXUOULgTFNXW0iWNn9NUP2d2ZDBss1A0xneeKMwLflck7BI8+LxO5tXgHscoCQ351MU0en4xtjm/bReClKtQptB37M8apsOj0JppViv4k6VJrJoH6U0BRBLo1X4grQKLVFbKbi+G3VuWf1SNLbljOiqk8UCb5g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(508600001)(110136005)(52536014)(6506007)(7696005)(8936002)(33656002)(5660300002)(38100700002)(6636002)(86362001)(26005)(66476007)(66946007)(66556008)(186003)(55016003)(64756008)(107886003)(8676002)(66446008)(76116006)(9686003)(38070700005)(4326008)(71200400001)(2906002)(82960400001)(316002)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zo/iabyvP3OzpvxCiUkj0NSfIihNcGZa2Vg5SD3HyHQ7OEuOei90+2A8i56N?= =?us-ascii?Q?aJuyaov+jgatLvM0i1kU3n7pj5EYgI/kbviR0xHYvkogGU7X207+rX5H6R9A?= =?us-ascii?Q?hwCmr32FbtnCWz1nJ7VnrQz+zpMSL3UEqaOsSH+BCfWf4GHOYc/mrXZJXd6k?= =?us-ascii?Q?tkn4Vm1lPCoXIZQYOtj2xSlEOpAuLrqx6Yk7t6hftpc2olIJrmBJxiP3+E6d?= =?us-ascii?Q?rZ1D4a6FNnlmXtDHNN8mfai3KJhJxgKn5UFTjVWN5yLkN1FK8auJxcSPCVRQ?= =?us-ascii?Q?gUwr5eiqDkTVDA9TXjUBuw5JeKpkwb8WoAPubBa3AKp827RmiOMB70iR5Ese?= =?us-ascii?Q?tfvmirPtp6NaePF4O1V7b0+geyatrf393Iksj2GMBFkzVx8QFif/PE0FYyff?= =?us-ascii?Q?+VWa6V6UUU70e+q9H1G7f0geuk+sQiBKSwOsSL1J27tlCSfIGHZr3IdnEnzr?= =?us-ascii?Q?llfrabtsX8egNxujo6QhDW/eb2tqMX6LXra3LzO+Tqua6wo3rgcM7pGNZN9A?= =?us-ascii?Q?e/k1WOetx73iH9qOusNhk+t1zhuB2JhvFUmdiY2AO+sjlqlyVlnUviRMynZx?= =?us-ascii?Q?MJcbkaV8y8RuTtCH2LwELomOdG6PcEUnAr9CtCk4t8cLuND7qyYHnhJu8uGM?= =?us-ascii?Q?TURLCXlskfj0S5AQNAP9RyWo2yIH15kQ1jDpcxYkbQbNHzuYhTxYhKXf/u/2?= =?us-ascii?Q?W4H3II/xQBsVHjIDMohA4iv3SF8Nk6iCjfDx/mcX97FuoRxcqx8D3me9WDUy?= =?us-ascii?Q?eW9bHT/TndQ9Z7/n65DDNigCGwvfagu7/50rvPVSaemFFLinHgkqiLF4zpnQ?= =?us-ascii?Q?pmMMft6d6uBaPUGlL9vzfT9lY+9ROMKkHRu/E9lmg/8q2Mz424Mctx/shETr?= =?us-ascii?Q?w6HE1Hj8Hiwnw8IUs/dnxCQ1ijymILEBIR6dknJLY4MCoKDObvqmRUCz4oTw?= =?us-ascii?Q?rsCL3fZ8cedZ+ObsfgnsIqiNUymS1CekHupAUFwvfIfJm8XrX58FL+gaHCc/?= =?us-ascii?Q?I4wa7Iz/3xTnB1KCeYE754vdDmAOe7XF9lUcTDjbEcZV2xHIjm+jL1QxlxXj?= =?us-ascii?Q?HUIieNW1cOEHkrsBkTZ0Zmy6qY76ofJKJtWg3QHVqR8rt8qqabM1GQHW04RC?= =?us-ascii?Q?/5iZ9pLqeX4iiIv/6q/QUftSC8WWui0eevoU8fxdr0HnGK5dcTkrWpTXjSCE?= =?us-ascii?Q?FOtsdCac4NND8Fkphx/kX+e2N/K+Hfq+trGNVpis1/B0TBR0S9rrUK2jbKx6?= =?us-ascii?Q?i9Dko9HiVd9JMvvt1WGhIHZ5P7PAsEza26qpJQOhsc1wlQd38vcjIyo2Shke?= =?us-ascii?Q?uiMFnlbmXxTvWuWPoVM4E1kiJQxuwLn0a7IH+frGCd1TJoQ8EO4RTgEwWeYV?= =?us-ascii?Q?dxbz9h3vh/zjKBoGpQUrIV4KZQoJJpm4vSC8B3+GSBfoSOJLd2ZcuSPwgshc?= =?us-ascii?Q?mjAZUKkzZsnhQBgcUL3IxQOL79mWeWCHkPMBT7cr1VzuPXl7mp8ncVu8hBuE?= =?us-ascii?Q?qdp0u+r2T6hb6JuDCavDc45nBQ29xO6lFBy59ToOYOJGIVS6zOXTw0F+z/4m?= =?us-ascii?Q?hxvEl7V0PWt0xVYTfSoM/EDp72hALNfsiiy8dFCO2UGlO7xGwWhZsKcOfLpo?= =?us-ascii?Q?PgkC0sW22U1XEpOR8y6pzUwfBlCLuJ9BmiHLBCMUIEiTteEAreg65NaY5Nco?= =?us-ascii?Q?xcgxoVBom+TWlD3uGfc1rOghj/7B+EXv/LWn0AXn0jWvBJ6yeHaAdpdZojHf?= =?us-ascii?Q?kpROYnEuSvkvmX2xDNPQZO56pHxH9Fc=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16271a40-c976-4d54-35b5-08da4281313a X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 21:13:07.0147 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: O1OBBtb/djdmCzVQJKMr78wYrdLJa2UdPfmBnZ2tdm8t5yYi9rnKRr+7SIN6P10jMQNSfFETB/zy8LgYmLtbmm/Iof4/ZAU4R0HhqsNUsZ0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5499 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Marcin, Comments inline below. > diff --git a/lib/sched/rte_sched.h b/lib/sched/rte_sched.h > index 5ece64e527..317ab3b68e 100644 > --- a/lib/sched/rte_sched.h > +++ b/lib/sched/rte_sched.h > @@ -579,6 +579,24 @@ rte_sched_port_enqueue(struct rte_sched_port > *port, struct rte_mbuf **pkts, uint > int > rte_sched_port_dequeue(struct rte_sched_port *port, struct rte_mbuf > **pkts, uint32_t n_pkts); >=20 > +/** > + * Hierarchical scheduler subport traffic class oversubscription called > + * to enable/disable feature at runtime. The "run-time" word here contrasts with the "initialization" word you use o= n the next sentence and it is also confusing. I suggest compressing the abo= ve statement to: " Hierarchical scheduler subport traffic class oversubscri= ption enable/disable.". > + * This function should be called at the time of subport initialization. > + * > + * @param port > + * Handle to port scheduler instance > + * @param subport_id > + * Subport ID > + * @param tc_ov_enable > + * Boolean flag to enable/disable TC OV > + * @return > + * 0 upon success, error code otherwise > + */ > +__rte_experimental > +int > +rte_sched_subport_tc_ov_config(struct rte_sched_port *port, uint32_t > subport_id, bool tc_ov_enable); > + > #ifdef __cplusplus > } > #endif Regards, Cristian