From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4DA3A0503; Thu, 19 May 2022 19:34:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 73C7340223; Thu, 19 May 2022 19:34:58 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id D1E4B40156 for ; Thu, 19 May 2022 19:34:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652981697; x=1684517697; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=BtjRVQFMfpeZ1n3ezRlA1o2d/cEiBGVfJDOo/Jujmvk=; b=Zqaqgb8ppFi+TGBfaW8qXpxcJFghj5+fHSsbfiSIeYkOfZkDf18ODlcY Ncjm2+gR1Uj8zclHfVwCyYaaVUtWSGuCZfK+hriXjPJMGAxHRck5hi05q Jw7CKpjQhEEyzH5M7X2lIQMjxuY+110NZ9+oqs37RN/BLselkZtfBnclz NlSKH/GnOO4n4E9guQd6v7TzzWQFkXPbs/GRqBEqaKNOePw5jkGavqzx3 XBuDzStHnsPM+XMPmJOGdCAwQIZ7a8CvrGhfYaeIe6vLtjJYXmEJjuwRV qZquqnMkKstTusdzj2XyUABuqe1fb8nD1tBACniIuXO+mu+ckqUdxRl7G g==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="335343712" X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="335343712" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 May 2022 10:34:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,237,1647327600"; d="scan'208";a="598698134" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 19 May 2022 10:34:55 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 10:34:54 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 19 May 2022 10:34:54 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 19 May 2022 10:34:54 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.49) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 19 May 2022 10:34:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WpYS98lZ6teJR6hpjNcR9aJ35gwegpSZtl8CySjMSLoLftimQslAvGfIoaXu79YIMV4WH/5vm1PKW9yVTyG3aJfuMfYFH4YdSAhVGRjveGot9dcg6vIjBGb/LI7PiVyeLLm5CubIKQV9R8A1JOTASOmoiTkReUuOp+pI/UGvCn69GD1FCJCfcJpwnst7lFrTOxOBJJ75B+3GtOLdXCVuAKXPf+EnGZrr2c85Juagq2+2DLGX9g904mpndjRDsEQ37r3qc1nMsHshYK8kSg/HtIQRTcHucsfiDOjaFW51yADqFfOlA8eo63L/gGlZI0UAmN0MuOnOQSdRfS1bBMJYhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yGOPNOrq3A4TkiyxafDAnvNZoTFdU1VTSdzW4WROXPw=; b=SMslMQrnBDz/wiW0tBcWWJaAeTjXRcFAVcT8nnrz4OgtFfXTjBKk3NT5Kl7J0hMJbt6L47hv34r5N7qeYlAWLA8/+rRmGLRNXSrxqGuBTzqH7iqLY1B7b9IEquotMEIaFHJPlBNW3FJ6PztDQRpKb/12tW7Ak37ba39rMjqEOPMfIzj9VhYYPNdIIGMxf35NumADkvcqMfmp2+upn9WAeUaC401YPMmW9e35YKMjrImqJXMVFc23WUUacshl3BMzKH6ywQ7f3MBLCgGM4K8Eax2pocZcGCfrgO3CrJjwEoJYrZEHPpN1EPuwVTCp/x9xGdOBQVb6x90Ogh0OZngUjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by BL0PR11MB3026.namprd11.prod.outlook.com (2603:10b6:208:75::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Thu, 19 May 2022 17:34:52 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b%6]) with mapi id 15.20.5273.017; Thu, 19 May 2022 17:34:52 +0000 From: "Dumitrescu, Cristian" To: Alexander Kozyrev , Ori Kam , "Jerin Jacob" , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Andrew Rybchenko , "Vipin.Varghese@amd.com" , Ajit Khaparde , Ferruh Yigit CC: Ray Kinsella , Sunil Kumar Kori , "Ivan Malov" , "Awal, Mohammad Abdul" , "Zhang, Qi Z" , "Richardson, Bruce" , Konstantin Ananyev , "Singh, Jasvinder" , "dev@dpdk.org" Subject: RE: [RFC] ethdev: datapath-focused meter actions, continue Thread-Topic: [RFC] ethdev: datapath-focused meter actions, continue Thread-Index: AQHYaVDsRZG6pHheSAGvOP6NbrvKkQAADvXArSZwc/A= Date: Thu, 19 May 2022 17:34:51 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d58f3b6b-e1ba-4908-9973-08da39bde16c x-ms-traffictypediagnostic: BL0PR11MB3026:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7Jv45D9x1+xyzACJLAcxoxNRDYXA9YyC7wkGORgGhbQWK33HRhqAVgPJ06vy6As+PAQcH/F8s98aYUS4M0u/f8HiURs/OU2Og3/zXAa4lMWla2vEiMNkHDt4C4FTOGNwRhACoCXhAD9oW0WtORi3U57JHbZ8mBrVeiFH7GBpTwT1pJUQB5TrMKT3ZtyJqhTI/GsrwdHO9xhPDL/OrazMins14ApZ1SP3xx4LhV7AckdBi+aJAyDGytla6K87CajxuzNB9D2d/VlxdTpUDSVN+D5zwi2L2nHY5sDRdZiUkWbhtFocA0N21rB2yvYBpE64/B3hyPm9qcIkYcAjQeaaCvHymS8SLGTh7meZhMFi7LQgww71C1vdP+15Ed7nFwLtnaijorOQ+cQtCdsDOS5YwejK1HvmFAkxSmalK0YEP1mrReDGKAya7b48oc3kY0+dwUH8sTQCqVDnhX48flPJmKP0jxw0K4QyaZBE9qh0nT8CRgT59ew0ntPJncx2VdxsnLDJFSftgXTeU1GnQvodHVMlWbDDAmsFYp36IK0a/aYOEeX0MRBQ6K5msVtgQBID2p/qWd2MqLRAMMgD/eQ9+2BdQG2GkIQ/si10fLtaLvL7lRoH8LjZiFLWUVZd4rq2B/W6K026eIvqazQI/fkOXc6xPzi036LK89dbR1h+BYXMqciJHWEN0SiZgD09lWvmve9AFfN6LSyfWulf3/HZF6XrCpJ5XYsPHBEKDhD3AfbNWqFTA86a6pu/hEI2KDDRjaie7U5DM/HlQSfMHx79U4fZIDGj0o43/uHC9Q/uJFE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(53546011)(7696005)(2906002)(66446008)(86362001)(26005)(6506007)(508600001)(9686003)(7416002)(8936002)(71200400001)(110136005)(55016003)(8676002)(66556008)(4326008)(38100700002)(38070700005)(66476007)(76116006)(64756008)(186003)(52536014)(33656002)(5660300002)(54906003)(83380400001)(66946007)(122000001)(966005)(316002)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hXKIZ/cAIbiT277+KOULGHfwGNzbei9juFbz55XD5qHa8htVaQwDuHPjuy2J?= =?us-ascii?Q?+GP/nKMuP8Jrp1GJLgg1yQAsREJlEs0JLnwdH/yA42BwB9dMB1QM+qihy2qj?= =?us-ascii?Q?9FHKhlSnXYr3ydVuRpQ64E3oeKcB/g8UT5oLMfkMWEDaOm2OeDU+7S283//G?= =?us-ascii?Q?HRY4XRc6tHxhxYK/3LpS47lu++U+wcY4S/uJON9N0KpF4N2C4Vdp+5tDSF/a?= =?us-ascii?Q?Jikz6qs0D/EEd0ke3BHxOex31W9QOFKZgrViXLqMMbiOcb/dBiXwd+nw9Dxl?= =?us-ascii?Q?ZheSFmJLWjII21XfjZrgtX814U5Br7BLDAqfg/jO0cwH010q1lDR4hNInWH6?= =?us-ascii?Q?f9iKll8/SAkk3qz5H3D4YseuOplruSuGAoLYRZGPAezuC1gbG79MbvYLvNoh?= =?us-ascii?Q?wW2wNDgsc1jtmOKpW8etLqsDGMyZOcNTdoR2hGAcmbCL7QVrj8Ik+fQkf5Fy?= =?us-ascii?Q?cc81Vkv2O0lNIASb9oNW11eUQkCEKp7nFAehtnZ+Twij8ul+xSBqGRasPfCl?= =?us-ascii?Q?7TduY45oKfNrnX0jADWEOwSWB0hMk7tNoaZzKQkKqF4KWf6v78+OVGUHQtPD?= =?us-ascii?Q?qSrZ7Z/bsmPBxhbAty/CmkwiVrk7XBpeTzSTj1gIi6SesQqx6FPgE+dGMcms?= =?us-ascii?Q?wntLErD5EgtFHcQofZ3sSm2MEKtxWWUM7XjtZEE3qTdRTy8j3o4yvxFKW8/B?= =?us-ascii?Q?oTEd0cVctFuykqkn+XdOQFI7Rh+eSs8B1/5g+B8krVVLQ3OWJv0g/hK4NM1I?= =?us-ascii?Q?pst41/cloecNFruWtU+3PNb6kKHggWPpJIDzZgZt019t+f9WMoR9szFYDqXI?= =?us-ascii?Q?TQgEWxntdM+AZZ8zvpFH4+ulRRGZBMwFiHEQ/eAxDcykFATkKTm5Z8sqSt71?= =?us-ascii?Q?Z69Nj2KracVYzKPJJMDU8QY5AKIZsq6vf4nsElG0euCxYofGn4n2NDBzcNi1?= =?us-ascii?Q?EWSP9s7B9wu/GJQ11+t5wRJ2Mh5+VLfOrRTlqZ55CMjwnQpdKo5IfwJYoX7s?= =?us-ascii?Q?vIeDQ2jraK57LBVAZ7iZn6t1KJ+kHW8SP+ah7f9V6B390jsbXKPwxUruNtkn?= =?us-ascii?Q?X47puaDwxcUpQNHeYy50I7Q/tyfv6FgtVYqXRpfbIbmK3nhO4UE3X1ooSDn1?= =?us-ascii?Q?mwMxVbPBRFgMtWkh66gp5KGJoMG5M3Mw0XqCDpJvSnrjh0DLP2cndRPZER8b?= =?us-ascii?Q?vIYYgckVSAIMGKKiCauYVh/S52GiZZZxaWrtbUq19ZnamgsxHJCqtOfbz3qK?= =?us-ascii?Q?+UQMgHa/gzyy3kXmI9//Q/4ZGAwOiQY7wsyxzx1x/QnZ/hGu6iLf6DN03UrG?= =?us-ascii?Q?rNsFahhWjwNF+YgrlflqJCYLNXWsh83VsylAlhzjQUnt7qToj/CCGN2PhpG8?= =?us-ascii?Q?hFVkSNn6PiCq3U3FmpR22IRkKHvP7sxQfgFnHANK1oADUztARun5MIr3DsZr?= =?us-ascii?Q?MxtCTFTHpCKox9HJz041qyAi8ESYcE5qntpWtGerGXDpvw6Z05+8KGs1PDWE?= =?us-ascii?Q?I1Cb2UCh184dzwtcfjAUaVbEqLRInw33xueTFdR3lp1odNODRfKRQsXFx4om?= =?us-ascii?Q?Va+cRSY67NlG9ZxmHzNhjCbHZliowV8tHn3OfDIJJocpaof0jxEglRl9BurD?= =?us-ascii?Q?P8rzy6lHgUw29d5giBT1fl28JkPQL4gRk35JtHlTA7aEUQwegj+JVLV/jE93?= =?us-ascii?Q?oE+o8YwxFSzVEi+fRh2ceMScKjwDfKZihgTmY2Ur5gm9vd07LL5nDOOr09lp?= =?us-ascii?Q?YWk03ABJKuAxLZ919XFgNli3jS9LHXo=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d58f3b6b-e1ba-4908-9973-08da39bde16c X-MS-Exchange-CrossTenant-originalarrivaltime: 19 May 2022 17:34:51.9783 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: A434OoySv6Dk04kmToSbA3w6XdmICa9mLUdFg3IovCOQiOSPA5awArttt1PZ3pgIBh/YUCiGgYI79X9wN3mLPF8fodJdODe41TzA7WwsFjg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3026 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi folks, Here are a few takeaways of mine, with a few actions for Alex and Ori: 1. Problem with pre-definition of meter profiles and policies: In the case = of the data plane adding flow rules to itself (as opposed to the control p= lane adding flow rules to the data plane), the API requirement of pre-defin= ing the profile and the policy results in a performance problem. This is be= cause the driver needs to acquire the lock to the list of profiles/policies= and to search for the profile/policy ID within the profile/policy list. Th= erefore, to avoid this issue, the API needs to allow passing the profile pa= rameters (i.e. the full profile) and the policy parameters (i.e. the full p= olicy) to the meter object creation/configuration. 2. Add the packet color to the list of possible match items: This would mak= e the meter policy specification redundant, as the packet color that is set= by a meter object could be used as match field into a subsequent table (gr= oup) to apply the actions that currently have to be specified as part of th= e meter policy. Therefore, in this case, passing the policy to the meter ob= ject creation/configuration is redundant, and therefore the API should acce= pt passing a NULL policy as well as a valid policy. 3. The flow METER action needs to continue to imply the implicit action of = setting the packet color (internal meta-data). 4. Translation of meter profile (i.e. srTCM/trTCM rates and bucket sizes) t= o the implementation-dependent low-level values: This is still required, as= it is taking significant cycles, which is a problem when the data plane is= adding flow rules to itself. What should be avoided is the registration of= the output of the translation as a pre-defined profile ID. 5. Proposal to create/configure a meter object as part of an rte_flow actio= n. Question to be addressed by Alexander Kozyrev and Ori Kam: How do we get= an ID for the meter object for the purpose of (1) sharing the same meter o= bject with other flows; (2) Freeing up the meter object after the flow is r= emoved (in fact, after all the flows sharing the same meter object are remo= ved). 6. Alexander Kozyrev to provide pseudo-code for the meter operation with th= e new proposal: (1) meter creation; (2) meter sharing; (3) meter reconfiguration: do we need to remove the flow/flows using the m= eter and re-add them with a new meter object that has updated configuration= , or can we update the meter object itself (what API?); (4) meter free. Regards, Cristian > -----Original Appointment----- > From: Alexander Kozyrev > Sent: Friday, May 13, 2022 10:37 PM > To: Alexander Kozyrev; Ori Kam; Jerin Jacob; Dumitrescu, Cristian; NBU- > Contact-Thomas Monjalon (EXTERNAL); Andrew Rybchenko; > Vipin.Varghese@amd.com; Ajit Khaparde; Ferruh Yigit > Cc: Ray Kinsella; Sunil Kumar Kori; Ivan Malov; Awal, Mohammad Abdul; Zha= ng, > Qi Z; Richardson, Bruce; Konstantin Ananyev; Singh, Jasvinder; dev@dpdk.o= rg > Subject: [RFC] ethdev: datapath-focused meter actions, continue > When: 19 May 2022 15:00-16:00 (UTC) Coordinated Universal Time. > Where: https://meet.jit.si/DPDK >=20 > Agenda: continue discussion about proposed improvements to Flow API in > regards to Meter handling (slides attached).