From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 83FFAA0A0C;
Tue, 29 Jun 2021 13:35:16 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 06A8E4117C;
Tue, 29 Jun 2021 13:35:16 +0200 (CEST)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by mails.dpdk.org (Postfix) with ESMTP id B6BF140E01;
Tue, 29 Jun 2021 13:35:13 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10029"; a="271984463"
X-IronPort-AV: E=Sophos;i="5.83,308,1616482800"; d="scan'208";a="271984463"
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
29 Jun 2021 04:35:12 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.83,308,1616482800"; d="scan'208";a="558696775"
Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15])
by fmsmga001.fm.intel.com with ESMTP; 29 Jun 2021 04:35:12 -0700
Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by
ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.4; Tue, 29 Jun 2021 04:35:11 -0700
Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by
ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.4; Tue, 29 Jun 2021 04:35:11 -0700
Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by
orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4
via Frontend Transport; Tue, 29 Jun 2021 04:35:11 -0700
Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by
edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2242.4; Tue, 29 Jun 2021 04:35:10 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=ibhoAGmydx3Neu/xkELJLCv91EvBvlMlBsUjPyYOwpp6ijTIzeoElPd+byqVsCyP7/9TWCDwXp16yaBdeTjLpDMq2rFc0l83lagDuj+7GV4+IdlJYjs9A6r4SY0CzM0Wl4/5Z8jCPQd1R8E1prHDQpUx/tmZQ0fnEIMp93Z/yO1WKdMBal38F3ELpzsmssAbuqtN1Yi18/JgUrjrANIKpsIwuANTprGpsZPwnhEFJXyTnLENxd+xPQbS0YWt9G3GahquHFymptNLZknKhrfi02hJCTv/eSymU5/3k2mWOCOnfjrwCVUiadPYqT/OcuNx1nk4goAM6YGPbRHCHA96jw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=vR1nBl5Xwpp7Yj10Ws4S2UuuKOGOur7uGwr/jYo1O/s=;
b=GGt5qaJuH0zLOb4fnp96Jbb9PWTe2Dg02RTbpONqgnG0POM0AD1Ez0w0C/9bj8CxPE6dVPDGcuji9VuwgEC/atv8zQxwM+aP0+paD+nllU1OxCb9Fr0uGA4BldsWkLFYcnYzcSw2msA4pk+tMVr56hWs86XfIB6Q2hccAHSP6yhciCXbN/kbiJVrumWgYmeTzIn07jiTUu3sHKokSroKXigjbfbXUR308fw5H0u3Nt5NXt2CKn8+kPw10y5S8S9xh6DGmtUuHaNoz+mC8w0DxbfrPw+EI0OH9r1znF5Spc2f6Qm+E2HT7TDFo8SjuvFb/zGIUj1dHZ067wMYag6s0A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=vR1nBl5Xwpp7Yj10Ws4S2UuuKOGOur7uGwr/jYo1O/s=;
b=oHn2Nx/OXfDjuqPUuCEohfDTTHrCQtWxvQKk63FYrgvU+agEUgAHHxnjlmzJWS3t70c79uSG1f0wQLMI0bejc9bIqO7YN3Pgbn81/vBT0SBC5rziws98y/sU6E0fEdYh+Ov+NFuQnh87f0UpwoNT8q0FZg4xon3WrVZ2lq+JVQ8=
Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by
DM8PR11MB5591.namprd11.prod.outlook.com (2603:10b6:8:38::23) with
Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.4264.18; Tue, 29 Jun 2021 11:35:09 +0000
Received: from DM8PR11MB5670.namprd11.prod.outlook.com
([fe80::e0f9:356e:4e86:85b9]) by DM8PR11MB5670.namprd11.prod.outlook.com
([fe80::e0f9:356e:4e86:85b9%3]) with mapi id 15.20.4264.026; Tue, 29 Jun 2021
11:35:09 +0000
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, Thomas Monjalon
<thomas@monjalon.net>, Thierry Herbelot <thierry.herbelot@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [dpdk-stable] [PATCH v2] table: fix typo
Thread-Index: AQHXUI/9ZE9ZEBe9tkWB87H3KQvEVaryfwcggCVs6ICAAAMEAIAGamIwgABw84CAAAWtAIAACz0ggAw5FfA=
Date: Tue, 29 Jun 2021 11:35:09 +0000
Message-ID: <DM8PR11MB5670B40C84A7B8A1755A0EB6EB029@DM8PR11MB5670.namprd11.prod.outlook.com>
References: <20210524085341.15184-1-thierry.herbelot@6wind.com>
<DM8PR11MB5670F7F6B9578261D48FAEEDEB0A9@DM8PR11MB5670.namprd11.prod.outlook.com>
<786a1730-37eb-8f22-7812-74a8a7096dd9@6wind.com> <3815134.CEuO83SSsj@thomas>
<DM8PR11MB5670AF0DBF3B05BF465FF925EB0A9@DM8PR11MB5670.namprd11.prod.outlook.com>
In-Reply-To: <DM8PR11MB5670AF0DBF3B05BF465FF925EB0A9@DM8PR11MB5670.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-version: 11.5.1.3
dlp-reaction: no-action
dlp-product: dlpe-windows
authentication-results: intel.com; dkim=none (message not signed)
header.d=none;intel.com; dmarc=none action=none header.from=intel.com;
x-originating-ip: [64.43.147.100]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 704af9f7-732b-4187-b626-08d93af1f34e
x-ms-traffictypediagnostic: DM8PR11MB5591:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM8PR11MB559168467298084B047F16EBEB029@DM8PR11MB5591.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: DcvFgw4qSgqO/7tm9aT1WRU7JFsFmXx+bxzS//OgivkmqMsbK3mCtYGXfeR1vtRpxX39snH6yGc38QGfgPwQJiMd9BZSQnE1KNUKSMWUvRMH19ZrPYu3x15SQ+1QooHVWje2eGlVdHOdIdaAmYc2VHarqwLCx+SFiCesrE+1DdedeyMMH7XHaapH6b7qWyUQR/XFj/XRQvaLV5V2I+OZa3czH8iiT2ZozGUHEV2m7XqOV50OMoZXlBa7veBdeqHHYZAW4+J2M1B9IUWaxXbdLc9TKSVwlPXYLqcHHcLDCI992K6PWu5U3c47rXw/iqw26gCXF6aSPmB3ypMU9P9ThaVZbbTFTjzTbV5QgDimQ8l9q8MsjOZ8eBGsxhxmXSVmibWj2Nd5hn1eoxt2Lg3uR2LVY2/whniz9YV7KSzY5iyd/mvS3+gvfPBxSKosyAsAoMJpp0e3Soi+Ez8q0MwNt2seQ7bNJqsGZtJhk5pghtffaxuWDsHboGeNPydrI9myVvnDg1eddfAMZYilWcWpizsqAu2cKf391Z3uxwpv7yaPHSg4ANF0wp0jUqkjNNaxp3f5VeQLIY0tTkq8x3FmRpE5ntOGrA8J4lRI+zcUfqCsjsQyFLg2gIiwHH2Z3J17KeECCM3XtZk0WQITVvW8bA==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(396003)(39860400002)(346002)(376002)(366004)(136003)(86362001)(9686003)(76116006)(7696005)(55016002)(53546011)(66946007)(6506007)(316002)(110136005)(83380400001)(8936002)(33656002)(66476007)(66556008)(64756008)(66446008)(54906003)(478600001)(8676002)(26005)(186003)(71200400001)(2906002)(5660300002)(4326008)(38100700002)(122000001)(52536014);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tmZgXnQwtY3dO3G0J0F6G4gQytKUm7wZfe5OBeoqcRZq5HkiPRW9FCf/l9Qr?=
=?us-ascii?Q?jtl9fiYohL8YcqSzOoJPmJW/PBNLh0hAeKoANH4AM/VT6kBObjWtGD8RDz5j?=
=?us-ascii?Q?1CTJKwphAHEWbhroy/+FAAU505WMvOuyWG82d3bjw9mLTIiEk5aT//d6ByK8?=
=?us-ascii?Q?ucYkwl/vYfNkvRh8HxZBd+iWM2115AMJ3TtR1mQcPM+w+5L2AaN5MVxxbDtJ?=
=?us-ascii?Q?0ThMqWMLaR6AAROEwrFNeB6YdImgqYJ0QXZhwZPaSJfPBnll0ODMRmfqcJ3+?=
=?us-ascii?Q?2fU/m4vIwlYoRz3jQCBbBlAxglBLZmoYq/fXYQne1bXZ2oraflsxugHSh/gH?=
=?us-ascii?Q?vXWLM59IhODwpVjSA+Ug3GJiqjPGB6k+m5pOvjtxJLF32A3i89HmSHTWq8Qx?=
=?us-ascii?Q?mcfScvRYHscia8JvOhP3pshbVdX37ZNZlVCe+ZUgDYZoRPsXkSB+SHcktIEg?=
=?us-ascii?Q?sIDwsksBhDcInI+VNLkikTfCdbGcKcBKbioUOcQeL+uTGXqmuSspx5k5vzmi?=
=?us-ascii?Q?LZdwYirYWv8i8o3llLLzKsEzmdFAN3AveRlY5vB5bhPS6x73ZXxO1zLiSFxM?=
=?us-ascii?Q?VB05gsni1tvL+uFKP2O7/SwrG96X4svbat2pTBqo7ayCMoOv6ZtqJ1dIVaQq?=
=?us-ascii?Q?YfnSeub9duv08qEGauA5S0Ws/u8BtZlBTq7ztBVXGy8HHe8q7q5/Oh9Om5WP?=
=?us-ascii?Q?CzJJF/gk7dWvqlif8Z47sszrBrG/XA09mLPyoLUPK7pPJY+9qQszBAc2Mx1v?=
=?us-ascii?Q?U9G6i1bYCuF0D0SZ3mrMgih2V4zLRQxDRZAi+mTe2xUH3dPTZwB0aNSXAIAw?=
=?us-ascii?Q?Bq1mw/I1KgW3VRDFS98IZy4FdfyySxfOTfsDAdxkjeBz+hR41PFt6JScW87r?=
=?us-ascii?Q?ULrIsbY3vxTQfye8CFDScdX1CVjlMHStdC7mCw1blb9AlTqM2phCUsklc+cf?=
=?us-ascii?Q?D13d0XY9CFJqCpS/kzNxWFC218h+nle0xoyC7RU4VUPsQdQ4Rl3yVyvnQZDp?=
=?us-ascii?Q?Pty3J3NmySKCcEg8v0kkpxQa6UsQCmg/AlneD1uTXqvwUHiaCXTCMFsGYS9C?=
=?us-ascii?Q?aKEl04rgafr+6iyX8g3ylwnWjHQk71YoXLn/jGHeAFKIEFlPlfqT84EEeQD/?=
=?us-ascii?Q?Tnu0MZHApys3b+DFDKYgZjFfuWWm5hKJEtxELMmONpa3PsWJDJBwoW+MALOU?=
=?us-ascii?Q?5IhlafKYtpjaX4ZMItcZhLnKVt2zIOudyN8bTkk+0AGXxVpLb6ndZD61Euz7?=
=?us-ascii?Q?e9bYR/MVVe6a/uy7NWFbIvck7JYTmqgMfcqMuXpLwBoZK58zPsZCk9CB1dPI?=
=?us-ascii?Q?X3rjmvJucGaBuWjKmo8W7yrh?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 704af9f7-732b-4187-b626-08d93af1f34e
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2021 11:35:09.2729 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: fyNj7OXpkc4Z8JUk6UT8z8XZ5J90ip7N9TqKDZAyeGA5xlbwdzpZSRbjEim+vhYuF3Fq4PlRnasW7IoLQ1yfMlAW8EqUyMyOdiIkyTlBKW4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5591
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dumitrescu, Cristian
> Sent: Monday, June 21, 2021 5:56 PM
> To: Thomas Monjalon <thomas@monjalon.net>; Thierry Herbelot
> <thierry.herbelot@6wind.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo
>=20
>=20
>=20
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Monday, June 21, 2021 5:15 PM
> > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Thierry Herbe=
lot
> > <thierry.herbelot@6wind.com>
> > Cc: dev@dpdk.org; stable@dpdk.org
> > Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo
> >
> > 21/06/2021 17:54, Thierry Herbelot:
> > > On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:
> > > > From: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > >> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
> > > >>>>> Check Bucket key for all possible indices.
> > > >>>>>
> > > >>>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
> > > >>>>> Cc: stable@dpdk.org
> > > >>>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > >>>>>
> > > >>>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > >>> [...]
> > > >>>>> - return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt-
> > >sig[2])
> > > >>>>> + return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt-
> > >sig[3])
> > > >>>>
> > > >>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > >>>>
> > > >>>> Thierry, thanks again, you could have actually added my ack from=
V1
> > :)
> > > >>>
> > > >>> The root cause looks to be a typo indeed,
> > > >>> but the impact or the scope of the issue
> > > >>> should stated in few words in the title please.
> > > >>> No need to send a v3, please suggest a title and I will apply.
> > > >>
> > > >> table: check a bucket is empty for all bucket keys
> > > >>
> > > >> Thierry
> > > >>
> > > >
> > > > Hi Thierry,
> > > >
> > > > I think Thomas is asking for you to send a new version of this patc=
h with
> > the title updated. Is this OK with you?
> >
> > No need to send a v3.
> > >
>=20
> OK, so you're going to fix the title while applying? Thanks, Thomas.
>=20
>=20
Hi Thomas,
I see this fix is not yet applied, is there any action required?
Thanks,
Cristian
> > > Hello Cristian
> > >
> > > Sure !
> > >
> > > What do you think of this title:
> > >
> > > "table: check a bucket is empty for all bucket keys"
> >
> > This title suggests it was not the intent before.
> > It should say that it fixes this check,
> > or better, name the area of the API which is fixed.
> >