From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 829BEA0032; Fri, 18 Feb 2022 12:17:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2422040150; Fri, 18 Feb 2022 12:17:09 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 4CD7440141 for ; Fri, 18 Feb 2022 12:17:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645183027; x=1676719027; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AUoZKC6c62Pdao91kxGCHx/FPCMxP6z81e+0Xn5UP9o=; b=UJ3J9+UUPUV4NU/lQvdAD2wpxjctDjbbhjpVOAQCrBMu0JLCt1hsENaO jG6pnZ9Sy8H6xC7mnwNyFayv7/YV6TM3iBVdi92GcB2bfgctlIYpUfIlu cW+uL+CfBGBa0NN3aFYSeGL3Ciz58vEjkD0pYCw7Em7OP3y44ycHCX/Aa R/dVITImvipV3lISOcz7y98XyRxdmd/0fGOQoIgDLBbFvSed3V5Q93NjT 56gU2QegATU9Xp6oqEG3m7LSAQYMbXSIS1GICY6J0hARb/Ym7Tx4VFgoA Uc12WrO5l6MsXvvp+N/AopPfKBPYvzkMR+tubwDan8+MsOXfmfktDrCkW g==; X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="275704062" X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="275704062" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 03:17:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="503971579" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP; 18 Feb 2022 03:17:05 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 03:17:05 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 03:17:05 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 18 Feb 2022 03:17:05 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 18 Feb 2022 03:17:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XA/SQgEMznNRtbxdMRYzdGtcBfyb8QcKv1yQvbLCjs1TZymrU37qz+ylXj1DUtlj4vPSUAM3gvCQmB/EofB+ZaoaGNetlPExc+wPCcHhIXUy6UBXmRgOU6sT2hXrNWTRa4s8dlx/zGD2U7/KVn41oIa6VqKCbITHO+p6FqNIzSoV6s7XLX/SU6yXR/T5nsZGscjwbbTkuuBdng3hZdvkkRmRXpFCKGxG+pqfhYdcydzlgnb2uHWL3QwGji13arn/jrsqWrCgocUTOiPa2EZBFSGWMYjKSYiwmJ7LMHP+Ks0BAoAIU75jQ24j5wZv1Ka0AMwisFSamhwf+0BgRs4H+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AUoZKC6c62Pdao91kxGCHx/FPCMxP6z81e+0Xn5UP9o=; b=nDVQj3DO8dj4HyC8l/KtGM3YlRaFPKPSdOl9dfz/nDeDNFJrWvhAscViVH1F/qBFB9Y+orO1oEWzsPKvNX5H9GzXydbI89xCvVynMP4J+RgmX5/pgbA6WVQVsvTKUQFPSh+u+yJP91FHvW8CDK2T6LvOx5Ly21O3UmY8EeQSyFteWLEGFwJMtuxMCKVxcHmuQM8U1afd2E4beqooeGb6odyttEOa894iiA3Hl8Ksk38216GiSE0dYRMhQHpWwSytfCcDjyNbya7E7PW6sa4hYckZ/kF8IzWFCxzpovCJd/1DHmyZ4zr2IFzDa9Cssy/FhCM996IhD/PntQhnRDj0Qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by BYAPR11MB3125.namprd11.prod.outlook.com (2603:10b6:a03:8e::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Fri, 18 Feb 2022 11:17:02 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e9b0:843e:2b39:6680]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::e9b0:843e:2b39:6680%4]) with mapi id 15.20.4995.024; Fri, 18 Feb 2022 11:17:02 +0000 From: "Dumitrescu, Cristian" To: Thomas Monjalon , "Ajmera, Megha" CC: "dev@dpdk.org" , "Singh, Jasvinder" , "david.marchand@redhat.com" Subject: RE: [PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config Thread-Topic: [PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config Thread-Index: AQHYJKsc1jK9fVn6rE+YuE7cQLMGvayZIeaAgAAGQEA= Date: Fri, 18 Feb 2022 11:17:02 +0000 Message-ID: References: <20220218093650.2549927-1-megha.ajmera@intel.com> <20220218093650.2549927-2-megha.ajmera@intel.com> <1712219.4herOUoSWf@thomas> In-Reply-To: <1712219.4herOUoSWf@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a780d3b3-7a40-45fe-9a18-08d9f2d03061 x-ms-traffictypediagnostic: BYAPR11MB3125:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 692ypR+PuL4r5VPz0XTtfDtY63zIrLWn/9LmNnM92PvgNDulk4Gn19tOdOI0sDCOK/bsJkvL8If4CHElQSpRYbsSKG6edaZopt3HyZ1HWcU2T1uBaSImyiBOFYwbcw07Zzd5cPLN47HiC807rNgdg89tggCODvccNJVDCopSO3zVOOPXHF8LyNMXugsvBvSyYXQg4dB3L5GRqu4rgF5cnxZu+hM0k+Qmpj+aeijkIO/31lHw74/XN9jpeZJRU3VElXFjWvZPmIJcbjpJeNPQS6CNr/86gfYesQRhtB77SH48COB6vvcDdlQGCQX4a9cov6JBSSKbZRrFiVisKk68Rc7dHXY9TeFpPG2X9Y66OFDmJ/KyZ/ZIcPY/xkd5hyCDclDlTjzWk7p9MU2pWw4oe6hzpu4olGbYI2W6BT1hX3fz0US6dUij7YNnrnljnso2RTGX+Db/+qpk008JWVgrwSJKIOsnO1KWXK79y3/QX00VvC+ndsl6PXUn+x8roZKdgoCfHwFnS1ROkWd9EbpgWf77jFJzpKXvVlN3WRijLgy4J3AMu+7HrJ+Nwh6fmThPkYD1APl09TySpy5yw88ecwUyBvr+Xj2bAEGBwtxOy/aEhWEgzf14NhzhZzBWt2j7QxA2tIgcCOtKbApFeR6piMBDKTWWmcgsd2L/tD41EqR3X4fLPa8wE5JTCaKqCSAL+VFS0MrpmrIxyMiTOv6W2g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2906002)(82960400001)(9686003)(26005)(186003)(71200400001)(6506007)(7696005)(508600001)(122000001)(38100700002)(33656002)(66476007)(4744005)(5660300002)(316002)(66946007)(86362001)(8936002)(55016003)(66556008)(52536014)(110136005)(6636002)(54906003)(66446008)(38070700005)(8676002)(4326008)(76116006)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ElbpPpts1sfQ4cPzs8lPZKDar30GsJiriN+0MmukVQcxc/DjgBslx+6rkXmO?= =?us-ascii?Q?mXCNzNHvH7Pd3/xcChl5CVpAJTS3yIb4Kf01lS7Z0jX11TEJBbr2mvII1Op5?= =?us-ascii?Q?LYKGZvgx0kG5HZgSPGyP1YpIP4R5KnMiL3N36QGOD1CLETlbG8gaQfXELFpF?= =?us-ascii?Q?GfponDEECLj4hmS7Qjem7xBI8BhaaYZD/trMkjyt1LHftU99WR00ZfKjpVZL?= =?us-ascii?Q?1pL8gUymsOPaLtTPMllq/WI/rwdvgsJTdwoNBxXj6+C4b0IBzOFwcrvKU6IL?= =?us-ascii?Q?kTJDKdVY0L4OkCzDV81SdrXz5Dyvo/d5QQdv49qNKdnvBOEXVXeng7L8M0tZ?= =?us-ascii?Q?iI3Os2k2Az1T/ZMoTj2OwZzHRx5rkqtWdscNqVQxeGkVsUI+7dUTb8U1Y+oC?= =?us-ascii?Q?UlVeD3ISNXMRleupDoM9hwRacWYoH/NXUAW+N/U/MxmL6Xni7eDXptQP2ik2?= =?us-ascii?Q?WuVrz21SrKEfHhvgNIjZr94WEazVZbdqDqBG+sQ+A5by4iGLswym5c7o2a+h?= =?us-ascii?Q?cRLUeBNL5uuZWJwrwmc8oopJZL++hDttz9Bft40rGsi8li9Us+rqdKcRbt0x?= =?us-ascii?Q?qFQ7/fG4XuR21jnf9orXcPQFxBdXg+qLIPv3rQgWjRGg16mKTDiT7f4B9qMT?= =?us-ascii?Q?Q9b6PrX1RhVIMX4M21aBaPntWepFhPAv+pWB3VDOwgtOkp191i4gDUJsU0CB?= =?us-ascii?Q?+LxXx2Hi4mHYQCif6rtWwRY7eV27DUs5/LBiGvxpDZDVmmr03UfEJPFU1an4?= =?us-ascii?Q?cf5RlfVU/+JE7NszTvfbL9MquamPdi+0AU5UldMIS12P+iKETtGjTPtTmtXo?= =?us-ascii?Q?e2rwAW6MFP5R63idPGmYKiVQqviwia2y1jgsg5E+Ol9Frac2ppcG5VfLxHVV?= =?us-ascii?Q?hO1BJtmwAuLVwzzehfZJ5zALlKyrfiRnFHAB36u0xjZ9bvfZ3zKrIwUVc+lu?= =?us-ascii?Q?QO9t7DREYRd1fJILotyfYq/C6Bmj6hG1cVbkp7Nu34FYBWgXxUh9JbZshAsz?= =?us-ascii?Q?6gWFnYBFYAuZRAVoUipke+a5UViGmc+u0cf4DPLaCP6bGBNK5pCWPEKgoIeL?= =?us-ascii?Q?MTaejvH4YaINp19MdKjKiS91r1NZzshe7Y/aGOnilU3D5X3vK/yfEJaYT19s?= =?us-ascii?Q?CAyObY6RiK23NEcGPi7eiM1mnJ1wSWXbJNbOfAhh9ul3uJMgKcQZzbEpdRjl?= =?us-ascii?Q?vqM2QKWM+PgbzqTA3peaH/rZY+4zJ3VV3P1yw6PqRp/sXt/r+1YWjposwien?= =?us-ascii?Q?EeDcWU9iciwuF5C44wdqxLZ+llXKGm58ZgUcZLGBsr6Pc6Si/ArRtHZ56/tk?= =?us-ascii?Q?4JMSPz4wjwPc/n8BNnqqeVsDpZD43Wg6bsiPpQpVZrATQSAiWNLvWQ5ZRv1r?= =?us-ascii?Q?v4+yS2QhN+xjeHIDGyjDM7f6/PSMZcCe1He5s5px7iRpuUPOyBM/H7zJXHgI?= =?us-ascii?Q?hfUymyHiBergX8aOGn+iYxI8GYJu9e2Cvg9LN1kGdgSrDf+ssAGKkh38ctx6?= =?us-ascii?Q?wclLX/gQ+gS08bRJ5JmqWj/RX9xmfktDtrMGqJTaGw9etpEFmd82Dl9CYa4f?= =?us-ascii?Q?MJBM/VzRf2bsHyYBezYtHbifpPRnM0u/Rrwete7lOJ+TNJFgvFgsCdbVkZtv?= =?us-ascii?Q?d64HmLtpdX/v/lKHEfEwBsJu6jGjjjkk/j4nm+DkjgbRdGh7NNkINlgPo0kW?= =?us-ascii?Q?ksIDMQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a780d3b3-7a40-45fe-9a18-08d9f2d03061 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 11:17:02.8145 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yoAuY05fMB5nHCXWCzwnFeEviYMG/tfTYqRXOJFnB5z81ESe7x0nJ/jDKwkEk1PfQZ4SIVlhUq0gYJQU3dIsq04QQFS4UNz5MwUjj2A/VP8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3125 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > -/* rte_sched defines */ > > -#undef RTE_SCHED_CMAN >=20 > So what is the purpose of the code under RTE_SCHED_CMAN #ifdef? > Is it a dead code? Should it be enabled with a hidden option? >=20 We want to keep congestion management enabled through CFLAGS for now, as we= have a bit more homework to do on understanding the performance impact to = enable the feature at build-time; we'll follow-up on this for next release.= Right, Megha?