From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B151EA0540; Mon, 30 May 2022 15:56:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 68C9040694; Mon, 30 May 2022 15:56:26 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id DC36D400D6 for ; Mon, 30 May 2022 15:56:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653918984; x=1685454984; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=lyK6n5UbjtIqo8Mnuj02g/crSsuzxPsqC828Jmvncw0=; b=LsxgRxNklcys9Dh6hwWj4NdzZmYziwJJpv7tFdpKaSqCXwVnCGPQQHiR /60rPDRiFjvkIV8FQP5YC6d4SuGnqpuQ/Vmu/xHhGExd0KbDrMYx8IAn1 x4Bhl4K8ylTXAaeE9aI8+NE0X88flZID6x91urCFF49JO+M+7Pb2IB3Q7 OpI3wWm9o1MNvChJnbPPcokwcj3RfDaNhnV8DiDIv9cwn+R5M1pS2Uquh ZaIP560lA4sCV7Xfj6Pta+i7qiRHVlgRgTHE2LlYLi87xWq1/i1kogtZ3 T1zNEAomn28y9P8UFwccY1TVBcV6cFp1hcktsTlsjYHT09kkxVx24ts/2 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10363"; a="361383480" X-IronPort-AV: E=Sophos;i="5.91,263,1647327600"; d="scan'208";a="361383480" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2022 06:55:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,263,1647327600"; d="scan'208";a="706168694" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 30 May 2022 06:55:19 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 30 May 2022 06:55:17 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 30 May 2022 06:55:16 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.42) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 30 May 2022 06:55:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lQqLOhUMYHtN0MayMVZjZdYoE2A6uvRY8rn7FFRqVY+UJIUNAvxlhJ3Jhk9i1f6AGKtuqkkZz3HQqr+GR0ykbj6Epeo8qO6DZmaVhDbXwBVew5BhOtbfSolpWqoEsGqx9tlnM9+nFfADUJvZ8PX882cmGT/tl8Wk2fja/28V9ybOVXBx3ShO4xrAykAaXrGvy3RQ9EnrdNSHjPYVlSFzbGB/f0IecCxndw9zgfwQBWQbNr3Q+KBMhomxt/YVyR8PvI0gY2YPyfqTxXT8aDxwrAkBIlKK/C+LW2sTKR2YTjrODxcVW3pgkMIqWKsVmvKHb/fRL7pZfnVL3c/Nu83Pfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BsrH/GNHZTIZmpjYepikV12H4Wok+mgFP0dG0H75IPI=; b=JLAH+9HrtMkzCMh/rFn6uwGLrUq62p6EAQm6QrOQz4rGQgk+hSdfsyRCJCtu59sn1VUU/KS+7a+P9cN0tEWx4B7AT7ifeIfNdGqach0s0sMgrjPmfJ1VZhinkjCRrVo9hzTEETe1/fvjV7z2zsitVvmhigvGkUx58tuNCozzzUE+DeX5wS56t+v0yvW1EM/v1w6OhSscdj+r9o6TCojoGtVEKppO/+dF9Dk7dgZxPBXi2QiodxrU89D6nD4/GlTqOcVzo1MoOJ1Ob3IOI7K2uEh7fFaCUWUJLPba7aBlugII8q10bkztJYdcHKDhpEtNuSYmilNlbIWvBPlum9GFcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by MW3PR11MB4699.namprd11.prod.outlook.com (2603:10b6:303:54::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Mon, 30 May 2022 13:55:15 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::89de:bffb:b66b:516b%7]) with mapi id 15.20.5293.019; Mon, 30 May 2022 13:55:15 +0000 From: "Dumitrescu, Cristian" To: "Danilewicz, MarcinX" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "Ajmera, Megha" , "Liu, Yu Y" Subject: RE: [PATCH v7] sched: enable traffic class oversubscription conditionally Thread-Topic: [PATCH v7] sched: enable traffic class oversubscription conditionally Thread-Index: AQHYdBwgzxwMSqXjFEatRQ8L+0zZQq03VKhQgAAVSnCAAAOVYA== Date: Mon, 30 May 2022 13:55:15 +0000 Message-ID: References: <20220530084520.827724-1-marcinx.danilewicz@intel.com> <20220530115500.829250-1-marcinx.danilewicz@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e38dd9c4-bac6-4cb3-b566-08da4244060e x-ms-traffictypediagnostic: MW3PR11MB4699:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5NXZ5q/rfOR0VFxXzGcqbSGhbCNfVcLHPVXmHwLQh/BgssZgskgh9Ixg3o7+ez7C4nOLq2hRCAJZcrMwOPl/CHSh6u/gbfaMcHGJ0PCnNYe0qcoqNBdgXLhBslCfbAlvdWflmDcuSWFPFVXxmjF1sACbPh6IniprqxwtWDDaAaBIdx2ZNKOEgjoKIVzYkMVsbD3YDsODgV/6Kgresvg/MympS5yA5tkGsRHdz56TDB0TGWLybNpF3XaVp5H3R5Vz/Y19b3tA07zMbZOZzrAsu53sjAb2zr4fPst3QyyOT+gpoS9EZCJ8A46Y7yOGKz4VqN3KYpfcchaZXRn/5U1FGQStvkhfbm4cuqI4ySLFYmHd2hIgSpCgp8r4jrAQoBouX6Ieeh2oWNpbHpVORT4/6fzlNeY29ewdBYRLVn4VNFd78Zqh+/J5p7dNVtBY/J+gCpWOlqcJibPADme5crRW9VfLoryCGLjr8uLaI24TMxF44e4d223pmDDQ2hXJVE6fca4LmmbmRNRvxDMN9InDmvoHmkZC/w7iNUYhWMad11YyB58lpZmzrsdEbX8851CPT2Cma18NFsTGnXuezPJszPozqiP0RIfyV01D+QSwuCIcGPyWiv6QWsXrIvWisuLTTUL8PHF+22y7E0d914Oh0e5s+YQC4m3bQXGjyEx29ZrfZGVA0lxF5JmDBhkBOmgWdIw/ZW9WN+13XX0gHjH+eA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(82960400001)(83380400001)(64756008)(5660300002)(55016003)(66446008)(8676002)(6506007)(7696005)(76116006)(508600001)(38100700002)(71200400001)(52536014)(66476007)(66556008)(4326008)(66946007)(8936002)(186003)(2906002)(316002)(86362001)(38070700005)(26005)(6636002)(54906003)(9686003)(122000001)(110136005)(33656002)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0GTKrNrUiQkS8tU+jmFanh84k9Xs/TiQpGzZkmnQMLxc0HTxFpqOMcu/09ZB?= =?us-ascii?Q?UeP9i828UUF2J64j3jJTk6/arfrI9LeZspQWZDNXUXV+xi8aVfbi3JMpRKKc?= =?us-ascii?Q?zavl3CGje4Isz41bhPNPC2bz3YV9D7GSVTcfOQyQv3IFPMxPdNGeFAk2RZJ6?= =?us-ascii?Q?uJjqYTzUXou+KfRUZvV4ET+V7fFulDgb76QsM6BvTrIOGKp8gApUqf745RkP?= =?us-ascii?Q?zuZyht/RgSf5r7wj0/A/YgI8wfg4hhWJFPr9SrluFg0EZPvVUyZjZWsogHDk?= =?us-ascii?Q?8Q5ImlWK3M1tFfaLdcKcXSQL8PE4eBBTxRnSop8X35Stfp2cX774A9jCXqvO?= =?us-ascii?Q?/ekbihJPI+jYaiL4HMMQFkMU+kDpFpC6628Zyd9hc0+Rt4qf+4IEv9PYyxnn?= =?us-ascii?Q?A9kTz6G5HgsQy14FiEg6arqFOUUyUV564MY/8ikUp2aUWATXCitNnnPWGqoN?= =?us-ascii?Q?3PQr3IGFuBlUUzvvA6bi0pQowam7DkwpbZBy0itWzo65DhvFgKKzJ4MxbjQC?= =?us-ascii?Q?ulc3Hosg3EG4TjnDSKgobOYcTioawXcBNS6LL1VtkWDPdhO9NQaOdPqIAuCk?= =?us-ascii?Q?8lItIvetk/AigMzsJQ0m+p5LKmLS8C4SBST6p81uYU8ZNQWNdkKMWTnD6cqL?= =?us-ascii?Q?uOg5RFb1ZN3mE/BIT9Rft/LKHomdi50Zau2kqfm2KICH7w+Lj428giWmIL2X?= =?us-ascii?Q?W0TU7tsIYwIy8xO3gN7kMu06+XrDqTgYDSVF5taKFmemt7BhZhnr+SzC8rRc?= =?us-ascii?Q?JQUY370O/WrFDqX1/3He+JhE/Ly+KWVGOGrODobMWxN98A3xd72edDSgr06a?= =?us-ascii?Q?r/roKAMjvEdG7Gay9pGsAx05H1I0qlpSrm9jUv6T6GFpF+Uk6fBx22srcia0?= =?us-ascii?Q?1e5/Xrm1S4ujSiVjRn5B8AAfhv4gdKOFa8y+7j8OHN1/JZfsR2jotYUKdib1?= =?us-ascii?Q?t9jPBzEi5ZyKQYiQVHRuQKiMOBKgrKRL/791EQUlr99z+rjn2h4IupGVtJHN?= =?us-ascii?Q?qXiAp3giJG4pGYQjEBwlBi+MPez8DBi2nqrplxDvjeg2BcEM6uI31NRbdAZv?= =?us-ascii?Q?i6scOtYPGBRWWLk7PmWAHfpqYNe/jlEFTahSFwp7prvBqvQ+W98N34QLVy1i?= =?us-ascii?Q?rOZqGYxONbCN1sFIxNNZbyf/zKqoGfyhHCgO49Lzqp1U2w70c1ZYIqugzKsv?= =?us-ascii?Q?W38I4IngPD7wrgXal9ZDAejrxDQUMDzehv09nh5G8Z45s/HOZak9pO9qAqdq?= =?us-ascii?Q?/4Fw6QAko6QZ5lSRT9MeXlq4b7svYttQsFc+GOeQRsk6sWjpN+BxanOoUolW?= =?us-ascii?Q?Ky+T9OvboDkOudkuH6mTddLSgjGBJlfjet9DB7A8pm02feUapdcktBrnT/b9?= =?us-ascii?Q?s89+lXHVDChK7rvYv8oJMeW2yjEYXSlFcekZa3qSkeeZR5JzukgB42AZUCzG?= =?us-ascii?Q?Ztm21doIQ1nWUmSx/b+KxK4fJ4GaW0Cs5IRoqGXKStwMn1eRSRrFBr3NxQ7Q?= =?us-ascii?Q?o6Q8fBe5mYBBjx4T3NES8OFjeWdqpuSyB3r4WYZRunRiBGN68pR2kNDhwXbq?= =?us-ascii?Q?AdemEpYZj3lq6jpFIXbxDwDV9aLlzwy+MLK1Drj+ngdvPEAfjk7LfSGVmWeO?= =?us-ascii?Q?/+nyBGd+JTteYlNfbAi/35GCRSSSI6JW/FAVGuuwcTT2W7WnlNBS4SQ59CFW?= =?us-ascii?Q?AJtz04OkQ+YtA9SBIctIvhSvJKWfo/IbrsP/J3dKWaj7zvIRkxR59DsjZ9HU?= =?us-ascii?Q?EfzrgXXlqxrMCfULgdSXXYzIGOsoUeU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e38dd9c4-bac6-4cb3-b566-08da4244060e X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2022 13:55:15.2557 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r9owdyVY6fXkhe2mhbGGlV/LWgEKWiZHkBvripvJXt+siYDWJL7wx316n+G4TbOND2+zHa3w/oGi3yDyZycY1ebPkdnLHDs6I5wiGyldbV8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4699 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Marcin, =20 > > > > Still only changes in rte_sched.c and no change in rte_sched.h for the = API > to > > configure this feature? >=20 > Yes, because you said to remove whole > rte_sched_subport_tc_ov_config(struct rte_sched_port *port, > uint32_t subport_id, > bool tc_ov_enable) > here as comment to v4: > > > > > > This function should not exist, please remove it and keep the initial= code > that > > > computes the tc_ov related variable regardless of whether tc_ov is > enabled > > or > > > not. >=20 > And by the latest other changes the TC OV is enabled by default. All othe= r init > for this feature is done with sched init as per yours other explanations.= In > turn any can change this new flag, but apparently in code without proper = API > for that? >=20 > Isnt that what you wanted? >=20 Nope, it looks like we have a misunderstanding here. Looking back at my com= ments from V3: What I meant is that the configuration values related to thi= s feature (all the tc_ov configuration values) should be computed at initia= lization regardless of whether this feature is enabled or not in order to m= inimize code changes and the size of the patch. In V3, you moved a lot of t= he init code into a different function, but it was my mistake not to realiz= e this was the API function you introduced, sorry about the misunderstandin= g. I think we definitely need an API function to simply set the internal subpo= rt tc_ov_enabled flag (while also doing the proper argument checks that any= well behaved API function must do), but we should not move here the init c= ode that does not really need to be here. Makes sense? Regards, Cristian