From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DF0CA0C4E; Fri, 15 Oct 2021 15:57:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3624411CB; Fri, 15 Oct 2021 15:57:03 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 9D786410F1 for ; Fri, 15 Oct 2021 15:57:02 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10137"; a="208717815" X-IronPort-AV: E=Sophos;i="5.85,375,1624345200"; d="scan'208";a="208717815" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2021 06:56:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,375,1624345200"; d="scan'208";a="461571300" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga002.jf.intel.com with ESMTP; 15 Oct 2021 06:56:55 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 15 Oct 2021 06:56:55 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 15 Oct 2021 06:56:55 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 15 Oct 2021 06:56:55 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 15 Oct 2021 06:56:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bz4dh2qEyQ2umF9P3tCExqzbGnczXyDpB4L9fz/znTxCgWBnSSqAKRrCgJVSyI08iPNaFRirPOzRw2VvnufU97ARtMaPqxhr0JGzt1GBwqkaTUflZd0XjaRjoEY1FPhhG+PxU4B+4zEqlthMBXfY8fc1b1GYl/7605VmiIQbBj2yclJhggU7JXsi1mal5G88xfvO9O9dNA61e8rfTrthls6l4Gv+//ZZAJCfx+EcC9fusNvOKpVfU92NDBUUoHnawGqlh7nLlNm7nR/YTNlLCfVWq3KUOQGdW2SGfNlwISMi28KtVgRpYVv6sMWAXlEyBkHe5sIL5u6eBIHGm15Wvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7Ok7GCjMmPGx5ENoIp+GPYw0yLwRREr0eJ0ZpP6dBps=; b=Z19cNZ5yMSMF8uxAFOPDdrVg8pFikZgOrKD4/IZde8CZkNM10y3440RypSQUaDvD+Az0lqjJTg7DMfyLbDAfXfHy+vzBKDVbdhbju23KkDTOudMLlUxXRNiWMF6vZMkkK4dVI+taTL+I+s6ZSIk5mjaOdGpIspFKIKgFfISMAIPnSfA2igOFS0GrpRRO7fYWwLQVzzh2cmF1oH19gUSvLAFVlqjnzpVTWQBZqqGi2odlz57fRdSBMp+6ljdSMIBWxja+VGeU3wS0waA4EzOOUAP0BF3EjA/dnz1NuJfPqTLcTa/OfX2ggujvSrkmWaZpFYElNwungWYkJ3GcJzhBRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7Ok7GCjMmPGx5ENoIp+GPYw0yLwRREr0eJ0ZpP6dBps=; b=iOH+fI1Ze/eCjK+JJ6GWrKzITBJdB6OHuIMeh3snYE+apEJ5LlL1Xiquw67uelXXdjdMnkd+CM8L9bd1L++4IshGoovzNXFR0rfYpwjHGARhVgBNKlE8Kd8iyPnL32acVLPM6njB9aAGMHAQfYVsn557xX8jpcxX0mSdxeS80Nk= Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by DM8PR11MB5574.namprd11.prod.outlook.com (2603:10b6:8:39::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Fri, 15 Oct 2021 13:56:54 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::c0f1:1135:ceb5:ac10]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::c0f1:1135:ceb5:ac10%9]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021 13:56:53 +0000 From: "Dumitrescu, Cristian" To: "Liguzinski, WojciechX" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "Ajmera, Megha" Thread-Topic: [PATCH v14 0/5] Add PIE support for HQoS library Thread-Index: AQHXwZ0Oqelq9y+5nEy57F/+nUJp/avUFTQg Date: Fri, 15 Oct 2021 13:56:53 +0000 Message-ID: References: <20211014153346.2816600-1-wojciechx.liguzinski@intel.com> <20211015081620.2873739-1-wojciechx.liguzinski@intel.com> In-Reply-To: <20211015081620.2873739-1-wojciechx.liguzinski@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6b55dbcc-2599-4743-597c-08d98fe3a517 x-ms-traffictypediagnostic: DM8PR11MB5574: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SBVF8srDssRoLM9uDAh45D62/yaQeuWCWIrZ8UUDLGb3wyZrNptWEuWjipqVw3KRb+vMaisvWWfy8HV9x5BxupGL4RmAsdWpXzhvkdYvQLm1TcVhPgQozbaMeRxdefZXwmCbCUBdLBPdOr3quKJt74EsNk2yg8/UN9fdNVAv+P5scxAEh1+TMP3f1SVHo4B6JyOAQqJyPvPOOdpqHynUGY2v4scNkCdGyoprH+Gy4lpXqf1kfDc+TAnqd3YWvtDez4oFSG3jtnQNIwJLUCf4bTSoTPp82r9NhNy7XBPKVacAiH6bgavnEi4g805CTPJOiu2l8uSN/im6VxsCGxR0TaLpAPglZYw3msbHA5Ra/UX9KTl66MV1WyYM7qOnG/LLJyAIJh72hoYtHn66P4zZ0OFnCdCl5RAWuxwU9uVr6VUWrS5Lu0gapkn8YkSpkpgzmK9obRnle8Ap9pnrWpTq1a6zCIFnstvTQFIEhZd7Sf0Tqu/FUTnhUvVQF4pLgsn8Wvfw+RhSMsuCgJzSCx133gZwyjQC6OJBZ3CPP9jQcid+4vihbT206hB6B02hj/2FWQHMfbhCKvs2pMZik2pRkbqhM5cPZl1gRKkhuKbXOqqcUaPtpt7E7GYMfToVIXPMaWFkwb6cqbMP2RDP0QC5fGMP+t6gWcfOlFLHLrgsstZ1vOwmDobTuuCM74s6Z/a6WCyAoxWWeKEfktY2m74LWg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6506007)(53546011)(66946007)(186003)(38070700005)(76116006)(66476007)(66556008)(64756008)(8936002)(82960400001)(9686003)(66446008)(52536014)(83380400001)(2906002)(110136005)(86362001)(55016002)(7696005)(4326008)(508600001)(5660300002)(33656002)(122000001)(6636002)(8676002)(26005)(71200400001)(38100700002)(316002)(107886003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3e4ZuudLnlGGMvKav/5cYYdttR3JARBrpkTQZcy8MIlS/eTsrtGwcqtBcLey?= =?us-ascii?Q?6To8DDmVoJH/aXxwMYxR+gE6YIik2JV7ge0rQ6Tl8DJaT+B/rScuVDK08t2k?= =?us-ascii?Q?CDX70mHK0YI2Lb4YkZD0qXFtqKCPieLwq+kBXOePV74dA2sWucuiy1m/kY3m?= =?us-ascii?Q?sPjfjFxCAyTsPv92SK5E+YYnKy2NRH9k9sVAASxiT9lBdbmDrSogFrkFycJK?= =?us-ascii?Q?dqxsLgOMA56RKScKrbe/BILM0c3Xy+0X2Z19EXh0lnmWGQ9kF+a59qLm5WII?= =?us-ascii?Q?6dZuYYEEGivcNvUUrx7e0V16rouMkRf0Um2xs1o1VQRBaoOH0+EtN8Sqn89v?= =?us-ascii?Q?wC00sYOSZB3zZZXxkoHYVXKTIejPPgQtQN9g6iw9L/B42iFeQ8C7RDTbVUBg?= =?us-ascii?Q?Q9s7rJugYB+ErbxKuAwVUA/brkXkuRTZyHOhkEa1yjUO5UeEiwFh4K6+XGrE?= =?us-ascii?Q?HJ7FXkBn4/M9rFvXwhCYH6/kwybNJzKFFZ72MOJ0wNOLxIO+vpPZshOR27PD?= =?us-ascii?Q?97j5vOxV9GE2dkbDO1FOzFfT5CAm5bj39PT0UZMvnAF/ZgubsQAd2OPDReyW?= =?us-ascii?Q?8D7dHr5rfybPzbg9apyYy0RyQ32cUae1KJYxsjRqku8U/TMqHqvfKNJKFBLu?= =?us-ascii?Q?AEHPbP2KsYu9cOsIGq1xqq9dF/mNhMZDlpvcE+nqBBLoTCw2c4sYgTqdKUuw?= =?us-ascii?Q?JHWDdmDdNK3paHt95zUgQlT4GACHh0l9d0sYtYEItATMVFnUaxZfNlrqsq5z?= =?us-ascii?Q?Sa2/gcEtA7cx2BAwC0nvQxJJX4cJXMKqdUvbU48leoL8uk3MJxPI/GKYMNsI?= =?us-ascii?Q?ha9WV7v1tU+S9YGGQnx8Cy5QJFwULksJpDJF4MqWHaTruA6FsN+IIsk5HFg5?= =?us-ascii?Q?8RmKOL/KsS1QwrZg6YIrG0khuSibmhUNC410xSXtkHhzlKhTiepPbcEs8URo?= =?us-ascii?Q?SP4Ij9zXf4A6iIGTcikK/6dEVH9P+wTmgtnmZYN9T7VTao+9Buuaid7kBWIH?= =?us-ascii?Q?hKawPbpoMcU45UQIpceCV7pJla6tgdPs4i+eXKeYVIDFS87Q8jeeNVgNZGIw?= =?us-ascii?Q?Po5E3UVAQf3hJtWDnscYrYPhCQKQ4zXyKM4tKzu19x+iRNlP5ViQdJ2Qmj9t?= =?us-ascii?Q?qqcVfv0Ys9GySwjSj67HaxHTob6c9WUP378t78b58gNiiJO/f/Dnw0GsG+mX?= =?us-ascii?Q?XAK8IionOD9cS2V08HOZliGCj6aT9xEngf3DcEYAG4FOVMsBv+O3fknRBCBn?= =?us-ascii?Q?D4hXJDcX5Dh7UQWPAz1GG9XLKVE7A8Q21+91iiGzvw23oNM9HGXTVMN7wYxX?= =?us-ascii?Q?vGp0Avgb2lpF+qWgCjx8x8Um?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b55dbcc-2599-4743-597c-08d98fe3a517 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2021 13:56:53.8858 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zDvTj38nWKPiovlf5LTUsZEtCYUs+mHU1gaJl6DcuL28LNPL9/GSkGc5fZgRJ4EtgMfu16Qe1kMyyC9viRpvo6Uvxg7XOj0dvOQ+IECBANY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5574 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v14 0/5] Add PIE support for HQoS library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Liguzinski, WojciechX > Sent: Friday, October 15, 2021 9:16 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v14 0/5] Add PIE support for HQoS library >=20 > DPDK sched library is equipped with mechanism that secures it from the > bufferbloat problem > which is a situation when excess buffers in the network cause high latenc= y > and latency > variation. Currently, it supports RED for active queue management (which = is > designed > to control the queue length but it does not control latency directly and = is now > being > obsoleted).=20 Please remove the statement that RED is obsolete, as it is not true. Please= refer only to the benefits on the new algorithm without any generic negati= ve statements not supported by data versus other algorithms, thank you! However, more advanced queue management is required to > address this problem > and provide desirable quality of service to users. >=20 > This solution (RFC) proposes usage of new algorithm called "PIE" > (Proportional Integral > controller Enhanced) that can effectively and directly control queuing la= tency > to address > the bufferbloat problem. >=20 > The implementation of mentioned functionality includes modification of > existing and > adding a new set of data structures to the library, adding PIE related AP= Is. > This affects structures in public API/ABI. That is why deprecation notice= is > going > to be prepared and sent. >=20 > Liguzinski, WojciechX (5): > sched: add PIE based congestion management > example/qos_sched: add PIE support > example/ip_pipeline: add PIE support > doc/guides/prog_guide: added PIE > app/test: add tests for PIE >=20 > app/test/meson.build | 4 + > app/test/test_pie.c | 1065 ++++++++++++++++++ > config/rte_config.h | 1 - > doc/guides/prog_guide/glossary.rst | 3 + > doc/guides/prog_guide/qos_framework.rst | 60 +- > doc/guides/prog_guide/traffic_management.rst | 13 +- > drivers/net/softnic/rte_eth_softnic_tm.c | 6 +- > examples/ip_pipeline/tmgr.c | 142 +-- > examples/qos_sched/app_thread.c | 1 - > examples/qos_sched/cfg_file.c | 111 +- > examples/qos_sched/cfg_file.h | 5 + > examples/qos_sched/init.c | 27 +- > examples/qos_sched/main.h | 3 + > examples/qos_sched/profile.cfg | 196 ++-- > lib/sched/meson.build | 10 +- > lib/sched/rte_pie.c | 86 ++ > lib/sched/rte_pie.h | 398 +++++++ > lib/sched/rte_sched.c | 240 ++-- > lib/sched/rte_sched.h | 63 +- > lib/sched/version.map | 3 + > 20 files changed, 2161 insertions(+), 276 deletions(-) > create mode 100644 app/test/test_pie.c > create mode 100644 lib/sched/rte_pie.c > create mode 100644 lib/sched/rte_pie.h >=20 > -- > 2.25.1