From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1259FA00BE; Tue, 15 Mar 2022 18:25:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90B1C40395; Tue, 15 Mar 2022 18:25:07 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id A4F3F4014F for ; Tue, 15 Mar 2022 18:25:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647365105; x=1678901105; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gyK84oDO7h4421XTmmGv3P9sNK7X+i5HR3h8pD4rFqU=; b=WkrDOBeqzT0uItnklLr6u4BI5oHOXFMi5ZncVF9aj7q0g+5KrGkMq/7f LF4ukhLiNateLfOsDDNA4ACXkmoZRQrdpn1yGvvUYCdVEsnTvXnDKAkb3 C9skAB84ezjvCxqqd7AZBYoCSFVKrIXMjQ7GscU4ejYBNlIJt+3PMyNfn /vUXyjGSyESnP+fOJLEQP8zTqBhQLrEb2yiGJIPdG+T34EBD/eKW+l1ip s8+5ix5/8nfipKUhQ7N7qHZzY37JmgTbhYgkZxSgb7pxLUqjol8CXRuTW /MIOCjZBQ0o0m9qQeAA3kUvquXZ+r5R5bnwKbLTj6OKtpTWCYKf1Ra3ys A==; X-IronPort-AV: E=McAfee;i="6200,9189,10286"; a="256095620" X-IronPort-AV: E=Sophos;i="5.90,184,1643702400"; d="scan'208";a="256095620" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2022 10:25:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,184,1643702400"; d="scan'208";a="557027334" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 15 Mar 2022 10:25:04 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Mar 2022 10:25:03 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 15 Mar 2022 10:25:03 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Tue, 15 Mar 2022 10:25:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GP2jMyGFZ50ZOJOLupqMVSLgXA6lMXtzxAq8/X08MLNoWOVx/gX0pkXSNFMlJNxq4LATgBmvCScfgppyXuvL7XGy5XsGPSKYtyqsyBbn2+o/SH2/r9HRfV45nNoazLEO72MzGKur4HFUPmUB/cfGFkCc83o1CTg7BlSVnjY2OfePEMpxTeyFoXyYylFO4akAIoexBqJO0SSpCFqWIOo1/lNDO72BYW0pCWX/D2UMrEPjEEUeJWZMGEjUIC+5oA3wf8/JgainrIFSh9DIZXOiJlLUj+kCulmJ184aRpzwoZmSadQ+k+zNRxHCfNMn15MAqbBB0WklnV1hC2Y8nSxtXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gyK84oDO7h4421XTmmGv3P9sNK7X+i5HR3h8pD4rFqU=; b=efZOGDR4CX5cP3VQyR+y2seWb+HODQF9C7a8xBHTe7TR+c2/eFh8Gbmxc83QvPHpeL/27Ri+zE7FoUjfdJwVFQqZFXZiprupPi+Af/h832EO83dKQSL1cSbr+Qekn8v5mjQZIIslLzhdhIsonQ/bmCb7EalZAZexczfiGZ2pWfBBSughNzmCRcIfA9PuCd0mYOMfaBIiezrByFXoMORKgPOdcyxxcerPJwEhi9p41O7KkDLC7zeq7zNZ/AkNxAXfCi5TzQ+ArUXOxzVNTnY6FIqLATOtL29ZcV6nKQnzNmfdY3CB1cOYqhTgs3DAAiyhxb0y8kVQgXXNLEn7n+Xu7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5670.namprd11.prod.outlook.com (2603:10b6:8:37::12) by MWHPR11MB1949.namprd11.prod.outlook.com (2603:10b6:300:110::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.14; Tue, 15 Mar 2022 17:25:00 +0000 Received: from DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::69dc:2fe0:11fb:f157]) by DM8PR11MB5670.namprd11.prod.outlook.com ([fe80::69dc:2fe0:11fb:f157%6]) with mapi id 15.20.5061.029; Tue, 15 Mar 2022 17:25:00 +0000 From: "Dumitrescu, Cristian" To: Thomas Monjalon , "Ajmera, Megha" CC: "dev@dpdk.org" , "Mcnamara, John" , "Singh, Jasvinder" , "Thakur, Sham Singh" , "david.marchand@redhat.com" Subject: RE: [PATCH v2] Revert "sched: enable traffic class oversubscription unconditionally" Thread-Topic: [PATCH v2] Revert "sched: enable traffic class oversubscription unconditionally" Thread-Index: AQHYN57iiT0Dv7EskkOt6GT3yvIY8qzATs+AgABdTeA= Date: Tue, 15 Mar 2022 17:25:00 +0000 Message-ID: References: <4dfde108-70ff-d916-4b42-5048d1a82042@redhat.com> <20220314122725.106088-1-megha.ajmera@intel.com> <3492155.hdfAi7Kttb@thomas> In-Reply-To: <3492155.hdfAi7Kttb@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f46c6566-8c55-4f66-bca9-08da06a8bc3d x-ms-traffictypediagnostic: MWHPR11MB1949:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FUskQMnNaHRRG6ymdZ58NlkJeELaB2f/99kkqKCG0bbUoUOs2CPbvysXdPKCqrnsQWHVmBJSAsJExf5qwlRt98sww1HtEnUQ7hjN+4udtWYr0reEvNgVw7UCnwC9hqyICJ5BWPP8CT04bxhV7SXsf7g4bnUxGoH6GbcsMn6LRVVxlnmxw+akHBpzteIVFPXo+nV4irJx9TSTMWJGxS1gCBwSe0lmarkdOmuaLmYXts/5vAzf3dWWCdOCI2Yqu32U1H0i2haYlplC1eHjkQQglEkSZDqueL9fmQWthxf11FGnzNqyaL2dCciY6GSE6NonCOdDnF445sZvP3YhN2xvzdbHxq9VsxhJpqb8UPDRW2Ugz0LfEgMd1k+/firELpe/c5VKI5MxJoxWEat0EM6ecWKkJ2AxfzfxNReU0wvI/jfZ4ONRngkbOCvfb2bTKgwerj9D8M5eW3R2sRZ31EyP79iqx034La3oRFpBHyRC10uBLBYKmQ5rq7rPcwUhSDu39iAbxgDGavL1JiKv5hEfxbRWptz/uirlGbnFC5mdX2DhDCHgUX8B0pJp7jeu9R96KWCMDJOLQ37D/HX/le4S+XMT0DzKt8KlzyFZgmxIJVZQYqHajIFXn2br5kIF7B3S5SRrSp0y4i4sDDeLP5dHJT8aoiozCjl0aapazbpr9BaSdgIOwjrgssnmFu054PrZ7SMhaUkRCNqdcBkJmpNW7g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5670.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(64756008)(508600001)(66946007)(66476007)(66446008)(8676002)(4326008)(76116006)(66556008)(186003)(26005)(86362001)(5660300002)(38070700005)(38100700002)(7696005)(53546011)(52536014)(6506007)(8936002)(82960400001)(122000001)(71200400001)(110136005)(9686003)(55016003)(2906002)(33656002)(316002)(6636002)(83380400001)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Rw136CNq4eEnAa01tzf/jf9QmPJxbjSSySjClZqISbb/E6OMMZ0si8F6bBmN?= =?us-ascii?Q?lBS6TeZYokw0b2k+NNtw6QTwQwysQThhQv3lPHjLGXe9FCQIguX+H6Hbtjth?= =?us-ascii?Q?sES5MqDrGUvFG1OWqacq8sDlka7g5c3s0fkGy2AxlBLQvSGzONBhQDTQK+1v?= =?us-ascii?Q?7Jd6wJ07DyOZumxPx72AMYuy/kjdK8UVj8YmPwi7uqgff49hUTdC2b/F6V1e?= =?us-ascii?Q?SA1eUCK1pLdC0/HdJf1SfMa2wGTENKKslXralMNcwQh8Eo7xsIlxjtt+98f/?= =?us-ascii?Q?JcsgdtEKAxN0UBh69TMt9v0Va/b8yLiAMfZIRoFW/REl3vFd2Kq6p+dp6brG?= =?us-ascii?Q?S1F1IIsWhES3QXlJiordJuBPYumf3XvNmoyd7a9VhH7ZzDXgOA3X2Hr5vbmN?= =?us-ascii?Q?WicEW1mkxNgQ2v4S049DVGvU4zrRBQeArBL9hNEPp/qIFri71ePsN7yZkkG+?= =?us-ascii?Q?+6blV9TFYOM7FJp9UcTmurus00xcZY5OMEvAecFPQH2oQ/y2IzcnPqA+U2lN?= =?us-ascii?Q?dp1/6MmgPJtQPPCftQylZtGD8dCP09OPSDDT/15/jyoHQwuAved9SM4ks9fw?= =?us-ascii?Q?NXEwjiahKZaGCc5u1gJjnh6dspDj2BjEr5SN9DlN1C5uz5ZXOAYqYDfmalkT?= =?us-ascii?Q?XQmv89LG/FIyr5314IwavhyWGVpK8qco7HSRFBjvbjJTcVd9RZRptyUKG13+?= =?us-ascii?Q?Z8SY1uj4W4pgzIR0QWxjM2VauQsLKBYIbiT66Ci4ACWwigpkDoVxJjCMlTYw?= =?us-ascii?Q?YsJZD24UJWpqGKSEcxi7CPI5YuaVXuGvgSMwV9AXXeIo/zWMkpzzcSHpeuT4?= =?us-ascii?Q?ORg6eFcETyoJnP7x1KedmA3/h45wjFwoBtXr3mNaEqVuVN9sqeKsMQxOcoVq?= =?us-ascii?Q?VI7d/BmaZzWal8hCusmxmH5LnwLsE+mHmjLZ/jKt/nME6nh9uSNCPLh/Pk9p?= =?us-ascii?Q?5pIxrG2sjWsahIceJHwgCgs5QMdR2LAEdfsrj3EAslBv3wqibHgExQn28gSV?= =?us-ascii?Q?dMk0Hj2RlKfRuCz9aQ0JuGaiNgwfNq4VzB9/diW6R+u7Pf6MlN6No4Jgafcf?= =?us-ascii?Q?M9uElpc95jmat2NzkBAwgUWHIAM5WSxRuyqwW+ZhwpgGzaZW00xU0aQbE7iz?= =?us-ascii?Q?tP1PM0lR+UFdS9VIVVhhFPlzHoUbVAaaUQQ+Plp1D2pffMSDSyOsnU2qjxO0?= =?us-ascii?Q?jdH3lOBmfZ+kwz4r52tJVqdDlINB0RISKHJX8/RB6S8ysv3XVffXKarV7Y6d?= =?us-ascii?Q?eWJc70gVfbYc+n2wCuhwMHcJl4FE4hdVMZDVYuiq8IoXZQonKZ6zu+4fSPLE?= =?us-ascii?Q?Fon7a2Say1pV1mWpXBQ4j3H3olzBjLZNXXT6+JCH8SuTVoohvCH6SXJLU969?= =?us-ascii?Q?dkIm219q4bJpiXkkqWRt5T6V5t+3DWXdKKb+Vs6Kds5iyrkwVdKAI26qXMUH?= =?us-ascii?Q?NMFD++BrSu/NOk+gtjduhRRr8nyCTWOiCBdusVsGG6w+xMQtBXpvzQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5670.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f46c6566-8c55-4f66-bca9-08da06a8bc3d X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2022 17:25:00.8156 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: A2C3/sjlh+7+Jig4T7aAkmOmIDbItAv+HINArDXXCvmam9tOFadGiOsHtVYn1RIGPOuCfqsR+eYHMRP8t4Bynjwk1oF1+TPjF3BTfLzduZc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1949 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, March 15, 2022 11:23 AM > To: Ajmera, Megha > Cc: dev@dpdk.org; Mcnamara, John ; Singh, > Jasvinder ; Dumitrescu, Cristian > ; Thakur, Sham Singh > ; david.marchand@redhat.com > Subject: Re: [PATCH v2] Revert "sched: enable traffic class oversubscript= ion > unconditionally" >=20 > 14/03/2022 13:27, Megha Ajmera: > > This reverts commit d91c4b1bb5a938734fe8e66da8f965304919f38e. > > > > When enabling TC OV unconditionally, it is observed the performance > > drops by ~20% hence reverting this commit. > > > > Fixes: d91c4b1bb5a9 ("sched: enable traffic class oversubscription > > unconditionally") > > > > Signed-off-by: Megha Ajmera >=20 > Repeating what was suggested yesterday in a private email. > Sorry Megha, I don't know why you were not Cc'ed by your Intel colleagues= . >=20 > David and I suggested to drop the code which was enabled > by the compilation flag RTE_SCHED_SUBPORT_TC_OV, > which was kind of dead code before enabling it unconditionally. > This way you maintain the performance of the default compilation, > and you can re-introduce the feature, if proven useful, > in the next release with a runtime option. >=20 >=20 After talking with Jasvinder and a few other folks, we think the best optio= n at this point is to keep the code as it is now in the repository, so no f= urther change at this point. There is a small performance glitch that we plan to fix shortly after the 2= 2.03 release by making the Traffic Class Oversubscription feature condition= ally enabled at run-time as opposed to enabled unconditionally. Megha alrea= dy sent a patch on this, which is under review. Is this OK with you? Thank you for your help, we don't want to delay the release in any way! Regards, Cristian