From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C586DA054A; Wed, 8 Jun 2022 10:25:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6CB8740689; Wed, 8 Jun 2022 10:25:53 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id A83844021D for ; Wed, 8 Jun 2022 10:25:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654676751; x=1686212751; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=UpR/XDtYtKwcTkbJNlrxsuuhF2aPWHvj9NCr4DJM++U=; b=fe456MN6nA95v7M24XHZXegBK8dsld3vPY54kCgy2Dl520ZvBUwRJC7R wDcdY+zWYqIasjJ6lvZ1VhMNO1j/oCML2oUaRsGe0JJvprLRuZAzoU74p VB3C+kGDiQCY9Z9Q4NVcEQrfnwcPkAkz5RM6EFijGX4aqOt6cQvvFVVtX ayx1wCWulvffEimJNAwfzrbQz7Ftk0gtawcfz/Rf5nfM+cZY3UXNe0tWn +b8x1mIqX5eEKNFXMkONV0odV5k7AMMEhr3Kkirbhe5e23stAYIHk2gMX UDBWx9l5eJ8AtjGaBhJk3DiNWTZwIWuo7iogrx5lWXMgqCI+9Ft+8drVi g==; X-IronPort-AV: E=McAfee;i="6400,9594,10371"; a="275577607" X-IronPort-AV: E=Sophos;i="5.91,285,1647327600"; d="scan'208";a="275577607" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2022 01:25:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,285,1647327600"; d="scan'208";a="759384184" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga005.jf.intel.com with ESMTP; 08 Jun 2022 01:25:49 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 8 Jun 2022 01:25:49 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 8 Jun 2022 01:25:49 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 8 Jun 2022 01:25:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AznvQf4nOQa1hwTLHDDo6ds7sl4BlcgFfHDZie/kJAy6UyIG0gH0GWqCnAw7tkIsiQufbqLyv1NoSIi7BDhuIuSGIYjUfnALyFWT1RTyYzYTHtuQiNAURx2O/3CLglv3y7xCipTmVEKAXJTR1Hy+GkWX2i+R37zWAk+Xzarcmbko5k3hrZRlMV7H4YzsUdHEVROk1LXqVJQ4Ihip4IZ0JkhEaVzg1QteKVvqKcoe4kYovDzD3z+ypLGXtnc2AxjO/ftDhRTtewO9z6m69rYyScd7VxVqLmZgRtWdJbEEQOarOj6DzTyBGkjVzYdpCIZXNGqD0gH7V3ajnluRYcuBGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pCNeFzCT9znDczjhijSD3onF8IHRS2n2ZpSnpHk0QFQ=; b=ZsueWgPXh5izvtljM1HkNoq1ZJNqvrGtot9wUYb7vrgCNghKUNaS/wm+AJJhC42XzXqVlaHfPVyrJQx6aq5sOfhKnYkOjvsapiK5VbFDkMwu0u0KTRaWqyYJm2N3ul9DvWmQOKF/g208oRDX2FXx5POcuP0qA3VFrxBGxTnsGHTI09q5R0WHbpRgUiigyAI9KRHurZoTCJBy/Xl4pv2I7TTZEyYvtoVwHpJE9bnyVhxbU7hcITES/z/XnMomSg/If2we96RB9liGyTxKdHPmc7gZz/wQRDGlEzFlM4EGZjfFYbalfX4qFX/iVfNginuuwlsA8d/PvJi4ex4JRkecuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5751.namprd11.prod.outlook.com (2603:10b6:8:12::16) by BN6PR11MB3969.namprd11.prod.outlook.com (2603:10b6:405:77::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12; Wed, 8 Jun 2022 08:25:47 +0000 Received: from DM8PR11MB5751.namprd11.prod.outlook.com ([fe80::4ca0:c733:3433:ce7b]) by DM8PR11MB5751.namprd11.prod.outlook.com ([fe80::4ca0:c733:3433:ce7b%3]) with mapi id 15.20.5314.019; Wed, 8 Jun 2022 08:25:47 +0000 From: "Wang, Xiao W" To: "Pei, Andy" , "dev@dpdk.org" CC: "Xia, Chenbo" , "maxime.coquelin@redhat.com" , "Xu, Rosen" , "Xiao, QimaiX" Subject: RE: [PATCH] vdpa/ifc: fix null pointer dereference Thread-Topic: [PATCH] vdpa/ifc: fix null pointer dereference Thread-Index: AQHYexEASQco/plBVEWKRf8Ae6epDq1FLFxw Date: Wed, 8 Jun 2022 08:25:47 +0000 Message-ID: References: <1654673642-151882-1-git-send-email-andy.pei@intel.com> In-Reply-To: <1654673642-151882-1-git-send-email-andy.pei@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.500.17 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 746350c0-4062-4d72-ba7c-08da49287d1c x-ms-traffictypediagnostic: BN6PR11MB3969:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: elvJLCobRvWrFry1RWYT3ImGoHUYNdompFk3H3qcopaoXbiKZDDkvRKEG2QJixOdtZGo6IyZF74Ukpdf2tCti9+kYRAh2a3+YkZymPK/+f5+Fe4f6q0LS4B6pZ7KzgjBzFJaMIQYH4tTd8mjKuDZrB4J9hvQNvWL3VJxFjNEu0qePe5dXnG9Y6WObL5FI7bovi/AOD/iJkQHWguJqJOgBd4OO8+Rje0Kidv1P+XFVCtPN5vrGTjRErjDl50ShoAvobEoC1fRPhrDGeZcw6u1HPRlVa+9ShfyfwwAf2sjg5DWUuzNY0T8eBMFCNbdWc1+cqE7CSMYMBJ4Ml2eGKLgdiJ7OmVgROqGFI3Zka2PnwlbMQkL1ZhPLSyZXgcmG0id0QaIVcqSUXkuUZlvOEjzT1jf6W0/Fy8BbGcp1D6zJt/jYFD7jf9+Rk54ZiG/hkNJcGoQ80SsyGafaWR9qHrBMdvtS7eCmn6ntuoA5RydkWf5xCMLNF1bcBuyivhkPaBJMh1kqQEyu7SRX25wy2HESPPE+MsjRsNtLTsZdXbofHV+gzzN1MJQvFzOe9U/TfQEHhrOXcw2PI+IozzKTBNjLlxNyvdpDzj2uCs/XMQ9Jj7Qwcqv7vWKWwIb6pJ+g+qhQuukS4SB7Kccseb/1hPJvxiGgV01XivWjlkPwaIAdoxrko6IKe0EzFNZpig/ptRH85qZbi1AIgrjpZSXQRpyrA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5751.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8936002)(38070700005)(186003)(83380400001)(53546011)(26005)(110136005)(316002)(71200400001)(508600001)(55016003)(2906002)(52536014)(33656002)(86362001)(38100700002)(54906003)(9686003)(7696005)(82960400001)(6506007)(122000001)(76116006)(5660300002)(4326008)(8676002)(66946007)(66476007)(66446008)(107886003)(66556008)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?FHZR5nfWZ75OUYtobfbGSxbOsfF3BdAcFpDPhDF3nAQ7uEOhUGFvtWBH?= =?Windows-1252?Q?N4czKwBILxacXb7VLoRN0ECdDHU7lgtrqTgqPFRvlDpHa+86XM+r5hYf?= =?Windows-1252?Q?j8KVmkPPoTN6zdW4N5APLQxJCgRE9mbHIFR7qQDUmcp4wVT1avY9D+/7?= =?Windows-1252?Q?1l15aIpV6lvrPniiRGp6kUPZgEvpB4S2/8P/XCSxsoazHRRbzsU9dWO/?= =?Windows-1252?Q?7jO+xWJMsYXaNVnMGL/GLi7CR6uRvPlrAuz9ZVNySmgmWPMK7S5re4qI?= =?Windows-1252?Q?3OAkPoAPgSyfur9H9XDFeOnwphCAL/Xrsy7rZ6uGKMUbrlLIrVHsEuuv?= =?Windows-1252?Q?1tB9FY6O1XQR3CE2tUJpAthTYADccILcOjU8q6c4BiwIUYi+eETgXx2h?= =?Windows-1252?Q?28Y5ykTb8g6BsodfvcUiRiwDKBtinm58H2qUXHRtQca15A1sdNqjzqKY?= =?Windows-1252?Q?8r3Zgu0Ko8Vt0dIzM6QBzWUI/CZwI2jmBrAMTgHQYjwyW/GlBYMq4TwT?= =?Windows-1252?Q?04yw/4CTfA8f9XXD5CAXHYPUUhNSdW1Hku4hOqJmhTGdhncaLxY/JE4q?= =?Windows-1252?Q?qlgOmiD/gJi2GAkqb433LfStXIl2T2FxsR4pK3ru+8yqeBWHQf8n/kXz?= =?Windows-1252?Q?Q+C5J6dvMOLxB3XqZGTZPUIV+DIDCzd1T1mHNjvScgPz1YDQs5xvQurX?= =?Windows-1252?Q?ljxSDRMPR3b/uqryCP2+2a8mGm7WAHQUFOeUsX4n6hUmirFXGzVxeL4w?= =?Windows-1252?Q?rW61qbrYUUSFGJLEn+U+Pb5h08VKU8ImvrKJNnKkfnw2XkrBh7W+mFQj?= =?Windows-1252?Q?094AazqXMf6qkRulLHZYeoPykfcUUef0i6awoBuqH8tN+byf/5CsnEhm?= =?Windows-1252?Q?7OS+x5ZFC6Es/XzhNsHJFdhvi9jcMlGiBxA7rXiwAet8PWcvOO+mbeA6?= =?Windows-1252?Q?z/W/imkw/9cOsrJhs6q48bwZH6cNSXnzeWhdNKwdulqPQ+IKpSa4Dme1?= =?Windows-1252?Q?7lZxTI2TxEF55nMnJ/6vkJKq0vzo6D6fqX7aTyxSNFNn5HX2H9yNIQq8?= =?Windows-1252?Q?xcYR/Qe0W92s6kHctJpLkEzYBY+WSsKhUClPg58QIizsDl7plWc7L5mO?= =?Windows-1252?Q?RRfC7AietDN/THJcPfXzIIAlUzJuMpUnK9UM5d4SvuBxyADWiAx83ReZ?= =?Windows-1252?Q?44avcTCZMCnY662cafHByO7YEfI7s3OZ2iZY3UUdz7dskCHHD5oMP/RC?= =?Windows-1252?Q?Za5kb0GAxL6F0qutOXLpgHSOoa63htQNzbnU3hmHEhe6XmNtRD1FDQnZ?= =?Windows-1252?Q?j8Ys8cVFh2r7HjmXGPn/br31K/WJdSOcPKmSCG3ft3fmQ9ugyUOO4HGN?= =?Windows-1252?Q?MiQTHmbiUksllgNeyI5dm1L69KuwUtthIeI4rD0W9QLqvxvwLzktPqfN?= =?Windows-1252?Q?jwi5LagI8vsZBW4sHb2i2yxVQA4XsHQxZrTMT3MM5xGVmJVH/UCaXsDm?= =?Windows-1252?Q?EjZpCzoeUet9HLDjkHfox+aDfKkjNLScz3RI4LAmY1crzk8T0R9QX97D?= =?Windows-1252?Q?r/VrJlnah+OD4aR9QQDgGXknaH++c72OnT/KLDx6bc1eJMQB/fFWU0xU?= =?Windows-1252?Q?/XeWhk4rLaFjy9jT4B9k4th0Zsz3mSdEwj0ulTWDtIbU3fp9oICa3fq/?= =?Windows-1252?Q?H0dy6zfPadgbuWIYnoM/JoS/fUHGzmoBRb5VgxNkB4CBBWfPNsOUzaOy?= =?Windows-1252?Q?CmO/UKPLgaAz1wmRcACm1j7Ckj4mE3gbxOLVctjYfTDbAkNnVjraCRz6?= =?Windows-1252?Q?f5cD2LdqYCgug+EEaKJDZrrJtIEL5Blh1PcCY5pDpfwTg1VbHVQjoh+D?= =?Windows-1252?Q?IQDM3BEKGlJxtg=3D=3D?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5751.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 746350c0-4062-4d72-ba7c-08da49287d1c X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2022 08:25:47.2432 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZrcWf0wX8skqAK/onhXYilaHphjgCQfWfPAIyem8l0BtMc88NcIVWfbrFkyDDz+dWN/9Pj3zQrzItHipZ+ey2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3969 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi > -----Original Message----- > From: Pei, Andy > Sent: Wednesday, June 8, 2022 3:34 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coquelin@redhat.com; > Wang, Xiao W ; Xu, Rosen ; > Xiao, QimaiX > Subject: [PATCH] vdpa/ifc: fix null pointer dereference >=20 > Fix null pointer dereference reported in coverity scan. >=20 > Coverity issue: 378882 > Fixes: 8162a4a9 ("vdpa/ifc/base: access correct register for blk device") > Signed-off-by: Andy Pei > --- > drivers/vdpa/ifc/base/ifcvf.c | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.= c > index dd475a7..0a9f71a 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.c > +++ b/drivers/vdpa/ifc/base/ifcvf.c > @@ -255,6 +255,10 @@ > u32 ring_state; >=20 > cfg =3D hw->common_cfg; > + if (!cfg) { > + DEBUGOUT("common_cfg in HW is NULL.\n"); > + return; > + } >=20 > IFCVF_WRITE_REG16(IFCVF_MSI_NO_VECTOR, &cfg->msix_config); > for (i =3D 0; i < hw->nr_vring; i++) { > @@ -262,6 +266,11 @@ > IFCVF_WRITE_REG16(0, &cfg->queue_enable); > IFCVF_WRITE_REG16(IFCVF_MSI_NO_VECTOR, &cfg- > >queue_msix_vector); >=20 > + if (!hw->lm_cfg) { > + DEBUGOUT("live migration cfg in HW is NULL.\n"); > + continue; > + } > + > if (hw->device_type =3D=3D IFCVF_BLK) > ring_state =3D *(u32 *)(hw->lm_cfg + > IFCVF_LM_RING_STATE_OFFSET + > -- > 1.8.3.1 Acked-by: Xiao Wang BRs, Xiao