From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71E1DA00C2; Thu, 8 Dec 2022 14:09:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 484F440E28; Thu, 8 Dec 2022 14:09:12 +0100 (CET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id B330B40A7E; Thu, 8 Dec 2022 14:09:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670504951; x=1702040951; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/nezoNB8Z5UKJOhuwbP6tSzsCT+1Ym53cm8Qc8sQbos=; b=HGbpJLie0fry41aY07d0t/z91bA5tXNhLzTVLWQuQbHbj/jXGtO7cBo7 +a4SgZsosnnQP+JuFTsUS6LSzi6jqEZ+4UlmvWcGs2/j37AdcP27sLlXb oX3XiwA68w+q6ja/NF0O8NkdTRIzJww2HUL1Vf+SLMIU6KsNj2E/6+/7M 9SPvQt4v/7h0VAUhCQenBLQnNQ59Gonb+hMPuvHmkZ55K72PvyN5zPFfB Xy3Nkhv93PqApL22ETMrb3O8tMwyeMoacrn99ewNWtJkBQHlikyzXN66n 4UVvn9sZo0R4/AMABax0ckRIg4VXZ/+1Ut37USSIHPy1qs4oT+wdbD8Jg A==; X-IronPort-AV: E=McAfee;i="6500,9779,10554"; a="379327277" X-IronPort-AV: E=Sophos;i="5.96,227,1665471600"; d="scan'208";a="379327277" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2022 05:08:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10554"; a="624693653" X-IronPort-AV: E=Sophos;i="5.96,227,1665471600"; d="scan'208";a="624693653" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 08 Dec 2022 05:08:57 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 8 Dec 2022 05:08:57 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 8 Dec 2022 05:08:57 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 8 Dec 2022 05:08:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dj+j6S0CE5itZLuklhwsaQzHF9jsmlQUh6BdtxvOl5DYNuBjo6r9UY6Q4yI2IGc4wK7lP87EzOjXYOaODeXeD5iL/yLAQ1UMDxcCVGCcZgNuSXXbDOod/fSz8yc6Q7aa2FPT/tgbKS6Izv8ffHRWAfuKXyU6scJUw6T1J4FXu0Ivtu70tnt6s7og+2gFuQyqjPzB9pBCGoRa+SWMHvT5xA0X5Qsk2IrDf/u3JygwEFvb3l68Bku/WoiDG5OoKcWHJ5bqhzuhFGB5+m9AO5n4JA3onWW6eFATtkBu7aD82ghDZG+dJV4dayk2jf2rLAFTS0cPztXSuym3iJ4Ha0J2IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UFeFrpmdaMmth/vdssev1hWcNT+NLq2+oP9v/iuKX3Y=; b=I+DaY5WhseAqW1imYFw1sryNBg23d0wszijZqe8lTqvr/u2+sArO6sMlzKqA/UXrh6mySafdZFac24V7KDqqMc9f5CLBfhUdfaw08UAmpkawUDR7O7pkrkHOjQg0mCYJerEiQIx48Aw1f4GHg7WEIygyyLAs2HHuzP6pyULJixVScTOqsd+JS00pAMWZ+Un1eBNp/B0+sFbt7//rG4upcvrdzX2XyJWzWx13ZCp9IRG4zPN06sodB6aF7ZZ480BKbDW2wFZQRvWAO1FGonVJqkeEJQOr2VG3tHMbSUXXDE/z8b/q3dgLAEBzYm6SxXeQG5dc4JaDkxC9ZWHy4xQo1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5751.namprd11.prod.outlook.com (2603:10b6:8:12::16) by SN7PR11MB6776.namprd11.prod.outlook.com (2603:10b6:806:263::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Thu, 8 Dec 2022 13:08:50 +0000 Received: from DM8PR11MB5751.namprd11.prod.outlook.com ([fe80::6894:1dbc:4681:66b6]) by DM8PR11MB5751.namprd11.prod.outlook.com ([fe80::6894:1dbc:4681:66b6%4]) with mapi id 15.20.5880.014; Thu, 8 Dec 2022 13:08:50 +0000 From: "Wang, Xiao W" To: "Maheshwari, Abhishek" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Xia, Chenbo" , "Mandal, Purna Chandra" , "Pei, Andy" Subject: RE: [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern virtio devices Thread-Topic: [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern virtio devices Thread-Index: AQHZCXbF4C5B58+cCkGkb8+1PnaLAq5j9s4g Date: Thu, 8 Dec 2022 13:08:49 +0000 Message-ID: References: <20221206125041.339275-1-abhishek.maheshwari@intel.com> <20221206125524.339468-1-abhishek.maheshwari@intel.com> In-Reply-To: <20221206125524.339468-1-abhishek.maheshwari@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5751:EE_|SN7PR11MB6776:EE_ x-ms-office365-filtering-correlation-id: 4bee0475-7316-476b-ef4d-08dad91d592b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aNa/Le1++rHlutPOuPAFVMqBmfC6NT+QGNq8V5FZVc5TYIEXrkenfvfTmXnhmk3O5yf2C9n0Y861bpzhb5g3cs3tiGmcmZ8pBTOMtPEToB8gb1M55i/H5BTa9kFlY8Gp52ZXPPbyXzqmQcQ/RsRNiTeFmfIRTegIDhsTQsvQvhnEYtfYe9gm2JiHVKwJLm2bwsoNm6Q3ZsYt7Yugz2XFnqj6HlOPYCowm/AuXcyda+abGu6XSFBOskMZ8J/W5cF9/RGFuYHj2qD07ibt9CUL6Tiu2458Brztto4B1/SkXLKukrn2dhqxRI3Grzd2ytaaqm1foHbn5E9nT4JGB521X/RWW+GfBVkqN8RwnXUhqZwdZvi7phlhig8173D51b6/huJp2V28Ctycx0q5/Myco4/R4+Yd80JF/6JN8R9BxVqTH0Lruk4MU/w/ZBX2rvRF9KLKhwKQr3xtvwF2wpQ4DlPAeRW2HbPX/Jl8WM8Ru7giMfbAH9hpxG+vpUH/+tHskKs6gJn1cK4zAqpUsnS3g4RsPobpD6v4PEcq5VAUpcY8i5vJpDnmHSsMBESRoF/DaI5utXaZY192c4ayWX3t0rwcMMDrG2qMSDjp7huXuTdKrF8mSk25b90zaXFICsXV5pE13oU+Ucg3pX5J4/G1DhHKIGF025gg9CRX5O8AxWOtByzNwPDn1OYjMHMI1qKDjG0UjliK94FeJyBoT6/4pw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5751.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(39860400002)(346002)(366004)(396003)(376002)(136003)(451199015)(53546011)(478600001)(2906002)(6506007)(26005)(9686003)(38070700005)(107886003)(33656002)(82960400001)(38100700002)(122000001)(186003)(83380400001)(7696005)(8936002)(66476007)(76116006)(86362001)(66946007)(450100002)(66446008)(64756008)(8676002)(4326008)(54906003)(316002)(6862004)(66556008)(6636002)(55016003)(71200400001)(52536014)(41300700001)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?vzvdKj0TRpxIINhVk3l8hnR7LyOAvzU99ku8DnF3rWiCutaPCt/tMJHQ?= =?Windows-1252?Q?OwQcB0aJXX29QBHfPtUyeBDTC5MvQi0bXNAODS744RBcrCRaA3UAN2Xr?= =?Windows-1252?Q?LaBKVyMmOKQ9hSgm4W4lj0fU3rZTOx6iI5LWDBLF3M5AhNUJxFM0QQTa?= =?Windows-1252?Q?C4m2bXuSW5KPABGJ0rEe451dXRxUpzbFsgtI2YNpeQmEf9ntfmlQFLTP?= =?Windows-1252?Q?JjyCr6uYDXow1SF4ZPxD0sNJ3mOK3EhJ7A57FxqnqXn/YA3DiFABWwF/?= =?Windows-1252?Q?/1UTeb+1ybLXLIv2UnxzsbAmCwT/BLzgsYDrd/Y3VVbs6c6YN5gD9nbB?= =?Windows-1252?Q?xT4GGeERPnQmD9rwr8ZnQbUyjxLZqZv/GPuZBFWIzfmx2Kx47feXLTNh?= =?Windows-1252?Q?Cd4t147N6fdOJqTLZwSdLL9yMovcptsMN7ihwCHRIBItq4fCt7QNXWEb?= =?Windows-1252?Q?bxUwq395+BglUHQGZG7jW5jSnvOhEH71ow36OYL58YGtELn1gd7mSCzV?= =?Windows-1252?Q?G8P8qNDlIb5Q4NRnILvTtIaP0KcswsZKVpJHekjBKj7Chf0bSkVu1pLF?= =?Windows-1252?Q?rKC29X1QHplYoJiT08DUCvjGQ+h07Bz78pwizFDKJyG0bQEKrt5mXLy/?= =?Windows-1252?Q?uz0BRJpLURvdw98jbeEmSCWKQYmYkvj9T4QmPaWzgtwt68x6if2puipz?= =?Windows-1252?Q?Ut8Q4Pk5IxS3UyvDqheUSzCTtmPfP5jxh4DgmeGWQiERQFNzvwfCxYPR?= =?Windows-1252?Q?DNe5exidrgNPnvLtdLTB7ZTwgeWBFm1xFHurr+n3sIfI2/QWyY4Th02h?= =?Windows-1252?Q?iik0ABSumIVbDItCL9VtzejnYIisx7bFbV1oa+DrcFva+WFYdPRt0RjX?= =?Windows-1252?Q?x/Hpy8eBO47YkRsMzsU8RGy18NepjZhLUm3yiPLjPuErszcgeZpJGUJ0?= =?Windows-1252?Q?lvCdm7z3EPAPbWMuKsRtSiV7Ygh7vkwu/HHgF5hiGS7frbw5xtcz30kP?= =?Windows-1252?Q?BnXG5vItmWcXZlBzrX6Xf2cHIvKEljrBuxSLaJX9JcXQOgluEX2UR32/?= =?Windows-1252?Q?6yJlXzjHUv1YQqP6AeWWaS88K4wK67xHNYbDjTDs03c2fj6yBmFOcW75?= =?Windows-1252?Q?ImxUsBR9Nsoi+eXGfQUWi0SwDWg/dArnprzZzlMtKe2B0NFQaCZ9Ti5g?= =?Windows-1252?Q?QlNYr+XthwUOjBzhP8Kho+it8aUVTLhtsJrRvJnKsYdVZNOZqs2UeYpp?= =?Windows-1252?Q?g/N8n0LUomS1Of21VsmUHAOopYCe5uJMArLyTYL5bPFaiE1zKzM4xtLA?= =?Windows-1252?Q?0OiiENc4JbClm08lMMFpxfb5sNSFRR8T/WLTTD6HbzB2FcPaQreIZwCa?= =?Windows-1252?Q?jlwi2OD/aCRC51W+VUW/a/lHAOWeLS+usnYWjUZR6dek1EgMSOE5/+dk?= =?Windows-1252?Q?lLg/rPMsneWGtHRX7CcwPjyQJRzo8308eS1EtRgCyTc2rTimbukt86HF?= =?Windows-1252?Q?vWNinragtv211reE+0JBY3SBj/x8z8DKY5uVx4xmC2keJWJZpa1083S+?= =?Windows-1252?Q?6BXdnnt0sXO0YbUvNdyAoSZlSartXzE/knqSo9x7NIS/NXmoCaKgZf8f?= =?Windows-1252?Q?SkpM6bCXtxFsuptdQOSfYDctaP1ZoiG/6PxupaMaK9eELqLg8Ktk1hJl?= =?Windows-1252?Q?1zLWm+8wcMqq4d8Dr+PcSe1XpEk6jrqE?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5751.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4bee0475-7316-476b-ef4d-08dad91d592b X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2022 13:08:49.9208 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ROWUPuw0UT7eosoxXR3dQurDljw8bCroGBXT6DrBLlYYzsil2s8u9i5Wr3eFxctJrjMKE+UOR2GuWKPozIEy6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6776 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Abhishek, Please see comments inline. BRs, Xiao > -----Original Message----- > From: Maheshwari, Abhishek > Sent: Tuesday, December 6, 2022 8:55 PM > To: Wang, Xiao W > Cc: dev@dpdk.org; stable@dpdk.org; Xia, Chenbo ; > Mandal, Purna Chandra ; Maheshwari, > Abhishek > Subject: [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern virtio > devices >=20 > Fixing the match table for vdpa/ifcvf driver because as per the Virtio > device specification, for modern virtio devices, drivers MAY match any > PCI Subsystem Vendor ID and any PCI Subsystem Device ID value. Here the "drivers" refers to virtio driver, not vdpa driver. With below change, this vdpa/ifc driver would hit the standard virtio devic= e which can't 100% match this driver. >=20 > Fixes: a60b747d0ad ("vdpa/ifc: support virtio block device") > Fixes: 5c806b94785 ("vdpa/ifc: add PCI ID for legacy network device") > Cc: stable@dpdk.org >=20 > Signed-off-by: Abhishek Maheshwari > --- > drivers/vdpa/ifc/ifcvf_vdpa.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.= c > index 49d68ad1b1..214d6e1f60 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -1824,8 +1824,8 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = =3D { > { .class_id =3D RTE_CLASS_ANY_ID, > .vendor_id =3D IFCVF_VENDOR_ID, > .device_id =3D IFCVF_NET_MODERN_DEVICE_ID, > - .subsystem_vendor_id =3D IFCVF_SUBSYS_VENDOR_ID, > - .subsystem_device_id =3D IFCVF_SUBSYS_DEVICE_ID, > + .subsystem_vendor_id =3D RTE_PCI_ANY_ID, > + .subsystem_device_id =3D RTE_PCI_ANY_ID, > }, >=20 > { .class_id =3D RTE_CLASS_ANY_ID, > @@ -1845,8 +1845,8 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = =3D { > { .class_id =3D RTE_CLASS_ANY_ID, > .vendor_id =3D IFCVF_VENDOR_ID, > .device_id =3D IFCVF_BLK_MODERN_DEVICE_ID, > - .subsystem_vendor_id =3D IFCVF_SUBSYS_VENDOR_ID, > - .subsystem_device_id =3D IFCVF_SUBSYS_BLK_DEVICE_ID, > + .subsystem_vendor_id =3D RTE_PCI_ANY_ID, > + .subsystem_device_id =3D RTE_PCI_ANY_ID, > }, >=20 > { .vendor_id =3D 0, /* sentinel */ > -- > 2.31.1