From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68F49A0547; Mon, 27 Sep 2021 10:46:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D77A8406A3; Mon, 27 Sep 2021 10:46:13 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 4D2724003D for ; Mon, 27 Sep 2021 10:46:12 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10119"; a="224086405" X-IronPort-AV: E=Sophos;i="5.85,326,1624345200"; d="scan'208";a="224086405" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2021 01:46:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,326,1624345200"; d="scan'208";a="436749839" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga006.jf.intel.com with ESMTP; 27 Sep 2021 01:45:58 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 27 Sep 2021 01:45:54 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 27 Sep 2021 01:45:54 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 27 Sep 2021 01:45:54 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 27 Sep 2021 01:45:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VWklPBetFvw3JMqWDCjcO5XljBXqMnhIjoTIeDv4YYLNmp6LPBmON3EuOk8qZIU17l4BFfGvprQHmWyTzd8R3kE7hiAy7dQrIJNwYWLGS0QWZHb6R3AccTMaHt3+zuRDvzGXSjD4Xs6TU9sKuoSkIplCRVtoPFD3bt4xp/otfBHtD1riA6e19anLR4BzDxCY10K2BV5JLrmQZ2oM27wo2HOsXt5NiiXuyEd/RP5FSk0UWLbvdF+f1OXKu0iEvX+49uVg3rcXEF3RBuVgSnY20Vh7hHXnyoj3XrpZnm0PxPNSh8gXVd9SgxCryA/lUV3eR2F1c3+5oPqo2jLXKHnnqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7NrNUtv1lS4iz6Fr4I07F3Zo1YY1nMQHxpEcGx31k3g=; b=glCsV7D2ZzCHiH3R2mn3fnwCrvEjxqEsHCPH1FYRSGY3hvN90lvaEz7ZwEX+cyRAD3MOIEjx7UXtkCKj1Qz/qkJNHNADtMQLbj0kJEv3/xlJ7u/ygAR40gEPm9rGKtSpHSzIgTYIFCB6NBlz2yj0u/CWTyI8w9uPjaOuqzKSuFlnSe8wzMuGLW7N3twXimAFSN+jkNjEH4TldYHuZzQH0Tv0Sh1JRAMgnPzjyE6uGy7Ys1x27KKxGVgxB2w5c8XT7q8MAPPGb4Zf7CK0ujnAhFwdvlfP7p36dRz4N8y5035uD1JHLgxSQkUkIFGg60UMc2UdM2k3UZDygaPqBWQTfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7NrNUtv1lS4iz6Fr4I07F3Zo1YY1nMQHxpEcGx31k3g=; b=jx0DFwuGuL4qsNrTfXaPXT+frY0l+GBZ+IxyBSXt9O6zKgejAFbCkfxh7e/xeegupAdW70MSk2Dt6iNla6xP1+CVBtN+a8yTx/GNusxKv1ykLn7miPEAfiU+Q4MO0bhdR2i3Sig0ONAuvvln5goWzd72fT411MkrugN2Vds7pLc= Received: from DM8PR11MB5751.namprd11.prod.outlook.com (2603:10b6:8:12::16) by DM4PR11MB5358.namprd11.prod.outlook.com (2603:10b6:5:395::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Mon, 27 Sep 2021 08:45:53 +0000 Received: from DM8PR11MB5751.namprd11.prod.outlook.com ([fe80::7d53:9d3b:b91f:9c09]) by DM8PR11MB5751.namprd11.prod.outlook.com ([fe80::7d53:9d3b:b91f:9c09%7]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 08:45:53 +0000 From: "Wang, Xiao W" To: jilei chen CC: "dev@dpdk.org" Thread-Topic: [PATCH] [v2] vdpa/ifc: increase readability in function Thread-Index: AQHXs3ZPTp0dGZo7ak+bHaB7i9WUqqu3jWbw Date: Mon, 27 Sep 2021 08:45:53 +0000 Message-ID: References: <20210927081146.20596-1-chenjilei@cmss.chinamobile.com> In-Reply-To: <20210927081146.20596-1-chenjilei@cmss.chinamobile.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: cmss.chinamobile.com; dkim=none (message not signed) header.d=none;cmss.chinamobile.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b2cae7d7-2311-4db8-0078-08d981933749 x-ms-traffictypediagnostic: DM4PR11MB5358: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: j2GNhyRhGxd9w2Mt+Ccmwqw3LIDCBS3ySy8lpiNDqSDBk7Ek/I6RRTnzU4NfJvmug3fzPvJmXooz1+HLvDcFOOL3zWcrac+9oz9bjujmA+u93xSYnTvfxnZVpq0Mxv7CucERLC6YIm7axL2UEk59/bvI4MMlNQPI7lPD7q90pLVQhSH8WN+0n+mGVqBxvDplXbimdlIsWcmoX3Vg7aMWRSCoKrDghJ0j9XWyC5bDxag6P1G5OVANzSUgzveid043Eja/wG7tv/QJNOZi/fS3TV7mybXk/twE4t8TZUIPwiAQWlBTw0Ux3hPAJVj3TAkX/QfXduitH9U31pzT7nSw2Sq0cB6bPe+gs7AYuv+BwtVdIftiqQxky1n4z8sHISvNZjSiZU/fLMRf8w/lM63soTJ5C91GFMSNbKHVNDZiA0UqeBEGsa/xGtsgrlxv8wHjHNphbKyNS4Vn4yufWPwZQO9MmZE48ot93y9er5kjoAr5melQhEf4nWmOCvSX1XnCkJo54H4y1ZJaArywLRo25jEHySQ3pGOHibe8qv0g+dGdTa2Q83Kn8nT7X+h/qU4y+4MP7RRXRHB57VlJt6Jysxg/MTNa4tasrVS44i4gOBE3d/sbNFsVmOVQSBbLifvouoAszIgBR87ezYCSrycRS4syjD2wD3unA5YjB8eOm2G74xEeZlui0zY7znTTPttRXkKwDTQzmjjwYVUf3fN9aA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5751.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(4326008)(83380400001)(52536014)(66556008)(122000001)(66946007)(66476007)(76116006)(7696005)(38070700005)(5660300002)(508600001)(71200400001)(9686003)(2906002)(33656002)(55016002)(316002)(38100700002)(8936002)(64756008)(66446008)(186003)(53546011)(6506007)(6916009)(86362001)(26005)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?NzW01ErfiOnegOv1IhhIJAGX8sRZh0B8adZLZCK0Oqr2ptZNXse/I276?= =?Windows-1252?Q?9nmNGRwPwQXVHNrjBjQ66FZzdjpNqM0X4J9lKnHvkKhqKJGmHRzMO4XA?= =?Windows-1252?Q?DIdf/Q+0CH7vd3pOeyC1Zcw/SVopsiB2/W7NmHU/c/Jp68p7DEOpqMyw?= =?Windows-1252?Q?Mh2dbdeXGajQwfA/6b7RSiZWbxIsPGh4lTToFJz22201U+2rbMI8GRwU?= =?Windows-1252?Q?zeckrqTFEymLEcOl67io2o947X09bXMMfh6Dp89pmu6x20Vo/CKzNDlm?= =?Windows-1252?Q?0c+IBAMwc+gFkKAq+ujKEYFxWSuvx2/pcTLxTwZ6uiUq+EX6BqCJ9OpF?= =?Windows-1252?Q?8QLolNYVtoBNZc64QjifNcXBp1+XeG42IZUqdkoZKovvWCuCRMrjqECe?= =?Windows-1252?Q?6AMpUsoytjLXtPLTEiGbZHu0pvjoqbVZEQawYO7HMsAtYXD1+6e0zbYE?= =?Windows-1252?Q?BpgP+1Akos+CSedMliD4EaDyhdEnI/EEc3nD2uXue7rSf/FBpm5s6Qda?= =?Windows-1252?Q?JIrnueH4v9m+gzgPuaW6mvtpk+jKmAn4V51rQSDQiNuva2wy/6ibWe8+?= =?Windows-1252?Q?NxRvjhCdckn7rpk63X6rVhY46V3teia7umhoWfnXrosIwEfRJhZayD4y?= =?Windows-1252?Q?+twFXgjX45tkjh1DYubsYktwszGR3SMOUyWJW9aZk8ZtcO0JMaWDZAaG?= =?Windows-1252?Q?nGk/iE1FeTQWjZkv6cgkX74J7x7sC97WPfhTDEykvS/xez3uHYDlKCoz?= =?Windows-1252?Q?cmcrg+L+4x0p19tD5En18VXdPP3tUNDZd+2DN36gm2xHpVCbzw8oom7k?= =?Windows-1252?Q?CyArSH0YPEVQ902jvqmABHRhy7W18s6ZrIhoyslfVl8HkF5N6Hj0vZb5?= =?Windows-1252?Q?1wpCQo4myQx73TA9JNFoEzX8YCioX0nbrlBRlRrIGhVobQaDRqXvI2Aq?= =?Windows-1252?Q?gppQNsoopoHzcHdITuB22+L7N1UbaVbKL1QbZsXbtPxPyQCBiAn7xOHt?= =?Windows-1252?Q?OV5ieQpaMzsfC4IwQIMZ5V6kGV7r5dKK7MrR2+kvvuOFEUBVAAxvm7v7?= =?Windows-1252?Q?Xxikz+dm1omfka/lNCRxS7kKeUhGiAQh1pl2tpD8QcN9JqOcdZTXzNMU?= =?Windows-1252?Q?uwc21VhH+117GLQIAOzOD2GmBLFPrRyx0T3kENyEaujZORlS12KdwNIr?= =?Windows-1252?Q?q/L/RHs6eGWA9yc+NFMDV2d0MMwY4u0naVuACOrXhWUOaGXBkMJ6nj5k?= =?Windows-1252?Q?n7135q1DDw/S8SeY6iG4osu47+Wp8VbNGMd6eJjmEb9Kg7cG1Ehj2lF6?= =?Windows-1252?Q?VVfSJIoV4LmItRWGsLtCluJ1VMOE/PdPiONtefiMg4k5TM+JSmOXO9dB?= =?Windows-1252?Q?YF+UPiCu0BmxzCSvGN/vk5BfsCpxa1xs5zE=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5751.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2cae7d7-2311-4db8-0078-08d981933749 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2021 08:45:53.6108 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H9UwDZ0n1/9fdcXahXo25RAuPjnzfWqnyexq/YNobYqqeyrzK6cNU9uO1UXX920o56fTS4uPpFG3q0Nvo0/ldg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5358 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] [v2] vdpa/ifc: increase readability in function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: jilei chen > Sent: Monday, September 27, 2021 4:12 PM > To: Wang, Xiao W > Cc: dev@dpdk.org > Subject: [PATCH] [v2] vdpa/ifc: increase readability in function >=20 > Optimize several parameters form order to better readability To the best of my English knowledge, there's a grammar error here. How about changing it to: Use bool type for function's switch parameter, this could avoid passing "1"= or "0" which is not reader friendly. BRs, Xiao >=20 > Signed-off-by: jilei chen > --- > v2: > * Concise subject of the patch > * Optimize function parameters > --- > drivers/vdpa/ifc/ifcvf_vdpa.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.= c > index 1dc813d0a3..365da2a8b9 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -182,7 +182,7 @@ ifcvf_vfio_setup(struct ifcvf_internal *internal) > } >=20 > static int > -ifcvf_dma_map(struct ifcvf_internal *internal, int do_map) > +ifcvf_dma_map(struct ifcvf_internal *internal, bool do_map) > { > uint32_t i; > int ret; > @@ -538,11 +538,11 @@ update_datapath(struct ifcvf_internal *internal) > if (!rte_atomic32_read(&internal->running) && > (rte_atomic32_read(&internal->started) && > rte_atomic32_read(&internal->dev_attached))) { > - ret =3D ifcvf_dma_map(internal, 1); > + ret =3D ifcvf_dma_map(internal, true); > if (ret) > goto err; >=20 > - ret =3D vdpa_enable_vfio_intr(internal, 0); > + ret =3D vdpa_enable_vfio_intr(internal, false); > if (ret) > goto err; >=20 > @@ -568,7 +568,7 @@ update_datapath(struct ifcvf_internal *internal) > if (ret) > goto err; >=20 > - ret =3D ifcvf_dma_map(internal, 0); > + ret =3D ifcvf_dma_map(internal, false); > if (ret) > goto err; >=20 > @@ -850,7 +850,7 @@ ifcvf_sw_fallback_switchover(struct ifcvf_internal > *internal) > goto error; >=20 > /* set up interrupt for interrupt relay */ > - ret =3D vdpa_enable_vfio_intr(internal, 1); > + ret =3D vdpa_enable_vfio_intr(internal, true); > if (ret) > goto unmap; >=20 > @@ -875,7 +875,7 @@ ifcvf_sw_fallback_switchover(struct ifcvf_internal > *internal) > unset_intr: > vdpa_disable_vfio_intr(internal); > unmap: > - ifcvf_dma_map(internal, 0); > + ifcvf_dma_map(internal, false); > error: > return -1; > } > @@ -934,7 +934,7 @@ ifcvf_dev_close(int vid) > vdpa_disable_vfio_intr(internal); >=20 > /* unset DMA map for guest memory */ > - ifcvf_dma_map(internal, 0); > + ifcvf_dma_map(internal, false); >=20 > internal->sw_fallback_running =3D false; > } else { > @@ -1130,7 +1130,7 @@ ifcvf_set_vring_state(int vid, int vring, int state= ) > } >=20 > if (state && !hw->vring[vring].enable) { > - ret =3D vdpa_enable_vfio_intr(internal, 0); > + ret =3D vdpa_enable_vfio_intr(internal, false); > if (ret) > return ret; > } > -- > 2.12.2 >=20 >=20